Re: DFS implementation status update

[Martin Schleier <drahemmaps@gmx.net>]

Goldenshtein, Victor <victorg@...> writes:

> 
> Dear all,
> 
> We're now in the final DFS development stage and planning to release
> RFC patchsets (both hostapd and nl/cfg/mac80211) in the next week or
> so.
> 
> Main idea
> [...]
Don't have the background to tell whenever these ideas are sane or not...

> Enclosed:
> 1. dfs_init_flow.jpeg: Which illustrates DFS init flow.
> 2. radar_event_channel_switch.jpeg: Which illustrates radar_detection
> event and the channel switch procedure.
But your diagrams look really odd to me. They seem to look like shiny UML
sequence diagrams, but some things are wrong.

The kernel will never "call" directly into userspace. But you
use a "synchronizied call" arrow for RADAR_EVENT from "driver" over
mac/nl80211 into hostapd. The same is true for CHANNEL_SWITCH as well.
That's not how this is supposed to work, mac80211 sends an async nl80211
message and hostapd's event listener is processing it.

Also why are you using "alt" [radar_detected], when there's only one
condition? Wouldn't it make it more sense to go for the "opt" fragment there?