From: Andreas Schwab <schwab@linux-m68k.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
Date: Thu, 30 Apr 2009 10:20:15 +0200 [thread overview]
Message-ID: <m28wlih7sw.fsf@igel.home> (raw)
In-Reply-To: <1241078967.25477.8.camel@johannes.local> (Johannes Berg's message of "Thu, 30 Apr 2009 10:09:26 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
>> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
>> this build error:
>>
>> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
>> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>>
>> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
>> ---
>> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>> misattributed as a compiler bug.
>
> At least in my tree the function isn't static...(yet I still got the
> compiler error)?
The static function is iwl3945_rx_queue_free.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-04-30 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 7:58 iwlwifi: remove EXPORT_SYMBOL for static symbol Andreas Schwab
2009-04-30 8:09 ` Johannes Berg
2009-04-30 8:20 ` Andreas Schwab [this message]
2009-04-30 8:36 ` Johannes Berg
2009-04-30 17:21 ` reinette chatre
2009-04-30 17:27 ` Andreas Schwab
2009-04-30 18:33 ` reinette chatre
2009-04-30 18:33 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28wlih7sw.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).