* iwlwifi: remove EXPORT_SYMBOL for static symbol
@ 2009-04-30 7:58 Andreas Schwab
2009-04-30 8:09 ` Johannes Berg
2009-04-30 17:21 ` reinette chatre
0 siblings, 2 replies; 8+ messages in thread
From: Andreas Schwab @ 2009-04-30 7:58 UTC (permalink / raw)
To: linux-wireless; +Cc: linux-kernel, netdev
It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
misattributed as a compiler bug.
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 08:59:41.000000000 +0200
+++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 09:34:14.000000000 +0200
@@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
rxq->bd = NULL;
rxq->rb_stts = NULL;
}
-EXPORT_SYMBOL(iwl3945_rx_queue_free);
/* Convert linear signal-to-noise ratio into dB */
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 7:58 iwlwifi: remove EXPORT_SYMBOL for static symbol Andreas Schwab
@ 2009-04-30 8:09 ` Johannes Berg
2009-04-30 8:20 ` Andreas Schwab
2009-04-30 17:21 ` reinette chatre
1 sibling, 1 reply; 8+ messages in thread
From: Johannes Berg @ 2009-04-30 8:09 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-wireless, linux-kernel, netdev
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> this build error:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> misattributed as a compiler bug.
At least in my tree the function isn't static...(yet I still got the
compiler error)?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 8:09 ` Johannes Berg
@ 2009-04-30 8:20 ` Andreas Schwab
2009-04-30 8:36 ` Johannes Berg
0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2009-04-30 8:20 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, linux-kernel
Johannes Berg <johannes@sipsolutions.net> writes:
> On Thu, 2009-04-30 at 09:58 +0200, Andreas Schwab wrote:
>> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
>> this build error:
>>
>> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:
>> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>>
>> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
>> ---
>> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>> misattributed as a compiler bug.
>
> At least in my tree the function isn't static...(yet I still got the
> compiler error)?
The static function is iwl3945_rx_queue_free.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 7:58 iwlwifi: remove EXPORT_SYMBOL for static symbol Andreas Schwab
2009-04-30 8:09 ` Johannes Berg
@ 2009-04-30 17:21 ` reinette chatre
2009-04-30 17:27 ` Andreas Schwab
1 sibling, 1 reply; 8+ messages in thread
From: reinette chatre @ 2009-04-30 17:21 UTC (permalink / raw)
To: Andreas Schwab
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vget.kernel.org
On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> this build error:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>From which repo is this commit id?
> misattributed as a compiler bug.
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-2.6.30-rc4.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 08:59:41.000000000 +0200
> +++ linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 09:34:14.000000000 +0200
> @@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct
> rxq->bd = NULL;
> rxq->rb_stts = NULL;
> }
> -EXPORT_SYMBOL(iwl3945_rx_queue_free);
>
>
> /* Convert linear signal-to-noise ratio into dB */
>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 17:21 ` reinette chatre
@ 2009-04-30 17:27 ` Andreas Schwab
2009-04-30 18:33 ` reinette chatre
0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2009-04-30 17:27 UTC (permalink / raw)
To: reinette chatre
Cc: Andreas Schwab,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-MogPR669STc76Z2rM5mHXA@public.gmane.org
reinette chatre
<reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
>> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
>> this build error:
>>
>> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>>
>> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
>> ---
>> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
>
>>From which repo is this commit id?
That's from davem/net-2.6 or linville/wireless-2.6.git
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 17:27 ` Andreas Schwab
@ 2009-04-30 18:33 ` reinette chatre
2009-04-30 18:33 ` Andreas Schwab
0 siblings, 1 reply; 8+ messages in thread
From: reinette chatre @ 2009-04-30 18:33 UTC (permalink / raw)
To: Andreas Schwab
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Andreas,
On Thu, 2009-04-30 at 10:27 -0700, Andreas Schwab wrote:
>
> reinette chatre
> <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
>
> > On Thu, 2009-04-30 at 00:58 -0700, Andreas Schwab wrote:
> >> It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes
> >> this build error:
> >>
> >> drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> >>
> >> Signed-off-by: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
> >> ---
> >> This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was
> >
> >>From which repo is this commit id?
>
> That's from davem/net-2.6 or linville/wireless-2.6.git
Thanks. Even though this patch obsoletes
6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
I would thus prefer that both patches are included.
Reinette
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: iwlwifi: remove EXPORT_SYMBOL for static symbol
2009-04-30 18:33 ` reinette chatre
@ 2009-04-30 18:33 ` Andreas Schwab
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Schwab @ 2009-04-30 18:33 UTC (permalink / raw)
To: reinette chatre
Cc: Andreas Schwab,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
reinette chatre
<reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> Thanks. Even though this patch obsoletes
> 6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have
> that patch in the repo as it removes another unnecessary EXPORT_SYMBOL.
> I would thus prefer that both patches are included.
I agree.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-04-30 19:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-30 7:58 iwlwifi: remove EXPORT_SYMBOL for static symbol Andreas Schwab
2009-04-30 8:09 ` Johannes Berg
2009-04-30 8:20 ` Andreas Schwab
2009-04-30 8:36 ` Johannes Berg
2009-04-30 17:21 ` reinette chatre
2009-04-30 17:27 ` Andreas Schwab
2009-04-30 18:33 ` reinette chatre
2009-04-30 18:33 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).