From: Andreas Schwab <schwab@linux-m68k.org>
To: public-alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@hugh.gmane.org
Cc: Larry Finger
<public-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@hugh.gmane.org>,
Rusty Russell
<public-rusty-8n+1lVoiYb80n/F98K4Iww@hugh.gmane.org>,
Arjan van de Ven
<public-arjan-VuQAYsv1563Yd54FQh9/CA@hugh.gmane.org>,
LKML <public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org>,
"Rafael J. Wysocki" <public-rjw-KKrjLPT3xs0@hugh.gmane.org>,
wireless
<public-linux-wireless-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org>
Subject: Re: Regression in 2.6.30-rc1 since commit acae0515 - wireless broken
Date: Wed, 08 Apr 2009 22:05:21 +0200 [thread overview]
Message-ID: <m2fxgi6hdq.fsf@igel.home> (raw)
In-Reply-To: <9b2b86520904081006m6e6b5276v834c3565b0f6f4c7@mail.gmail.com> (Alan Jenkins's message of "Wed, 8 Apr 2009 18:06:18 +0100")
Alan Jenkins <sourcejedi.lkml-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
writes:
> I agree that commit looks like it should be a no-op though :-).
But it isn't.
Andreas.
---
Fix try_then_request_module to use waiting __request_module again.
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
include/linux/kmod.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.30-rc1/include/linux/kmod.h
===================================================================
--- linux-2.6.30-rc1.orig/include/linux/kmod.h 2009-04-08 12:47:54.000000000 +0200
+++ linux-2.6.30-rc1/include/linux/kmod.h 2009-04-08 17:39:35.000000000 +0200
@@ -34,7 +34,7 @@ extern int __request_module(bool wait, c
#define request_module(mod...) __request_module(true, mod)
#define request_module_nowait(mod...) __request_module(false, mod)
#define try_then_request_module(x, mod...) \
- ((x) ?: (__request_module(false, mod), (x)))
+ ((x) ?: (__request_module(true, mod), (x)))
#else
static inline int request_module(const char *name, ...) { return -ENOSYS; }
static inline int request_module_nowait(const char *name, ...) { return -ENOSYS; }
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-04-08 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 4:54 Regression in 2.6.30-rc1 since commit acae0515 - wireless broken Larry Finger
2009-04-08 5:11 ` Arjan van de Ven
2009-04-08 7:01 ` Rusty Russell
2009-04-08 13:46 ` Sedat Dilek
2009-04-08 14:49 ` Larry Finger
2009-04-08 17:06 ` Alan Jenkins
2009-04-08 17:32 ` Larry Finger
2009-04-08 23:49 ` Randy Dunlap
2009-04-09 0:02 ` Larry Finger
2009-04-08 20:05 ` Andreas Schwab [this message]
2009-04-08 21:13 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fxgi6hdq.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=public-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@hugh.gmane.org \
--cc=public-alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@hugh.gmane.org \
--cc=public-arjan-VuQAYsv1563Yd54FQh9/CA@hugh.gmane.org \
--cc=public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org \
--cc=public-linux-wireless-u79uwXL29TY76Z2rM5mHXA@hugh.gmane.org \
--cc=public-rjw-KKrjLPT3xs0@hugh.gmane.org \
--cc=public-rusty-8n+1lVoiYb80n/F98K4Iww@hugh.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).