From: Chris Ball <cjb@laptop.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mmc: sdio: fix runtime PM path during driver removal
Date: Sun, 26 Jun 2011 11:09:43 -0400 [thread overview]
Message-ID: <m2tybceiiw.fsf@bob.laptop.org> (raw)
In-Reply-To: <BANLkTi=JcXG04coTJCA=fvwxXzuRsYzT4Q@mail.gmail.com> (Ohad Ben-Cohen's message of "Sun, 26 Jun 2011 14:50:50 +0300")
Hi Ohad,
On Sun, Jun 26 2011, Ohad Ben-Cohen wrote:
> On Fri, Jun 10, 2011 at 2:40 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
>> After commit e1866b3 "PM / Runtime: Rework runtime PM handling
>> during driver removal" was introduced, the driver core stopped
>> incrementing the runtime PM usage counter of the device during
>> the invocation of the ->remove() callback.
>>
>> This indirectly broke SDIO's runtime PM path during driver removal,
>> because no one calls _put_sync() anymore after ->remove() completes.
>>
>> This means that the power of runtime-PM-managed SDIO cards is kept
>> high after their driver is removed (even if it was powered down
>> beforehand).
>>
>> Fix that by directly calling _put_sync() when the last usage
>> counter is downref'ed by the SDIO bus.
>
> Can you please take this 1-liner into 3.0-rc ?
>
> It fixes SDIO runtime PM after a breakage was introduced in 3.0.
Merged, thanks. I'll be sending a pull request on my for-linus branch
shortly:
http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=shortlog;h=refs/heads/for-linus
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-06-26 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 23:40 [PATCH] mmc: sdio: fix runtime PM path during driver removal Ohad Ben-Cohen
2011-06-26 11:50 ` Ohad Ben-Cohen
2011-06-26 15:09 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tybceiiw.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).