* [PATCH v4 09/34] wireless: group Realtek wireless on kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
There's only a few of these so we keep them under a config option
which expands upon selection.
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index a04ca56..c2e88dc 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -407,6 +407,15 @@ config USB_NET_RNDIS_WLAN
If you choose to build a module, it'll be called rndis_wlan.
+config REALTEK_80211
+ bool "Realtek"
+ depends on WLAN_80211
+ ---help---
+ This will enable the support for Realtek wireless drivers. This includes
+ the PCI rtl8180 driver and the USB rtl8187 driver.
+
+if REALTEK_80211
+
config RTL8180
tristate "Realtek 8180/8185 PCI support"
depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
@@ -492,6 +501,8 @@ config RTL8187_LEDS
depends on RTL8187 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = RTL8187)
default y
+endif # REALTEK_80211
+
config ADM8211
tristate "ADMtek ADM8211 support"
depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 08/34] wireless: group ZyDAS wireless drivers in kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez, Daniel Drake,
Stephen Chen
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
There's only a few of these so we keep them under a config option
which expands upon selection.
Cc: Daniel Drake <dsd@gentoo.org>
Cc: Stephen Chen <stephen.chen@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 9f1b5b6..a04ca56 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -347,6 +347,15 @@ config PRISM54
endif # CONEXANT_ST_80211
+config ZYDAS_80211
+ bool "ZyDAS"
+ depends on WLAN_80211
+ ---help---
+ This will enable the support for ZyDAS wireless drivers. This includes
+ the 802.11g zd1211rw usb driver and the older 802.11b zd1201 usb driver.
+
+if ZYDAS_80211
+
source "drivers/net/wireless/zd1211rw/Kconfig"
config USB_ZD1201
@@ -367,6 +376,8 @@ config USB_ZD1201
To compile this driver as a module, choose M here: the
module will be called zd1201.
+endif # ZYDAS_80211
+
config USB_NET_RNDIS_WLAN
tristate "Wireless RNDIS USB support"
depends on USB && WLAN_80211 && EXPERIMENTAL
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 07/34] wireless: move zd1211rw option closer to old ZyDAS on kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez, Daniel Drake,
Stephen Chen
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
Cc: Daniel Drake <dsd@gentoo.org>
Cc: Stephen Chen <stephen.chen@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index a123f6e..9f1b5b6 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -347,6 +347,8 @@ config PRISM54
endif # CONEXANT_ST_80211
+source "drivers/net/wireless/zd1211rw/Kconfig"
+
config USB_ZD1201
tristate "USB ZD1201 based Wireless device support"
depends on USB && WLAN_80211
@@ -539,7 +541,6 @@ endif # INTEL_80211
source "drivers/net/wireless/hostap/Kconfig"
source "drivers/net/wireless/b43/Kconfig"
source "drivers/net/wireless/b43legacy/Kconfig"
-source "drivers/net/wireless/zd1211rw/Kconfig"
source "drivers/net/wireless/rt2x00/Kconfig"
source "drivers/net/wireless/orinoco/Kconfig"
source "drivers/net/wireless/wl12xx/Kconfig"
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 06/34] wireless: group Conexant / STEricsson drivers in kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez,
Christian Lamparter, Kalle Valo
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
There's only a few of these so we keep them under a
config option which expands upon selection.
Cc: Christian Lamparter <chunkeey@web.de>
Cc: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index cfd192e..a123f6e 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -284,6 +284,18 @@ config PCMCIA_WL3501
It has basic support for Linux wireless extensions and initial
micro support for ethtool.
+config CONEXANT_ST_80211
+ bool "Intersil / Conexant / STEricsson"
+ depends on WLAN_80211
+ ---help---
+ This will enable the support for Intersil / Conexant and STEricsson
+ wireless drivers. All these companies have sell wireless cards which
+ have shared common parts one way or another. The drivers for these cards
+ include the mac80211 based p54 drivers for PCI, USB and SPI (Nokia N810
+ and N800), and and the old PCI FullMAC driver prism54.
+
+if CONEXANT_ST_80211
+
source "drivers/net/wireless/p54/Kconfig"
config PRISM54
@@ -333,6 +345,8 @@ config PRISM54
say M here and read <file:Documentation/kbuild/modules.txt>.
The module will be called prism54.
+endif # CONEXANT_ST_80211
+
config USB_ZD1201
tristate "USB ZD1201 based Wireless device support"
depends on USB && WLAN_80211
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 05/34] wireless: move p54 and prism54 drivers closer on kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez,
Christian Lamparter
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
Cc: Christian Lamparter <chunkeey@web.de>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index fdf0257..cfd192e 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -284,6 +284,8 @@ config PCMCIA_WL3501
It has basic support for Linux wireless extensions and initial
micro support for ethtool.
+source "drivers/net/wireless/p54/Kconfig"
+
config PRISM54
tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus'
depends on PCI && EXPERIMENTAL && WLAN_80211
@@ -503,7 +505,6 @@ config MAC80211_HWSIM
To compile this driver as a module, choose M here: the module will be
called mac80211_hwsim. If unsure, say N.
-source "drivers/net/wireless/p54/Kconfig"
source "drivers/net/wireless/ath/Kconfig"
menuconfig INTEL_80211
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 03/34] wireless: move MWL8K right below libertas on kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index ab7a185..abb6930 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -176,6 +176,15 @@ config LIBERTAS_THINFIRM_USB
---help---
A driver for Marvell Libertas 8388 USB devices using thinfirm.
+config MWL8K
+ tristate "Marvell 88W8xxx PCI/PCIe Wireless support"
+ depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
+ ---help---
+ This driver supports Marvell TOPDOG 802.11 wireless cards.
+
+ To compile this driver as a module, choose M here: the module
+ will be called mwl8k. If unsure, say N.
+
config AIRO
tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
depends on ISA_DMA_API && WLAN_80211 && (PCI || BROKEN)
@@ -484,15 +493,6 @@ config MAC80211_HWSIM
To compile this driver as a module, choose M here: the module will be
called mac80211_hwsim. If unsure, say N.
-config MWL8K
- tristate "Marvell 88W8xxx PCI/PCIe Wireless support"
- depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
- ---help---
- This driver supports Marvell TOPDOG 802.11 wireless cards.
-
- To compile this driver as a module, choose M here: the module
- will be called mwl8k. If unsure, say N.
-
source "drivers/net/wireless/p54/Kconfig"
source "drivers/net/wireless/ath/Kconfig"
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 02/34] wireless: group intel wireless drivers on kconfig
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez, Zhu Yi,
Wey-Yi Guy, Samuel Ortiz, Reinette Chatre
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
This moves intel wireless drivers into their own menu.
Intel drivers are plenty and so are their driver options so we
give them its own menuconfig.
Cc: Zhu Yi <yi.zhu@intel.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: Samuel Ortiz <samuel.ortiz@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 72dbac6..ab7a185 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -495,9 +495,22 @@ config MWL8K
source "drivers/net/wireless/p54/Kconfig"
source "drivers/net/wireless/ath/Kconfig"
+
+menuconfig INTEL_80211
+ bool "Intel"
+ depends on WLAN_80211
+ ---help---
+ This will enable the support for Intel wireless drivers. This
+ includes ipw2100, ipw2200, iwl3945, iwlagn, and iwmc3200wifi
+
+if INTEL_80211
+
source "drivers/net/wireless/ipw2x00/Kconfig"
source "drivers/net/wireless/iwlwifi/Kconfig"
source "drivers/net/wireless/iwmc3200wifi/Kconfig"
+
+endif # INTEL_80211
+
source "drivers/net/wireless/hostap/Kconfig"
source "drivers/net/wireless/b43/Kconfig"
source "drivers/net/wireless/b43legacy/Kconfig"
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 01/34] wireless: move iwmc3200wifi closer to the other intel drivers
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez, Zhu Yi,
Wey-Yi Guy, Samuel Ortiz, Reinette Chatre
In-Reply-To: <1250281559-13041-1-git-send-email-lrodriguez@atheros.com>
Cc: Zhu Yi <yi.zhu@intel.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: Samuel Ortiz <samuel.ortiz@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index dda7cc2..72dbac6 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -497,6 +497,7 @@ source "drivers/net/wireless/p54/Kconfig"
source "drivers/net/wireless/ath/Kconfig"
source "drivers/net/wireless/ipw2x00/Kconfig"
source "drivers/net/wireless/iwlwifi/Kconfig"
+source "drivers/net/wireless/iwmc3200wifi/Kconfig"
source "drivers/net/wireless/hostap/Kconfig"
source "drivers/net/wireless/b43/Kconfig"
source "drivers/net/wireless/b43legacy/Kconfig"
@@ -504,6 +505,5 @@ source "drivers/net/wireless/zd1211rw/Kconfig"
source "drivers/net/wireless/rt2x00/Kconfig"
source "drivers/net/wireless/orinoco/Kconfig"
source "drivers/net/wireless/wl12xx/Kconfig"
-source "drivers/net/wireless/iwmc3200wifi/Kconfig"
endmenu
--
1.6.2.5
^ permalink raw reply related
* [PATCH v4 00/34] wireless: update/re-arrange kconfigs
From: Luis R. Rodriguez @ 2009-08-14 20:25 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Larry.Finger, Luis R. Rodriguez
Here is the 4th iteration of this series (3rd one was
just some two small updates). I made a change which did require
rebasing the others so just sending a new series. This is also
now rebased on today's wireless testing.
This series incorporates the changes made by Gabor and Luciano.
I've also expanded this and updated the net/wireless/Kconfig,
net/mac80211/Kconfig, the top level description for Wireless LAN
and made some more changes talked about on IRC for prism54.ko.
The only other thing left which I feel could use some updating
is the rate control selection for mac80211. I am able to select
only minstrel as the default. I believe this should not even be
visible if that is the default. Also did we really plan for
PID to be only selectable if embedded? IIRC I was able to build
it last only when selecting embedded. Anyway we can enhance
this if needed later.
Holger asked for a uni-bomb patch, here it is, for your convenience:
http://bombadil.infradead.org/~mcgrof/patches/wireless/2009/08/08-14-wireless-kconfig-all.patch
You can just git am that one file on top of today's wireless-testing.
Luis R. Rodriguez (34):
wireless: move iwmc3200wifi closer to the other intel drivers
wireless: group intel wireless drivers on kconfig
wireless: move MWL8K right below libertas on kconfig
wireless: group Marvell wireless in kconfig
wireless: move p54 and prism54 drivers closer on kconfig
wireless: group Conexant / STEricsson drivers in kconfig
wireless: move zd1211rw option closer to old ZyDAS on kconfig
wireless: group ZyDAS wireless drivers in kconfig
wireless: group Realtek wireless on kconfig
wireless: group Broadcom drivers on kconfig
wireless: clarify rndis_wlan is not broadcom specific
wireless: group Atmel wireless together on kconfig
wireless: move AIRO_CS closer to AIRO_CS
wireless: group Cisco together on kconfig
wireless: move group drivers together
wireless: organize group drivers alphabetically
wireless: remove IEEE 802.11 description on hostapd
wireless: move mac80211_hwsim to top level wireless driver menu
wireless: organize individual drivers alphabetically
wireless: simplify WLAN_PRE80211 entries
wireless: simplify WLAN_80211 entries
wireless: remove "Wireless" from rndis kconfig entry
wireless: downgrade TI driver from menuconfig to config
wireless: Update TI kconfig description
wireless: make ath consistent with the other groups
wireless: update top level wireless driver entry
wireless: update wireless kconfig description
wireless: update cfg80211 kconfig entry
wireless: update reg debug kconfig entry
wireless: update WIRELESS_EXT kconfig entry
wireless: update mac80211 kconfig entry
wireless: make mac80211 select cfg80211
wireless: remove mac80211 rate selection extra menu
wireless: mark prism54.ko as deprecated and mark for removal
Documentation/feature-removal-schedule.txt | 29 ++
drivers/net/wireless/Kconfig | 522 ++++++++++++++++------------
drivers/net/wireless/ath/Kconfig | 3 +-
drivers/net/wireless/ath/ar9170/Kconfig | 2 +-
drivers/net/wireless/ath/ath5k/Kconfig | 2 +-
drivers/net/wireless/ath/ath9k/Kconfig | 2 +-
drivers/net/wireless/b43/Kconfig | 2 +-
drivers/net/wireless/b43legacy/Kconfig | 2 +-
drivers/net/wireless/hostap/Kconfig | 3 +-
drivers/net/wireless/ipw2x00/Kconfig | 6 +-
drivers/net/wireless/iwlwifi/Kconfig | 2 +-
drivers/net/wireless/iwmc3200wifi/Kconfig | 2 +-
drivers/net/wireless/orinoco/Kconfig | 2 +-
drivers/net/wireless/p54/Kconfig | 2 +-
drivers/net/wireless/rt2x00/Kconfig | 2 +-
drivers/net/wireless/wl12xx/Kconfig | 13 +-
drivers/net/wireless/zd1211rw/Kconfig | 2 +-
net/Kconfig | 8 +-
net/mac80211/Kconfig | 32 ++-
net/wireless/Kconfig | 32 ++-
20 files changed, 414 insertions(+), 256 deletions(-)
^ permalink raw reply
* Re: [PATCH] b43: Add LP-PHY firmware loading support
From: Gábor Stefanik @ 2009-08-14 20:20 UTC (permalink / raw)
To: Michael Buesch
Cc: John Linville, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <200908142217.40004.mb@bu3sch.de>
2009/8/14 Michael Buesch <mb@bu3sch.de>:
> On Friday 14 August 2009 13:51:59 Gábor Stefanik wrote:
>> Add support for loading LP-PHY firmware to b43_try_request_fw.
>>
>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>
> ack
> --
> Greetings, Michael.
>
This version is broken - ack "v3 this time really" instead.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH] b43: Add LP-PHY firmware loading support
From: Michael Buesch @ 2009-08-14 20:17 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <4A854FDF.5020208@gmail.com>
On Friday 14 August 2009 13:51:59 Gábor Stefanik wrote:
> Add support for loading LP-PHY firmware to b43_try_request_fw.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
ack
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio
From: Michael Buesch @ 2009-08-14 20:16 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Larry Finger, Broadcom Wireless, linux-wireless
In-Reply-To: <4A849075.7000000@gmail.com>
On Friday 14 August 2009 00:15:17 Gábor Stefanik wrote:
> -Move pdiv from lpphy_2062_init to struct b43_phy_lp.
> -Add channel table for the B2062 radio.
> -Add code for tuning the B2062 radio to channel.
> -Add error handling to op_switch_channel, and use it for both radios.
>
> Rev0/1/B2062 will now hopefully show some signs of life, though
> it won't work at full performance, as calibration is still missing.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
ack
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Implement channel switching for rev2+/B2063 radio
From: Michael Buesch @ 2009-08-14 20:16 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Larry Finger, Broadcom Wireless, linux-wireless
In-Reply-To: <4A847BA6.30803@gmail.com>
On Thursday 13 August 2009 22:46:30 Gábor Stefanik wrote:
> Rev.2+/B2063 will now hopefully show some signs of life, though
> it won't work at full performance, as calibration is still missing.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
ack
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH] b43: Fix sparse warnings
From: Michael Buesch @ 2009-08-14 20:15 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, bcm43xx-dev, linux-wireless
In-Reply-To: <4a84906b.+IYGhiNLKPSjrrR7%Larry.Finger@lwfinger.net>
On Friday 14 August 2009 00:15:07 Larry Finger wrote:
> The b43 driver generates the following sparse warnings:
>
> CHECK drivers/net/wireless/b43/phy_g.c
> drivers/net/wireless/b43/phy_g.c:974:35: warning: cast truncates bits from constant value (ffff7fff becomes 7fff)
> CHECK drivers/net/wireless/b43/wa.c
> drivers/net/wireless/b43/wa.c:385:53: warning: cast truncates bits from constant value (ffff00ff becomes ff)
> drivers/net/wireless/b43/wa.c:403:48: warning: cast truncates bits from constant value (ffff00ff becomes ff)
> drivers/net/wireless/b43/wa.c:405:48: warning: cast truncates bits from constant value (ffff00ff becomes ff)
> drivers/net/wireless/b43/wa.c:415:50: warning: cast truncates bits from constant value (ffff0fff becomes fff)
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John,
>
> There is no hurry for this material.
>
> Larry
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/phy_g.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/phy_g.c
> +++ wireless-testing/drivers/net/wireless/b43/phy_g.c
> @@ -971,7 +971,7 @@ b43_radio_interference_mitigation_enable
> b43_phy_maskset(dev, 0x04A2, 0xFFF0, 0x000B);
>
> if (phy->rev >= 3) {
> - b43_phy_mask(dev, 0x048A, (u16)~0x8000);
> + b43_phy_mask(dev, 0x048A, (u16)(~0x8000 & 0xFFFF));
Uh come on...
The u16 cast already is stupid as hell, but this is becoming braindead.
The code is perfectly fine. Sparse should instead provide an option to disable
this fragile check.
--
Greetings, Michael.
^ permalink raw reply
* [PATCH] b43: LP-PHY: Update TX gain override for a spec typo fix
From: Gábor Stefanik @ 2009-08-14 20:10 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger
Cc: Mark Huijgen, Broadcom Wireless, linux-wireless
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
drivers/net/wireless/b43/phy_lp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 558224b..bf89173 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -747,7 +747,7 @@ static void lpphy_set_tx_gains(struct b43_wldev *dev,
b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFF7F, 1 << 7);
b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xBFFF, 1 << 14);
}
- b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFBF, 1 << 4);
+ b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFBF, 1 << 6);
}
static void lpphy_rev0_1_set_rx_gain(struct b43_wldev *dev, u32 gain)
--
1.6.2.4
^ permalink raw reply related
* Re: Spare warnings - wireless drivers
From: reinette chatre @ 2009-08-14 19:33 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless
In-Reply-To: <43e72e890908131331q371320a3gf1ab53ea27574549@mail.gmail.com>
On Thu, 2009-08-13 at 13:31 -0700, Luis R. Rodriguez wrote:
> CHECK drivers/net/wireless/ipw2x00/ipw2100.c
> include/net/inet_sock.h:208:17: warning: do-while statement is not a
> compound statement
> drivers/net/wireless/ipw2x00/ipw2100.c:2847:21: warning: symbol 'i'
> shadows an earlier one
> drivers/net/wireless/ipw2x00/ipw2100.c:2770:16: originally declared here
> drivers/net/wireless/ipw2x00/ipw2100.c:7888:22: warning: symbol 'mode'
> shadows an earlier one
> drivers/net/wireless/ipw2x00/ipw2100.c:188:12: originally declared here
> drivers/net/wireless/ipw2x00/ipw2100.c:7952:18: warning: symbol 'mode'
> shadows an earlier one
> drivers/net/wireless/ipw2x00/ipw2100.c:188:12: originally declared here
> drivers/net/wireless/ipw2x00/ipw2100.c:8000:18: warning: symbol 'mode'
> shadows an earlier one
[...]
Thanks Luis.
Does not look like sparse was ever run for ipw2x00 ... the driver
specific ones will be addressed. Seems like other people also ran into
the:
> CHECK drivers/net/wireless/ipw2x00/libipw_module.c
> include/net/inet_sock.h:208:17: warning: do-while statement is not a
> compound statement
There is already a patch for this one ([1]) but I cannot tell of the
kmemcheck folks merged it.
Reinette
[1] http://thread.gmane.org/gmane.linux.kernel/861983
^ permalink raw reply
* Re: pull request: wireless-next-2.6 2009-08-14
From: David Miller @ 2009-08-14 19:29 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev
In-Reply-To: <20090814141315.GI2650@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 14 Aug 2009 10:13:15 -0400
> Yet another round of updates intended for 2.6.32...
>
> -- sdio support fo wl1251
> -- other wl1251 fixes
> -- new driver for wl1271
> -- some orinoco fixes
> -- some work on LP-PHY support for b43 (finally...hooray!)
> -- add new FIF_PSPOLL filter flag
> -- mesh mode fixes
> -- ath9k, ath5k, mac80211 updates, etc...
>
> Please let me know if there are problems!
Looks good, pulled, thanks!
^ permalink raw reply
* Re: pull request: wireless-2.6 2009-08-14
From: David Miller @ 2009-08-14 19:28 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev
In-Reply-To: <20090814141224.GH2650@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 14 Aug 2009 10:12:24 -0400
> A couple more squeakers for 2.6.31...one avoids a panic related to
> 802.11n, the other avoids some memory corruption with rt2x00 devices.
Pulled, thanks John.
^ permalink raw reply
* [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration
From: Gábor Stefanik @ 2009-08-14 19:19 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
Call set_tx_power_control with a LPPHY_TXPCTL rather than an
LPPHY_TX_PWR_CTL_CMD_MODE.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
This should fix the WARN_ON testers were seeing during init.
drivers/net/wireless/b43/phy_lp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index adfa7bf..558224b 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
B43_LPPHY_TX_PWR_CTL_CMD_MODE;
- lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
+ lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
lpphy_disable_crs(dev);
loopback = lpphy_loopback(dev);
if (loopback == -1)
--
1.6.2.4
^ permalink raw reply related
* [PATCH] b43: LP-PHY: Don't adjust gain table for rev2+ when setting channel
From: Gábor Stefanik @ 2009-08-14 19:11 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger
Cc: Broadcom Wireless, linux-wireless
Rev2+ never needs to have gain tables adjusted according to the spec.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
drivers/net/wireless/b43/phy_lp.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 76457f7..adfa7bf 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -2059,10 +2059,9 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
if (err)
return err;
lpphy_japan_filter(dev, new_channel);
+ lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel));
}
- lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel));
-
return 0;
}
--
1.6.2.4
^ permalink raw reply related
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: Larry Finger @ 2009-08-14 18:44 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Michael Buesch, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <4A85AD1B.1060008@gmail.com>
Gábor Stefanik wrote:
> Check the mode the hardware is in, not the mode we used the last time.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> Mark, please test if this fixes the TX power control WARN_ON you were
> seeing.
It does not fix it here. I'll take a look at the specs.
Larry
^ permalink raw reply
* [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: Gábor Stefanik @ 2009-08-14 18:29 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
Check the mode the hardware is in, not the mode we used the last time.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
Mark, please test if this fixes the TX power control WARN_ON you were seeing.
drivers/net/wireless/b43/phy_lp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 292ee51..76457f7 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct b43_wldev *dev,
struct b43_phy_lp *lpphy = dev->phy.lp;
enum b43_lpphy_txpctl_mode oldmode;
- oldmode = lpphy->txpctl_mode;
lpphy_read_tx_pctl_mode_from_hardware(dev);
- if (lpphy->txpctl_mode == mode)
+ oldmode = lpphy->txpctl_mode;
+ if (oldmode == mode)
return;
lpphy->txpctl_mode = mode;
--
1.6.2.4
^ permalink raw reply related
* Re: Spare warnings - wireless drivers
From: Gábor Stefanik @ 2009-08-14 18:11 UTC (permalink / raw)
To: Johannes Berg; +Cc: Dave, Luis R. Rodriguez, linux-wireless
In-Reply-To: <1250273426.4411.0.camel@johannes.local>
On Fri, Aug 14, 2009 at 8:10 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> On Fri, 2009-08-14 at 18:30 +0100, Dave wrote:
>
>> I've been staring at setibssport for 5 minutes, and can't see the
>> alleged imbalance. False positive?
>>
>> I can't see why sparse picked on setibssport either - half the other
>> functions in that file do exactly the same.
>
> Yeah, I've been there too -- no idea why that particular function trips
> up sparse.
>
> johannes
>
It's literally a sparse warning, then.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: Spare warnings - wireless drivers
From: Johannes Berg @ 2009-08-14 18:10 UTC (permalink / raw)
To: Dave; +Cc: Luis R. Rodriguez, linux-wireless
In-Reply-To: <4A859F52.1000608@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
On Fri, 2009-08-14 at 18:30 +0100, Dave wrote:
> I've been staring at setibssport for 5 minutes, and can't see the
> alleged imbalance. False positive?
>
> I can't see why sparse picked on setibssport either - half the other
> functions in that file do exactly the same.
Yeah, I've been there too -- no idea why that particular function trips
up sparse.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* compat-wireless-2009-08-13 - connection problems
From: Bringfried Stecklum @ 2009-08-14 17:46 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless
In-Reply-To: <43e72e890908121902g11b136e8y3f1cd30e6c607c08@mail.gmail.com>
Hi,
compilation of compat-wireless-2009-08-13 on my Ubuntu 8.10 kernel 2.6.27-12
x86_64 system went fine. I noticed however, that upon resuming from
standby/hibernate and unloading/loading iwlagn persistent connection problems
occur which were not present with compat-wireless-2009-06-30 (the version I used
until now). Here are the excerpts from /var/log/messages which illustrate the case
compat-wireless-2009-08-13
--------------------------
> 2009/08/14 18:29:44 :: No wired connection present, attempting to autoconnect to wireless network
> 2009/08/14 18:29:45 :: Unable to autoconnect, you'll have to manually connect
> 2009/08/14 18:29:50 :: No wired connection present, attempting to autoconnect to wireless network
> 2009/08/14 18:29:50 :: trying to automatically connect to...NET2NET
> 2009/08/14 18:29:50 :: Connecting to wireless network NET2NET
> 2009/08/14 18:29:50 :: Putting interface down
> 2009/08/14 18:29:50 :: Releasing DHCP leases...
> 2009/08/14 18:29:51 :: Setting false IP...
> 2009/08/14 18:29:52 :: Stopping wpa_supplicant and any DHCP clients
> 2009/08/14 18:29:52 :: Flushing the routing table...
> 2009/08/14 18:29:52 :: Generating psk...
> 2009/08/14 18:29:52 :: Attempting to authenticate...
> 2009/08/14 18:29:53 :: Putting interface up...
> 2009/08/14 18:29:55 :: Running DHCP
> 2009/08/14 18:29:55 :: Internet Systems Consortium DHCP Client V3.1.1
> 2009/08/14 18:29:55 :: Copyright 2004-2008 Internet Systems Consortium.
> 2009/08/14 18:29:55 :: All rights reserved.
> 2009/08/14 18:29:55 :: For info, please visit http://www.isc.org/sw/dhcp/
> 2009/08/14 18:29:55 ::
> 2009/08/14 18:29:57 :: Listening on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 18:29:57 :: Sending on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 18:29:57 :: Sending on Socket/fallback
> 2009/08/14 18:30:00 :: DHCPREQUEST of 192.168.178.37 on wlan0 to 255.255.255.255 port 67
> 2009/08/14 18:30:08 :: DHCPREQUEST of 192.168.178.37 on wlan0 to 255.255.255.255 port 67
> 2009/08/14 18:30:28 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 4
> 2009/08/14 18:30:32 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 5
> 2009/08/14 18:30:37 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 8
> 2009/08/14 18:30:45 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 15
> 2009/08/14 18:31:00 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 13
> 2009/08/14 18:31:13 :: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 16
> 2009/08/14 18:31:29 :: No DHCPOFFERS received.
> 2009/08/14 18:31:29 :: Trying recorded lease 192.168.178.37
> 2009/08/14 18:31:32 :: PING 192.168.178.1 (192.168.178.1) 56(84) bytes of data.
> 2009/08/14 18:31:32 ::
> 2009/08/14 18:31:32 :: --- 192.168.178.1 ping statistics ---
> 2009/08/14 18:31:32 :: 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms
> 2009/08/14 18:31:32 ::
> 2009/08/14 18:31:32 :: Trying recorded lease 192.168.2.105
> 2009/08/14 18:31:35 :: PING 192.168.2.1 (192.168.2.1) 56(84) bytes of data.
> 2009/08/14 18:31:35 ::
> 2009/08/14 18:31:35 :: --- 192.168.2.1 ping statistics ---
> 2009/08/14 18:31:35 :: 1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms
> 2009/08/14 18:31:35 ::
> 2009/08/14 18:31:35 :: No working leases in persistent database - sleeping.
> 2009/08/14 18:31:35 :: DHCP connection failed
> 2009/08/14 18:31:35 :: exiting connection thread
> 2009/08/14 18:31:39 :: No wired connection present, attempting to autoconnect to wireless network
> 2009/08/14 18:31:39 :: trying to automatically connect to...NET2NET
> 2009/08/14 18:31:39 :: Connecting to wireless network NET2NET
> 2009/08/14 18:31:39 :: Putting interface down
> 2009/08/14 18:31:39 :: Releasing DHCP leases...
> 2009/08/14 18:31:39 :: Setting false IP...
> 2009/08/14 18:31:40 :: Stopping wpa_supplicant and any DHCP clients
> 2009/08/14 18:31:40 :: Flushing the routing table...
> 2009/08/14 18:31:40 :: Generating psk...
> 2009/08/14 18:31:40 :: Attempting to authenticate...
> 2009/08/14 18:31:40 :: Putting interface up...
> 2009/08/14 18:31:41 :: Running DHCP
> 2009/08/14 18:31:41 :: Internet Systems Consortium DHCP Client V3.1.1
> 2009/08/14 18:31:41 :: Copyright 2004-2008 Internet Systems Consortium.
> 2009/08/14 18:31:41 :: All rights reserved.
> 2009/08/14 18:31:41 :: For info, please visit http://www.isc.org/sw/dhcp/
> 2009/08/14 18:31:42 :: Listening on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 18:31:42 :: Sending on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 18:31:42 :: Sending on Socket/fallback
> 2009/08/14 18:31:42 :: DHCPREQUEST of 192.168.178.37 on wlan0 to 255.255.255.255 port 67
> 2009/08/14 18:31:42 :: DHCPACK of 192.168.178.37 from 192.168.178.1
> 2009/08/14 18:31:42 :: bound to 192.168.178.37 -- renewal in 349940 seconds.
> 2009/08/14 18:31:42 :: DHCP connection successful
> 2009/08/14 18:31:42 :: Connecting thread exiting.
compat-wireless-2009-06-30
--------------------------
> 2009/08/14 19:30:16 :: No wired connection present, attempting to autoconnect to wireless network
> 2009/08/14 19:30:16 :: Unable to autoconnect, you'll have to manually connect
> 2009/08/14 19:30:22 :: No wired connection present, attempting to autoconnect to wireless network
> 2009/08/14 19:30:22 :: trying to automatically connect to...NET2NET
> 2009/08/14 19:30:22 :: Connecting to wireless network NET2NET
> 2009/08/14 19:30:22 :: Putting interface down
> 2009/08/14 19:30:22 :: Releasing DHCP leases...
> 2009/08/14 19:30:23 :: Setting false IP...
> 2009/08/14 19:30:23 :: Stopping wpa_supplicant and any DHCP clients
> 2009/08/14 19:30:23 :: Flushing the routing table...
> 2009/08/14 19:30:23 :: Generating psk...
> 2009/08/14 19:30:23 :: Attempting to authenticate...
> 2009/08/14 19:30:23 :: Putting interface up...
> 2009/08/14 19:30:32 :: Running DHCP
> 2009/08/14 19:30:32 :: Internet Systems Consortium DHCP Client V3.1.1
> 2009/08/14 19:30:32 :: Copyright 2004-2008 Internet Systems Consortium.
> 2009/08/14 19:30:32 :: All rights reserved.
> 2009/08/14 19:30:32 :: For info, please visit http://www.isc.org/sw/dhcp/
> 2009/08/14 19:30:32 ::
> 2009/08/14 19:30:33 :: Listening on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 19:30:33 :: Sending on LPF/wlan0/00:21:5c:a0:ee:f7
> 2009/08/14 19:30:33 :: Sending on Socket/fallback
> 2009/08/14 19:30:37 :: DHCPREQUEST of 192.168.178.37 on wlan0 to 255.255.255.255 port 67
> 2009/08/14 19:30:37 :: DHCPACK of 192.168.178.37 from 192.168.178.1
> 2009/08/14 19:30:37 :: bound to 192.168.178.37 -- renewal in 347388 seconds.
> 2009/08/14 19:30:37 :: DHCP connection successful
> 2009/08/14 19:30:37 :: Connecting thread exiting.
Regards,
Bringfried
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox