* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: Larry Finger @ 2009-08-17 21:18 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John W. Linville, Michael Buesch, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <69e28c910908171303m69a575f0kad6e32592d3184ea@mail.gmail.com>
Gábor Stefanik wrote:
> 2009/8/17 John W. Linville <linville@tuxdriver.com>:
>> On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
>>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>> Check the mode the hardware is in, not the mode we used the last time.
>>>>
>>>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>>>> ---
>>>> Mark, please test if this fixes the TX power control WARN_ON you were
>>>> seeing.
>>>>
>>>> drivers/net/wireless/b43/phy_lp.c | 4 ++--
>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/b43/phy_lp.c
>>>> b/drivers/net/wireless/b43/phy_lp.c
>>>> index 292ee51..76457f7 100644
>>>> --- a/drivers/net/wireless/b43/phy_lp.c
>>>> +++ b/drivers/net/wireless/b43/phy_lp.c
>>>> @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
>>>> b43_wldev *dev,
>>>> struct b43_phy_lp *lpphy = dev->phy.lp;
>>>> enum b43_lpphy_txpctl_mode oldmode;
>>>>
>>>> - oldmode = lpphy->txpctl_mode;
>>>> lpphy_read_tx_pctl_mode_from_hardware(dev);
>>>> - if (lpphy->txpctl_mode == mode)
>>>> + oldmode = lpphy->txpctl_mode;
>>>> + if (oldmode == mode)
>>>> return;
>>>> lpphy->txpctl_mode = mode;
>>>>
>>>> --
>>>> 1.6.2.4
>>>>
>>> John, any news on this one? I can't see it in wireless testing.
>> Larry said "It does not fix it here. I'll take a look at the specs"...
>
> It did not fix the warning, but it is nevertheless a legitimate fix.
> (I found this bug when I was looking for the source of the WARN_ON -
> this is not the source of the WARN_ON, but still a bug.)
This patch is OK.
Larry
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration
From: Larry Finger @ 2009-08-17 21:17 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John W. Linville, Michael Buesch, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <69e28c910908171302s3aed3181w38ba402ca7dfa13d@mail.gmail.com>
Gábor Stefanik wrote:
> 2009/8/17 John W. Linville <linville@tuxdriver.com>:
>> On Mon, Aug 17, 2009 at 09:32:42PM +0200, Gábor Stefanik wrote:
>>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>> Call set_tx_power_control with a LPPHY_TXPCTL rather than an
>>>> LPPHY_TX_PWR_CTL_CMD_MODE.
>>>>
>>>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>>>> ---
>>>> This should fix the WARN_ON testers were seeing during init.
>>>>
>>>> drivers/net/wireless/b43/phy_lp.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/b43/phy_lp.c
>>>> b/drivers/net/wireless/b43/phy_lp.c
>>>> index adfa7bf..558224b 100644
>>>> --- a/drivers/net/wireless/b43/phy_lp.c
>>>> +++ b/drivers/net/wireless/b43/phy_lp.c
>>>> @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev
>>>> *dev)
>>>> old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
>>>> B43_LPPHY_TX_PWR_CTL_CMD_MODE;
>>>>
>>>> - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
>>>> + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
>>>> lpphy_disable_crs(dev);
>>>> loopback = lpphy_loopback(dev);
>>>> if (loopback == -1)
>>>> --
>>>> 1.6.2.4
>>>>
>>> John, any news on this one? I can't see it in wireless testing.
>> Larry said:
>>
>> With this one, I still get WARNING: at
>> drivers/net/wireless/b43/phy_lp.c:1006
>> lpphy_set_tx_power_control+0xbf/0xdd [b43]().
>>
>
> Previously, he was getting 2 warnings. This fixes one of them, the
> other one is handled by commit
> 1181d724fc2897f11f95bf6ebc86ae111390929c ("Fix another TX power
> control abuse").
>
I need to be more careful with my comments. This pack is needed and
OK. Because of my involvement with the RE, I cannot ack any of these
LP PHY patches.
Larry
^ permalink raw reply
* status of AP mode in iwlwifi?
From: Andrey Yurovsky @ 2009-08-17 21:13 UTC (permalink / raw)
To: linux-wireless
Hi folks. What's the status of AP mode in iwlwifi? I used it some
time in the past but I see that it's disabled in wireless-testing now.
Is there an issue with AP mode in this driver? Can it be re-enabled?
Thanks,
-Andrey
^ permalink raw reply
* Re: [rt2x00-users] [PATCH 4/7] rt2x00: Set SKBDESC_L2_PADDED in RX path
From: Benoit PAPILLAULT @ 2009-08-17 20:46 UTC (permalink / raw)
To: rt2x00 Users List; +Cc: John Linville, linux-wireless
In-Reply-To: <200908171854.50790.IvDoorn@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ivo van Doorn a écrit :
> When the RX descriptor indicates the frame was L2 padded,
> the SKBDESC_L2_PADDED flag should be set to make sure the
> L2 padding is removed before it is send to mac80211.
>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
b/drivers/net/wireless/rt2x00/rt2800usb.c
> index c82474e..6de2eda 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2163,8 +2163,10 @@ static void rt2800usb_fill_rxdone(struct
queue_entry *entry,
> if (rt2x00_get_field32(rxd0, RXD_W0_MY_BSS))
> rxdesc->dev_flags |= RXDONE_MY_BSS;
>
> - if (rt2x00_get_field32(rxd0, RXD_W0_L2PAD))
> + if (rt2x00_get_field32(rxd0, RXD_W0_L2PAD)) {
> rxdesc->dev_flags |= RXDONE_L2PAD;
> + skbdesc->flags |= SKBDESC_L2_PADDED;
> + }
>
> if (rt2x00_get_field32(rxwi1, RXWI_W1_SHORT_GI))
> rxdesc->flags |= RX_FLAG_SHORT_GI;
I have tested this patch as well and it looks correct. However, during
my test, the hardware does not set L2PAD flag, even if padding is
present (for some frames). I did the same test with the rt2870sta
driver from Ralink and the L2PAD was indeed set.
Ivo : what happens during your tests?
Regards,
Benoit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkqJwZkACgkQOR6EySwP7oLcEACcDDUaE5oeOhF8CsC1hdg6cKQ6
7K4An2DKy76bVP2CpfhOJePGNrSWDI2v
=3ymH
-----END PGP SIGNATURE-----
^ permalink raw reply
* Re: [PATCH] b43: Fix sparse warnings
From: Pavel Roskin @ 2009-08-17 20:30 UTC (permalink / raw)
To: Michael Buesch
Cc: Gábor Stefanik, linux-wireless, bcm43xx-dev, Larry Finger
In-Reply-To: <200908151204.11024.mb@bu3sch.de>
On Sat, 2009-08-15 at 12:04 +0200, Michael Buesch wrote:
> I still do not understand why it does complain about an _explicit_ truncation.
> That's simply stupid. If I program an explicit truncation I _do_ mean to truncate the value.
Actually, it's a bug in sparse. Sparse acts inconsistently.
This causes a warning:
void mask(unsigned short mask);
static void test(void)
{
mask((unsigned short)0xffff0000);
}
test.c:4:30: warning: cast truncates bits from constant value (ffff0000
becomes 0)
But this is OK:
void mask(unsigned short mask);
static void test(void)
{
mask((unsigned short)0xfffff000);
}
Moreover, this is OK, even though the cast changes the value of the
constant:
void mask(unsigned short mask);
static void test(void)
{
mask((unsigned short)0xfffff000U);
}
I suggest that we take no action until sparse is fixed. I'm going to
report the issue to the sparse mailing list now.
--
Regards,
Pavel Roskin
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: Gábor Stefanik @ 2009-08-17 20:03 UTC (permalink / raw)
To: John W. Linville
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <20090817195607.GJ5500@tuxdriver.com>
2009/8/17 John W. Linville <linville@tuxdriver.com>:
> On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>> > Check the mode the hardware is in, not the mode we used the last time.
>> >
>> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>> > ---
>> > Mark, please test if this fixes the TX power control WARN_ON you were
>> > seeing.
>> >
>> > drivers/net/wireless/b43/phy_lp.c | 4 ++--
>> > 1 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/b43/phy_lp.c
>> > b/drivers/net/wireless/b43/phy_lp.c
>> > index 292ee51..76457f7 100644
>> > --- a/drivers/net/wireless/b43/phy_lp.c
>> > +++ b/drivers/net/wireless/b43/phy_lp.c
>> > @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
>> > b43_wldev *dev,
>> > struct b43_phy_lp *lpphy = dev->phy.lp;
>> > enum b43_lpphy_txpctl_mode oldmode;
>> >
>> > - oldmode = lpphy->txpctl_mode;
>> > lpphy_read_tx_pctl_mode_from_hardware(dev);
>> > - if (lpphy->txpctl_mode == mode)
>> > + oldmode = lpphy->txpctl_mode;
>> > + if (oldmode == mode)
>> > return;
>> > lpphy->txpctl_mode = mode;
>> >
>> > --
>> > 1.6.2.4
>> >
>>
>> John, any news on this one? I can't see it in wireless testing.
>
> Larry said "It does not fix it here. I'll take a look at the specs"...
It did not fix the warning, but it is nevertheless a legitimate fix.
(I found this bug when I was looking for the source of the WARN_ON -
this is not the source of the WARN_ON, but still a bug.)
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration
From: Gábor Stefanik @ 2009-08-17 20:02 UTC (permalink / raw)
To: John W. Linville
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <20090817195718.GK5500@tuxdriver.com>
2009/8/17 John W. Linville <linville@tuxdriver.com>:
> On Mon, Aug 17, 2009 at 09:32:42PM +0200, Gábor Stefanik wrote:
>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>> > Call set_tx_power_control with a LPPHY_TXPCTL rather than an
>> > LPPHY_TX_PWR_CTL_CMD_MODE.
>> >
>> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>> > ---
>> > This should fix the WARN_ON testers were seeing during init.
>> >
>> > drivers/net/wireless/b43/phy_lp.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/b43/phy_lp.c
>> > b/drivers/net/wireless/b43/phy_lp.c
>> > index adfa7bf..558224b 100644
>> > --- a/drivers/net/wireless/b43/phy_lp.c
>> > +++ b/drivers/net/wireless/b43/phy_lp.c
>> > @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev
>> > *dev)
>> > old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
>> > B43_LPPHY_TX_PWR_CTL_CMD_MODE;
>> >
>> > - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
>> > + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
>> > lpphy_disable_crs(dev);
>> > loopback = lpphy_loopback(dev);
>> > if (loopback == -1)
>> > --
>> > 1.6.2.4
>> >
>>
>> John, any news on this one? I can't see it in wireless testing.
>
> Larry said:
>
> With this one, I still get WARNING: at
> drivers/net/wireless/b43/phy_lp.c:1006
> lpphy_set_tx_power_control+0xbf/0xdd [b43]().
>
Previously, he was getting 2 warnings. This fixes one of them, the
other one is handled by commit
1181d724fc2897f11f95bf6ebc86ae111390929c ("Fix another TX power
control abuse").
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration
From: John W. Linville @ 2009-08-17 19:57 UTC (permalink / raw)
To: Gábor Stefanik
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <69e28c910908171232i6828d42bh3aac1d236f789c91@mail.gmail.com>
On Mon, Aug 17, 2009 at 09:32:42PM +0200, Gábor Stefanik wrote:
> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> > Call set_tx_power_control with a LPPHY_TXPCTL rather than an
> > LPPHY_TX_PWR_CTL_CMD_MODE.
> >
> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> > ---
> > This should fix the WARN_ON testers were seeing during init.
> >
> > drivers/net/wireless/b43/phy_lp.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/phy_lp.c
> > b/drivers/net/wireless/b43/phy_lp.c
> > index adfa7bf..558224b 100644
> > --- a/drivers/net/wireless/b43/phy_lp.c
> > +++ b/drivers/net/wireless/b43/phy_lp.c
> > @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev
> > *dev)
> > old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
> > B43_LPPHY_TX_PWR_CTL_CMD_MODE;
> >
> > - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
> > + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
> > lpphy_disable_crs(dev);
> > loopback = lpphy_loopback(dev);
> > if (loopback == -1)
> > --
> > 1.6.2.4
> >
>
> John, any news on this one? I can't see it in wireless testing.
Larry said:
With this one, I still get WARNING: at
drivers/net/wireless/b43/phy_lp.c:1006
lpphy_set_tx_power_control+0xbf/0xdd [b43]().
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: John W. Linville @ 2009-08-17 19:56 UTC (permalink / raw)
To: Gábor Stefanik
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
In-Reply-To: <69e28c910908171233l75b4f72cq8981fb048ad8ffbb@mail.gmail.com>
On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> > Check the mode the hardware is in, not the mode we used the last time.
> >
> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> > ---
> > Mark, please test if this fixes the TX power control WARN_ON you were
> > seeing.
> >
> > drivers/net/wireless/b43/phy_lp.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/phy_lp.c
> > b/drivers/net/wireless/b43/phy_lp.c
> > index 292ee51..76457f7 100644
> > --- a/drivers/net/wireless/b43/phy_lp.c
> > +++ b/drivers/net/wireless/b43/phy_lp.c
> > @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
> > b43_wldev *dev,
> > struct b43_phy_lp *lpphy = dev->phy.lp;
> > enum b43_lpphy_txpctl_mode oldmode;
> >
> > - oldmode = lpphy->txpctl_mode;
> > lpphy_read_tx_pctl_mode_from_hardware(dev);
> > - if (lpphy->txpctl_mode == mode)
> > + oldmode = lpphy->txpctl_mode;
> > + if (oldmode == mode)
> > return;
> > lpphy->txpctl_mode = mode;
> >
> > --
> > 1.6.2.4
> >
>
> John, any news on this one? I can't see it in wireless testing.
Larry said "It does not fix it here. I'll take a look at the specs"...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* [PATCH v5 13/33] wireless: move AIRO_CS closer to AIRO
From: Luis R. Rodriguez @ 2009-08-17 19:46 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 40 ++++++++++++++++++++--------------------
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index b489d9c..b03035f 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -213,6 +213,26 @@ config AIRO
The driver can be compiled as a module and will be named "airo".
+config AIRO_CS
+ tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
+ depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
+ select WIRELESS_EXT
+ select CRYPTO
+ select CRYPTO_AES
+ ---help---
+ This is the standard Linux driver to support Cisco/Aironet PCMCIA
+ 802.11 wireless cards. This driver is the same as the Aironet
+ driver part of the Linux Pcmcia package.
+ It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
+ - with or without encryption) as well as card before the Cisco
+ acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
+ supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
+ 802.11b cards.
+
+ This driver support both the standard Linux Wireless Extensions
+ and Cisco proprietary API, so both the Linux Wireless Tools and the
+ Cisco Linux utilities can be used to configure the card.
+
config ATMEL_80211
bool "Atmel"
depends on WLAN_80211
@@ -265,26 +285,6 @@ config AT76C50X_USB
endif # ATMEL_80211
-config AIRO_CS
- tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
- depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
- select WIRELESS_EXT
- select CRYPTO
- select CRYPTO_AES
- ---help---
- This is the standard Linux driver to support Cisco/Aironet PCMCIA
- 802.11 wireless cards. This driver is the same as the Aironet
- driver part of the Linux Pcmcia package.
- It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
- - with or without encryption) as well as card before the Cisco
- acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
- supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
- 802.11b cards.
-
- This driver support both the standard Linux Wireless Extensions
- and Cisco proprietary API, so both the Linux Wireless Tools and the
- Cisco Linux utilities can be used to configure the card.
-
config PCMCIA_WL3501
tristate "Planet WL3501 PCMCIA cards"
depends on EXPERIMENTAL && PCMCIA && WLAN_80211
--
1.6.2.5
^ permalink raw reply related
* Re: [PATCH v5 13/33] wireless: move AIRO_CS closer to AIRO_CS
From: Luis R. Rodriguez @ 2009-08-17 19:45 UTC (permalink / raw)
To: Gábor Stefanik; +Cc: linville, linux-wireless
In-Reply-To: <69e28c910908171222g17e9563csd38dadfcc8fe0bae@mail.gmail.com>
2009/8/17 Gábor Stefanik <netrolller.3d@gmail.com>:
> On Mon, Aug 17, 2009 at 7:27 PM, Luis R.
> Rodriguez<lrodriguez@atheros.com> wrote:
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>> drivers/net/wireless/Kconfig | 40 ++++++++++++++++++++--------------------
>> 1 files changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
>> index b489d9c..b03035f 100644
>> --- a/drivers/net/wireless/Kconfig
>> +++ b/drivers/net/wireless/Kconfig
>> @@ -213,6 +213,26 @@ config AIRO
>>
>> The driver can be compiled as a module and will be named "airo".
>>
>> +config AIRO_CS
>> + tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
>> + depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
>> + select WIRELESS_EXT
>> + select CRYPTO
>> + select CRYPTO_AES
>> + ---help---
>> + This is the standard Linux driver to support Cisco/Aironet PCMCIA
>> + 802.11 wireless cards. This driver is the same as the Aironet
>> + driver part of the Linux Pcmcia package.
>> + It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
>> + - with or without encryption) as well as card before the Cisco
>> + acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
>> + supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
>> + 802.11b cards.
>> +
>> + This driver support both the standard Linux Wireless Extensions
>> + and Cisco proprietary API, so both the Linux Wireless Tools and the
>> + Cisco Linux utilities can be used to configure the card.
>> +
>> config ATMEL_80211
>> bool "Atmel"
>> depends on WLAN_80211
>> @@ -265,26 +285,6 @@ config AT76C50X_USB
>>
>> endif # ATMEL_80211
>>
>> -config AIRO_CS
>> - tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
>> - depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
>> - select WIRELESS_EXT
>> - select CRYPTO
>> - select CRYPTO_AES
>> - ---help---
>> - This is the standard Linux driver to support Cisco/Aironet PCMCIA
>> - 802.11 wireless cards. This driver is the same as the Aironet
>> - driver part of the Linux Pcmcia package.
>> - It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
>> - - with or without encryption) as well as card before the Cisco
>> - acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
>> - supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
>> - 802.11b cards.
>> -
>> - This driver support both the standard Linux Wireless Extensions
>> - and Cisco proprietary API, so both the Linux Wireless Tools and the
>> - Cisco Linux utilities can be used to configure the card.
>> -
>> config PCMCIA_WL3501
>> tristate "Planet WL3501 PCMCIA cards"
>> depends on EXPERIMENTAL && PCMCIA && WLAN_80211
>> --
>> 1.6.2.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> AIRO_CS has an identity crisis again...
Heh, will resend with a fix in the commit log entry.
Thanks,
Luis
^ permalink raw reply
* [RFT/RFC] p54: fix broadcast buffering in AP mode
From: Christian Lamparter @ 2009-08-17 19:24 UTC (permalink / raw)
To: linux-wireless; +Cc: John Linville, Johannes Berg
The patch "mac80211: fix PS-poll response race" somehow broke
broadcast buffering in a funny way.
During normal operation - stations are awake - the firmware refused
to transmit broadcast frames and reported P54_TX_PSM_CANCELLED.
But everything worked as soon as one station entered PSM.
The best explanation I could come up with is:
The stack sets IEEE80211_TX_CTL_SEND_AFTER_DTIM for outgoing
broadcast frames as soon as a station is marked as sleeping.
This flag triggers a path which will reroute these frames
into p54's "content after beacon" queue.
The most likely reason why this worked before is because mac80211
always sets IEEE80211_TX_CTL_CLEAR_PS_FILT flag for outgoing
broadcast frames. This once - before the PS-poll patch -
was used to signalize the firmware to overwrite the
ps canceling for this special frame.
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff --git a/drivers/net/wireless/p54/fwio.c b/drivers/net/wireless/p54/fwio.c
index e7b9e9c..57a0ffd 100644
--- a/drivers/net/wireless/p54/fwio.c
+++ b/drivers/net/wireless/p54/fwio.c
@@ -283,7 +283,10 @@ int p54_sta_unlock(struct p54_common *priv, u8 *addr)
return -ENOMEM;
sta = (struct p54_sta_unlock *)skb_put(skb, sizeof(*sta));
- memcpy(sta->addr, addr, ETH_ALEN);
+ if (addr)
+ memcpy(sta->addr, addr, ETH_ALEN);
+ else
+ memset(sta->addr, ~0, ETH_ALEN);
p54_tx(priv, skb);
return 0;
}
diff --git a/drivers/net/wireless/p54/main.c b/drivers/net/wireless/p54/main.c
index 77203e3..db415c2 100644
--- a/drivers/net/wireless/p54/main.c
+++ b/drivers/net/wireless/p54/main.c
@@ -38,20 +38,42 @@ static void p54_sta_notify(struct ieee80211_hw *dev, struct ieee80211_vif *vif,
struct ieee80211_sta *sta)
{
struct p54_common *priv = dev->priv;
+ struct p54_sta_info *sta_info = (void *) sta->drv_priv;
+
switch (notify_cmd) {
case STA_NOTIFY_ADD:
case STA_NOTIFY_REMOVE:
+ case STA_NOTIFY_AWAKE:
/*
* Notify the firmware that we don't want or we don't
* need to buffer frames for this station anymore.
*/
p54_sta_unlock(priv, sta->addr);
+
+ if (sta_info->state & STA_DOZING) {
+ if (atomic_dec_and_test(&priv->num_sta_ps)) {
+ /*
+ * The last station has woken up.
+ *
+ * Disable broadcast ps filter, which has
+ * been secretly set by firmware.
+ */
+
+ p54_sta_unlock(priv, NULL);
+ }
+ }
+
+ sta_info->state &= ~STA_DOZING;
break;
- case STA_NOTIFY_AWAKE:
- /* update the firmware's filter table */
- p54_sta_unlock(priv, sta->addr);
+
+ case STA_NOTIFY_SLEEP:
+ if (!(sta_info->state & STA_DOZING))
+ atomic_inc(&priv->num_sta_ps);
+
+ sta_info->state |= STA_DOZING;
break;
+
default:
break;
}
@@ -185,6 +207,8 @@ static int p54_start(struct ieee80211_hw *dev)
priv->softled_state = 0;
err = p54_set_leds(priv);
+ atomic_set(&priv->num_sta_ps, 0);
+
out:
mutex_unlock(&priv->conf_mutex);
return err;
@@ -581,6 +605,8 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
*/
dev->wiphy->ps_default = false;
+ dev->sta_data_size = sizeof(struct p54_sta_info);
+
mutex_init(&priv->conf_mutex);
mutex_init(&priv->eeprom_mutex);
init_completion(&priv->eeprom_comp);
diff --git a/drivers/net/wireless/p54/p54.h b/drivers/net/wireless/p54/p54.h
index 1afc394..8cacb7a 100644
--- a/drivers/net/wireless/p54/p54.h
+++ b/drivers/net/wireless/p54/p54.h
@@ -228,6 +228,7 @@ struct p54_common {
/* statistics */
struct ieee80211_low_level_stats stats;
struct delayed_work work;
+ atomic_t num_sta_ps;
/* eeprom handling */
void *eeprom;
@@ -235,6 +236,14 @@ struct p54_common {
struct mutex eeprom_mutex;
};
+enum p54_sta_state_t {
+ STA_DOZING = BIT(0),
+};
+
+struct p54_sta_info {
+ enum p54_sta_state_t state;
+};
+
/* interfaces for the drivers */
int p54_rx(struct ieee80211_hw *dev, struct sk_buff *skb);
void p54_free_skb(struct ieee80211_hw *dev, struct sk_buff *skb);
---
Of course, instead of the big patch above we could restore the
original behavior with:
diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c
index 6fc0b61..b6dda2b 100644
--- a/drivers/net/wireless/p54/txrx.c
+++ b/drivers/net/wireless/p54/txrx.c
@@ -623,6 +623,9 @@ static void p54_tx_80211_header(struct p54_common *priv, struct sk_buff *skb,
if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE)
*flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
+ if (info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT)
+ *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
+
*queue = skb_get_queue_mapping(skb) + P54_QUEUE_DATA;
switch (priv->mode) {
---
pools are open! Didn't have a chance to test them on real HW & setup.
Please report if these patches fix/break anything...
Regards,
Chr
^ permalink raw reply related
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
From: Gábor Stefanik @ 2009-08-17 19:33 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
In-Reply-To: <4A85AD1B.1060008@gmail.com>
2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> Check the mode the hardware is in, not the mode we used the last time.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> Mark, please test if this fixes the TX power control WARN_ON you were
> seeing.
>
> drivers/net/wireless/b43/phy_lp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 292ee51..76457f7 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
> b43_wldev *dev,
> struct b43_phy_lp *lpphy = dev->phy.lp;
> enum b43_lpphy_txpctl_mode oldmode;
>
> - oldmode = lpphy->txpctl_mode;
> lpphy_read_tx_pctl_mode_from_hardware(dev);
> - if (lpphy->txpctl_mode == mode)
> + oldmode = lpphy->txpctl_mode;
> + if (oldmode == mode)
> return;
> lpphy->txpctl_mode = mode;
>
> --
> 1.6.2.4
>
John, any news on this one? I can't see it in wireless testing.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration
From: Gábor Stefanik @ 2009-08-17 19:32 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
In-Reply-To: <4A85B8DE.3000704@gmail.com>
2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> Call set_tx_power_control with a LPPHY_TXPCTL rather than an
> LPPHY_TX_PWR_CTL_CMD_MODE.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> This should fix the WARN_ON testers were seeing during init.
>
> drivers/net/wireless/b43/phy_lp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index adfa7bf..558224b 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev
> *dev)
> old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) &
> B43_LPPHY_TX_PWR_CTL_CMD_MODE;
>
> - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF);
> + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
> lpphy_disable_crs(dev);
> loopback = lpphy_loopback(dev);
> if (loopback == -1)
> --
> 1.6.2.4
>
John, any news on this one? I can't see it in wireless testing.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH v5 13/33] wireless: move AIRO_CS closer to AIRO_CS
From: Gábor Stefanik @ 2009-08-17 19:22 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless
In-Reply-To: <1250530052-14783-14-git-send-email-lrodriguez@atheros.com>
On Mon, Aug 17, 2009 at 7:27 PM, Luis R.
Rodriguez<lrodriguez@atheros.com> wrote:
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> drivers/net/wireless/Kconfig | 40 ++++++++++++++++++++--------------------
> 1 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> index b489d9c..b03035f 100644
> --- a/drivers/net/wireless/Kconfig
> +++ b/drivers/net/wireless/Kconfig
> @@ -213,6 +213,26 @@ config AIRO
>
> The driver can be compiled as a module and will be named "airo".
>
> +config AIRO_CS
> + tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
> + depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
> + select WIRELESS_EXT
> + select CRYPTO
> + select CRYPTO_AES
> + ---help---
> + This is the standard Linux driver to support Cisco/Aironet PCMCIA
> + 802.11 wireless cards. This driver is the same as the Aironet
> + driver part of the Linux Pcmcia package.
> + It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
> + - with or without encryption) as well as card before the Cisco
> + acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
> + supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
> + 802.11b cards.
> +
> + This driver support both the standard Linux Wireless Extensions
> + and Cisco proprietary API, so both the Linux Wireless Tools and the
> + Cisco Linux utilities can be used to configure the card.
> +
> config ATMEL_80211
> bool "Atmel"
> depends on WLAN_80211
> @@ -265,26 +285,6 @@ config AT76C50X_USB
>
> endif # ATMEL_80211
>
> -config AIRO_CS
> - tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
> - depends on PCMCIA && (BROKEN || !M32R) && WLAN_80211
> - select WIRELESS_EXT
> - select CRYPTO
> - select CRYPTO_AES
> - ---help---
> - This is the standard Linux driver to support Cisco/Aironet PCMCIA
> - 802.11 wireless cards. This driver is the same as the Aironet
> - driver part of the Linux Pcmcia package.
> - It supports the new 802.11b cards from Cisco (Cisco 34X, Cisco 35X
> - - with or without encryption) as well as card before the Cisco
> - acquisition (Aironet 4500, Aironet 4800, Aironet 4800B). It also
> - supports OEM of Cisco such as the DELL TrueMobile 4800 and Xircom
> - 802.11b cards.
> -
> - This driver support both the standard Linux Wireless Extensions
> - and Cisco proprietary API, so both the Linux Wireless Tools and the
> - Cisco Linux utilities can be used to configure the card.
> -
> config PCMCIA_WL3501
> tristate "Planet WL3501 PCMCIA cards"
> depends on EXPERIMENTAL && PCMCIA && WLAN_80211
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
AIRO_CS has an identity crisis again...
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* [PATCH v5 26/33] wireless: mark prism54 as deprecated and mark for removal
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Luis R. Rodriguez, aquilaver, linux-kernel,
Dan Williams, Kai Engert, Jean Tourrilhes, Tim de Waal,
Roy Marples, Alan Cox, Christian Lamparter, Björn Steinbrink,
Tim Gardner, Larry Finger, Johannes Berg
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
The preferred modules is p54 which also supports FullMAC
PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
to remove this is no one really is testing prism54 anymore,
and while it works p54 provides support for the same hardware.
It should be noted I have been told some FullMAC devices may not
have worked with the SoftMAC driver but to date we have yet to
recieve a single bug report regarding this. If there are users
out there please let us know!
Cc: aquilaver@yahoo.com
Cc: linux-kernel@vger.kernel.org
Cc: Dan Williams <dcbw@redhat.com>
Cc: Kai Engert <kengert@redhat.com>
Cc: Jean Tourrilhes <jt@hpl.hp.com>
Cc: Tim de Waal<tim.dewaal@yahoo.com>
Cc: Roy Marples <uberlord@gentoo.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Christian Lamparter <chunkeey@web.de>
Cc: Björn Steinbrink <B.Steinbrink@gmx.de>
Cc: Tim Gardner <tim.gardner@canonical.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Documentation/feature-removal-schedule.txt | 29 +++++++++++++++
drivers/net/wireless/Kconfig | 53 +++++++--------------------
2 files changed, 43 insertions(+), 39 deletions(-)
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 09e031c..147688a 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -6,6 +6,35 @@ be removed from this file.
---------------------------
+What: PRISM54
+When: 2.6.34
+
+Why: prism54 FullMAC PCI / Cardbus devices used to be supported only by the
+ prism54 wireless driver. After Intersil stopped selling these
+ devices in preference for the newer more flexible SoftMAC devices
+ a SoftMAC device driver was required and prism54 did not support
+ them. The p54 driver now exists and has been present in the kernel for
+ a while. This driver supports both SoftMAC devices and FullMAC devices.
+ The main difference between these devices was the amount of memory which
+ could be used for the firmware. The SoftMAC devices support a smaller
+ amount of memory. Because of this the SoftMAC firmware fits into FullMAC
+ devices's memory. p54 supports not only PCI / Cardbus but also USB
+ and SPI. Since p54 supports all devices prism54 supports
+ you will have a conflict. I'm not quite sure how distributions are
+ handling this conflict right now. prism54 was kept around due to
+ claims users may experience issues when using the SoftMAC driver.
+ Time has passed users have not reported issues. If you use prism54
+ and for whatever reason you cannot use p54 please let us know!
+ E-mail us at: linux-wireless@vger.kernel.org
+
+ For more information see the p54 wiki page:
+
+ http://wireless.kernel.org/en/users/Drivers/p54
+
+Who: Luis R. Rodriguez <lrodriguez@atheros.com>
+
+---------------------------
+
What: IRQF_SAMPLE_RANDOM
Check: IRQF_SAMPLE_RANDOM
When: July 2009
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 6be46f3..ed9093f 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -258,51 +258,26 @@ if CONEXANT_ST_80211
source "drivers/net/wireless/p54/Kconfig"
config PRISM54
- tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus'
+ tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus (DEPRECATED)'
depends on PCI && EXPERIMENTAL
select WIRELESS_EXT
select FW_LOADER
---help---
- Enable PCI and Cardbus support for the following chipset based cards:
+ This enables support for FullMAC PCI/Cardbus prism54 devices. This
+ driver is now deprecated in favor for the SoftMAC driver, p54. p54
+ supports FullMAC PCI/Cardbus devices as well. For details on the
+ removal of this driver on the kernel see the feature removal
+ schedule:
- ISL3880 - Prism GT 802.11 b/g
- ISL3877 - Prism Indigo 802.11 a
- ISL3890 - Prism Duette 802.11 a/b/g
-
- For a complete list of supported cards visit <http://prism54.org>.
- Here is the latest confirmed list of supported cards:
-
- 3com OfficeConnect 11g Cardbus Card aka 3CRWE154G72 (version 1)
- Allnet ALL0271 PCI Card
- Compex WL54G Cardbus Card
- Corega CG-WLCB54GT Cardbus Card
- D-Link Air Plus Xtreme G A1 Cardbus Card aka DWL-g650
- I-O Data WN-G54/CB Cardbus Card
- Kobishi XG-300 aka Z-Com Cardbus Card
- Netgear WG511 Cardbus Card
- Ovislink WL-5400PCI PCI Card
- Peabird WLG-PCI PCI Card
- Sitecom WL-100i Cardbus Card
- Sitecom WL-110i PCI Card
- SMC2802W - EZ Connect g 2.4GHz 54 Mbps Wireless PCI Card
- SMC2835W - EZ Connect g 2.4GHz 54 Mbps Wireless Cardbus Card
- SMC2835W-V2 - EZ Connect g 2.4GHz 54 Mbps Wireless Cardbus Card
- Z-Com XG-900 PCI Card
- Zyxel G-100 Cardbus Card
-
- If you enable this you will need a firmware file as well.
- You will need to copy this to /usr/lib/hotplug/firmware/isl3890.
- You can get this non-GPL'd firmware file from the Prism54 project page:
- <http://prism54.org>
- You will also need the /etc/hotplug/firmware.agent script from
- a current hotplug package.
-
- Note: You need a motherboard with DMA support to use any of these cards
+ Documentation/feature-removal-schedule.txt
+
+ For more information refer to the prism54 wiki:
+
+ http://wireless.kernel.org/en/users/Drivers/p54
+
+ Note: You need a motherboard with DMA support to use any of these cards
- If you want to compile the driver as a module ( = code which can be
- inserted in and removed from the running kernel whenever you want),
- say M here and read <file:Documentation/kbuild/modules.txt>.
- The module will be called prism54.
+ When built as module you get the module prism54
endif # CONEXANT_ST_80211
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 25/33] wireless: make ath consistent with the other groups
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/ath/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/Kconfig b/drivers/net/wireless/ath/Kconfig
index 9bfa909..b974b73 100644
--- a/drivers/net/wireless/ath/Kconfig
+++ b/drivers/net/wireless/ath/Kconfig
@@ -1,5 +1,5 @@
menuconfig ATH_COMMON
- tristate "Atheros Wireless Cards"
+ tristate "Atheros"
depends on CFG80211
---help---
This will enable the support for the Atheros wireless drivers.
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 29/33] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
cfg80211 is now *the* wireless configuration API. Lets also
give a little explanation as to what it is and refer people to
the wireless wiki for more information.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index c6031d5..1591e2b 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -1,6 +1,15 @@
config CFG80211
- tristate "Improved wireless configuration API"
+ tristate "cfg80211 - wireless configuration API"
depends on RFKILL || !RFKILL
+ ---help---
+ cfg80211 is the Linux wireless LAN (802.11) configuration API.
+ Enable this if you have a wireless device.
+
+ For more information refer to documentation on the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/cfg80211
+
+ When built as a module cfg80211 will be built as cfg80211
config NL80211_TESTMODE
bool "nl80211 testmode command"
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 28/33] wireless: update wireless kconfig description
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
"Wireless" is a misnomer 802.11 as there are plently
of other wireless technologies. Be more specific and refer
people to our good hearty wireless wiki for documentation.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/Kconfig | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/net/Kconfig b/net/Kconfig
index 041c35e..31c208d 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -260,9 +260,15 @@ config FIB_RULES
bool
menuconfig WIRELESS
- bool "Wireless"
+ bool "IEEE 802.11 - Wireless LAN"
depends on !S390
default y
+ ---help---
+ This allows you to enable different parts of the networking subsystem
+ to support IEEE 802.11 Wireless LAN networks. For news and
+ documentation refer to the wireless wiki:
+
+ http://wireless.kernel.org
if WIRELESS
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 23/33] wireless: downgrade TI driver from menuconfig to config
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Kalle Valo
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
There's only a few options here so let this expand upon
selection. To give it the same effect of a menuconfig
though we ifdef the options based on the base config
menu selection. Because of this new check we can simplify
the kconfig entries to not depend on WL12XX anymore as that
is now implied.
Cc: Kalle Valo <kalle.valo@nokia.com>
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/wl12xx/Kconfig | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/Kconfig b/drivers/net/wireless/wl12xx/Kconfig
index 1818e45..ef250e9 100644
--- a/drivers/net/wireless/wl12xx/Kconfig
+++ b/drivers/net/wireless/wl12xx/Kconfig
@@ -1,13 +1,15 @@
-menuconfig WL12XX
+config WL12XX
boolean "TI wl12xx driver support"
depends on MAC80211 && EXPERIMENTAL
---help---
This will enable TI wl12xx driver support. The drivers make
use of the mac80211 stack.
+if WL12XX
+
config WL1251
tristate "TI wl1251 support"
- depends on WL12XX && GENERIC_HARDIRQS
+ depends on GENERIC_HARDIRQS
select FW_LOADER
select CRC7
---help---
@@ -41,7 +43,7 @@ config WL1251_SDIO
config WL1271
tristate "TI wl1271 support"
- depends on WL12XX && SPI_MASTER && GENERIC_HARDIRQS
+ depends on SPI_MASTER && GENERIC_HARDIRQS
select FW_LOADER
select CRC7
---help---
@@ -50,3 +52,5 @@ config WL1271
If you choose to build a module, it'll be called wl1271. Say N if
unsure.
+
+endif # WL12XX
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 32/33] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Jouni Malinen, Johannes Berg
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
This updates the mac80211 kconfig entry to clarify
what it is and refer people to our wireless wiki for
more documentation.
Cc: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/mac80211/Kconfig | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 9db4ff8..72006f9 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -1,5 +1,5 @@
config MAC80211
- tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
+ tristate "mac80211 - SoftMAC device support"
depends on CFG80211
select CRYPTO
select CRYPTO_ECB
@@ -7,8 +7,21 @@ config MAC80211
select CRYPTO_AES
select CRC32
---help---
- This option enables the hardware independent IEEE 802.11
- networking stack.
+ This option enables support for a framework used by IEEE-802.11
+ SoftMAC devices. SoftMAC devices allow for a finer control of the
+ hardware, allowing for 802.11 frame management to be done in software
+ for them, for both parsing and generation of 802.11 wireless frames.
+ Most 802.11 devices today tend to be of this type.
+
+ If you have new userspace utitlities which support nl80211 you do not
+ need wireless-extensions to support a mac80211 device.
+
+ For more information refer the the wireless wiki entry on mac80211:
+
+ http://wireless.kernel.org/en/developers/Documentation/mac80211
+
+ When built as a module mac80211 will be built as mac80211, if not sure
+ you should build this as a module.
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 27/33] wireless: update top level wireless driver entry
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
Change it to a menuconfig to give it some documentation, to
refer users to our wireless wiki for extra resources and
documentation. It seems our wiki is still obscure to some.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index ed9093f..2dab145 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -2,8 +2,17 @@
# Wireless LAN device configuration
#
-menu "Wireless LAN"
+menuconfig WLAN
+ bool "IEEE 802.11 - Wireless LAN"
depends on !S390
+ ---help---
+ This section contains all the pre 802.11 and 802.11 wireless
+ device drivers. For a complete list of drivers and documentation
+ on them refer to the wireless wiki:
+
+ http://wireless.kernel.org/en/users/Drivers
+
+if WLAN
menuconfig WLAN_PRE80211
bool "Wireless LAN (pre-802.11)"
@@ -579,4 +588,4 @@ config MAC80211_HWSIM
To compile this driver as a module, choose M here: the module will be
called mac80211_hwsim. If unsure, say N.
-endmenu
+endif # WLAN
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 30/33] wireless: update reg debug kconfig entry
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
Refer to the wireless wiki for more information.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 1591e2b..991e177 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -32,6 +32,10 @@ config CFG80211_REG_DEBUG
default n
---help---
You can enable this if you want to debug regulatory changes.
+ For more information on cfg80211 regulatory refer to the wireless
+ wiki:
+
+ http://wireless.kernel.org/en/developers/Regulatory
If unsure, say N.
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 31/33] wireless: update WIRELESS_EXT kconfig entry
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
Provide more documentation as to why its being deprecated.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 991e177..982004b 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -81,8 +81,16 @@ config WIRELESS_EXT
bool "Wireless extensions"
default y
---help---
- This option enables the legacy wireless extensions
- (wireless network interface configuration via ioctls.)
+ This option enables the legacy wireless extensions.
+ Wireless extensions was the first 802.11 wireless configuration
+ API used by the networking subsystem. You will not need this unless
+ you have old userspace utilities or old wireless devices which
+ have not yet been ported to cfg80211.
+
+ Wireless extensions is being deprecated in favor for cfg80211. For
+ information regarding why see the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/Wireless-Extensions
Say Y unless you've upgraded all your userspace to use
nl80211 instead of wireless extensions.
--
1.6.2.5
^ permalink raw reply related
* [PATCH v5 33/33] wireless: remove mac80211 rate selection extra menu
From: Luis R. Rodriguez @ 2009-08-17 17:27 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1250530052-14783-1-git-send-email-lrodriguez@atheros.com>
We can just display this upon enabling mac80211 with an
'if MAC80211 != n' check.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/mac80211/Kconfig | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 72006f9..8300d19 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -26,8 +26,7 @@ config MAC80211
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
-menu "Rate control algorithm selection"
- depends on MAC80211 != n
+if MAC80211 != n
config MAC80211_RC_PID
bool "PID controller based rate control algorithm" if EMBEDDED
@@ -74,7 +73,7 @@ config MAC80211_RC_DEFAULT
default "pid" if MAC80211_RC_DEFAULT_PID
default ""
-endmenu
+endif
config MAC80211_MESH
bool "Enable mac80211 mesh networking (pre-802.11s) support"
--
1.6.2.5
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox