* [PATCH 1/7] wireless: update top level wireless driver entry
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
Change it to a menuconfig to give it some documentation, to
refer users to our wireless wiki for extra resources and
documentation. It seems our wiki is still obscure to some.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/Kconfig | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index dda7cc2..1e45444 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -2,8 +2,17 @@
# Wireless LAN device configuration
#
-menu "Wireless LAN"
+menuconfig WLAN
+ bool "IEEE 802.11 - Wireless LAN"
depends on !S390
+ ---help---
+ This section contains all the pre 802.11 and 802.11 wireless
+ device drivers. For a complete list of drivers and documentation
+ on them refer to the wireless wiki:
+
+ http://wireless.kernel.org/en/users/Drivers
+
+if WLAN
menuconfig WLAN_PRE80211
bool "Wireless LAN (pre-802.11)"
@@ -506,4 +515,4 @@ source "drivers/net/wireless/orinoco/Kconfig"
source "drivers/net/wireless/wl12xx/Kconfig"
source "drivers/net/wireless/iwmc3200wifi/Kconfig"
-endmenu
+endif # WLAN
--
1.6.3.3
^ permalink raw reply related
* [PATCH 2/7] wireless: update wireless kconfig description
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
"Wireless" is a misnomer 802.11 as there are plently
of other wireless technologies. Be more specific and refer
people to our good hearty wireless wiki for documentation.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/Kconfig | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/net/Kconfig b/net/Kconfig
index 041c35e..31c208d 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -260,9 +260,15 @@ config FIB_RULES
bool
menuconfig WIRELESS
- bool "Wireless"
+ bool "IEEE 802.11 - Wireless LAN"
depends on !S390
default y
+ ---help---
+ This allows you to enable different parts of the networking subsystem
+ to support IEEE 802.11 Wireless LAN networks. For news and
+ documentation refer to the wireless wiki:
+
+ http://wireless.kernel.org
if WIRELESS
--
1.6.3.3
^ permalink raw reply related
* [PATCH 3/7] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
cfg80211 is now *the* wireless configuration API. Lets also
give a little explanation as to what it is and refer people to
the wireless wiki for more information.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index aea7e68..9fd570b 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -1,6 +1,15 @@
config CFG80211
- tristate "Improved wireless configuration API"
+ tristate "cfg80211 - wireless configuration API"
depends on RFKILL || !RFKILL
+ ---help---
+ cfg80211 is the Linux wireless LAN (802.11) configuration API.
+ Enable this if you have a wireless device.
+
+ For more information refer to documentation on the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/cfg80211
+
+ When built as a module cfg80211 will be built as cfg80211
config NL80211_TESTMODE
bool "nl80211 testmode command"
--
1.6.3.3
^ permalink raw reply related
* [PATCH 4/7] wireless: update reg debug kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
Refer to the wireless wiki for more information.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 9fd570b..08f6733 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -49,6 +49,10 @@ config CFG80211_REG_DEBUG
default n
---help---
You can enable this if you want to debug regulatory changes.
+ For more information on cfg80211 regulatory refer to the wireless
+ wiki:
+
+ http://wireless.kernel.org/en/developers/Regulatory
If unsure, say N.
--
1.6.3.3
^ permalink raw reply related
* [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
Provide more documentation as to why its being deprecated.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/Kconfig | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 08f6733..521ef6a 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -98,8 +98,16 @@ config WIRELESS_EXT
bool "Wireless extensions"
default y
---help---
- This option enables the legacy wireless extensions
- (wireless network interface configuration via ioctls.)
+ This option enables the legacy wireless extensions.
+ Wireless extensions was the first 802.11 wireless configuration
+ API used by the networking subsystem. You will not need this unless
+ you have old userspace utilities or old wireless devices which
+ have not yet been ported to cfg80211.
+
+ Wireless extensions is being deprecated in favor for cfg80211. For
+ information regarding why see the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/Wireless-Extensions
Say Y unless you've upgraded all your userspace to use
nl80211 instead of wireless extensions.
--
1.6.3.3
^ permalink raw reply related
* [PATCH 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Jouni Malinen, Johannes Berg
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
This updates the mac80211 kconfig entry to clarify
what it is and refer people to our wireless wiki for
more documentation.
Cc: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/mac80211/Kconfig | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 9db4ff8..72006f9 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -1,5 +1,5 @@
config MAC80211
- tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
+ tristate "mac80211 - SoftMAC device support"
depends on CFG80211
select CRYPTO
select CRYPTO_ECB
@@ -7,8 +7,21 @@ config MAC80211
select CRYPTO_AES
select CRC32
---help---
- This option enables the hardware independent IEEE 802.11
- networking stack.
+ This option enables support for a framework used by IEEE-802.11
+ SoftMAC devices. SoftMAC devices allow for a finer control of the
+ hardware, allowing for 802.11 frame management to be done in software
+ for them, for both parsing and generation of 802.11 wireless frames.
+ Most 802.11 devices today tend to be of this type.
+
+ If you have new userspace utitlities which support nl80211 you do not
+ need wireless-extensions to support a mac80211 device.
+
+ For more information refer the the wireless wiki entry on mac80211:
+
+ http://wireless.kernel.org/en/developers/Documentation/mac80211
+
+ When built as a module mac80211 will be built as mac80211, if not sure
+ you should build this as a module.
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
--
1.6.3.3
^ permalink raw reply related
* [PATCH 7/7] wireless: remove mac80211 rate selection extra menu
From: Luis R. Rodriguez @ 2009-09-01 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
In-Reply-To: <1251818566-9264-1-git-send-email-lrodriguez@atheros.com>
We can just display this upon enabling mac80211 with an
'if MAC80211 != n' check.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/mac80211/Kconfig | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 72006f9..8300d19 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -26,8 +26,7 @@ config MAC80211
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
-menu "Rate control algorithm selection"
- depends on MAC80211 != n
+if MAC80211 != n
config MAC80211_RC_PID
bool "PID controller based rate control algorithm" if EMBEDDED
@@ -74,7 +73,7 @@ config MAC80211_RC_DEFAULT
default "pid" if MAC80211_RC_DEFAULT_PID
default ""
-endmenu
+endif
config MAC80211_MESH
bool "Enable mac80211 mesh networking (pre-802.11s) support"
--
1.6.3.3
^ permalink raw reply related
* [PATCH] wireless: mark prism54 as deprecated and mark for removal
From: Luis R. Rodriguez @ 2009-09-01 15:31 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Luis R. Rodriguez, aquilaver, linux-kernel,
Dan Williams, Kai Engert, Jean Tourrilhes, Tim de Waal,
Roy Marples, Alan Cox, Christian Lamparter, Björn Steinbrink,
Tim Gardner, Larry Finger, Johannes Berg
The preferred modules is p54 which also supports FullMAC
PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
to remove this is no one really is testing prism54 anymore,
and while it works p54 provides support for the same hardware.
It should be noted I have been told some FullMAC devices may not
have worked with the SoftMAC driver but to date we have yet to
recieve a single bug report regarding this. If there are users
out there please let us know!
Cc: aquilaver@yahoo.com
Cc: linux-kernel@vger.kernel.org
Cc: Dan Williams <dcbw@redhat.com>
Cc: Kai Engert <kengert@redhat.com>
Cc: Jean Tourrilhes <jt@hpl.hp.com>
Cc: Tim de Waal<tim.dewaal@yahoo.com>
Cc: Roy Marples <uberlord@gentoo.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Christian Lamparter <chunkeey@web.de>
Cc: Björn Steinbrink <B.Steinbrink@gmx.de>
Cc: Tim Gardner <tim.gardner@canonical.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Documentation/feature-removal-schedule.txt | 29 ++++++++++++++
drivers/net/wireless/Kconfig | 57 ++++++++--------------------
2 files changed, 45 insertions(+), 41 deletions(-)
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 09e031c..147688a 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -6,6 +6,35 @@ be removed from this file.
---------------------------
+What: PRISM54
+When: 2.6.34
+
+Why: prism54 FullMAC PCI / Cardbus devices used to be supported only by the
+ prism54 wireless driver. After Intersil stopped selling these
+ devices in preference for the newer more flexible SoftMAC devices
+ a SoftMAC device driver was required and prism54 did not support
+ them. The p54 driver now exists and has been present in the kernel for
+ a while. This driver supports both SoftMAC devices and FullMAC devices.
+ The main difference between these devices was the amount of memory which
+ could be used for the firmware. The SoftMAC devices support a smaller
+ amount of memory. Because of this the SoftMAC firmware fits into FullMAC
+ devices's memory. p54 supports not only PCI / Cardbus but also USB
+ and SPI. Since p54 supports all devices prism54 supports
+ you will have a conflict. I'm not quite sure how distributions are
+ handling this conflict right now. prism54 was kept around due to
+ claims users may experience issues when using the SoftMAC driver.
+ Time has passed users have not reported issues. If you use prism54
+ and for whatever reason you cannot use p54 please let us know!
+ E-mail us at: linux-wireless@vger.kernel.org
+
+ For more information see the p54 wiki page:
+
+ http://wireless.kernel.org/en/users/Drivers/p54
+
+Who: Luis R. Rodriguez <lrodriguez@atheros.com>
+
+---------------------------
+
What: IRQF_SAMPLE_RANDOM
Check: IRQF_SAMPLE_RANDOM
When: July 2009
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 1e45444..a1c8a7c 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -275,51 +275,26 @@ config PCMCIA_WL3501
micro support for ethtool.
config PRISM54
- tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus'
+ tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus (DEPRECATED)'
depends on PCI && EXPERIMENTAL && WLAN_80211
select WIRELESS_EXT
select FW_LOADER
---help---
- Enable PCI and Cardbus support for the following chipset based cards:
-
- ISL3880 - Prism GT 802.11 b/g
- ISL3877 - Prism Indigo 802.11 a
- ISL3890 - Prism Duette 802.11 a/b/g
-
- For a complete list of supported cards visit <http://prism54.org>.
- Here is the latest confirmed list of supported cards:
-
- 3com OfficeConnect 11g Cardbus Card aka 3CRWE154G72 (version 1)
- Allnet ALL0271 PCI Card
- Compex WL54G Cardbus Card
- Corega CG-WLCB54GT Cardbus Card
- D-Link Air Plus Xtreme G A1 Cardbus Card aka DWL-g650
- I-O Data WN-G54/CB Cardbus Card
- Kobishi XG-300 aka Z-Com Cardbus Card
- Netgear WG511 Cardbus Card
- Ovislink WL-5400PCI PCI Card
- Peabird WLG-PCI PCI Card
- Sitecom WL-100i Cardbus Card
- Sitecom WL-110i PCI Card
- SMC2802W - EZ Connect g 2.4GHz 54 Mbps Wireless PCI Card
- SMC2835W - EZ Connect g 2.4GHz 54 Mbps Wireless Cardbus Card
- SMC2835W-V2 - EZ Connect g 2.4GHz 54 Mbps Wireless Cardbus Card
- Z-Com XG-900 PCI Card
- Zyxel G-100 Cardbus Card
-
- If you enable this you will need a firmware file as well.
- You will need to copy this to /usr/lib/hotplug/firmware/isl3890.
- You can get this non-GPL'd firmware file from the Prism54 project page:
- <http://prism54.org>
- You will also need the /etc/hotplug/firmware.agent script from
- a current hotplug package.
-
- Note: You need a motherboard with DMA support to use any of these cards
-
- If you want to compile the driver as a module ( = code which can be
- inserted in and removed from the running kernel whenever you want),
- say M here and read <file:Documentation/kbuild/modules.txt>.
- The module will be called prism54.
+ This enables support for FullMAC PCI/Cardbus prism54 devices. This
+ driver is now deprecated in favor for the SoftMAC driver, p54. p54
+ supports FullMAC PCI/Cardbus devices as well. For details on the
+ removal of this driver on the kernel see the feature removal
+ schedule:
+
+ Documentation/feature-removal-schedule.txt
+
+ For more information refer to the prism54 wiki:
+
+ http://wireless.kernel.org/en/users/Drivers/p54
+
+ Note: You need a motherboard with DMA support to use any of these cards
+
+ When built as module you get the module prism54
config USB_ZD1201
tristate "USB ZD1201 based Wireless device support"
--
1.6.3.3
^ permalink raw reply related
* Re: [PATCH 2/7] wireless: update wireless kconfig description
From: Johannes Berg @ 2009-09-01 15:31 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless
In-Reply-To: <1251818566-9264-3-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Tue, 2009-09-01 at 08:22 -0700, Luis R. Rodriguez wrote:
> "Wireless" is a misnomer 802.11 as there are plently
> of other wireless technologies. Be more specific and refer
> people to our good hearty wireless wiki for documentation.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/Kconfig | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 041c35e..31c208d 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -260,9 +260,15 @@ config FIB_RULES
> bool
>
> menuconfig WIRELESS
> - bool "Wireless"
> + bool "IEEE 802.11 - Wireless LAN"
But this also has WEXT under it which supports pre-802.11 technologies,
no? Might not matter at this point though.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: soft lockup in cfg80211 find_ie()
From: Johannes Berg @ 2009-09-01 15:33 UTC (permalink / raw)
To: Bob Copeland; +Cc: linux-wireless
In-Reply-To: <20090901121728.GA15790@hash.localnet>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Tue, 2009-09-01 at 08:17 -0400, Bob Copeland wrote:
> Hi,
>
> My laptop was on all night and at some point got stuck in a loop.
> Unfortunately I don't know exactly what happened since dmesg buffer
> filled up and there was nothing incriminating in /var/log, but
> here's my interpretation:
>
> EIP points to line 146:
>
> while (len > 2 && ies[0] != num) ...
>
> ECX holds len, which is negative (unfortunately size_t is unsigned)
> EDX holds ies, looks like a valid pointer
> EBX holds num, which is 0.
>
> This looks like this is a DoS-able bug if there are any malformed
> packets, no? I think we should change 'len' to int here.
Absolutely. Can you send a patch? Also to .31/stable.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH 3/7] wireless: update cfg80211 kconfig entry
From: Larry Finger @ 2009-09-01 15:37 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251818566-9264-4-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> cfg80211 is now *the* wireless configuration API. Lets also
> give a little explanation as to what it is and refer people to
> the wireless wiki for more information.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/wireless/Kconfig | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index aea7e68..9fd570b 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -1,6 +1,15 @@
> config CFG80211
> - tristate "Improved wireless configuration API"
> + tristate "cfg80211 - wireless configuration API"
> depends on RFKILL || !RFKILL
> + ---help---
> + cfg80211 is the Linux wireless LAN (802.11) configuration API.
> + Enable this if you have a wireless device.
> +
> + For more information refer to documentation on the wireless wiki:
> +
> + http://wireless.kernel.org/en/developers/Documentation/cfg80211
> +
> + When built as a module cfg80211 will be built as cfg80211
First of all, I think this modest change is much better than the
previous set of patches, and that the additional info you provide for
mac80211 and friends will be useful for those who don't live with
802.11 wifi all day long.
That said, I find the above statement to be a little clumsy. Perhaps
it should be "When built as a module, it will be called cfg80211". The
same comment also applies to patch 6 for mac80211.
Larry
^ permalink raw reply
* Re: [PATCH 2/7] wireless: update wireless kconfig description
From: Luis R. Rodriguez @ 2009-09-01 15:46 UTC (permalink / raw)
To: Johannes Berg
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
In-Reply-To: <1251819096.22442.17.camel@johannes.local>
On Tue, Sep 01, 2009 at 08:31:36AM -0700, Johannes Berg wrote:
> On Tue, 2009-09-01 at 08:22 -0700, Luis R. Rodriguez wrote:
> > "Wireless" is a misnomer 802.11 as there are plently
> > of other wireless technologies. Be more specific and refer
> > people to our good hearty wireless wiki for documentation.
> >
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> > net/Kconfig | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 041c35e..31c208d 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -260,9 +260,15 @@ config FIB_RULES
> > bool
> >
> > menuconfig WIRELESS
> > - bool "Wireless"
> > + bool "IEEE 802.11 - Wireless LAN"
>
> But this also has WEXT under it which supports pre-802.11 technologies,
> no?
Heh yeah, good point.
> Might not matter at this point though.
Probably not, its more 802.11 than pre now.
Luis
^ permalink raw reply
* Re: [PATCH 3/7] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:47 UTC (permalink / raw)
To: Larry Finger
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, Johannes Berg
In-Reply-To: <4A9D3FA8.9020800@lwfinger.net>
On Tue, Sep 01, 2009 at 08:37:12AM -0700, Larry Finger wrote:
> Luis R. Rodriguez wrote:
> > cfg80211 is now *the* wireless configuration API. Lets also
> > give a little explanation as to what it is and refer people to
> > the wireless wiki for more information.
> >
> > Cc: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> > net/wireless/Kconfig | 11 ++++++++++-
> > 1 files changed, 10 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> > index aea7e68..9fd570b 100644
> > --- a/net/wireless/Kconfig
> > +++ b/net/wireless/Kconfig
> > @@ -1,6 +1,15 @@
> > config CFG80211
> > - tristate "Improved wireless configuration API"
> > + tristate "cfg80211 - wireless configuration API"
> > depends on RFKILL || !RFKILL
> > + ---help---
> > + cfg80211 is the Linux wireless LAN (802.11) configuration API.
> > + Enable this if you have a wireless device.
> > +
> > + For more information refer to documentation on the wireless wiki:
> > +
> > + http://wireless.kernel.org/en/developers/Documentation/cfg80211
> > +
> > + When built as a module cfg80211 will be built as cfg80211
>
> First of all, I think this modest change is much better than the
> previous set of patches, and that the additional info you provide for
> mac80211 and friends will be useful for those who don't live with
> 802.11 wifi all day long.
>
> That said, I find the above statement to be a little clumsy. Perhaps
> it should be "When built as a module, it will be called cfg80211". The
> same comment also applies to patch 6 for mac80211.
Thanks, will resend.
Luis
^ permalink raw reply
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: Larry Finger @ 2009-09-01 15:53 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251818566-9264-6-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> Provide more documentation as to why its being deprecated.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/wireless/Kconfig | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index 08f6733..521ef6a 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -98,8 +98,16 @@ config WIRELESS_EXT
> bool "Wireless extensions"
> default y
> ---help---
> - This option enables the legacy wireless extensions
> - (wireless network interface configuration via ioctls.)
> + This option enables the legacy wireless extensions.
> + Wireless extensions was the first 802.11 wireless configuration
> + API used by the networking subsystem. You will not need this unless
> + you have old userspace utilities or old wireless devices which
> + have not yet been ported to cfg80211.
I would like this to read "You will need this if you have old
userspace utilities or old wireless devices that have not yet been
ported to cfg80211."
Larry
^ permalink raw reply
* [PATCH v2 3/7] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:53 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
cfg80211 is now *the* wireless configuration API. Lets also
give a little explanation as to what it is and refer people to
the wireless wiki for more information.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Changes description of when we build cfg80211 as a module
as pointed out by Larry.
net/wireless/Kconfig | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index aea7e68..9fd570b 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -1,6 +1,15 @@
config CFG80211
- tristate "Improved wireless configuration API"
+ tristate "cfg80211 - wireless configuration API"
depends on RFKILL || !RFKILL
+ ---help---
+ cfg80211 is the Linux wireless LAN (802.11) configuration API.
+ Enable this if you have a wireless device.
+
+ For more information refer to documentation on the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/cfg80211
+
+ When built as a module it will be called cfg80211.
config NL80211_TESTMODE
bool "nl80211 testmode command"
--
1.6.3.3
^ permalink raw reply related
* [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:54 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Jouni Malinen, Johannes Berg
This updates the mac80211 kconfig entry to clarify
what it is and refer people to our wireless wiki for
more documentation.
Cc: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Changed description of when built as a module as pointed out
by Larry.
net/mac80211/Kconfig | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 9db4ff8..72006f9 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -1,5 +1,5 @@
config MAC80211
- tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
+ tristate "mac80211 - SoftMAC device support"
depends on CFG80211
select CRYPTO
select CRYPTO_ECB
@@ -7,8 +7,21 @@ config MAC80211
select CRYPTO_AES
select CRC32
---help---
- This option enables the hardware independent IEEE 802.11
- networking stack.
+ This option enables support for a framework used by IEEE-802.11
+ SoftMAC devices. SoftMAC devices allow for a finer control of the
+ hardware, allowing for 802.11 frame management to be done in software
+ for them, for both parsing and generation of 802.11 wireless frames.
+ Most 802.11 devices today tend to be of this type.
+
+ If you have new userspace utitlities which support nl80211 you do not
+ need wireless-extensions to support a mac80211 device.
+
+ For more information refer the the wireless wiki entry on mac80211:
+
+ http://wireless.kernel.org/en/developers/Documentation/mac80211
+
+ When built as a module it will be called as mac80211, if not sure
+ you should build this as a module.
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
--
1.6.3.3
^ permalink raw reply related
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: Johannes Berg @ 2009-09-01 15:54 UTC (permalink / raw)
To: Larry Finger; +Cc: Luis R. Rodriguez, linville, linux-wireless
In-Reply-To: <4A9D436E.20509@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Tue, 2009-09-01 at 10:53 -0500, Larry Finger wrote:
> > @@ -98,8 +98,16 @@ config WIRELESS_EXT
> > bool "Wireless extensions"
> > default y
> > ---help---
> > - This option enables the legacy wireless extensions
> > - (wireless network interface configuration via ioctls.)
> > + This option enables the legacy wireless extensions.
> > + Wireless extensions was the first 802.11 wireless configuration
> > + API used by the networking subsystem. You will not need this unless
> > + you have old userspace utilities or old wireless devices which
> > + have not yet been ported to cfg80211.
>
> I would like this to read "You will need this if you have old
> userspace utilities or old wireless devices that have not yet been
> ported to cfg80211."
Don't those "select WIRELESS_EXT" anyway so you don't have a choice?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH] wireless: mark prism54 as deprecated and mark for removal
From: Larry Finger @ 2009-09-01 16:06 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: linville, linux-wireless, aquilaver, linux-kernel, Dan Williams,
Kai Engert, Jean Tourrilhes, Tim de Waal, Roy Marples, Alan Cox,
Christian Lamparter, Björn Steinbrink, Tim Gardner,
Johannes Berg
In-Reply-To: <1251819116-10004-1-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> The preferred modules is p54 which also supports FullMAC
This needs to be "modules are" or "module is". I know p54 is really a
family, but I think you specifically mean p54pci here.
> PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
> to remove this is no one really is testing prism54 anymore,
> and while it works p54 provides support for the same hardware.
===
p54pci?
> It should be noted I have been told some FullMAC devices may not
> have worked with the SoftMAC driver but to date we have yet to
> recieve a single bug report regarding this. If there are users
=======
receive
> out there please let us know!
=========
Those words can be removed.
Otherwise, ACK.
Larry
^ permalink raw reply
* Re: [PATCH] wireless: mark prism54 as deprecated and mark for removal
From: Luis R. Rodriguez @ 2009-09-01 16:15 UTC (permalink / raw)
To: Larry Finger
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, aquilaver@yahoo.com,
linux-kernel@vger.kernel.org, Dan Williams, Kai Engert,
Jean Tourrilhes, Tim de Waal, Roy Marples, Alan Cox,
Christian Lamparter, Björn Steinbrink, Tim Gardner,
Johannes Berg
In-Reply-To: <4A9D469B.9060005@lwfinger.net>
On Tue, Sep 01, 2009 at 09:06:51AM -0700, Larry Finger wrote:
> Luis R. Rodriguez wrote:
> > The preferred modules is p54 which also supports FullMAC
>
> This needs to be "modules are" or "module is". I know p54 is really a
> family, but I think you specifically mean p54pci here.
Will fix.
> > PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
> > to remove this is no one really is testing prism54 anymore,
> > and while it works p54 provides support for the same hardware.
> ===
> p54pci?
That would make it clearer, yes thanks.
> > It should be noted I have been told some FullMAC devices may not
> > have worked with the SoftMAC driver but to date we have yet to
> > recieve a single bug report regarding this. If there are users
> =======
> receive
ack
> > out there please let us know!
> =========
>
> Those words can be removed.
>
> Otherwise, ACK.
Thanks for the review, will resend with the changes.
Luis
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Jouni Malinen @ 2009-09-01 16:33 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251820465-11104-1-git-send-email-lrodriguez@atheros.com>
On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> This updates the mac80211 kconfig entry to clarify
> what it is and refer people to our wireless wiki for
> more documentation.
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
> + tristate "mac80211 - SoftMAC device support"
Uh.. Do we really need to call this SoftMAC or well have that in the
title? I prefer the current text or if you want to, just move the
mac80211 into the beginning..
> + This option enables support for a framework used by IEEE-802.11
s/IEEE-802.11/IEEE 802.11/
> + SoftMAC devices. SoftMAC devices allow for a finer control of the
Again, I don't really like the term "SoftMAC" here..
> + hardware, allowing for 802.11 frame management to be done in software
> + for them, for both parsing and generation of 802.11 wireless frames.
> + Most 802.11 devices today tend to be of this type.
s/802.11/IEEE 802.11/g
> + If you have new userspace utitlities which support nl80211 you do not
s/utitlities/utilities/
> + need wireless-extensions to support a mac80211 device.
s/wireless-extensions/wireless extensions/
> + When built as a module it will be called as mac80211, if not sure
> + you should build this as a module.
s/, if/. If/
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply
* Re: rtl8187b Problem with tx level
From: Larry Finger @ 2009-09-01 16:37 UTC (permalink / raw)
To: Hin-Tak Leung
Cc: Gábor Stefanik, Luis R. Rodriguez, Tobias Schlemmer,
linux-wireless
In-Reply-To: <3ace41890908311616k4040d59fub051d21e822604d0@mail.gmail.com>
Hin-Tak Leung wrote:
>
> The r8187 is distributed from OEMs - stand to reason, as realtek don't
> really sell their own brand on high-street shops? We got one release
> e-mailed to us, and there are a few floating around on the internet
> under some laptop or usb hardware vendors. It is available under this,
> for example: http://service.one.de/index.php?&direction=0&order=&directory=NOTEBOOKS/ONE_A1XX/LINUX/Source-code/Wireless
> r8187mesh is the one in the mesh directory.
Thanks for this link. I got this code and I am in the process of
comparing it with the current rtl8187. So far, I find that the code
that sets the TX power levels is identical with ours.
Larry
^ permalink raw reply
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: John W. Linville @ 2009-09-01 16:58 UTC (permalink / raw)
To: Johannes Berg; +Cc: Larry Finger, Luis R. Rodriguez, linux-wireless
In-Reply-To: <1251820483.24846.0.camel@johannes.local>
On Tue, Sep 01, 2009 at 05:54:43PM +0200, Johannes Berg wrote:
> On Tue, 2009-09-01 at 10:53 -0500, Larry Finger wrote:
>
> > > @@ -98,8 +98,16 @@ config WIRELESS_EXT
> > > bool "Wireless extensions"
> > > default y
> > > ---help---
> > > - This option enables the legacy wireless extensions
> > > - (wireless network interface configuration via ioctls.)
> > > + This option enables the legacy wireless extensions.
> > > + Wireless extensions was the first 802.11 wireless configuration
> > > + API used by the networking subsystem. You will not need this unless
> > > + you have old userspace utilities or old wireless devices which
> > > + have not yet been ported to cfg80211.
> >
> > I would like this to read "You will need this if you have old
> > userspace utilities or old wireless devices that have not yet been
> > ported to cfg80211."
>
> Don't those "select WIRELESS_EXT" anyway so you don't have a choice?
Old userland won't do that.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Gábor Stefanik @ 2009-09-01 17:17 UTC (permalink / raw)
To: Jouni Malinen; +Cc: Luis R. Rodriguez, linville, linux-wireless, Johannes Berg
In-Reply-To: <20090901163300.GA29047@jm.kir.nu>
On Tue, Sep 1, 2009 at 6:33 PM, Jouni Malinen<j@w1.fi> wrote:
> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
>> This updates the mac80211 kconfig entry to clarify
>> what it is and refer people to our wireless wiki for
>> more documentation.
>
>> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
>
>> - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
>> + tristate "mac80211 - SoftMAC device support"
>
> Uh.. Do we really need to call this SoftMAC or well have that in the
> title? I prefer the current text or if you want to, just move the
> mac80211 into the beginning..
>
>
>> + This option enables support for a framework used by IEEE-802.11
>
> s/IEEE-802.11/IEEE 802.11/
>
>> + SoftMAC devices. SoftMAC devices allow for a finer control of the
>
> Again, I don't really like the term "SoftMAC" here..
>
>> + hardware, allowing for 802.11 frame management to be done in software
>> + for them, for both parsing and generation of 802.11 wireless frames.
>> + Most 802.11 devices today tend to be of this type.
>
> s/802.11/IEEE 802.11/g
>
>> + If you have new userspace utitlities which support nl80211 you do not
>
> s/utitlities/utilities/
>
>> + need wireless-extensions to support a mac80211 device.
>
> s/wireless-extensions/wireless extensions/
>
>> + When built as a module it will be called as mac80211, if not sure
>> + you should build this as a module.
>
> s/, if/. If/
Also, s/called as/called/
>
> --
> Jouni Malinen PGP id EFC895FA
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 17:18 UTC (permalink / raw)
To: Jouni Malinen
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, Johannes Berg
In-Reply-To: <20090901163300.GA29047@jm.kir.nu>
On Tue, Sep 01, 2009 at 09:33:00AM -0700, Jouni Malinen wrote:
> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> > This updates the mac80211 kconfig entry to clarify
> > what it is and refer people to our wireless wiki for
> > more documentation.
>
> > diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
>
> > - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
> > + tristate "mac80211 - SoftMAC device support"
>
> Uh.. Do we really need to call this SoftMAC or well have that in the
> title?
I was hoping this would clarify to users a little more on what this really
was instead of referring it as a generic "IEEE 802.11 stack". For example,
I'd expect a few users to be a bit puzzled why a cfg80211 driver did not make
use of the "IEEE 802.11 stack".
> I prefer the current text or if you want to, just move the
> mac80211 into the beginning..
I am not sure if this would be clear to users, as cfg80211 grows driver
support I think a clearer distinction would help. But then again that's just
my thoughts on this.
An alternative to accomplish what I want to do -- which is to educate users --
is to keep just change this as you suggest as:
"mac80211 - IEEE 802.11 Networking Stack"
but then also educate that a "IEEE 802.11 Networking Stack" is only required for
certain types of devices. This still seems a bit confusing to me though.
Would like your opinion on how to best educate users on this taxonomy.
> > + This option enables support for a framework used by IEEE-802.11
>
> s/IEEE-802.11/IEEE 802.11/
>
> > + SoftMAC devices. SoftMAC devices allow for a finer control of the
>
> Again, I don't really like the term "SoftMAC" here..
What's a better term?
> > + hardware, allowing for 802.11 frame management to be done in software
> > + for them, for both parsing and generation of 802.11 wireless frames.
> > + Most 802.11 devices today tend to be of this type.
>
> s/802.11/IEEE 802.11/g
>
> > + If you have new userspace utitlities which support nl80211 you do not
>
> s/utitlities/utilities/
>
> > + need wireless-extensions to support a mac80211 device.
>
> s/wireless-extensions/wireless extensions/
>
> > + When built as a module it will be called as mac80211, if not sure
> > + you should build this as a module.
>
> s/, if/. If/
Thanks for the review, will fix the typos, and will re-send after further feedback on
the taxonomy.
Luis
^ permalink raw reply
* wireless_send_event kmemleaks
From: Luis R. Rodriguez @ 2009-09-01 17:24 UTC (permalink / raw)
To: linux-wireless
Can't tell you how to reproduce yet.
unreferenced object 0xffff88003ba5fd00 (size 256):
comm "events/0", pid 9, jiffies 4297130623
backtrace:
[<ffffffff8112200d>] create_object+0x13d/0x2d0
[<ffffffff811222c5>] kmemleak_alloc+0x25/0x60
[<ffffffff81118a63>] kmem_cache_alloc_node+0x193/0x200
[<ffffffff81446cca>] __alloc_skb+0x4a/0x180
[<ffffffff81506be2>] wireless_send_event+0x1f2/0x410
[<ffffffffa0175074>] ___cfg80211_scan_done+0xe4/0x110 [cfg80211]
[<ffffffffa01750c6>] __cfg80211_scan_done+0x26/0x50 [cfg80211]
[<ffffffff8106de60>] worker_thread+0x1d0/0x380
[<ffffffff81073246>] kthread+0xa6/0xb0
[<ffffffff810130ca>] child_rip+0xa/0x20
[<ffffffffffffffff>] 0xffffffffffffffff
unreferenced object 0xffff88001f662000 (size 4096):
comm "events/0", pid 9, jiffies 4297130623
backtrace:
[<ffffffff8112200d>] create_object+0x13d/0x2d0
[<ffffffff811222c5>] kmemleak_alloc+0x25/0x60
[<ffffffff811198db>] __kmalloc_node_track_caller+0x1ab/0x220
[<ffffffff81446cfb>] __alloc_skb+0x7b/0x180
[<ffffffff81506be2>] wireless_send_event+0x1f2/0x410
[<ffffffffa0175074>] ___cfg80211_scan_done+0xe4/0x110 [cfg80211]
[<ffffffffa01750c6>] __cfg80211_scan_done+0x26/0x50 [cfg80211]
[<ffffffff8106de60>] worker_thread+0x1d0/0x380
[<ffffffff81073246>] kthread+0xa6/0xb0
[<ffffffff810130ca>] child_rip+0xa/0x20
[<ffffffffffffffff>] 0xffffffffffffffff
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox