* Re: zd1211rw on ppc (iBook G4)
From: Leonardo H. Souza Hamada @ 2009-09-01 20:02 UTC (permalink / raw)
To: linux-wireless
In-Reply-To: <3ace41890908311126m5212926cl27172ae775fc92f2@mail.gmail.com>
Some more diagnostic info for the rw driver, this time compiled as
built-in and debug option in the kernel for 2.6.30.
dmesg for rw driver output:
usb 1-2: new high speed USB device using ehci_hcd and address 2
usb 1-2: New USB device found, idVendor=0411, idProduct=00da
usb 1-2: New USB device strings: Mfr=16, Product=32, SerialNumber=0
usb 1-2: Product: USB2.0 WLAN
usb 1-2: Manufacturer: Buffalo
usb 1-2: configuration #1 chosen from 1 choice
usb 1-2: print_id() 0411:00da v4810 high
usb 1-2: reset high speed USB device using ehci_hcd and address 2
zd1211rw 1-2:1.0: zd_chip_read_mac_addr_fw()
phy0: Selected rate control algorithm 'minstrel'
zd1211rw 1-2:1.0: probe() successful
zd1211rw 1-2:1.0: phy0
zd1211rw 1-2:1.0: zd_usb_init_hw()
usb 1-2: request_fw_file() fw name zd1211/zd1211b_ub
usb 1-2: firmware: requesting zd1211/zd1211b_ub
usb 1-2: upload_firmware() firmware device id 0x4810 is equal to the
actual device id
usb 1-2: request_fw_file() fw name zd1211/zd1211b_uphr
usb 1-2: firmware: requesting zd1211/zd1211b_uphr
usb 1-2: upload_code() transfer size 4096
usb 1-2: upload_code() transfer size 1024
usb 1-2: upload_code() firmware confirm return value 0x01
zd1211rw 1-2:1.0: zd_usb_enable_int()
zd1211rw 1-2:1.0: zd_usb_enable_int() submit urb ce577580
zd1211rw 1-2:1.0: zd_chip_init_hw()
zd1211rw 1-2:1.0: dump_cr() CR_AFTER_PNP 0x00000000
zd1211rw 1-2:1.0: dump_cr() CR_GPI_EN 0x00000000
zd1211rw 1-2:1.0: dump_cr() CR_INTERRUPT 0x00000000
zd1211rw 1-2:1.0: read_fw_regs_offset() fw_regs_base: 0xf7f1
zd1211rw 1-2:1.0: read_pod() E2P_POD 0xa000011a
zd1211rw 1-2:1.0: read_pod() RF AL2230S_RF 0xa PA type 0x0 patch CCK 1
patch CR157 0 patch 6M 0 new PHY 1 link LED1 tx led 1
zd1211rw 1-2:1.0: hw_init()
zd1211rw 1-2:1.0: zd1211b_hw_reset_phy()
zd1211rw 1-2:1.0: zd1211b_hw_init_hmac()
zd1211rw 1-2:1.0: zd_usb_rfwrite() value 0x0241000 bits 24
zd1211rw 1-2:1.0: firmware version 4725
zd1211rw 1-2:1.0: dump_fw_registers() FW_FIRMWARE_VER 0x4725
zd1211rw 1-2:1.0: dump_fw_registers() FW_USB_SPEED 0x0001
zd1211rw 1-2:1.0: dump_fw_registers() FW_FIX_TX_RATE 0x0000
zd1211rw 1-2:1.0: dump_fw_registers() FW_LINK_STATUS 0x0000
zd1211rw 1-2:1.0: dump_cr() CR_AFTER_PNP 0x00000001
zd1211rw 1-2:1.0: dump_cr() CR_GPI_EN 0x00000000
zd1211rw 1-2:1.0: dump_cr() CR_INTERRUPT 0x00000000
zd1211rw 1-2:1.0: zd1211b chip 0411:00da v4810 high 00-16-01 AL2230S_RF
pa0 g--N-
zd1211rw 1-2:1.0: zd_read_regdomain() regdomain: 0x49
zd1211rw 1-2:1.0: zd_usb_disable_int() urb ce577580 killed
zd1211rw 1-2:1.0: zd_usb_init_hw() couldn't initialize mac. Error number 1
iwconfig:
lo no wireless extensions.
eth0 no wireless extensions.
tunl0 no wireless extensions.
gre0 no wireless extensions.
wmaster0 no wireless extensions.
wlan0 IEEE 802.11bg ESSID:""
Mode:Managed Frequency:2.412 GHz Access Point: Not-Associated
Tx-Power=0 dBm
Retry min limit:7 RTS thr:off Fragment thr:off
Encryption key:off
Power Management:off
Link Quality:0 Signal level:0 Noise level:0
Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0
Tx excessive retries:0 Invalid misc:0 Missed beacon:0
Hin-Tak Leung wrote:
> I have a bunch of patches which bring the 2.22 vendor driver up to
> 2.6.29 and 3.0 the vendor driver up to 2.6.30:
> http://htl10.users.sourceforge.net/patchsets/
> It doesn't fix the rw driver, but might be good enough for you?
>
I have downloaded the vendor driver and applied your patchset.
Inserted the vendor { USB_DEVICE(0x0411, 0x00DA) }, in
ar2524drv/src/zdusb.c
Recompiled as zd1211REV_B
dmesg for vendor driver:
udev: starting version 145
_____ ____ _ ____
|__ / _| _ \ / \ / ___|
/ / | | | | | |/ _ \ \___ \
/ /| |_| | |_| / ___ \ ___) |
/____\__, |____/_/ \_\____/
|___/
zd1211 - version 3.0.0.56
vendor_id = 0411
product_id = 00da
USB 2.0 Host
Release Ver = 4810
EEPORM Ver = 4330
Finsih download Firmware. Ready to reboot
Finsih download Firmware. Ready to reboot
Finsih download Firmware. Ready to reboot
ohci1394 0002:20:0e.0: enabling device (0000 -> 0002)
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
ohci1394: fw-host0: OHCI-1394 1.1 (PCI): IRQ=[40]
MMIO=[f5000000-f50007ff] Max Packet=[2048] IR/IT contexts=[8/8]
PA type: 2
Airoha AL2230S_RF
Overwrite CR157 = 0x0
Overwrite CR47 = 0x10019
zd1205_config: EEP(HWFeature)=0xF7D0
AllowedChannel = 00013fff
Region:0
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
usbcore: registered new interface driver zd1211
I am able to do iwlist ath0 scanning, a list of acess point appears but
sometimes this fails.
iwlist ath0 scanning:
ath0 Scan completed :
Cell 01 - Address: 00:21:91:0E:0B:F7
ESSID:"adminWF10"
Mode:Master
Frequency=2.412 GHz (Channel 1)
Quality=46/100 Signal level=-74 dBm Noise
level=-96 dBm
Encryption key:off
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 6 Mb/s
12 Mb/s; 24 Mb/s; 36 Mb/s; 9 Mb/s; 18 Mb/s
48 Mb/s; 54 Mb/s
Extra:bcn_int=100
Cell 02 - Address: 00:1D:0F:D1:4D:D2
ESSID:"LGAA_P_CENTRAL_WF01"
Mode:Master
Frequency=2.437 GHz (Channel 6)
Quality=43/100 Signal level=-76 dBm Noise
level=-96 dBm
Encryption key:off
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 6 Mb/s
12 Mb/s; 24 Mb/s; 36 Mb/s; 9 Mb/s; 18 Mb/s
48 Mb/s; 54 Mb/s
Extra:bcn_int=100
Cell 03 - Address: 00:1B:11:87:A7:0C
ESSID:"ponto-acesso-mutsuo"
Mode:Master
Frequency=2.437 GHz (Channel 6)
Quality=43/100 Signal level=-76 dBm Noise
level=-96 dBm
Encryption key:off
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 6 Mb/s
9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s; 36 Mb/s
48 Mb/s; 54 Mb/s
Extra:bcn_int=100
Scan again, it fails and works seemingly in an unknown manner.
iwlist ath0 scanning
ath0 Failed to read scan data : Resource temporarily unavailable
Some message in dmesg of relevance:
...
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
zd1211_USB_PACKAGE_READ_REGISTER: warning, restarting INT EP
zd1211_readl retry OK
....(many times over)
and
1211_readl failed for 5 attempts...Very Serious<3>1211_readl failed for
5 attempts...Very Serious<3>1211_readl failed for 5 attempts...Very
Serious<3>1211_readl failed for 5 attempts...Very Serious<3>1211_readl
failed for 5 attempts...Very Serious<3>1211_readl failed for 5
attempts...Very Serious<3>1211_readl failed for 5 attempts...Very
Serious<3>1211_readl failed for 5 attempts...Very Serious<3>1211_readl
failed for 5 attempts...Very Serious<3>1211_readl failed for 5
attempts...Very Serious<3>1211_readl failed for 5 attempts...Very
Serious<3>1211_readl failed for 5 attempts...Very Serious<3>1211_readl
failed for 5 attempts...Very Serious<3>1211_readl failed for 5
attempts...Very Serious<3>1211_readl failed for 5 attempts...Very
Serious<7>zd1205_notify_disjoin_event
Giving up .... for now.
Regards,
Leonardo
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 19:19 UTC (permalink / raw)
To: Johannes Berg
Cc: Gábor Stefanik, Luis Rodriguez,
linux-wireless@vger.kernel.org
In-Reply-To: <1251832064.24846.2.camel@johannes.local>
On Tue, Sep 1, 2009 at 12:07 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> On Tue, 2009-09-01 at 11:01 -0700, Luis R. Rodriguez wrote:
>
>> Software MAC sounds reasonable to me. Anyone else?
>
> Except we're not actually talking about the MAC at all. The MAC is still
> in the hardware.
How how about just:
"mac80211 - IEEE 802.11 frame processing"
Then as for referring to these type of devices I am not aware of other
vocabulary for them other than SoftMAC or its derivative names.
Luis
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Johannes Berg @ 2009-09-01 19:07 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: Gábor Stefanik, Luis Rodriguez,
linux-wireless@vger.kernel.org
In-Reply-To: <20090901180147.GA4272@mosca>
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
On Tue, 2009-09-01 at 11:01 -0700, Luis R. Rodriguez wrote:
> Software MAC sounds reasonable to me. Anyone else?
Except we're not actually talking about the MAC at all. The MAC is still
in the hardware.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: wireless_send_event kmemleaks
From: Pavel Roskin @ 2009-09-01 18:43 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless
In-Reply-To: <43e72e890909011024p7b7176a6vfad3902ac714df79@mail.gmail.com>
On Tue, 2009-09-01 at 10:24 -0700, Luis R. Rodriguez wrote:
> Can't tell you how to reproduce yet.
>
> unreferenced object 0xffff88003ba5fd00 (size 256):
> comm "events/0", pid 9, jiffies 4297130623
> backtrace:
> [<ffffffff8112200d>] create_object+0x13d/0x2d0
> [<ffffffff811222c5>] kmemleak_alloc+0x25/0x60
> [<ffffffff81118a63>] kmem_cache_alloc_node+0x193/0x200
> [<ffffffff81446cca>] __alloc_skb+0x4a/0x180
> [<ffffffff81506be2>] wireless_send_event+0x1f2/0x410
I wonder if we can translate it to the line numbers. Together with the
git revision, it would be quite useful. addr2line can do it for an
individual address, but to process the whole dump, a script would be
needed.
--
Regards,
Pavel Roskin
^ permalink raw reply
* [PATCH v2] wireless-regdb: TH gets 5 GHz enabled as of new regulatory rules
From: Luis R. Rodriguez @ 2009-09-01 18:20 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Michael Green, David Quan
Phattanon Duangdara reported the National Telecommunication
Commisions of Thailand has announced new regulatory rules
about 5GHz for RLAN last year.
I have verified this matches our documentation internally
at Atheros. I also verified HT40 is allowed.
Reference in Thai Language:
http://www.ratchakitcha.soc.go.th/DATA/PDF/2551/E/042/64.PDF
Cc: Michael Green <michael.green@atheros.com>
Cc: David Quan <david.quan@atheros.com>
Reported-by: Phattanon Duangdara <sfalpha@gmail.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
John, this is v2, I have verified internally TH does allow for HT40.
db.txt | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/db.txt b/db.txt
index fad098d..84be443 100644
--- a/db.txt
+++ b/db.txt
@@ -535,6 +535,10 @@ country TW:
country TH:
(2402 - 2482 @ 40), (N/A, 20)
+ (5170 - 5250 @ 40), (3, 17)
+ (5250 - 5330 @ 40), (3, 20), DFS
+ (5490 - 5710 @ 40), (3, 20), DFS
+ (5735 - 5835 @ 40), (3, 30)
country TT:
(2402 - 2482 @ 40), (N/A, 20)
--
1.6.3.3
^ permalink raw reply related
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: John W. Linville @ 2009-09-01 18:07 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: Gábor Stefanik, Luis Rodriguez,
linux-wireless@vger.kernel.org
In-Reply-To: <20090901180147.GA4272@mosca>
On Tue, Sep 01, 2009 at 11:01:47AM -0700, Luis R. Rodriguez wrote:
> On Tue, Sep 01, 2009 at 10:47:43AM -0700, Gábor Stefanik wrote:
> > The description isn't the problem - the term "SoftMAC" is, due to its
> > connections with ieee80211softmac. Even "Software MAC" would be better
> > here.
>
> Software MAC sounds reasonable to me. Anyone else?
Seems fine -- IMHO "soft MAC" would be fine as well...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 18:01 UTC (permalink / raw)
To: Gábor Stefanik; +Cc: Luis Rodriguez, linux-wireless@vger.kernel.org
In-Reply-To: <69e28c910909011047p2ecb7f9fg84b4089a70d1be5c@mail.gmail.com>
On Tue, Sep 01, 2009 at 10:47:43AM -0700, Gábor Stefanik wrote:
> 2009/9/1 Luis R. Rodriguez <lrodriguez@atheros.com>:
> > On Tue, Sep 01, 2009 at 10:28:35AM -0700, Gábor Stefanik wrote:
> >> On Tue, Sep 1, 2009 at 7:18 PM, Luis R. Rodriguez<lrodriguez@atheros.com> wrote:
> >> > On Tue, Sep 01, 2009 at 09:33:00AM -0700, Jouni Malinen wrote:
> >> >> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> >> >> > + SoftMAC devices. SoftMAC devices allow for a finer control of the
> >> >>
> >> >> Again, I don't really like the term "SoftMAC" here..
> >> >
> >> > What's a better term?
> >> >
> >>
> >> "Software-based", "Software-MAC", "Software-defined", or anything that
> >> neither implies that the stack is designed for PrismGT (the
> >> capitalization "SoftMAC" comes from Intersil AFAIK), nor allows
> >> confusion with ieee80211softmac (which could result if we write it
> >> with all small letters as "softmac").
> >
> > Indeed, I picked up 'SoftMAC' and 'FullMAC' terminology from the prism54 days
> > after they decided to move in that direction as others were or already had. For
> > better or for worse I have been using 'SoftMAC' throughout wireless.kernel.org
> > documentation to distinguish between 'FullMAC' cards. I really have not been
> > able to find any other suitable replacements, are there legal reasons to not use
> > such terms?
> >
> > I thought 'mac80211' name was brilliant as it highlighted the main focus for the
> > module, to focus on the MAC frame processing, I just cannot think of any
> > description for it other than something to support SoftMAC cards.
>
> The description isn't the problem - the term "SoftMAC" is, due to its
> connections with ieee80211softmac. Even "Software MAC" would be better
> here.
Software MAC sounds reasonable to me. Anyone else?
Luis
^ permalink raw reply
* Re: memleaks, acpi + ext4 + tty
From: Luis R. Rodriguez @ 2009-09-01 18:00 UTC (permalink / raw)
To: Zhu Yi
Cc: Eric Paris, John W. Linville, Eric Paris, Catalin Marinas,
H. Peter Anvin, linux-kernel@vger.kernel.org, Aneesh Kumar K.V,
Greg Kroah-Hartman, linux-wireless
In-Reply-To: <1251786829.8830.277.camel@debian>
On Mon, Aug 31, 2009 at 11:33 PM, Zhu Yi<yi.zhu@intel.com> wrote:
> On Tue, 2009-09-01 at 08:31 +0800, Luis R. Rodriguez wrote:
>> >>
>> http://git.infradead.org/users/eparis/notify.git/commit/b962e7312ae87006aed6f68ceee94bdf8db08338
>> >>
>> >> FWIW for that patch:
>> >>
>> >> Tested-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> >>
>> >> So -- you if you're like me and had issues with bootup lag on
>> >> wireless-testing, you can probably fix your wireless-testing by
>> >> pulling his patches:
>> >>
>> >> git pull git://git.infradead.org/users/eparis/notify.git for-linus
>> >>
>> >> I saw Linus had some other fixes but I'll wait for rc9 for that as
>> my
>> >> box seems reasonably stable right now.
>> >
>> > Yes, -rc8 broke pretty badly for a number of people. Linus did pull
>> all
>> > of the fixes that I know of. I wouldn't suggest pulling just that
>> one
>> > commit. All 3 of the post -rc8 patches in my tree fix -rc8
>> > regressions :(
>>
>> Thanks, the note -- so I guess best is to just pull from Linus ontop
>> of wireless-testing.
>
> I confirm I'm also suffered with the problem on today's wireless-testing
> tip (udevadm --settle hangs on boot) and the above patch does fix the
> issue for me. Thanks both for identify and fix the problem.
Just a heads up -- the relevant fixes are now merged on
wireless-testing, thanks John.
Luis
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Gábor Stefanik @ 2009-09-01 17:47 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Luis Rodriguez, linux-wireless
In-Reply-To: <20090901173822.GG8261@mosca>
2009/9/1 Luis R. Rodriguez <lrodriguez@atheros.com>:
> On Tue, Sep 01, 2009 at 10:28:35AM -0700, Gábor Stefanik wrote:
>> On Tue, Sep 1, 2009 at 7:18 PM, Luis R. Rodriguez<lrodriguez@atheros.com> wrote:
>> > On Tue, Sep 01, 2009 at 09:33:00AM -0700, Jouni Malinen wrote:
>> >> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
>> >> > + SoftMAC devices. SoftMAC devices allow for a finer control of the
>> >>
>> >> Again, I don't really like the term "SoftMAC" here..
>> >
>> > What's a better term?
>> >
>>
>> "Software-based", "Software-MAC", "Software-defined", or anything that
>> neither implies that the stack is designed for PrismGT (the
>> capitalization "SoftMAC" comes from Intersil AFAIK), nor allows
>> confusion with ieee80211softmac (which could result if we write it
>> with all small letters as "softmac").
>
> Indeed, I picked up 'SoftMAC' and 'FullMAC' terminology from the prism54 days
> after they decided to move in that direction as others were or already had. For
> better or for worse I have been using 'SoftMAC' throughout wireless.kernel.org
> documentation to distinguish between 'FullMAC' cards. I really have not been
> able to find any other suitable replacements, are there legal reasons to not use
> such terms?
>
> I thought 'mac80211' name was brilliant as it highlighted the main focus for the
> module, to focus on the MAC frame processing, I just cannot think of any
> description for it other than something to support SoftMAC cards.
The description isn't the problem - the term "SoftMAC" is, due to its
connections with ieee80211softmac. Even "Software MAC" would be better
here.
>
> Luis
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 17:38 UTC (permalink / raw)
To: Gábor Stefanik; +Cc: Luis Rodriguez, linux-wireless
In-Reply-To: <69e28c910909011028i25fba508t9e68fb24168193eb@mail.gmail.com>
On Tue, Sep 01, 2009 at 10:28:35AM -0700, Gábor Stefanik wrote:
> On Tue, Sep 1, 2009 at 7:18 PM, Luis R. Rodriguez<lrodriguez@atheros.com> wrote:
> > On Tue, Sep 01, 2009 at 09:33:00AM -0700, Jouni Malinen wrote:
> >> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> >> > + SoftMAC devices. SoftMAC devices allow for a finer control of the
> >>
> >> Again, I don't really like the term "SoftMAC" here..
> >
> > What's a better term?
> >
>
> "Software-based", "Software-MAC", "Software-defined", or anything that
> neither implies that the stack is designed for PrismGT (the
> capitalization "SoftMAC" comes from Intersil AFAIK), nor allows
> confusion with ieee80211softmac (which could result if we write it
> with all small letters as "softmac").
Indeed, I picked up 'SoftMAC' and 'FullMAC' terminology from the prism54 days
after they decided to move in that direction as others were or already had. For
better or for worse I have been using 'SoftMAC' throughout wireless.kernel.org
documentation to distinguish between 'FullMAC' cards. I really have not been
able to find any other suitable replacements, are there legal reasons to not use
such terms?
I thought 'mac80211' name was brilliant as it highlighted the main focus for the
module, to focus on the MAC frame processing, I just cannot think of any
description for it other than something to support SoftMAC cards.
Luis
^ permalink raw reply
* wireless_send_event kmemleaks
From: Luis R. Rodriguez @ 2009-09-01 17:24 UTC (permalink / raw)
To: linux-wireless
Can't tell you how to reproduce yet.
unreferenced object 0xffff88003ba5fd00 (size 256):
comm "events/0", pid 9, jiffies 4297130623
backtrace:
[<ffffffff8112200d>] create_object+0x13d/0x2d0
[<ffffffff811222c5>] kmemleak_alloc+0x25/0x60
[<ffffffff81118a63>] kmem_cache_alloc_node+0x193/0x200
[<ffffffff81446cca>] __alloc_skb+0x4a/0x180
[<ffffffff81506be2>] wireless_send_event+0x1f2/0x410
[<ffffffffa0175074>] ___cfg80211_scan_done+0xe4/0x110 [cfg80211]
[<ffffffffa01750c6>] __cfg80211_scan_done+0x26/0x50 [cfg80211]
[<ffffffff8106de60>] worker_thread+0x1d0/0x380
[<ffffffff81073246>] kthread+0xa6/0xb0
[<ffffffff810130ca>] child_rip+0xa/0x20
[<ffffffffffffffff>] 0xffffffffffffffff
unreferenced object 0xffff88001f662000 (size 4096):
comm "events/0", pid 9, jiffies 4297130623
backtrace:
[<ffffffff8112200d>] create_object+0x13d/0x2d0
[<ffffffff811222c5>] kmemleak_alloc+0x25/0x60
[<ffffffff811198db>] __kmalloc_node_track_caller+0x1ab/0x220
[<ffffffff81446cfb>] __alloc_skb+0x7b/0x180
[<ffffffff81506be2>] wireless_send_event+0x1f2/0x410
[<ffffffffa0175074>] ___cfg80211_scan_done+0xe4/0x110 [cfg80211]
[<ffffffffa01750c6>] __cfg80211_scan_done+0x26/0x50 [cfg80211]
[<ffffffff8106de60>] worker_thread+0x1d0/0x380
[<ffffffff81073246>] kthread+0xa6/0xb0
[<ffffffff810130ca>] child_rip+0xa/0x20
[<ffffffffffffffff>] 0xffffffffffffffff
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 17:18 UTC (permalink / raw)
To: Jouni Malinen
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, Johannes Berg
In-Reply-To: <20090901163300.GA29047@jm.kir.nu>
On Tue, Sep 01, 2009 at 09:33:00AM -0700, Jouni Malinen wrote:
> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> > This updates the mac80211 kconfig entry to clarify
> > what it is and refer people to our wireless wiki for
> > more documentation.
>
> > diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
>
> > - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
> > + tristate "mac80211 - SoftMAC device support"
>
> Uh.. Do we really need to call this SoftMAC or well have that in the
> title?
I was hoping this would clarify to users a little more on what this really
was instead of referring it as a generic "IEEE 802.11 stack". For example,
I'd expect a few users to be a bit puzzled why a cfg80211 driver did not make
use of the "IEEE 802.11 stack".
> I prefer the current text or if you want to, just move the
> mac80211 into the beginning..
I am not sure if this would be clear to users, as cfg80211 grows driver
support I think a clearer distinction would help. But then again that's just
my thoughts on this.
An alternative to accomplish what I want to do -- which is to educate users --
is to keep just change this as you suggest as:
"mac80211 - IEEE 802.11 Networking Stack"
but then also educate that a "IEEE 802.11 Networking Stack" is only required for
certain types of devices. This still seems a bit confusing to me though.
Would like your opinion on how to best educate users on this taxonomy.
> > + This option enables support for a framework used by IEEE-802.11
>
> s/IEEE-802.11/IEEE 802.11/
>
> > + SoftMAC devices. SoftMAC devices allow for a finer control of the
>
> Again, I don't really like the term "SoftMAC" here..
What's a better term?
> > + hardware, allowing for 802.11 frame management to be done in software
> > + for them, for both parsing and generation of 802.11 wireless frames.
> > + Most 802.11 devices today tend to be of this type.
>
> s/802.11/IEEE 802.11/g
>
> > + If you have new userspace utitlities which support nl80211 you do not
>
> s/utitlities/utilities/
>
> > + need wireless-extensions to support a mac80211 device.
>
> s/wireless-extensions/wireless extensions/
>
> > + When built as a module it will be called as mac80211, if not sure
> > + you should build this as a module.
>
> s/, if/. If/
Thanks for the review, will fix the typos, and will re-send after further feedback on
the taxonomy.
Luis
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Gábor Stefanik @ 2009-09-01 17:17 UTC (permalink / raw)
To: Jouni Malinen; +Cc: Luis R. Rodriguez, linville, linux-wireless, Johannes Berg
In-Reply-To: <20090901163300.GA29047@jm.kir.nu>
On Tue, Sep 1, 2009 at 6:33 PM, Jouni Malinen<j@w1.fi> wrote:
> On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
>> This updates the mac80211 kconfig entry to clarify
>> what it is and refer people to our wireless wiki for
>> more documentation.
>
>> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
>
>> - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
>> + tristate "mac80211 - SoftMAC device support"
>
> Uh.. Do we really need to call this SoftMAC or well have that in the
> title? I prefer the current text or if you want to, just move the
> mac80211 into the beginning..
>
>
>> + This option enables support for a framework used by IEEE-802.11
>
> s/IEEE-802.11/IEEE 802.11/
>
>> + SoftMAC devices. SoftMAC devices allow for a finer control of the
>
> Again, I don't really like the term "SoftMAC" here..
>
>> + hardware, allowing for 802.11 frame management to be done in software
>> + for them, for both parsing and generation of 802.11 wireless frames.
>> + Most 802.11 devices today tend to be of this type.
>
> s/802.11/IEEE 802.11/g
>
>> + If you have new userspace utitlities which support nl80211 you do not
>
> s/utitlities/utilities/
>
>> + need wireless-extensions to support a mac80211 device.
>
> s/wireless-extensions/wireless extensions/
>
>> + When built as a module it will be called as mac80211, if not sure
>> + you should build this as a module.
>
> s/, if/. If/
Also, s/called as/called/
>
> --
> Jouni Malinen PGP id EFC895FA
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: John W. Linville @ 2009-09-01 16:58 UTC (permalink / raw)
To: Johannes Berg; +Cc: Larry Finger, Luis R. Rodriguez, linux-wireless
In-Reply-To: <1251820483.24846.0.camel@johannes.local>
On Tue, Sep 01, 2009 at 05:54:43PM +0200, Johannes Berg wrote:
> On Tue, 2009-09-01 at 10:53 -0500, Larry Finger wrote:
>
> > > @@ -98,8 +98,16 @@ config WIRELESS_EXT
> > > bool "Wireless extensions"
> > > default y
> > > ---help---
> > > - This option enables the legacy wireless extensions
> > > - (wireless network interface configuration via ioctls.)
> > > + This option enables the legacy wireless extensions.
> > > + Wireless extensions was the first 802.11 wireless configuration
> > > + API used by the networking subsystem. You will not need this unless
> > > + you have old userspace utilities or old wireless devices which
> > > + have not yet been ported to cfg80211.
> >
> > I would like this to read "You will need this if you have old
> > userspace utilities or old wireless devices that have not yet been
> > ported to cfg80211."
>
> Don't those "select WIRELESS_EXT" anyway so you don't have a choice?
Old userland won't do that.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* Re: rtl8187b Problem with tx level
From: Larry Finger @ 2009-09-01 16:37 UTC (permalink / raw)
To: Hin-Tak Leung
Cc: Gábor Stefanik, Luis R. Rodriguez, Tobias Schlemmer,
linux-wireless
In-Reply-To: <3ace41890908311616k4040d59fub051d21e822604d0@mail.gmail.com>
Hin-Tak Leung wrote:
>
> The r8187 is distributed from OEMs - stand to reason, as realtek don't
> really sell their own brand on high-street shops? We got one release
> e-mailed to us, and there are a few floating around on the internet
> under some laptop or usb hardware vendors. It is available under this,
> for example: http://service.one.de/index.php?&direction=0&order=&directory=NOTEBOOKS/ONE_A1XX/LINUX/Source-code/Wireless
> r8187mesh is the one in the mesh directory.
Thanks for this link. I got this code and I am in the process of
comparing it with the current rtl8187. So far, I find that the code
that sets the TX power levels is identical with ours.
Larry
^ permalink raw reply
* Re: [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Jouni Malinen @ 2009-09-01 16:33 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251820465-11104-1-git-send-email-lrodriguez@atheros.com>
On Tue, Sep 01, 2009 at 08:54:25AM -0700, Luis R. Rodriguez wrote:
> This updates the mac80211 kconfig entry to clarify
> what it is and refer people to our wireless wiki for
> more documentation.
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> - tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
> + tristate "mac80211 - SoftMAC device support"
Uh.. Do we really need to call this SoftMAC or well have that in the
title? I prefer the current text or if you want to, just move the
mac80211 into the beginning..
> + This option enables support for a framework used by IEEE-802.11
s/IEEE-802.11/IEEE 802.11/
> + SoftMAC devices. SoftMAC devices allow for a finer control of the
Again, I don't really like the term "SoftMAC" here..
> + hardware, allowing for 802.11 frame management to be done in software
> + for them, for both parsing and generation of 802.11 wireless frames.
> + Most 802.11 devices today tend to be of this type.
s/802.11/IEEE 802.11/g
> + If you have new userspace utitlities which support nl80211 you do not
s/utitlities/utilities/
> + need wireless-extensions to support a mac80211 device.
s/wireless-extensions/wireless extensions/
> + When built as a module it will be called as mac80211, if not sure
> + you should build this as a module.
s/, if/. If/
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply
* Re: [PATCH] wireless: mark prism54 as deprecated and mark for removal
From: Luis R. Rodriguez @ 2009-09-01 16:15 UTC (permalink / raw)
To: Larry Finger
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, aquilaver@yahoo.com,
linux-kernel@vger.kernel.org, Dan Williams, Kai Engert,
Jean Tourrilhes, Tim de Waal, Roy Marples, Alan Cox,
Christian Lamparter, Björn Steinbrink, Tim Gardner,
Johannes Berg
In-Reply-To: <4A9D469B.9060005@lwfinger.net>
On Tue, Sep 01, 2009 at 09:06:51AM -0700, Larry Finger wrote:
> Luis R. Rodriguez wrote:
> > The preferred modules is p54 which also supports FullMAC
>
> This needs to be "modules are" or "module is". I know p54 is really a
> family, but I think you specifically mean p54pci here.
Will fix.
> > PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
> > to remove this is no one really is testing prism54 anymore,
> > and while it works p54 provides support for the same hardware.
> ===
> p54pci?
That would make it clearer, yes thanks.
> > It should be noted I have been told some FullMAC devices may not
> > have worked with the SoftMAC driver but to date we have yet to
> > recieve a single bug report regarding this. If there are users
> =======
> receive
ack
> > out there please let us know!
> =========
>
> Those words can be removed.
>
> Otherwise, ACK.
Thanks for the review, will resend with the changes.
Luis
^ permalink raw reply
* Re: [PATCH] wireless: mark prism54 as deprecated and mark for removal
From: Larry Finger @ 2009-09-01 16:06 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: linville, linux-wireless, aquilaver, linux-kernel, Dan Williams,
Kai Engert, Jean Tourrilhes, Tim de Waal, Roy Marples, Alan Cox,
Christian Lamparter, Björn Steinbrink, Tim Gardner,
Johannes Berg
In-Reply-To: <1251819116-10004-1-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> The preferred modules is p54 which also supports FullMAC
This needs to be "modules are" or "module is". I know p54 is really a
family, but I think you specifically mean p54pci here.
> PCI / Cardbus devices. We schedule removal for 2.6.34. Reason
> to remove this is no one really is testing prism54 anymore,
> and while it works p54 provides support for the same hardware.
===
p54pci?
> It should be noted I have been told some FullMAC devices may not
> have worked with the SoftMAC driver but to date we have yet to
> recieve a single bug report regarding this. If there are users
=======
receive
> out there please let us know!
=========
Those words can be removed.
Otherwise, ACK.
Larry
^ permalink raw reply
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: Johannes Berg @ 2009-09-01 15:54 UTC (permalink / raw)
To: Larry Finger; +Cc: Luis R. Rodriguez, linville, linux-wireless
In-Reply-To: <4A9D436E.20509@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Tue, 2009-09-01 at 10:53 -0500, Larry Finger wrote:
> > @@ -98,8 +98,16 @@ config WIRELESS_EXT
> > bool "Wireless extensions"
> > default y
> > ---help---
> > - This option enables the legacy wireless extensions
> > - (wireless network interface configuration via ioctls.)
> > + This option enables the legacy wireless extensions.
> > + Wireless extensions was the first 802.11 wireless configuration
> > + API used by the networking subsystem. You will not need this unless
> > + you have old userspace utilities or old wireless devices which
> > + have not yet been ported to cfg80211.
>
> I would like this to read "You will need this if you have old
> userspace utilities or old wireless devices that have not yet been
> ported to cfg80211."
Don't those "select WIRELESS_EXT" anyway so you don't have a choice?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* [PATCH v2 6/7] wireless: update mac80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:54 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Jouni Malinen, Johannes Berg
This updates the mac80211 kconfig entry to clarify
what it is and refer people to our wireless wiki for
more documentation.
Cc: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Changed description of when built as a module as pointed out
by Larry.
net/mac80211/Kconfig | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 9db4ff8..72006f9 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -1,5 +1,5 @@
config MAC80211
- tristate "Generic IEEE 802.11 Networking Stack (mac80211)"
+ tristate "mac80211 - SoftMAC device support"
depends on CFG80211
select CRYPTO
select CRYPTO_ECB
@@ -7,8 +7,21 @@ config MAC80211
select CRYPTO_AES
select CRC32
---help---
- This option enables the hardware independent IEEE 802.11
- networking stack.
+ This option enables support for a framework used by IEEE-802.11
+ SoftMAC devices. SoftMAC devices allow for a finer control of the
+ hardware, allowing for 802.11 frame management to be done in software
+ for them, for both parsing and generation of 802.11 wireless frames.
+ Most 802.11 devices today tend to be of this type.
+
+ If you have new userspace utitlities which support nl80211 you do not
+ need wireless-extensions to support a mac80211 device.
+
+ For more information refer the the wireless wiki entry on mac80211:
+
+ http://wireless.kernel.org/en/developers/Documentation/mac80211
+
+ When built as a module it will be called as mac80211, if not sure
+ you should build this as a module.
comment "CFG80211 needs to be enabled for MAC80211"
depends on CFG80211=n
--
1.6.3.3
^ permalink raw reply related
* [PATCH v2 3/7] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:53 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez, Johannes Berg
cfg80211 is now *the* wireless configuration API. Lets also
give a little explanation as to what it is and refer people to
the wireless wiki for more information.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
Changes description of when we build cfg80211 as a module
as pointed out by Larry.
net/wireless/Kconfig | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index aea7e68..9fd570b 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -1,6 +1,15 @@
config CFG80211
- tristate "Improved wireless configuration API"
+ tristate "cfg80211 - wireless configuration API"
depends on RFKILL || !RFKILL
+ ---help---
+ cfg80211 is the Linux wireless LAN (802.11) configuration API.
+ Enable this if you have a wireless device.
+
+ For more information refer to documentation on the wireless wiki:
+
+ http://wireless.kernel.org/en/developers/Documentation/cfg80211
+
+ When built as a module it will be called cfg80211.
config NL80211_TESTMODE
bool "nl80211 testmode command"
--
1.6.3.3
^ permalink raw reply related
* Re: [PATCH 5/7] wireless: update WIRELESS_EXT kconfig entry
From: Larry Finger @ 2009-09-01 15:53 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251818566-9264-6-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> Provide more documentation as to why its being deprecated.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/wireless/Kconfig | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index 08f6733..521ef6a 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -98,8 +98,16 @@ config WIRELESS_EXT
> bool "Wireless extensions"
> default y
> ---help---
> - This option enables the legacy wireless extensions
> - (wireless network interface configuration via ioctls.)
> + This option enables the legacy wireless extensions.
> + Wireless extensions was the first 802.11 wireless configuration
> + API used by the networking subsystem. You will not need this unless
> + you have old userspace utilities or old wireless devices which
> + have not yet been ported to cfg80211.
I would like this to read "You will need this if you have old
userspace utilities or old wireless devices that have not yet been
ported to cfg80211."
Larry
^ permalink raw reply
* Re: [PATCH 3/7] wireless: update cfg80211 kconfig entry
From: Luis R. Rodriguez @ 2009-09-01 15:47 UTC (permalink / raw)
To: Larry Finger
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, Johannes Berg
In-Reply-To: <4A9D3FA8.9020800@lwfinger.net>
On Tue, Sep 01, 2009 at 08:37:12AM -0700, Larry Finger wrote:
> Luis R. Rodriguez wrote:
> > cfg80211 is now *the* wireless configuration API. Lets also
> > give a little explanation as to what it is and refer people to
> > the wireless wiki for more information.
> >
> > Cc: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> > net/wireless/Kconfig | 11 ++++++++++-
> > 1 files changed, 10 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> > index aea7e68..9fd570b 100644
> > --- a/net/wireless/Kconfig
> > +++ b/net/wireless/Kconfig
> > @@ -1,6 +1,15 @@
> > config CFG80211
> > - tristate "Improved wireless configuration API"
> > + tristate "cfg80211 - wireless configuration API"
> > depends on RFKILL || !RFKILL
> > + ---help---
> > + cfg80211 is the Linux wireless LAN (802.11) configuration API.
> > + Enable this if you have a wireless device.
> > +
> > + For more information refer to documentation on the wireless wiki:
> > +
> > + http://wireless.kernel.org/en/developers/Documentation/cfg80211
> > +
> > + When built as a module cfg80211 will be built as cfg80211
>
> First of all, I think this modest change is much better than the
> previous set of patches, and that the additional info you provide for
> mac80211 and friends will be useful for those who don't live with
> 802.11 wifi all day long.
>
> That said, I find the above statement to be a little clumsy. Perhaps
> it should be "When built as a module, it will be called cfg80211". The
> same comment also applies to patch 6 for mac80211.
Thanks, will resend.
Luis
^ permalink raw reply
* Re: [PATCH 2/7] wireless: update wireless kconfig description
From: Luis R. Rodriguez @ 2009-09-01 15:46 UTC (permalink / raw)
To: Johannes Berg
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
In-Reply-To: <1251819096.22442.17.camel@johannes.local>
On Tue, Sep 01, 2009 at 08:31:36AM -0700, Johannes Berg wrote:
> On Tue, 2009-09-01 at 08:22 -0700, Luis R. Rodriguez wrote:
> > "Wireless" is a misnomer 802.11 as there are plently
> > of other wireless technologies. Be more specific and refer
> > people to our good hearty wireless wiki for documentation.
> >
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> > net/Kconfig | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 041c35e..31c208d 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -260,9 +260,15 @@ config FIB_RULES
> > bool
> >
> > menuconfig WIRELESS
> > - bool "Wireless"
> > + bool "IEEE 802.11 - Wireless LAN"
>
> But this also has WEXT under it which supports pre-802.11 technologies,
> no?
Heh yeah, good point.
> Might not matter at this point though.
Probably not, its more 802.11 than pre now.
Luis
^ permalink raw reply
* Re: [PATCH 3/7] wireless: update cfg80211 kconfig entry
From: Larry Finger @ 2009-09-01 15:37 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, Johannes Berg
In-Reply-To: <1251818566-9264-4-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> cfg80211 is now *the* wireless configuration API. Lets also
> give a little explanation as to what it is and refer people to
> the wireless wiki for more information.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/wireless/Kconfig | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index aea7e68..9fd570b 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -1,6 +1,15 @@
> config CFG80211
> - tristate "Improved wireless configuration API"
> + tristate "cfg80211 - wireless configuration API"
> depends on RFKILL || !RFKILL
> + ---help---
> + cfg80211 is the Linux wireless LAN (802.11) configuration API.
> + Enable this if you have a wireless device.
> +
> + For more information refer to documentation on the wireless wiki:
> +
> + http://wireless.kernel.org/en/developers/Documentation/cfg80211
> +
> + When built as a module cfg80211 will be built as cfg80211
First of all, I think this modest change is much better than the
previous set of patches, and that the additional info you provide for
mac80211 and friends will be useful for those who don't live with
802.11 wifi all day long.
That said, I find the above statement to be a little clumsy. Perhaps
it should be "When built as a module, it will be called cfg80211". The
same comment also applies to patch 6 for mac80211.
Larry
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox