Linux wireless drivers development
 help / color / mirror / Atom feed
* Re: pull request: wireless-next-2.6 2009-10-28
From: Ivo van Doorn @ 2009-11-04 21:17 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Pavel Machek, Luis Correia, John W. Linville, Ingo Molnar,
	Johannes Berg, Jarek Poplawski, Bartlomiej Zolnierkiewicz,
	Pekka Enberg, David Miller, linux-wireless, netdev, linux-kernel
In-Reply-To: <alpine.LRH.2.00.0911041403480.31913@twin.jikos.cz>

On Wednesday 04 November 2009, Jiri Kosina wrote:
> On Mon, 2 Nov 2009, Pavel Machek wrote:
> 
> > > I've searched on my GMail archives and the only patch Bart has
> > > provided so far for the rt2x00 project is this:
> > > 
> > > [PATCH] MAINTAINERS: rt2x00 list is moderated
> > > 
> > > Which, while technically correct, adds nothing to the project.
> > > 
> > > So, I will personally continue to ignore Bart's comments, regards and
> > > rants, until he provides patches for rt2x00 that actually make the
> > > driver better.
> > 
> > Well, he provided review feedback... he should be thanked for that,
> > not flamed for it.
> 
> He has actually written real patches (and quite non-trivial both in amount 
> and in functionality), see
> 
> 	http://lkml.org/lkml/2009/11/3/372

Please look at the TIMESTAMP of the mail you refer to, and the TIMESTAMP
of the mail from Luis. And then you can make assumptions about the text...

> But yes, he got flamed for this for some odd reason. I got the impression 
> that the community around rt2x00 doesn't like (or understand) the way how 
> opensource development happens.

Well you mean the open source development where non-contributors
complain that the contributors work too slowly? Well if that is the way
things should go, then I don't want to be part of such idiocy. Perhaps
that is the policy in some companies which try to import it into the
Open Source world...

Ivo

^ permalink raw reply

* Re: compat-wireless and minstrel
From: Derek Smithies @ 2009-11-04 21:01 UTC (permalink / raw)
  To: Christian Lamparter; +Cc: Adam Wozniak, linux-wireless, nbd
In-Reply-To: <200911041653.33737.chunkeey@googlemail.com>

Hi,
On Wed, 4 Nov 2009, Christian Lamparter wrote:

> On Wednesday 04 November 2009 02:13:49 Adam Wozniak wrote:
>> I have two systems under test, both Dell laptops (a Latitude D630 and an
>> Inspiron 600m) both running Ubuntu 9.10 with the latest updates, and
>> bleeding edge compat-wireless-2009-11-02.  I'm using identical AR9170
>> based D-Link DWA-160 USB 802.11adapters.  I'm using nuttcp to measure
>> throughput.  I'm running in ad-hoc mode.  Both machines have the same
>> ar9170 files in /lib/firmware.  The machines are sitting about 5 feet
>> apart in my office.
>>
>> I'm having occasional problems where throughput drops through the floor
>> (0.5Mbps - 1.5Mbps).  When I cat
>> /sys/kernel/debug/ieee80211/*/stations/*/rc_stats, one of the machines
>> lists the full set of rates, but the other only lists 1M and 54M.  After
>> a period of time, that machine drops 54M and lists only one rate
>> (1Mbps), and the throughput listed by nuttcp drops accordingly.  I
>> assume that, for whatever reason, the rates drop off the list and
>> minstrel uses the only one left available to it.
>>
>> If I modify include/net/mac80211.h and force the inline function
>> rate_supported to always return 1, this fixes the problem.  However, I
>> think this is a band aid around some other issue.
>>
>> Any clues or ideas what the real issue might be here?

My guess::

When an adhoc node (call it A) merges with a second adhoc node (call it 
B) there is a capability comparison.
Node A looks at the rates supported by B and says,
   "I must only transmit at rates supported by B"

Some management frames don't contain a full report of the rates supported 
by the sender.
My view is that node A (in this example) is incorrectly determining that B 
only supports the 1mb/sec rate. Consequently, node A fills the 
rate_supported  array with one rate - 1mb/sec.

=====

There is no evidence that Minstrel is doing anything wrong.

The original poster's report of examining
>> /sys/kernel/debug/ieee80211/*/stations/*/rc_stats
is very important, as it shows exactly what minstrel is doing.

When examining network problems, one should always check the rc_stats 
file. This tells you much about what is going on in the radio medium.

Derek.

Derek Smithies Ph.D. 
IndraNet Technologies Ltd. 
ph +64 3 365 6485 
Web: http://www.indranet-technologies.com/

"The only thing IE should be used for is to download Fire Fox"

"My favorite language is call STAR. It's extremely concise. It has
  exactly one verb '*', which does exactly what I want at the moment."
     --Larry Wall

^ permalink raw reply

* Re: [rt2x00-users] rt61pci bug
From: Luis Correia @ 2009-11-04 20:39 UTC (permalink / raw)
  To: rt2x00 Users List, Tim Blechmann, linux-wireless
In-Reply-To: <20091104192704.GJ3418@katherina.student.utwente.nl>

On Wed, Nov 4, 2009 at 19:27, Matthijs Kooijman <matthijs@stdin.nl> wrote:
>> [ 1656.653963] Please file bug report to http://rt2x00.serialmonkey.com
>>
>> Is that message correct?  The bug reports link at the wiki seems a bit unclear...
> Also, I just noticed that the "mailing lists" link in the first section, as
> well as the "LISTS" link in the menu bar at the top point to the old
> sourceforge lists page, which is empty.
>
> Perhaps the frontpage should be reviewed a bit?
>
> Gr.
>
> Matthijs
>

I've notified Mark, our webmaster.

Hopefully, we'll have it fixed in a couple of days, thanks for the notice.

Luis Correia
rt2x00 project admin

^ permalink raw reply

* Re: Marvell 88w8385 Support
From: Dan Williams @ 2009-11-04 20:34 UTC (permalink / raw)
  To: Holger Schurig; +Cc: tsr, linux-wireless, mangoo
In-Reply-To: <m3eioe48c0.wl%holgerschurig@googlemail.com>

On Wed, 2009-11-04 at 16:29 +0100, Holger Schurig wrote:
> > From what I can tell there was a patch (referenced here:
> > http://marc.info/?l=linux-wireless&m=123782768023390&w=2) to fix this
> > but I also get indications that this is not the case since there is both
> > a USB and miniPCI version of the 88w8385.
> 
> This patch is only for the CF/PCMCIA versions of this those chips.
> 
> There is no if_pci.c yet inside drivers/net/wireless/libertas/, if you
> are certain you've a PCI card you're welcome to write one, should be
> pretty easy. You can get help by looking at the other if_*.c files for
> other physical interfaces.
> 
> 
> > You write something
> > (http://marc.info/?l=linux-wireless&m=124334594302472&w=2) that is
> > cryptic to me.
> 
> Can you elaborate?  What exactly here is cryptic?
> 
> CF/SDIO/GSPO/USB ?
> 8015/8385 ?
> 
> 
> > Also searching the kernel gittree I found
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/net/wireless/libertas/if_spi.c;h=06a46d7b3d6c2460aecd793d2827033c7c0348f6;hb=cadeba315cc91ae1b57632e61b0cec3a4ed7088d
> > which seems to include a driver for the miniPCI libertas 88w8385.
> 
> No, if_spi.c is an indicator that this is  for an SPI or GSPI.
> 
> There's to my knowledge no such thing as a PCI-based Marvell 8385
> chip/card/whatever.

I'm fairly sure 8385 is only CF and SDIO.

Perhaps he means 8335 instead?  That was available in both USB and PCI,
but it's a softmac part that doesn't have mwl8k support yet afaik.

Dan


> There is, however, some support for other Marvel 8xxx PCI-based cards
> in linux, see drivers/net/wireless/mwl8k.c.


^ permalink raw reply

* Re: [PATCH 24/41] rt2800usb: convert to use struct rt2800_ops methods
From: Gertjan van Wingerde @ 2009-11-04 20:22 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173453.28463.94062.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800usb: convert to use struct rt2800_ops methods
>
> Add chipset registers access abstraction layer and prepare for later
> code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH 22/41] rt2800pci: add rt2800_mcu_request() wrapper
From: Gertjan van Wingerde @ 2009-11-04 20:21 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173439.28463.20951.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800pci: add rt2800_mcu_request() wrapper
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH 00/41] rewritten rt2800 drivers
From: Gertjan van Wingerde @ 2009-11-04 20:19 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173151.28463.68742.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:31 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
>
> Hi,
>
> Here is the rt2800 rewrite in the form of patches (I've trimmed cc:
> list considerably since I'm not sure whether most people really want
> to see 40+ patches in their mailboxes).
>
>
> There were some minor changes since yesterday:
>
> - two new patches were added at the top of tree fixing Kconfig help
>  entries of rt2800[pci,usb] drivers to be more helpful and to prevent
>  wasting people's time (I think that patch #1 should go to Linus'
>  tree as soon as possible, ditto for patch #2 and net-next tree)
>
> - patch descriptions were improved for many patches
>  (suggestion from Ingo)
>
> - rt2x00_intf_is_[pci,usb]() helpers for commonly used checks were
>  added to "rt2x00: add support for different chipset interfaces" patch
>  (suggestion from Ivo)
>
> - addition of separate rt2800 MAINTAINERS entry was dropped for now
>  because it stirred needless controversies distracting people from
>  technical issues (thanks to Julian Calaby for pointing this to me),
>  the goal of change was to make sure that people won't bother busy
>  rt2x00 maintainers about rt2800 tree so it is not a big deal anyway
>
>
> The rt2800 tree has also been updated to reflect those changes
> (old branch is still available as rt2800-v1 for reference):
>
> The following changes since commit fa867e7355a1bdcd9bf7d55ebe9296f5b9c4028a:
>  Juuso Oikarinen (1):
>        wl1271: Generalize command response reading
>
> are available in the git repository at:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git rt2800
>
> Bartlomiej Zolnierkiewicz (41):
>      rt2800usb: make Kconfig help entry more helpful
>      rt2800pci: make Kconfig help entry more helpful
>      rt2800usb: fix rt2800usb_rfcsr_read()
>      rt2800pci: fix crypto in TX frame
>      rt2800pci: fix comment about register access
>      rt2800pci: fix comment about IV/EIV fields
>      rt2x00: fix rt2x00usb_register_read() comment
>      rt2800usb: use rt2x00usb_register_multiwrite() to set key entries
>      rt2800usb: add rt2800_register_[read,write]() wrappers
>      rt2800pci: add rt2800_register_[read,write]() wrappers
>      rt2800usb: add rt2800_register_multi[read,write]() wrappers
>      rt2800pci: add rt2800_register_multi[read,write]() wrappers
>      rt2800usb: add rt2800_regbusy_read() wrapper
>      rt2800pci: add rt2800_regbusy_read() wrapper
>      rt2800usb: add rt2800_bbp_[read,write]() wrappers
>      rt2800pci: add rt2800_bbp_[read,write]() wrappers
>      rt2800usb: add rt2800_rfcsr_[read,write]() wrappers
>      rt2800pci: add rt2800_rfcsr_[read,write]() wrappers
>      rt2800usb: add rt2800_rf_[read,write]() wrappers
>      rt2800pci: add rt2800_rf_[read,write]() wrappers
>      rt2800usb: add rt2800_mcu_request() wrapper
>      rt2800pci: add rt2800_mcu_request() wrapper
>      rt2x00: add driver private field to struct rt2x00_dev
>      rt2800usb: convert to use struct rt2800_ops methods
>      rt2800pci: convert to use struct rt2800_ops methods
>      rt2x00: fix rt2x00usb_register_multiwrite() arguments
>      rt2x00: fix rt2x00usb_regbusy_read() arguments
>      rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
>      rt2800: add rt2800lib.h
>      rt2800usb: fix comments in rt2800usb.h
>      rt2800usb: add RXINFO_DESC_SIZE definition
>      rt2800: fix duplication in header files
>      rt2800: fix comments in rt2800.h
>      rt2x00: add support for different chipset interfaces
>      rt2800: prepare for rt2800lib addition
>      rt2800: add rt2800lib (part one)
>      rt2x00: remove needless ifdefs from rt2x00leds.h
>      rt2800: add rt2800lib (part two)
>      rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
>      rt2800: add rt2800lib (part three)
>      rt2800: add rt2800lib (part four)
>
>  drivers/net/wireless/rt2x00/Kconfig      |   16 +-
>  drivers/net/wireless/rt2x00/Makefile     |    1 +
>  drivers/net/wireless/rt2x00/rt2800.h     | 1816 ++++++++++++++++++++++++++++
>  drivers/net/wireless/rt2x00/rt2800lib.c  | 1817 ++++++++++++++++++++++++++++
>  drivers/net/wireless/rt2x00/rt2800lib.h  |  134 +++
>  drivers/net/wireless/rt2x00/rt2800pci.c  | 1908 +++---------------------------
>  drivers/net/wireless/rt2x00/rt2800pci.h  | 1780 ----------------------------
>  drivers/net/wireless/rt2x00/rt2800usb.c  | 1828 ++---------------------------
>  drivers/net/wireless/rt2x00/rt2800usb.h  | 1818 +----------------------------
>  drivers/net/wireless/rt2x00/rt2x00.h     |   43 +
>  drivers/net/wireless/rt2x00/rt2x00leds.h |    4 -
>  drivers/net/wireless/rt2x00/rt2x00pci.h  |   24 +-
>  drivers/net/wireless/rt2x00/rt2x00usb.c  |    2 +-
>  drivers/net/wireless/rt2x00/rt2x00usb.h  |   17 +-
>  14 files changed, 4048 insertions(+), 7160 deletions(-)
>  create mode 100644 drivers/net/wireless/rt2x00/rt2800.h
>  create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.c
>  create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.h
>

Hi Bart,

Many thanks for these patches.

So far I have been able to go through the first 30 patches of the
series. I'll finish the other 11 tomorrow (when I'm back home and have
better facilities to review these more elaborate patches of the
series).
They all look fine to me, I only had a comment for patch 10.

I've sent my ACKs for the remaining 29 I reviewed.

I guess Ivo still has to review them as well, as, so far, he has been
the one of the rt2x00 project to give the final ACK for inclusion,
unless he indicates that he is fine with my assessments.

---
Gertjan
rt2x00 developer

^ permalink raw reply

* Re: [rt2x00-users] rt61pci bug
From: Matthijs Kooijman @ 2009-11-04 19:27 UTC (permalink / raw)
  To: rt2x00 Users List; +Cc: Tim Blechmann, linux-wireless
In-Reply-To: <20091104185212.GL12965@tuxdriver.com>

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

> [ 1656.653963] Please file bug report to http://rt2x00.serialmonkey.com
> 
> Is that message correct?  The bug reports link at the wiki seems a bit unclear...
Also, I just noticed that the "mailing lists" link in the first section, as
well as the "LISTS" link in the menu bar at the top point to the old
sourceforge lists page, which is empty.

Perhaps the frontpage should be reviewed a bit?

Gr.

Matthijs

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply

* Re: [PATCH 30/41] rt2800usb: fix comments in rt2800usb.h
From: Gertjan van Wingerde @ 2009-11-04 20:12 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173539.28463.82770.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800usb: fix comments in rt2800usb.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: pci_set_mwi() and ath5k
From: Nick Kossifidis @ 2009-11-04 20:12 UTC (permalink / raw)
  To: Luis R. Rodriguez
  Cc: linux-wireless, ath5k-devel, Matthew Wilcox, Stephen Hemminger
In-Reply-To: <43e72e890911041204n55b54f8iace79938b40baa32@mail.gmail.com>

2009/11/4 Luis R. Rodriguez <mcgrof@gmail.com>:
> Curious if anyone recalls the issues seen with enabling MWI on ath5k.
> I could have sworn there was some discussion on this but for the life
> of me I cannot find it.
>
>  Luis

Maybe this one ?
http://osdir.com/ml/linux.drivers.ath5k.devel/2008-07/msg00088.html



-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

^ permalink raw reply

* Re: [PATCH 29/41] rt2800: add rt2800lib.h
From: Gertjan van Wingerde @ 2009-11-04 20:09 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173532.28463.33083.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib.h
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: ralink rt2x00 maintainer list error
From: Tim Blechmann @ 2009-11-04 20:08 UTC (permalink / raw)
  To: Luis Correia; +Cc: linux-wireless
In-Reply-To: <efe7343f0911041201n6636adbahbbed24b45abd8c23@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

>>>> the MAINTAINERS file contains the entries for the ralink rt2k00:
>>>> L:      linux-wireless@vger.kernel.org
>>>> L:      users@rt2x00.serialmonkey.com (moderated for non-subscribers)
>>>>
>>>> the second list doesn't exist any more, though ... would be nice, if the
>>>> entry could be updated ...
>>>
>>> You can find the list information here:
>>> http://rt2x00.serialmonkey.com/mailman/listinfo
>>
>> odd, that my posting was rejected, then ...
>>
>> btw, it would be nice, if you could mirror the list at gmane ... [1]
>> seems to be outdated ...
> 
> We've had some issues with Gmane some years ago and we've decided not
> to mirror any of our lists there, sorry mate.

some people (like me) prefer using mailinglists via nntp instead of
subscribing to the developer mailinglists of dozens of projects ...
but, well, if my bug is fixed before the 2.6.32 release, i am happy :)

tim

-- 
tim@klingt.org
http://tim.klingt.org

Nothing exists until or unless it is observed. An artist is making
something exist by observing it. And his hope for other people is that
they will also make it exist by observing it. I call it 'creative
observation.' Creative viewing.
  William S. Burroughs


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply

* pci_set_mwi() and ath5k
From: Luis R. Rodriguez @ 2009-11-04 20:04 UTC (permalink / raw)
  To: linux-wireless; +Cc: ath5k-devel, Matthew Wilcox, Stephen Hemminger

Curious if anyone recalls the issues seen with enabling MWI on ath5k.
I could have sworn there was some discussion on this but for the life
of me I cannot find it.

  Luis

^ permalink raw reply

* Re: [PATCH 28/41] rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
From: Gertjan van Wingerde @ 2009-11-04 20:04 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173525.28463.40807.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
>
> Change type of 'length' argument from u16 to u32 (all arguments
> match rt2x00usb_register_multi[read,write]() ones now).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH] libertas if_usb: Fix crash on 64-bit machines
From: Dan Williams @ 2009-11-04 20:01 UTC (permalink / raw)
  To: David Woodhouse
  Cc: John W. Linville, Christian Lamparter, Larry Finger, libertas-dev,
	linux-wireless, stern, davem
In-Reply-To: <1257363418.22822.28.camel@macbook.infradead.org>

On Wed, 2009-11-04 at 19:36 +0000, David Woodhouse wrote:
> On Wed, 2009-11-04 at 14:16 -0500, John W. Linville wrote:
> > Is anyone evaluating these suggestions?  Should I be expecting
> > properly formatted patch emails? 
> 
> The suggestions make sense, but not for stable. Let's fix the crasher
> bug first, and worry about the rest later.

Sounds good to me...

Dan



^ permalink raw reply

* Re: [PATCH 27/41] rt2x00: fix rt2x00usb_regbusy_read() arguments
From: Gertjan van Wingerde @ 2009-11-04 20:01 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173518.28463.61728.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: fix rt2x00usb_regbusy_read() arguments
>
> Add const to 'field' argument of rt2x00usb_regbusy_read()
> (all arguments match rt2x00pci_regbusy_read() ones now).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: ralink rt2x00 maintainer list error
From: Luis Correia @ 2009-11-04 20:01 UTC (permalink / raw)
  To: Tim Blechmann; +Cc: linux-wireless
In-Reply-To: <4AF1DCC8.8020400@klingt.org>

Hi again,

On Wed, Nov 4, 2009 at 19:58, Tim Blechmann <tim@klingt.org> wrote:
>>> the MAINTAINERS file contains the entries for the ralink rt2k00:
>>> L:      linux-wireless@vger.kernel.org
>>> L:      users@rt2x00.serialmonkey.com (moderated for non-subscribers)
>>>
>>> the second list doesn't exist any more, though ... would be nice, if the
>>> entry could be updated ...
>>
>> You can find the list information here:
>> http://rt2x00.serialmonkey.com/mailman/listinfo
>
> odd, that my posting was rejected, then ...
>
> btw, it would be nice, if you could mirror the list at gmane ... [1]
> seems to be outdated ...

We've had some issues with Gmane some years ago and we've decided not
to mirror any of our lists there, sorry mate.

>
> thnx, tim
>
> [1] http://news.gmane.org/gmane.linux.drivers.rt2x00.general
>
> --
> tim@klingt.org
> http://tim.klingt.org
>
> The aim of education is the knowledge, not of facts, but of values
>  William S. Burroughs
>
>

Luis Correia
rt2x00 project admin

^ permalink raw reply

* Re: [PATCH 26/41] rt2x00: fix rt2x00usb_register_multiwrite() arguments
From: Gertjan van Wingerde @ 2009-11-04 19:59 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173510.28463.24779.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: fix rt2x00usb_register_multiwrite() arguments
>
> Add const to 'value' argument of rt2x00usb_register_multiwrite()
> (all arguments match rt2x00pci_register_multiwrite() ones now).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH 25/41] rt2800pci: convert to use struct rt2800_ops methods
From: Gertjan van Wingerde @ 2009-11-04 19:56 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173500.28463.89800.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:35 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800pci: convert to use struct rt2800_ops methods
>
> Add chipset registers access abstraction layer and prepare for later
> code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: ralink rt2x00 maintainer list error
From: Luis Correia @ 2009-11-04 19:55 UTC (permalink / raw)
  To: Tim Blechmann; +Cc: linux-wireless
In-Reply-To: <hcsfnq$bft$2@ger.gmane.org>

Hi Tim,

On Wed, Nov 4, 2009 at 18:04, Tim Blechmann <tim@klingt.org> wrote:
> the MAINTAINERS file contains the entries for the ralink rt2k00:
> L:      linux-wireless@vger.kernel.org
> L:      users@rt2x00.serialmonkey.com (moderated for non-subscribers)
>
> the second list doesn't exist any more, though ... would be nice, if the
> entry could be updated ...

You can find the list information here:
http://rt2x00.serialmonkey.com/mailman/listinfo

>
> thnx, tim
>
> --
> tim@klingt.org
> http://tim.klingt.org

Luis Correia
rt2x00 project admin

^ permalink raw reply

* Re: [PATCH 23/41] rt2x00: add driver private field to struct rt2x00_dev
From: Gertjan van Wingerde @ 2009-11-04 19:55 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173446.28463.62662.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: add driver private field to struct rt2x00_dev
>
> Enhance rt2x00 infrastructure by adding driver specific field to
> struct rt2x00_dev.
>
> The new field will be used by rt2800 drivers for chipset registers
> access abstraction layer.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [RFC] usb: Check results of dma_map_single
From: Christian Lamparter @ 2009-11-04 19:49 UTC (permalink / raw)
  To: Larry Finger; +Cc: Greg Kroah-Hartman, linux-wireless, linux-usb
In-Reply-To: <4af115c3.JUDAYfcydqPYCYyH%Larry.Finger@lwfinger.net>

On Wednesday 04 November 2009 06:48:51 Larry Finger wrote:
> At http://marc.info/?l=linux-wireless&m=125695331205062&w=2, a problem
> with DMA buffer processing was corrected for the libertas driver. Because
> routine usb_fill_bulk_urb() does not check that DMA is possible when
           ^^^
hmm, usb_fill_bulk_urb? No, that should be usb_submit_urb :)

http://osdir.com/ml/linux-wireless/2009-10/msg01182.html

> dma_map_single() is called, this condition was not detected until the buffer
> was unmapped. By this time memory corruption had occurred.
> 
> The situation is fixed by testing the returned DMA address. If not a legal
> address, a WARN_ON(1) is executed to provide traceback and the error is
> returned.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>


^ permalink raw reply

* Re: [PATCH 21/41] rt2800usb: add rt2800_mcu_request() wrapper
From: Gertjan van Wingerde @ 2009-11-04 19:48 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173432.28463.51210.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800usb: add rt2800_mcu_request() wrapper
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH 20/41] rt2800pci: add rt2800_rf_[read,write]() wrappers
From: Gertjan van Wingerde @ 2009-11-04 19:47 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173425.28463.74288.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800pci: add rt2800_rf_[read,write]() wrappers
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what is is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply

* Re: [PATCH 19/41] rt2800usb: add rt2800_rf_[read,write]() wrappers
From: Gertjan van Wingerde @ 2009-11-04 19:46 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173418.28463.79825.sendpatchset@localhost.localdomain>

On Wed, Nov 4, 2009 at 6:34 PM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800usb: add rt2800_rf_[read,write]() wrappers
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---

For what it is worth:

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox