* [PATCH] zd1211rw: ignore unknown regulatory domain.
From: Kouhei Sutou @ 2010-06-13 5:52 UTC (permalink / raw)
To: linux-wireless
[-- Attachment #1: Type: Text/Plain, Size: 1570 bytes --]
Hi,
I'm using PLANEX GW-US54GXS (2019:5303) and it works with
the attached patch. Could you consider to merge the attached
patch?
Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
a regulatory domain reported by GW-US54GXS (0x49).
Solutions:
(1) add a new regulatory domain (0x49). Here is a patch to
use the approach:
----
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index 163a8a0..faf45f1 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
@@ -43,6 +43,7 @@ static struct zd_reg_alpha2_map reg_alpha2_map[] = {
{ ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
{ ZD_REGDOMAIN_JAPAN, "JP" },
{ ZD_REGDOMAIN_JAPAN_ADD, "JP" },
+ { ZD_REGDOMAIN_JAPAN_GW_US54GXS, "JP" },
{ ZD_REGDOMAIN_SPAIN, "ES" },
{ ZD_REGDOMAIN_FRANCE, "FR" },
};
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.h b/drivers/net/wireless/zd1211rw/zd_mac.h
index 630c298..7ab19d5 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.h
+++ b/drivers/net/wireless/zd1211rw/zd_mac.h
@@ -214,6 +214,7 @@ struct zd_mac {
#define ZD_REGDOMAIN_FRANCE 0x32
#define ZD_REGDOMAIN_JAPAN_ADD 0x40
#define ZD_REGDOMAIN_JAPAN 0x41
+#define ZD_REGDOMAIN_JAPAN_GW_US54GXS 0x49
enum {
MIN_CHANNEL24 = 1,
----
(2) just ignore unknown regulatory domain. (the attached
patch approach)
It seems that (2) is a better solution because we can change
regulatory domain by CRDA (*).
(*) http://wireless.kernel.org/en/developers/Regulatory/CRDA
Thanks,
--
kou
[-- Attachment #2: 0001-zd1211rw-ignore-unknown-regulatory-domain.patch --]
[-- Type: Text/X-Patch, Size: 1353 bytes --]
>From c230320db45e9261814b69e7596d4f641c3c8aad Mon Sep 17 00:00:00 2001
From: Kouhei Sutou <kou@clear-code.com>
Date: Sun, 13 Jun 2010 14:37:54 +0900
Subject: [PATCH] zd1211rw: ignore unknown regulatory domain.
Zd1211rw supports 7 regulatory domains (ZD_REGDOMAIN_*) but they
aren't cover all regulatory domains. For example, PLANEX
GW-US54GXS (2019:5303) uses 0x49 for its regulatory domain.
If zd1211rw can't convert a regulatory domain to alpha2, it
reports that initialization is failed. But we can change
regulatory domain by another way (CRDA). So it seems that zd1211rw
can ignore unknown regulatory domain.
Signed-off-by: Kouhei Sutou <kou@clear-code.com>
---
drivers/net/wireless/zd1211rw/zd_mac.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index 163a8a0..8b04d93 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
@@ -198,11 +198,9 @@ int zd_mac_init_hw(struct ieee80211_hw *hw)
if (r)
goto disable_int;
- r = zd_reg2alpha2(mac->regdomain, alpha2);
- if (r)
- goto disable_int;
+ if (zd_reg2alpha2(mac->regdomain, alpha2))
+ r = regulatory_hint(hw->wiphy, alpha2);
- r = regulatory_hint(hw->wiphy, alpha2);
disable_int:
zd_chip_disable_int(chip);
out:
--
1.7.1
^ permalink raw reply related
* [PATCH 2.6.35 V2] p54pci: add Symbol AP-300 minipci adapters pciid
From: Christian Lamparter @ 2010-06-13 12:22 UTC (permalink / raw)
To: linux-wireless; +Cc: Joerg Albert, John W Linville
From: Joerg Albert <jal2@gmx.de>
Cc: stable@kernel.org
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
> On Sunday 13 June 2010, Joerg Albert wrote:
>
> BTW, the 2.4 GHz card in the AP-300 has the same id
---
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index 791e2ae..4357e69 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -42,6 +42,8 @@ static DEFINE_PCI_DEVICE_TABLE(p54p_table) = {
{ PCI_DEVICE(0x1260, 0x3877) },
/* Intersil PRISM Javelin/Xbow Wireless LAN adapter */
{ PCI_DEVICE(0x1260, 0x3886) },
+ /* Intersil PRISM Xbow Wireless LAN adapter (Symbol AP-300) */
+ { PCI_DEVICE(0x1260, 0xffff) },
{ },
};
^ permalink raw reply related
* 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34
From: Rafael J. Wysocki @ 2010-06-13 14:45 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
[NOTES:
* This report has been delayed, because I had to go through all of the
entries and filter out the fixed ones, invalid ones etc. Of course, I might
have missed some, but hopefully not too many.
* E-mail reports from the last 7 days are not included.]
This message contains a list of some post-2.6.33 regressions introduced before
2.6.34, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.33 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-06-13 111 40 34
2010-05-09 80 27 24
2010-05-04 76 26 22
2010-04-20 64 35 34
2010-04-07 48 35 33
2010-03-21 15 13 10
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16170
Subject : Leadtek Winfast DTV Dongle (STK7700P based) is not working in 2.6.34
Submitter : macjariel <macjariel@gmail.com>
Date : 2010-06-09 11:11 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16162
Subject : SSD + sata_nv + btrfs oops
Submitter : Dave Airlie <airlied@gmail.com>
Date : 2010-06-01 3:04 (13 days old)
Message-ID : <AANLkTilqsIdlzZgUf7TMLHYKqHDZoVkcs42vcG8wXKEr@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127536149022333&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16158
Subject : winxp guest hangs after idle for ~30 minutes
Submitter : brimhall <brimhall@pobox.com>
Date : 2010-06-08 17:52 (6 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16139
Subject : wait_even_interruptible_timeout(), signal, spin_lock() = system hang
Submitter : Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Date : 2010-05-28 16:44 (17 days old)
Message-ID : <AANLkTiliRFydAhxH2-Dp1RKuz6sq7vgWIcMvLMi68ftg@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127506510328758&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16137
Subject : Ooops in BTRFS in 2.6.34 / x86_64 when mounting subvolume by name
Submitter : armin walland <a.walland@focusmr.com>
Date : 2010-05-27 12:27 (18 days old)
Message-ID : <201005271428.01239.a.walland@focusmr.com>
References : http://marc.info/?l=linux-kernel&m=127496434110736&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16136
Subject : Linux 2.6.34 causes system lockup on Compaq Presario 2200 Laptop
Submitter : Jeffrey Merkey <jeffmerkey@gmail.com>
Date : 2010-05-27 18:08 (18 days old)
Message-ID : <AANLkTil6GGSoc8TpzRacr1LZBZS3ee3H1ejYDSqfdul4@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127498375415689&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16135
Subject : [BUG] kacpi_notify goes into an infinite loop (luckly it calls cond_resched)
Submitter : Steven Rostedt <rostedt@goodmis.org>
Date : 2010-05-29 1:01 (16 days old)
First-Bad-Commit: http://git.kernel.org/linus/fa80945269f312bc609e8384302f58b03c916e12
Message-ID : <1275094882.22648.607.camel@gandalf.stny.rr.com>
References : http://marc.info/?l=linux-kernel&m=127509490405845&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16134
Subject : 2.6.34 hard lock ppp/do_tty_hangup, regression
Submitter : Richard Zidlicky <rz@linux-m68k.org>
Date : 2010-05-26 8:48 (19 days old)
Message-ID : <20100526084811.GA5890@linux-m68k.org>
References : http://marc.info/?l=linux-kernel&m=127486354023473&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16111
Subject : hostap_pci: infinite registered netdevice wifi0
Submitter : Petr Pisar <petr.pisar@atlas.cz>
Date : 2010-06-02 20:55 (12 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16097
Subject : 2.6.34 on Samsung P460: reset after "Waiting for /dev to be fully populated"
Submitter : Harald Dunkel <harald.dunkel@aixigo.de>
Date : 2010-05-25 9:12 (20 days old)
Message-ID : <4BFB947E.9080509@aixigo.de>
References : http://marc.info/?l=linux-kernel&m=127477877432254&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16084
Subject : iwl3945 bug in 2.6.34
Submitter : Satish Eerpini <eerpini@gmail.com>
Date : 2010-05-23 6:37 (22 days old)
Message-ID : <AANLkTik_7rxDBc0TKlAfoYyM5S6Cf_Hyxbr4W5ORnTsq@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127459596015626&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16082
Subject : host panic on kernel 2.6.34
Submitter : Hao, Xudong <xudong.hao@intel.com>
Date : 2010-05-24 8:23 (21 days old)
Message-ID : <BC00F5384FCFC9499AF06F92E8B78A9E04DCCCE242@shsmsx502.ccr.corp.intel.com>
References : http://marc.info/?l=linux-kernel&m=127468951208864&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16054
Subject : UML broken for CONFIG_SLAB
Submitter : Parag Warudkar <parag.lkml@gmail.com>
Date : 2010-05-23 21:40 (22 days old)
Message-ID : <alpine.DEB.2.00.1005231149100.605@parag-laptop>
References : http://marc.info/?l=linux-kernel&m=127465083806617&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16050
Subject : The ibmcam driver is not working
Submitter : Bill Davidsen <davidsen@tmr.com>
Date : 2010-05-25 23:02 (20 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16040
Subject : kacpid consumes ~40% of cpu all the time beginning with 2.6.34
Submitter : Mehmet Giritli <mehmet@giritli.eu>
Date : 2010-05-24 07:32 (21 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16035
Subject : Incorrect initial resolution of (external) vga monitor with KMS
Submitter : andreas.eckstein <andreas.eckstein@gmx.net>
Date : 2010-05-23 12:28 (22 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16034
Subject : 2.6.34: dlm: possible circular locking dependency detected
Submitter : CaT <cat@zip.com.au>
Date : 2010-05-21 6:59 (24 days old)
Message-ID : <20100521065933.GH2657@zip.com.au>
References : http://marc.info/?l=linux-kernel&m=127442519608471&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15977
Subject : WARNING: at lib/dma-debug.c:866 check_for_stack
Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date : 2010-05-14 8:56 (31 days old)
Message-ID : <AANLkTikyx2eaxaiUCFDSfpmn1UG0t2GOxArz6F4wp1LJ@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127382742729825&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15970
Subject : BUG: amd64-agp (2.6.34-rc7)
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-05-11 20:56 (34 days old)
Message-ID : <4BE9C469.2020901@oracle.com>
References : http://marc.info/?l=linux-kernel&m=127361149610881&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15951
Subject : commit 9630bdd9 changes behavior of the poweroff
Submitter : Michal Hocko <mhocko@suse.cz>
Date : 2010-04-01 13:39 (74 days old)
First-Bad-Commit: http://git.kernel.org/linus/9630bdd9b15d2f489c646d8bc04b60e53eb5ec78
Message-ID : <20100401133923.GA4104@tiehlicka.suse.cz>
References : http://marc.info/?l=linux-kernel&m=127012918316305&w=4
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15936
Subject : Suspicious rcu_dereference_check() usage detected during 2.6.34-rc6 boot on PPC64/p5 processor
Submitter : Subrata Modak <subrata@linux.vnet.ibm.com>
Date : 2010-05-06 7:29 (39 days old)
Message-ID : <1273130279.4898.5.camel@subratamodak.linux.ibm.com>
References : http://marc.info/?l=linux-kernel&m=127313031922395&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15924
Subject : kacpid consumes ~100% CPU, system freezes randomly
Submitter : Jaroslav Kameník <jaroslav@kamenik.cz>
Date : 2010-05-06 21:12 (39 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15862
Subject : 2.6.34-rc4/5: iwlagn unusable until reload
Submitter : Nico Schottelius <nico-linux-20100427@schottelius.org>
Date : 2010-04-27 7:49 (48 days old)
Message-ID : <20100427074934.GB3261@ikn.schottelius.org>
References : http://marc.info/?l=linux-kernel&m=127235784004839&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15858
Subject : [2.6.34-rc5] bad page state copying to/from HFS+ filesystem...
Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
Date : 2010-04-25 21:14 (50 days old)
Message-ID : <v2k6278d2221004251414kbbcc41baw78b86120d81dce7d@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127223008621881&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15805
Subject : reiserfs locking
Submitter : Alexander Beregalov <a.beregalov@gmail.com>
Date : 2010-04-15 21:02 (60 days old)
Message-ID : <t2ka4423d671004151402n7b2dc425mdc9c6bb9640d63fb@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127136535323933&w=2
Handled-By : Frederic Weisbecker <fweisbec@gmail.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15717
Subject : bluetooth oops
Submitter : Pavel Machek <pavel@ucw.cz>
Date : 2010-03-14 20:14 (92 days old)
Message-ID : <20100314201434.GE22059@elf.ucw.cz>
References : http://marc.info/?l=linux-kernel&m=126859771528426&w=4
Handled-By : Marcel Holtmann <marcel@holtmann.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15713
Subject : hackbench regression due to commit 9dfc6e68bfe6e
Submitter : Alex Shi <alex.shi@intel.com>
Date : 2010-03-25 8:40 (81 days old)
First-Bad-Commit: http://git.kernel.org/linus/9dfc6e68bfe6ee452efb1a4e9ca26a9007f2b864
Message-ID : <1269506457.4513.141.camel@alexs-hp.sh.intel.com>
References : http://marc.info/?l=linux-kernel&m=126950632920682&w=4
Handled-By : Christoph Lameter <cl@linux-foundation.org>
Pekka Enberg <penberg@cs.helsinki.fi>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15712
Subject : [regression] 2.6.34-rc1 to -rc3 on zaurus: no longer boots
Submitter : Pavel Machek <pavel@ucw.cz>
Date : 2010-04-01 6:06 (74 days old)
Message-ID : <20100401060624.GA1329@ucw.cz>
References : http://marc.info/?l=linux-kernel&m=127010200817402&w=2
Handled-By : Eric Miao <eric.y.miao@gmail.com>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15704
Subject : [r8169] WARNING: at net/sched/sch_generic.c
Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date : 2010-03-31 10:21 (75 days old)
Message-ID : <20100331102142.GA3294@swordfish.minsk.epam.com>
References : http://marc.info/?l=linux-kernel&m=127003090406108&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15673
Subject : 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
Submitter : Thomas Meyer <thomas@m3y3r.de>
Date : 2010-03-28 11:31 (78 days old)
Message-ID : <1269775909.5301.4.camel@localhost.localdomain>
References : http://marc.info/?l=linux-kernel&m=126977593326800&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15671
Subject : intel graphic card hanging (Hangcheck timer elapsed... GPU hung)
Submitter : Norbert Preining <preining@logic.at>
Date : 2010-03-27 16:11 (79 days old)
Message-ID : <20100327161104.GA12043@gamma.logic.tuwien.ac.at>
References : http://marc.info/?l=linux-kernel&m=126970883105262&w=2
Handled-By : Jesse Barnes <jbarnes@virtuousgeek.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15669
Subject : INFO: suspicious rcu_dereference_check()
Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date : 2010-03-08 1:26 (98 days old)
Message-ID : <c4e36d111003250348q678eb2e6w4f3e8133e7fd6e58@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=126801163107713&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15664
Subject : Graphics hang and kernel backtrace when starting Azureus with Compiz enabled
Submitter : Alex Villacis Lasso <avillaci@ceibo.fiec.espol.edu.ec>
Date : 2010-04-01 01:09 (74 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15659
Subject : [Regresion] [2.6.34-rc1] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung
Submitter : Maciej Rutecki <maciej.rutecki@gmail.com>
Date : 2010-03-25 20:04 (81 days old)
Message-ID : <201003252104.24965.maciej.rutecki@gmail.com>
References : http://marc.info/?l=linux-kernel&m=126954749618319&w=2
Handled-By : Chris Wilson <chris@chris-wilson.co.uk>
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16147
Subject : ksoftirq hogs the CPU
Submitter : Thomas Jarosch <thomas.jarosch@intra2net.com>
Date : 2010-06-07 15:17 (7 days old)
First-Bad-Commit: http://git.kernel.org/linus/ae74e823cb7d4cd476f623fce9a38f625f6c09a8
Handled-By : Martin Wilck <martin.wilck@ts.fujitsu.com>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26732
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16138
Subject : PCMCIA regression
Submitter : Mikulas Patocka <mpatocka@redhat.com>
Date : 2010-05-25 20:25 (20 days old)
Message-ID : <Pine.LNX.4.64.1005251619020.12278@hs20-bc2-1.build.redhat.com>
References : http://marc.info/?l=linux-kernel&m=127481913909672&w=2
Handled-By : Dominik Brodowski <linux@brodo.de>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26685
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16007
Subject : x86/pci Oops with CONFIG_SND_HDA_INTEL
Submitter : Graham Ramsey <ramsey.graham@ntlworld.com>
Date : 2010-05-19 17:09 (26 days old)
Handled-By : Yinghai Lu <yinghai@kernel.org>
Patch : https://patchwork.kernel.org/patch/105662/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15909
Subject : open("a/",O_NOFOLLOW) fails with ELOOP if "a" is a symbolic link to a directory.
Submitter : Marius Tolzmann <tolzmann@molgen.mpg.de>
Date : 2010-05-05 13:01 (40 days old)
Handled-By : OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Jan Kara <jack@suse.cz>
Patch : https://patchwork.kernel.org/patch/99291/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15863
Subject : 2.6.34-rc5-git7 (plus all patches) -- another suspicious rcu_dereference_check() usage.
Submitter : Miles Lane <miles.lane@gmail.com>
Date : 2010-04-27 0:51 (48 days old)
Message-ID : <h2ya44ae5cd1004261751waa5cb65ei3d139cbcfa2cc5cf@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127232949104878&w=2
Handled-By : Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Patch : https://patchwork.kernel.org/patch/96096/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15589
Subject : 2.6.34-rc1: Badness at fs/proc/generic.c:316
Submitter : Christian Kujau <lists@nerdbynature.de>
Date : 2010-03-13 23:53 (93 days old)
Message-ID : <<alpine.DEB.2.01.1003131544340.5493@bogon.housecafe.de>>
References : http://marc.info/?l=linux-kernel&m=126852442903680&w=2
Handled-By : Michael Ellerman <michael@ellerman.id.au>
Patch : http://patchwork.ozlabs.org/patch/52978/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.33 and 2.6.34, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=15310
Please let the tracking teak know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* Re: [rt2800pci] indirect register access failed
From: Markus Krainz @ 2010-06-13 16:41 UTC (permalink / raw)
To: linux-wireless
In-Reply-To: <20100611001357.27b316ba@vlado.suse.cz>
Vladimir Botka <vbotka@...> writes:
>
> Hallo,
>
> with the wireless-testing kernel [1] and the ralink [1814:3090] I can
> not load the firmware [2]. Any idea ?
>
> [1] 2.6.35-rc2-wl-wt-ralink+
>
> [2]
> Jun 11 00:07:10 calpella kernel: [ 6828.735900] phy0 ->
rt2800pci_load_firmware: Error - PBF system
> register not ready.
> Jun 11 00:07:10 calpella kernel: [ 6828.736466] phy0 ->
rt2x00pci_regbusy_read: Error - Indirect
> register access failed: offset=0x00007010, value=0x55555555
>
> Thank you,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Using Ubuntu 10.04 distro I upgraded from 2.6.32 to 2.6.34. Now I have the same
issue.
kernel: [ 2190.398394] phy0 -> rt2800pci_load_firmware: Error - PBF system
register not ready.
kernel: [ 2190.401983] phy0 -> rt2x00pci_regbusy_read: Error - Indirect register
access failed: offset=0x00007010, value=0xd53ac0a5
Help is greatly appreciated.
^ permalink raw reply
* DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 19
From: sundar mahadevan @ 2010-06-13 17:08 UTC (permalink / raw)
To: linux-wireless
Hi All,
Greetings. I am on Oracle Enterprise Linux (OEL 5.5 x86_64) same as
Redhat 5.5. I must use OEL5.5 because of my software installation
requirements. NetworkManager detects my ssid but its just not getting
ip from my router assigned. I use a Belkin 54g router with WPA/WPA2
encryption. The other options available on my router are WPA2 only,
WEP and Disabled. I have spent more than 20 hours trying to get wifi
working but no luck. Your help is highly appreciated.
[root@localhost ~]$uname -a
Linux localhost.localdomain 2.6.18-194.el5 #1 SMP Mon Mar 29 22:10:29
EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
[root@localhost /etc/wpa_supplicant]$lspci | grep -i ath
04:00.0 Network controller: Atheros Communications Inc. AR928X
Wireless Network Adapter (PCI-Express) (rev 01)
[root@localhost /etc/wpa_supplicant]$cat wpa_supplicant.conf
ctrl_interface=/var/run/wpa_supplicant
ctrl_interface_group=wheel
network={
ssid="any"
key_mgmt=NONE
}
[root@localhost ~]$service network restart
Shutting down interface wlan0: [ OK ]
Shutting down loopback interface: [ OK ]
Bringing up loopback interface: [ OK ]
Bringing up interface eth0:
Determining IP information for eth0...dhclient(5038) is already
running - exiting.
exiting.
failed.
[FAILED]
Bringing up interface wlan0: Error for wireless request "Set Mode" (8B06) :
SET failed on device wlan0 ; Invalid argument.
Determining IP information for wlan0... failed.
[FAILED]
[root@localhost /etc/sysconfig/network-scripts]$cat ifcfg-wlan0
# Atheros Communications Inc. AR928X Wireless Network Adapter (PCI-Express)
DEVICE=wlan0
BOOTPROTO=dhcp
ONBOOT=yes
HWADDR=90:4c:e5:56:ce:14
NETMASK=
DHCP_HOSTNAME=
IPADDR=
BONDING_OPTS=
DOMAIN=
MASTER=
TYPE=Wireless
USERCTL=no
IPV6INIT=no
PEERDNS=yes
ESSID=suma
CHANNEL=9
MODE=Auto
SECURITYMODE=off
RATE=auto
[root@localhost ~]$tail -f /var/log/messages
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
starting connection 'Auto suma'
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): device
state change: 3 -> 4
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) scheduled...
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) started...
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) scheduled...
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) complete.
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) starting...
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): device
state change: 4 -> 5
Jun 12 23:37:36 localhost NetworkManager: (info) Activation
(wlan0/wireless): access point 'Auto suma' has security, but secrets
are required.
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): device
state change: 5 -> 6
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) complete.
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) scheduled...
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) started...
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): device
state change: 6 -> 4
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) scheduled...
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 1 of 5 (Device Prepare) complete.
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) starting...
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): device
state change: 4 -> 5
Jun 12 23:37:36 localhost NetworkManager: (info) Activation
(wlan0/wireless): connection 'Auto suma' has security, and secrets
exist. No new secrets needed.
Jun 12 23:37:36 localhost NetworkManager: (info) Config: added 'ssid'
value 'suma'
Jun 12 23:37:36 localhost NetworkManager: (info) Config: added
'scan_ssid' value '1'
Jun 12 23:37:36 localhost NetworkManager: (info) Config: added
'key_mgmt' value 'WPA-PSK'
Jun 12 23:37:36 localhost NetworkManager: (info) Config: added 'psk'
value '(omitted)'
Jun 12 23:37:36 localhost NetworkManager: (info) Activation (wlan0)
Stage 2 of 5 (Device Configure) complete.
Jun 12 23:37:36 localhost NetworkManager: (info) Config: set
interface ap_scan to 1
Jun 12 23:37:36 localhost NetworkManager: (info) (wlan0): supplicant
connection state: disconnected -> scanning
Jun 12 23:37:37 localhost NetworkManager: (info) (wlan0): supplicant
connection state: scanning -> associating
Jun 12 23:37:38 localhost NetworkManager: (info) (wlan0): supplicant
connection state: associating -> associated
Jun 12 23:37:40 localhost NetworkManager: (info) (wlan0): supplicant
connection state: associated -> 4-way handshake
Jun 12 23:37:40 localhost NetworkManager: (info) (wlan0): supplicant
connection state: 4-way handshake -> group handshake
Jun 12 23:37:40 localhost NetworkManager: (info) (wlan0): supplicant
connection state: group handshake -> completed
Jun 12 23:37:40 localhost NetworkManager: (info) Activation
(wlan0/wireless) Stage 2 of 5 (Device Configure) successful.
Connected to wireless network 'suma'.
Jun 12 23:37:40 localhost NetworkManager: (info) Activation (wlan0)
Stage 3 of 5 (IP Configure Start) scheduled.
Jun 12 23:37:40 localhost NetworkManager: (info) Activation (wlan0)
Stage 3 of 5 (IP Configure Start) started...
Jun 12 23:37:40 localhost NetworkManager: (info) (wlan0): device
state change: 5 -> 7
Jun 12 23:37:40 localhost NetworkManager: (info) Activation (wlan0)
Beginning DHCP transaction.
Jun 12 23:37:40 localhost NetworkManager: (info) dhclient started with pid 4713
Jun 12 23:37:40 localhost NetworkManager: (info) Activation (wlan0)
Stage 3 of 5 (IP Configure Start) complete.
Jun 12 23:37:40 localhost dhclient: Internet Systems Consortium DHCP
Client V3.0.5-RedHat
Jun 12 23:37:40 localhost dhclient: Copyright 2004-2006 Internet
Systems Consortium.
Jun 12 23:37:40 localhost dhclient: All rights reserved.
Jun 12 23:37:40 localhost dhclient: For info, please visit
http://www.isc.org/sw/dhcp/
Jun 12 23:37:40 localhost dhclient:
Jun 12 23:37:40 localhost NetworkManager: (info) DHCP: device wlan0
state changed normal exit -> preinit
Jun 12 23:37:40 localhost dhclient: Listening on LPF/wlan0/90:4c:e5:56:ce:14
Jun 12 23:37:40 localhost dhclient: Sending on LPF/wlan0/90:4c:e5:56:ce:14
Jun 12 23:37:40 localhost dhclient: Sending on Socket/fallback
Jun 12 23:37:40 localhost dhclient: DHCPDISCOVER on wlan0 to
255.255.255.255 port 67 interval 3
Jun 12 23:37:43 localhost dhclient: DHCPDISCOVER on wlan0 to
255.255.255.255 port 67 interval 7
Jun 12 23:37:49 localhost dhclient: DHCPDISCOVER on wlan0 to
255.255.255.255 port 67 interval 20
Jun 12 23:38:10 localhost dhclient: DHCPDISCOVER on wlan0 to
255.255.255.255 port 67 interval 19
Jun 12 23:38:25 localhost NetworkManager: (info) Device 'wlan0' DHCP
transaction took too long (>45s), stopping it.
Jun 12 23:38:25 localhost NetworkManager: (info) wlan0: canceled DHCP
transaction, dhcp client pid 4713
Jun 12 23:38:25 localhost NetworkManager: (info) Activation (wlan0)
Stage 4 of 5 (IP Configure Timeout) scheduled...
Jun 12 23:38:25 localhost NetworkManager: (info) Activation (wlan0)
Stage 4 of 5 (IP Configure Timeout) started...
Jun 12 23:38:25 localhost NetworkManager: (info) (wlan0): device
state change: 7 -> 9
Jun 12 23:38:25 localhost NetworkManager: (info) Activation (wlan0)
failed for access point (suma)
Jun 12 23:38:25 localhost NetworkManager: (info) Marking connection
'Auto suma' invalid.
Jun 12 23:38:25 localhost NetworkManager: (info) Activation (wlan0) failed.
Jun 12 23:38:25 localhost NetworkManager: (info) Activation (wlan0)
Stage 4 of 5 (IP Configure Timeout) complete.
Jun 12 23:38:25 localhost NetworkManager: (info) (wlan0): device
state change: 9 -> 3
Jun 12 23:38:25 localhost NetworkManager: (info) (wlan0):
deactivating device (reason: 0).
^ permalink raw reply
* [PATCH 1/2] mac80211: Fix bss_info_changed comment regarding sleeping
From: Ivo van Doorn @ 2010-06-13 18:15 UTC (permalink / raw)
To: John W. Linville; +Cc: rt2x00 Users List, linux-wireless, Johannes Berg
The bss_info_changed callback function is allowed to sleep,
however when operating in Mesh mode, it can be used in
atomic context. Fixing it would seem to require major
locking changes in the mesh implementation.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
include/net/mac80211.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index de22cbf..73cf3ad 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -1533,7 +1533,8 @@ enum ieee80211_ampdu_mlme_action {
* This function should not be used if no BSS has been set, unless
* for association indication. The @changed parameter indicates which
* of the bss parameters has changed when a call is made. The callback
- * can sleep.
+ * can sleep except when operating in Mesh mode where the callback
+ * must be atomic.
*
* @prepare_multicast: Prepare for multicast filter configuration.
* This callback is optional, and its return value is passed
--
1.6.6.1
^ permalink raw reply related
* [PATCH 2/2] rt2x00: Disable Mesh mode for USB drivers
From: Ivo van Doorn @ 2010-06-13 18:16 UTC (permalink / raw)
To: John W. Linville; +Cc: rt2x00 Users List, linux-wireless, Johannes Berg
In-Reply-To: <201006132015.10629.IvDoorn@gmail.com>
bss_info_changed must be atomic in Mesh mode.
As a result it must be disabled for all USB drivers.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
drivers/net/wireless/rt2x00/rt2x00dev.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 7d30efd..8661ada 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -852,13 +852,22 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
* beacon entries.
*/
rt2x00dev->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
- if (rt2x00dev->ops->bcn->entry_num > 0)
+ if (rt2x00dev->ops->bcn->entry_num > 0) {
rt2x00dev->hw->wiphy->interface_modes |=
BIT(NL80211_IFTYPE_ADHOC) |
BIT(NL80211_IFTYPE_AP) |
- BIT(NL80211_IFTYPE_MESH_POINT) |
BIT(NL80211_IFTYPE_WDS);
+ /*
+ * The bss_info_changed() callback function is not
+ * allowed to sleep in mesh mode. As a result, we
+ * can't support Mesh mode for the USB drivers.
+ */
+ if (!rt2x00_is_usb(rt2x00dev))
+ rt2x00dev->hw->wiphy->interface_modes |=
+ BIT(NL80211_IFTYPE_MESH_POINT);
+ }
+
/*
* Let the driver probe the device to detect the capabilities.
*/
--
1.6.6.1
^ permalink raw reply related
* [PATCH 1/2] compat: backport dma_set_coherent_mask
From: Hauke Mehrtens @ 2010-06-13 19:56 UTC (permalink / raw)
To: lrodriguez; +Cc: linux-wireless, mcgrof, Hauke Mehrtens
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
include/linux/compat-2.6.34.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/compat-2.6.34.h b/include/linux/compat-2.6.34.h
index b1c15a7..336c61b 100644
--- a/include/linux/compat-2.6.34.h
+++ b/include/linux/compat-2.6.34.h
@@ -216,6 +216,14 @@ do { \
#define dma_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0)
#endif
+static inline int dma_set_coherent_mask(struct device *dev, u64 mask)
+{
+ if (!dma_supported(dev, mask))
+ return -EIO;
+ dev->coherent_dma_mask = mask;
+ return 0;
+}
+
#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,34)) */
#endif /* LINUX_26_34_COMPAT_H */
--
1.7.0.4
^ permalink raw reply related
* [PATCH 2/2] compat: backport sdio_writeb_readb
From: Hauke Mehrtens @ 2010-06-13 19:56 UTC (permalink / raw)
To: lrodriguez; +Cc: linux-wireless, mcgrof, Hauke Mehrtens
In-Reply-To: <1276459009-17168-1-git-send-email-hauke@hauke-m.de>
This is needed by wl1251_sdio.c
Use sdio_readb instead of sdio_writeb_readb as long as sdio_writeb_readb was not realy backported.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
include/linux/compat-2.6.35.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/compat-2.6.35.h b/include/linux/compat-2.6.35.h
index 886815d..c6e7136 100644
--- a/include/linux/compat-2.6.35.h
+++ b/include/linux/compat-2.6.35.h
@@ -23,6 +23,8 @@ static inline wait_queue_head_t *sk_sleep(struct sock *sk)
return sk->sk_sleep;
}
+#define sdio_writeb_readb(func, write_byte, addr, err_ret) sdio_readb(func, addr, err_ret)
+
#endif /* (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,35)) */
#endif /* LINUX_26_35_COMPAT_H */
--
1.7.0.4
^ permalink raw reply related
* Re: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 19
From: Luis R. Rodriguez @ 2010-06-13 20:16 UTC (permalink / raw)
To: sundar mahadevan; +Cc: linux-wireless, John W. Linville
In-Reply-To: <AANLkTincbrPV9DTY0qIM1iBZ6byvsSV1t84OVoFNZ2Bq@mail.gmail.com>
On Sun, Jun 13, 2010 at 10:08 AM, sundar mahadevan
<sundarmahadevan82@gmail.com> wrote:
> Hi All,
> Greetings. I am on Oracle Enterprise Linux (OEL 5.5 x86_64) same as
> Redhat 5.5. I must use OEL5.5 because of my software installation
> requirements. NetworkManager detects my ssid but its just not getting
> ip from my router assigned. I use a Belkin 54g router with WPA/WPA2
> encryption. The other options available on my router are WPA2 only,
> WEP and Disabled. I have spent more than 20 hours trying to get wifi
> working but no luck. Your help is highly appreciated.
>
> [root@localhost ~]$uname -a
> Linux localhost.localdomain 2.6.18-194.el5 #1 SMP Mon Mar 29 22:10:29
> EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
>
> [root@localhost /etc/wpa_supplicant]$lspci | grep -i ath
> 04:00.0 Network controller: Atheros Communications Inc. AR928X
> Wireless Network Adapter (PCI-Express) (rev 01)
Please see:
http://wireless.kernel.org/en/users/Drivers/ath9k/RHEL5#Known_issues
Seems like the same issue.
Luis
^ permalink raw reply
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
From: Luis R. Rodriguez @ 2010-06-13 20:23 UTC (permalink / raw)
To: Kouhei Sutou, Stephen Chen, David Quan; +Cc: linux-wireless, Michael Green
In-Reply-To: <20100613.145200.1459063883179763823.kou@clear-code.com>
Note: this e-mail is on a public mailing list!
On Sat, Jun 12, 2010 at 10:52 PM, Kouhei Sutou <kou@clear-code.com> wrote:
> Hi,
>
> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
> the attached patch. Could you consider to merge the attached
> patch?
>
> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
> a regulatory domain reported by GW-US54GXS (0x49).
>
> Solutions:
>
> (1) add a new regulatory domain (0x49). Here is a patch to
> use the approach:
Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
Here is our list so far:
#define ZD_REGDOMAIN_FCC 0x10
#define ZD_REGDOMAIN_IC 0x20
#define ZD_REGDOMAIN_ETSI 0x30
#define ZD_REGDOMAIN_SPAIN 0x31
#define ZD_REGDOMAIN_FRANCE 0x32
#define ZD_REGDOMAIN_JAPAN_ADD 0x40
#define ZD_REGDOMAIN_JAPAN 0x41
This is what they map to:
static struct zd_reg_alpha2_map reg_alpha2_map[] = {
{ ZD_REGDOMAIN_FCC, "US" },
{ ZD_REGDOMAIN_IC, "CA" },
{ ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
{ ZD_REGDOMAIN_JAPAN, "JP" },
{ ZD_REGDOMAIN_JAPAN_ADD, "JP" },
{ ZD_REGDOMAIN_SPAIN, "ES" },
{ ZD_REGDOMAIN_FRANCE, "FR" },
};
Kouhei, if no regulatory domain is found, instead we should world
roam, we cannot allow letting the user change regulatory domains at
their whim. We can, however let them choose one to help compliance,
but you can only help compliance once you know your actual regulatory
domain.
Luis
^ permalink raw reply
* Re: [PATCH 2/2] compat: backport sdio_writeb_readb
From: Luis R. Rodriguez @ 2010-06-13 20:25 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-wireless, mcgrof
In-Reply-To: <1276459009-17168-2-git-send-email-hauke@hauke-m.de>
On Sun, Jun 13, 2010 at 12:56 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> This is needed by wl1251_sdio.c
> Use sdio_readb instead of sdio_writeb_readb as long as sdio_writeb_readb was not realy backported.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks, applied both!
Luis
^ permalink raw reply
* wireless button problem with atheros on hp machines
From: Leonardo @ 2010-06-13 20:49 UTC (permalink / raw)
To: linux-wireless
hello all, i don't know if this is the correct channel to report, but
from Slackware 13.0 (2.6.29.6) to 13.1 (2.6.33.4) the wireless button
stopped to work properly.
it is happening on 2 different hp machines: hp dv5-1220br (AR5001) and
hp dv4-2140us (AR9285).
basically i can't touch the wireless button, if i do that i will not
be able to recover the net, also the button color will not back to
blue, will remain orange.
also if i touch the button not even restarting the machine or removing
the battery the bluetooth subsystem come back.
on dv5 i have only linux, but on dv4 if i give up and enter on windows
just to restart bluetooth;
as i related before, at least on dv5 one it worked like a charm on older one.
please if anyone can help, tell me what can i do to help to track such
bug (what kind of output to send, maybe a downgrade, etc)
thanks in advance.
^ permalink raw reply
* Re: wireless button problem with atheros on hp machines
From: Luis R. Rodriguez @ 2010-06-13 20:55 UTC (permalink / raw)
To: Leonardo; +Cc: linux-wireless
In-Reply-To: <AANLkTim4kDJZnEdNy-C4xhOigWiTWQZhVJAs36LOUbjQ@mail.gmail.com>
On Sun, Jun 13, 2010 at 1:49 PM, Leonardo <sombriks@gmail.com> wrote:
> hello all, i don't know if this is the correct channel to report, but
> from Slackware 13.0 (2.6.29.6) to 13.1 (2.6.33.4) the wireless button
> stopped to work properly.
Try 2.6.30, 2.6.31, and 2.6.32 and see if you see the issue on one of
those. If so then you can use git bisect to find the culprit. I
realize this can be quite cumbersome, but without more information I'm
afraid this is as good as it gets. Instead of using Linus' tree you'll
want to use the linux-2.6-allstable.git tree since that will have the
extra version kernel revisions.
git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-allstable.git
Luis
^ permalink raw reply
* Re: 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34
From: Luis R. Rodriguez @ 2010-06-13 21:02 UTC (permalink / raw)
To: linux-wireless, linux-bluetooth
Cc: Rafael J. Wysocki, Aeolus Yang, David Quan
In-Reply-To: <g77CuMUl7QI.A.5wF.V5OFMB@chimera>
For your convenience in reading the regression report here's the
802.11 and Bluetooth ones. There's one PCMCIA one which I left in as I
think these patches now go through John (?) The other ones are 1
Bluetooth regression, 1 hostap_pci, 1 iwl3945 and 1 iwlagn regression.
Luis
On Sun, Jun 13, 2010 at 7:45 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> Unresolved regressions
> ----------------------
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16111
> Subject : hostap_pci: infinite registered netdevice wifi0
> Submitter : Petr Pisar <petr.pisar@atlas.cz>
> Date : 2010-06-02 20:55 (12 days old)
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16084
> Subject : iwl3945 bug in 2.6.34
> Submitter : Satish Eerpini <eerpini@gmail.com>
> Date : 2010-05-23 6:37 (22 days old)
> Message-ID : <AANLkTik_7rxDBc0TKlAfoYyM5S6Cf_Hyxbr4W5ORnTsq@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127459596015626&w=2
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15862
> Subject : 2.6.34-rc4/5: iwlagn unusable until reload
> Submitter : Nico Schottelius <nico-linux-20100427@schottelius.org>
> Date : 2010-04-27 7:49 (48 days old)
> Message-ID : <20100427074934.GB3261@ikn.schottelius.org>
> References : http://marc.info/?l=linux-kernel&m=127235784004839&w=2
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15717
> Subject : bluetooth oops
> Submitter : Pavel Machek <pavel@ucw.cz>
> Date : 2010-03-14 20:14 (92 days old)
> Message-ID : <20100314201434.GE22059@elf.ucw.cz>
> References : http://marc.info/?l=linux-kernel&m=126859771528426&w=4
> Handled-By : Marcel Holtmann <marcel@holtmann.org>
> Regressions with patches
> ------------------------
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16138
> Subject : PCMCIA regression
> Submitter : Mikulas Patocka <mpatocka@redhat.com>
> Date : 2010-05-25 20:25 (20 days old)
> Message-ID : <Pine.LNX.4.64.1005251619020.12278@hs20-bc2-1.build.redhat.com>
> References : http://marc.info/?l=linux-kernel&m=127481913909672&w=2
> Handled-By : Dominik Brodowski <linux@brodo.de>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26685
^ permalink raw reply
* Re: [ath5k-devel] [PATCH] ath5k: disable all tasklets while resetting
From: Bruno Randolf @ 2010-06-14 1:50 UTC (permalink / raw)
To: Bob Copeland; +Cc: Johannes Berg, ath5k-devel, linux-wireless, linville
In-Reply-To: <AANLkTik0Q2JM_DNaiLxc33Nn6dpI6uT52uG7b8-F4QjW@mail.gmail.com>
On Friday 11 June 2010 23:38:15 Bob Copeland wrote:
> On Fri, Jun 11, 2010 at 10:21 AM, Bob Copeland <me@bobcopeland.com> wrote:
> > On Fri, Jun 11, 2010 at 6:41 AM, Johannes Berg
> >
> > <johannes@sipsolutions.net> wrote:
> >> I have no idea how long a reset can take, but this means that all these
> >> tasklets will spin while your reset is running if they were scheduled.
> >
> > It looks to me like tasklet_action() will bail out when the tasklet has a
> > positive t->count (which disable elevates) rather than spin. What did I
> > miss?
>
> As Johannes pointed out on irc, I missed that it re-raises the softirq.
> doh!
well, what else can we do? we have to make sure the tasklets don't run
concurrently to a reset to keep rx and tx buffers consistent.
we disable interrupts right after disabling the tasklets, so they should not
be scheduled again, right? actually, we should disable interrupts first, and
then disable tasklets... but then it should be safe, no?
bruno
^ permalink raw reply
* [PATCH]compat: trivial fix for typo in config.mk
From: Richard Farina @ 2010-06-14 4:44 UTC (permalink / raw)
To: linux-wireless, Luis R. Rodriguez
commit e96ac45542ab5f02d2b13981df3a9c34d990afbf
Author: Rick Farina <sidhayn@gmail.com>
Date: Mon Jun 14 00:40:03 2010 -0400
[PATCH]compat: trivial fix for typo in config.mk
In config.mk we find "# CONFIG_RT2X00_LIB_DEBUGFS" which clearly
should have an "=y" at the end like ever other config line.
Signed-off-by: Rick Farina <sidhayn@gmail.com>
diff --git a/config.mk b/config.mk
index 0001a7d..adebbbf 100644
--- a/config.mk
+++ b/config.mk
@@ -453,7 +453,7 @@ CONFIG_RT2X00_LIB_FIRMWARE=y
CONFIG_RT2X00_LIB_CRYPTO=y
CONFIG_RT2X00_LIB_LEDS=y
# CONFIG_RT2X00_DEBUG=y
-# CONFIG_RT2X00_LIB_DEBUGFS
+# CONFIG_RT2X00_LIB_DEBUGFS=y
endif
ifeq ($(NEED_RT2X00_FIRMWARE),y)
^ permalink raw reply related
* [PATCH 0/3] mac80211: Add support for configuring ibss basic rates
From: Teemu Paasikivi @ 2010-06-14 6:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Teemu Paasikivi
This patch set implements support for configuring basic rates for ibss network when joining/creating one. First two patches are basically patch proposed by Johannes Berg on linux-wireless posting list split in two. These implement interface to nl80211 to do actual configuration from user space. Last patch impelents removal of the BSS information from the cfg80211 when leaving the IBSS and there is no other active STA's.
Teemu Paasikivi (3):
mac80211: Set basic rates while joining ibss network
mac80211: Set changed basic rates flag
mac80211: remove BSS from cfg80211 list when leaving IBSS
include/net/cfg80211.h | 2 +
net/mac80211/ibss.c | 38 +++++++++++++++++++++++++++++++++-
net/mac80211/ieee80211_i.h | 2 +
net/wireless/nl80211.c | 49 ++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 90 insertions(+), 1 deletions(-)
^ permalink raw reply
* [PATCH 3/3] mac80211: remove BSS from cfg80211 list when leaving IBSS
From: Teemu Paasikivi @ 2010-06-14 6:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Teemu Paasikivi
In-Reply-To: <1276496145-5623-3-git-send-email-ext-teemu.3.paasikivi@nokia.com>
Remove BSS from cfg80211 BSS list if we are only member in IBSS when
leaving it.
Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
---
net/mac80211/ibss.c | 33 +++++++++++++++++++++++++++++++++
1 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index ff91265..6d5489b 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -969,6 +969,39 @@ int ieee80211_ibss_leave(struct ieee80211_sub_if_data *sdata)
{
struct sk_buff *skb;
+ struct ieee80211_if_ibss *ifibss = &sdata->u.ibss;
+ struct ieee80211_local *local = sdata->local;
+ struct cfg80211_bss *cbss;
+ struct ieee80211_channel *chan = NULL;
+ const u8 *bssid = NULL;
+ u16 capability;
+ int active_ibss = 0;
+
+
+ active_ibss = ieee80211_sta_active_ibss(sdata);
+
+ if (!active_ibss) {
+ capability = WLAN_CAPABILITY_IBSS;
+ if (ifibss->privacy)
+ capability |= WLAN_CAPABILITY_PRIVACY;
+ if (ifibss->fixed_bssid)
+ bssid = ifibss->bssid;
+ if (ifibss->fixed_channel)
+ chan = ifibss->channel;
+ if (!is_zero_ether_addr(ifibss->bssid))
+ bssid = ifibss->bssid;
+ cbss = cfg80211_get_bss(local->hw.wiphy, chan, bssid,
+ ifibss->ssid, ifibss->ssid_len,
+ WLAN_CAPABILITY_IBSS |
+ WLAN_CAPABILITY_PRIVACY,
+ capability);
+
+ if (cbss) {
+ cfg80211_unlink_bss(local->hw.wiphy, cbss);
+ cfg80211_put_bss(cbss);
+ }
+ }
+
del_timer_sync(&sdata->u.ibss.timer);
clear_bit(IEEE80211_IBSS_REQ_RUN, &sdata->u.ibss.request);
cancel_work_sync(&sdata->u.ibss.work);
--
1.5.6.3
^ permalink raw reply related
* [PATCH 2/3] mac80211: Set changed basic rates flag
From: Teemu Paasikivi @ 2010-06-14 6:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Teemu Paasikivi
In-Reply-To: <1276496145-5623-2-git-send-email-ext-teemu.3.paasikivi@nokia.com>
Add changed basic rates flag to bss_changed while joinig ibss network.
This patch is split from the patch containing support for setting basic
rates when creating ibss network. Original patch was posted by Johannes
Berg on the linux-wireless posting list.
Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
---
net/mac80211/ibss.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index 8be5a96..ff91265 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -178,6 +178,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
bss_change |= BSS_CHANGED_BSSID;
bss_change |= BSS_CHANGED_BEACON;
bss_change |= BSS_CHANGED_BEACON_ENABLED;
+ bss_change |= BSS_CHANGED_BASIC_RATES;
bss_change |= BSS_CHANGED_IBSS;
sdata->vif.bss_conf.ibss_joined = true;
ieee80211_bss_info_change_notify(sdata, bss_change);
--
1.5.6.3
^ permalink raw reply related
* [PATCH 1/3] mac80211: Set basic rates while joining ibss network
From: Teemu Paasikivi @ 2010-06-14 6:15 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Teemu Paasikivi
In-Reply-To: <1276496145-5623-1-git-send-email-ext-teemu.3.paasikivi@nokia.com>
This patch adds support to nl80211 and mac80211 to set basic rates when
joining/creating ibss network.
Original patch was posted by Johannes Berg on the linux-wireless posting list.
Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
---
include/net/cfg80211.h | 2 +
net/mac80211/ibss.c | 4 ++-
net/mac80211/ieee80211_i.h | 2 +
net/wireless/nl80211.c | 49 ++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 56 insertions(+), 1 deletions(-)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 22ab9d8..64374f4 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -810,6 +810,7 @@ struct cfg80211_disassoc_request {
* @beacon_interval: beacon interval to use
* @privacy: this is a protected network, keys will be configured
* after joining
+ * @basic_rates: bitmap of basic rates to use when creating the IBSS
*/
struct cfg80211_ibss_params {
u8 *ssid;
@@ -818,6 +819,7 @@ struct cfg80211_ibss_params {
u8 *ie;
u8 ssid_len, ie_len;
u16 beacon_interval;
+ u32 basic_rates;
bool channel_fixed;
bool privacy;
};
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index d7a96ce..8be5a96 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -172,6 +172,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
rcu_assign_pointer(ifibss->presp, skb);
sdata->vif.bss_conf.beacon_int = beacon_int;
+ sdata->vif.bss_conf.basic_rates = basic_rates;
bss_change = BSS_CHANGED_BEACON_INT;
bss_change |= ieee80211_reset_erp_info(sdata);
bss_change |= BSS_CHANGED_BSSID;
@@ -529,7 +530,7 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
sdata->drop_unencrypted = 0;
__ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
- ifibss->channel, 3, /* first two are basic */
+ ifibss->channel, ifibss->basic_rates,
capability, 0);
}
@@ -910,6 +911,7 @@ int ieee80211_ibss_join(struct ieee80211_sub_if_data *sdata,
sdata->u.ibss.fixed_bssid = false;
sdata->u.ibss.privacy = params->privacy;
+ sdata->u.ibss.basic_rates = params->basic_rates;
sdata->vif.bss_conf.beacon_int = params->beacon_interval;
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 4d3883e..fde058b 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -393,6 +393,8 @@ struct ieee80211_if_ibss {
unsigned long request;
unsigned long last_scan_completed;
+ u32 basic_rates;
+
bool timer_running;
bool fixed_bssid;
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 90ab3c8..324b4a5 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -3955,6 +3955,55 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
}
}
+ if (info->attrs[NL80211_ATTR_BSS_BASIC_RATES]) {
+ u8 *rates =
+ nla_data(info->attrs[NL80211_ATTR_BSS_BASIC_RATES]);
+ int n_rates =
+ nla_len(info->attrs[NL80211_ATTR_BSS_BASIC_RATES]);
+ struct ieee80211_supported_band *sband =
+ wiphy->bands[ibss.channel->band];
+ int i, j;
+
+ if (n_rates == 0) {
+ err = -EINVAL;
+ goto out;
+ }
+
+ for (i = 0; i < n_rates; i++) {
+ int rate = (rates[i] & 0x7f) * 5;
+ bool found = false;
+
+ for (j = 0; j < sband->n_bitrates; j++) {
+ if (sband->bitrates[j].bitrate == rate) {
+ found = true;
+ ibss.basic_rates |= BIT(j);
+ break;
+ }
+ }
+ if (!found) {
+ err = -EINVAL;
+ goto out;
+ }
+ }
+ } else {
+ /*
+ * If no rates were explicitly configured,
+ * use the mandatory rate set for 11b or
+ * 11a for maximum compatibility.
+ */
+ struct ieee80211_supported_band *sband =
+ wiphy->bands[ibss.channel->band];
+ int j;
+ u32 flag = ibss.channel->band == IEEE80211_BAND_5GHZ ?
+ IEEE80211_RATE_MANDATORY_A :
+ IEEE80211_RATE_MANDATORY_B;
+
+ for (j = 0; j < sband->n_bitrates; j++) {
+ if (sband->bitrates[j].flags & flag)
+ ibss.basic_rates |= BIT(j);
+ }
+ }
+
err = cfg80211_join_ibss(rdev, dev, &ibss, connkeys);
out:
--
1.5.6.3
^ permalink raw reply related
* Re: [PATCH 1/3] mac80211: Set basic rates while joining ibss network
From: Johannes Berg @ 2010-06-14 6:30 UTC (permalink / raw)
To: Teemu Paasikivi; +Cc: linville, linux-wireless
In-Reply-To: <1276496145-5623-2-git-send-email-ext-teemu.3.paasikivi@nokia.com>
On Mon, 2010-06-14 at 09:15 +0300, Teemu Paasikivi wrote:
> This patch adds support to nl80211 and mac80211 to set basic rates when
> joining/creating ibss network.
>
> Original patch was posted by Johannes Berg on the linux-wireless posting list.
Did you actually change it at all? (Ok I see you did make a bugfix, good
catch)
I personally don't care at all, but I guess generally you should
attribute it to the person who actually did (most of) the work.
In any case, John will need this:
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
> ---
> include/net/cfg80211.h | 2 +
> net/mac80211/ibss.c | 4 ++-
> net/mac80211/ieee80211_i.h | 2 +
> net/wireless/nl80211.c | 49 ++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 56 insertions(+), 1 deletions(-)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 22ab9d8..64374f4 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -810,6 +810,7 @@ struct cfg80211_disassoc_request {
> * @beacon_interval: beacon interval to use
> * @privacy: this is a protected network, keys will be configured
> * after joining
> + * @basic_rates: bitmap of basic rates to use when creating the IBSS
> */
> struct cfg80211_ibss_params {
> u8 *ssid;
> @@ -818,6 +819,7 @@ struct cfg80211_ibss_params {
> u8 *ie;
> u8 ssid_len, ie_len;
> u16 beacon_interval;
> + u32 basic_rates;
> bool channel_fixed;
> bool privacy;
> };
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index d7a96ce..8be5a96 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -172,6 +172,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
> rcu_assign_pointer(ifibss->presp, skb);
>
> sdata->vif.bss_conf.beacon_int = beacon_int;
> + sdata->vif.bss_conf.basic_rates = basic_rates;
> bss_change = BSS_CHANGED_BEACON_INT;
> bss_change |= ieee80211_reset_erp_info(sdata);
> bss_change |= BSS_CHANGED_BSSID;
> @@ -529,7 +530,7 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
> sdata->drop_unencrypted = 0;
>
> __ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
> - ifibss->channel, 3, /* first two are basic */
> + ifibss->channel, ifibss->basic_rates,
> capability, 0);
> }
>
> @@ -910,6 +911,7 @@ int ieee80211_ibss_join(struct ieee80211_sub_if_data *sdata,
> sdata->u.ibss.fixed_bssid = false;
>
> sdata->u.ibss.privacy = params->privacy;
> + sdata->u.ibss.basic_rates = params->basic_rates;
>
> sdata->vif.bss_conf.beacon_int = params->beacon_interval;
>
> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> index 4d3883e..fde058b 100644
> --- a/net/mac80211/ieee80211_i.h
> +++ b/net/mac80211/ieee80211_i.h
> @@ -393,6 +393,8 @@ struct ieee80211_if_ibss {
> unsigned long request;
> unsigned long last_scan_completed;
>
> + u32 basic_rates;
> +
> bool timer_running;
>
> bool fixed_bssid;
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 90ab3c8..324b4a5 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -3955,6 +3955,55 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
> }
> }
>
> + if (info->attrs[NL80211_ATTR_BSS_BASIC_RATES]) {
> + u8 *rates =
> + nla_data(info->attrs[NL80211_ATTR_BSS_BASIC_RATES]);
> + int n_rates =
> + nla_len(info->attrs[NL80211_ATTR_BSS_BASIC_RATES]);
> + struct ieee80211_supported_band *sband =
> + wiphy->bands[ibss.channel->band];
> + int i, j;
> +
> + if (n_rates == 0) {
> + err = -EINVAL;
> + goto out;
> + }
> +
> + for (i = 0; i < n_rates; i++) {
> + int rate = (rates[i] & 0x7f) * 5;
> + bool found = false;
> +
> + for (j = 0; j < sband->n_bitrates; j++) {
> + if (sband->bitrates[j].bitrate == rate) {
> + found = true;
> + ibss.basic_rates |= BIT(j);
> + break;
> + }
> + }
> + if (!found) {
> + err = -EINVAL;
> + goto out;
> + }
> + }
> + } else {
> + /*
> + * If no rates were explicitly configured,
> + * use the mandatory rate set for 11b or
> + * 11a for maximum compatibility.
> + */
> + struct ieee80211_supported_band *sband =
> + wiphy->bands[ibss.channel->band];
> + int j;
> + u32 flag = ibss.channel->band == IEEE80211_BAND_5GHZ ?
> + IEEE80211_RATE_MANDATORY_A :
> + IEEE80211_RATE_MANDATORY_B;
> +
> + for (j = 0; j < sband->n_bitrates; j++) {
> + if (sband->bitrates[j].flags & flag)
> + ibss.basic_rates |= BIT(j);
> + }
> + }
> +
> err = cfg80211_join_ibss(rdev, dev, &ibss, connkeys);
>
> out:
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH 2/3] mac80211: Set changed basic rates flag
From: Johannes Berg @ 2010-06-14 6:30 UTC (permalink / raw)
To: Teemu Paasikivi; +Cc: linville, linux-wireless
In-Reply-To: <1276496145-5623-3-git-send-email-ext-teemu.3.paasikivi@nokia.com>
On Mon, 2010-06-14 at 09:15 +0300, Teemu Paasikivi wrote:
> Add changed basic rates flag to bss_changed while joinig ibss network.
>
> This patch is split from the patch containing support for setting basic
> rates when creating ibss network. Original patch was posted by Johannes
> Berg on the linux-wireless posting list.
>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
> ---
> net/mac80211/ibss.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index 8be5a96..ff91265 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -178,6 +178,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
> bss_change |= BSS_CHANGED_BSSID;
> bss_change |= BSS_CHANGED_BEACON;
> bss_change |= BSS_CHANGED_BEACON_ENABLED;
> + bss_change |= BSS_CHANGED_BASIC_RATES;
> bss_change |= BSS_CHANGED_IBSS;
> sdata->vif.bss_conf.ibss_joined = true;
> ieee80211_bss_info_change_notify(sdata, bss_change);
^ permalink raw reply
* Re: [PATCH 3/3] mac80211: remove BSS from cfg80211 list when leaving IBSS
From: Johannes Berg @ 2010-06-14 6:33 UTC (permalink / raw)
To: Teemu Paasikivi; +Cc: linville, linux-wireless
In-Reply-To: <1276496145-5623-4-git-send-email-ext-teemu.3.paasikivi@nokia.com>
On Mon, 2010-06-14 at 09:15 +0300, Teemu Paasikivi wrote:
> Remove BSS from cfg80211 BSS list if we are only member in IBSS when
> leaving it.
>
> Signed-off-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
> ---
> net/mac80211/ibss.c | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index ff91265..6d5489b 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -969,6 +969,39 @@ int ieee80211_ibss_leave(struct ieee80211_sub_if_data *sdata)
> {
> struct sk_buff *skb;
>
> + struct ieee80211_if_ibss *ifibss = &sdata->u.ibss;
remove that empty live please
> + struct ieee80211_local *local = sdata->local;
> + struct cfg80211_bss *cbss;
> + struct ieee80211_channel *chan = NULL;
> + const u8 *bssid = NULL;
> + u16 capability;
> + int active_ibss = 0;
> +
> +
> + active_ibss = ieee80211_sta_active_ibss(sdata);
> +
> + if (!active_ibss) {
> + capability = WLAN_CAPABILITY_IBSS;
> + if (ifibss->privacy)
> + capability |= WLAN_CAPABILITY_PRIVACY;
> + if (ifibss->fixed_bssid)
> + bssid = ifibss->bssid;
Don't we update ifibss->bssid even if it's not fixed?
> + if (ifibss->fixed_channel)
> + chan = ifibss->channel;
> + if (!is_zero_ether_addr(ifibss->bssid))
> + bssid = ifibss->bssid;
I guess we do, but can it really ever be zeroed? Or does that happen
when we haven't even joined yet? But in that case you'd pass a NULL
bssid into get_bss() which would return a random one ... shouldn't you
rather not do anything in that case? Like making the first condition
if (!active_ibss && !is_zero_ether_addr(ifibss->bssid)) {
and then never worry about the bssid again?
johannes
^ permalink raw reply
* Re: [PATCH 1/3] mac80211: Set basic rates while joining ibss network
From: Teemu Paasikivi @ 2010-06-14 6:48 UTC (permalink / raw)
To: ext Johannes Berg; +Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
In-Reply-To: <1276497001.3926.4.camel@jlt3.sipsolutions.net>
Hi,
On Mon, 2010-06-14 at 08:30 +0200, ext Johannes Berg wrote:
> On Mon, 2010-06-14 at 09:15 +0300, Teemu Paasikivi wrote:
> > This patch adds support to nl80211 and mac80211 to set basic rates when
> > joining/creating ibss network.
> >
> > Original patch was posted by Johannes Berg on the linux-wireless posting list.
>
> Did you actually change it at all? (Ok I see you did make a bugfix, good
> catch)
>
You're right, I only made that bugfix.
> I personally don't care at all, but I guess generally you should
> attribute it to the person who actually did (most of) the work.
>
> In any case, John will need this:
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
I'm very sorry about forgetting that. I'll send new versions of patches
with appropriate Signed-off-by's.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
Teemu
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox