* [PATCH 04/15] mmc: support embedded data field in mmc_host
From: Ohad Ben-Cohen @ 2010-07-06 0:37 UTC (permalink / raw)
To: linux-wireless, linux-mmc, linux-omap
Cc: linux-arm-kernel, linux, Chikkature Rajashekar Madhusudhan,
Luciano Coelho, akpm, San Mehat, Ohad Ben-Cohen
In-Reply-To: <1278376666-3509-1-git-send-email-ohad@wizery.com>
From: Ohad Ben-Cohen <ohadb@ti.com>
Add support to set/get mmc_host private embedded
data.
This is needed to allow software to dynamically
create (and remove) SDIO functions which represents
embedded SDIO devices.
Typically, it will be used to set the context of
a driver that is creating a new SDIO function
(and would then expect to be able to get that context
back upon creation of the new sdio func).
Signed-off-by: Ohad Ben-Cohen <ohadb@ti.com>
---
drivers/mmc/core/Kconfig | 8 ++++++++
include/linux/mmc/host.h | 16 ++++++++++++++++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
index bb22ffd..ab27eb3 100644
--- a/drivers/mmc/core/Kconfig
+++ b/drivers/mmc/core/Kconfig
@@ -16,3 +16,11 @@ config MMC_UNSAFE_RESUME
This option sets a default which can be overridden by the
module parameter "removable=0" or "removable=1".
+
+config MMC_EMBEDDED_SDIO
+ boolean "MMC embedded SDIO device support"
+ help
+ If you say Y here, support will be added for embedded SDIO
+ devices (e.g. hardwired embedded WLAN SDIO devices).
+ Such devices require software support for emulating
+ card detect events.
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index f65913c..9a48486 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -209,6 +209,10 @@ struct mmc_host {
struct led_trigger *led; /* activity led */
#endif
+#ifdef CONFIG_MMC_EMBEDDED_SDIO
+ void *embedded_data;
+#endif
+
struct dentry *debugfs_root;
unsigned long private[0] ____cacheline_aligned;
@@ -264,5 +268,17 @@ static inline void mmc_set_disable_delay(struct mmc_host *host,
host->disable_delay = disable_delay;
}
+#ifdef CONFIG_MMC_EMBEDDED_SDIO
+static inline void *mmc_get_embedded_data(struct mmc_host *host)
+{
+ return host->embedded_data;
+}
+
+static inline void mmc_set_embedded_data(struct mmc_host *host, void *data)
+{
+ host->embedded_data = data;
+}
+#endif
+
#endif
--
1.7.0.4
^ permalink raw reply related
* [PATCH 03/15] omap: mmc: prepare for software card detect support
From: Ohad Ben-Cohen @ 2010-07-06 0:37 UTC (permalink / raw)
To: linux-wireless, linux-mmc, linux-omap
Cc: linux-arm-kernel, linux, Chikkature Rajashekar Madhusudhan,
Luciano Coelho, akpm, San Mehat, Ohad Ben-Cohen
In-Reply-To: <1278376666-3509-1-git-send-email-ohad@wizery.com>
From: Ohad Ben-Cohen <ohadb@ti.com>
Make it possible for board files to give the
host controller two handlers needed for emulating
card detect events in software:
* The virtual_get_cd handler will allow the host
controller to query the status of the software
card detect (for the given controller/slot).
* The register_embedded_control will allow the host
controller to register handlers that will be used by
board devices to:
1. trigger a software card detect event
2. set private data (e.g. device context) that can later
be used by an sdio function driver
Signed-off-by: Ohad Ben-Cohen <ohadb@ti.com>
---
arch/arm/mach-omap2/hsmmc.c | 4 ++++
arch/arm/mach-omap2/hsmmc.h | 5 +++++
arch/arm/plat-omap/include/plat/mmc.h | 5 +++++
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
index 1ef54b0..1361128 100644
--- a/arch/arm/mach-omap2/hsmmc.c
+++ b/arch/arm/mach-omap2/hsmmc.c
@@ -269,6 +269,10 @@ void __init omap2_hsmmc_init(struct omap2_hsmmc_info *controllers)
mmc->slots[0].remux = c->remux;
+ mmc->slots[0].register_embedded_control =
+ c->register_embedded_control;
+ mmc->slots[0].virtual_get_cd = c->virtual_get_cd;
+
if (c->cover_only)
mmc->slots[0].cover = 1;
diff --git a/arch/arm/mach-omap2/hsmmc.h b/arch/arm/mach-omap2/hsmmc.h
index 36f0ba8..dc12c90 100644
--- a/arch/arm/mach-omap2/hsmmc.h
+++ b/arch/arm/mach-omap2/hsmmc.h
@@ -23,6 +23,11 @@ struct omap2_hsmmc_info {
int ocr_mask; /* temporary HACK */
/* Remux (pad configuation) when powering on/off */
void (*remux)(struct device *dev, int slot, int power_on);
+ /* following methods are for embedded sdio devices, e.g. wl1271 */
+ int (*register_embedded_control)(void *dev_id,
+ void (*set_virtual_cd)(void *dev_id, int card_present),
+ void (*set_embedded_data)(void *dev_id, void *priv));
+ int (*virtual_get_cd)(void);
};
#if defined(CONFIG_MMC_OMAP_HS) || defined(CONFIG_MMC_OMAP_HS_MODULE)
diff --git a/arch/arm/plat-omap/include/plat/mmc.h b/arch/arm/plat-omap/include/plat/mmc.h
index c835f1e..0f5bf12 100644
--- a/arch/arm/plat-omap/include/plat/mmc.h
+++ b/arch/arm/plat-omap/include/plat/mmc.h
@@ -140,6 +140,11 @@ struct omap_mmc_platform_data {
unsigned int ban_openended:1;
+ /* Embedded SDIO devices control */
+ int (*register_embedded_control)(void *dev_id,
+ void (*set_virtual_cd)(void *dev_id, int card_present),
+ void (*set_embedded_data)(void *dev_id, void *priv));
+ int (*virtual_get_cd)(void);
} slots[OMAP_MMC_MAX_SLOTS];
};
--
1.7.0.4
^ permalink raw reply related
* [PATCH 02/15] wireless: wl1271: remove SDIO IDs from driver
From: Ohad Ben-Cohen @ 2010-07-06 0:37 UTC (permalink / raw)
To: linux-wireless, linux-mmc, linux-omap
Cc: linux-arm-kernel, linux, Chikkature Rajashekar Madhusudhan,
Luciano Coelho, akpm, San Mehat, Ohad Ben-Cohen
In-Reply-To: <1278376666-3509-1-git-send-email-ohad@wizery.com>
From: Ohad Ben-Cohen <ohadb@ti.com>
Remove SDIO IDs from the driver code since now it is
included in linux/mmc/sdio_ids.h.
Signed-off-by: Ohad Ben-Cohen <ohadb@ti.com>
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_sdio.c b/drivers/net/wireless/wl12xx/wl1271_sdio.c
index d3d6f30..9903ae9 100644
--- a/drivers/net/wireless/wl12xx/wl1271_sdio.c
+++ b/drivers/net/wireless/wl12xx/wl1271_sdio.c
@@ -37,14 +37,6 @@
#define RX71_WL1271_IRQ_GPIO 42
-#ifndef SDIO_VENDOR_ID_TI
-#define SDIO_VENDOR_ID_TI 0x0097
-#endif
-
-#ifndef SDIO_DEVICE_ID_TI_WL1271
-#define SDIO_DEVICE_ID_TI_WL1271 0x4076
-#endif
-
static const struct sdio_device_id wl1271_devices[] = {
{ SDIO_DEVICE(SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271) },
{}
--
1.7.0.4
^ permalink raw reply related
* [PATCH 01/15] sdio: add TI + wl1271 ids
From: Ohad Ben-Cohen @ 2010-07-06 0:37 UTC (permalink / raw)
To: linux-wireless, linux-mmc, linux-omap
Cc: linux-arm-kernel, linux, Chikkature Rajashekar Madhusudhan,
Luciano Coelho, akpm, San Mehat, Ohad Ben-Cohen
In-Reply-To: <1278376666-3509-1-git-send-email-ohad@wizery.com>
From: Ohad Ben-Cohen <ohadb@ti.com>
Add SDIO IDs for TI and for TI's wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen <ohadb@ti.com>
---
include/linux/mmc/sdio_ids.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index 33b2ea0..0d313c6 100644
--- a/include/linux/mmc/sdio_ids.h
+++ b/include/linux/mmc/sdio_ids.h
@@ -43,4 +43,7 @@
#define SDIO_DEVICE_ID_SIANO_NOVA_A0 0x1100
#define SDIO_DEVICE_ID_SIANO_STELLAR 0x5347
+#define SDIO_VENDOR_ID_TI 0x0097
+#define SDIO_DEVICE_ID_TI_WL1271 0x4076
+
#endif
--
1.7.0.4
^ permalink raw reply related
* [PATCH 00/15] wlan+omap+mmc: out-of-the-box WLAN support for ZOOM2/3
From: Ohad Ben-Cohen @ 2010-07-06 0:37 UTC (permalink / raw)
To: linux-wireless, linux-mmc, linux-omap
Cc: linux-arm-kernel, linux, Chikkature Rajashekar Madhusudhan,
Luciano Coelho, akpm, San Mehat, Ohad Ben-Cohen
From: Ohad Ben-Cohen <ohadb@ti.com>
The ZOOM2/3 boards include TI's wl1271 wlan sdio device,
hardwired to the 3rd mmc controller.
These patches add support for WLAN on the ZOOM2/3 boards
using only mainline components (most notably mac80211 and wl1271).
Patches were tested on both ZOOM2 and ZOOM3.
In short, these patches add software control for emulating
card detect events, add board configurations to support the
wl1271 device, and update the wl1271 driver to make use of
these new mechanisms.
Software card detect emulation is based on Android's
EMBEDDED_SDIO patch by San Mehat <san@google.com> (thanks, San!).
These patches span over several differnt subsystems, but since
they are highly dependent on each other, it is preferrable
to pull them all together into a single tree (once approved).
Patches are available at:
git://wizery.com/pub/linux-2.6.git wl1271
And will also be sent as a follow-on to this message to the
omap, mmc, arm and wireless mailing lists.
Patches are based on mainline 2.6.35-rc4, but can easily be applied
on wireless-testing (with two minor conflicts). If desired, I can
rebase to wireless-testing and resend.
Note: last missing part for full mainline community support
of the wl1271 on ZOOM is the firmware, and for that there is already
on-going TI work to provide it in linux-firmware. Hopefully
that would be resolved soon.
Thanks,
Ohad Ben-Cohen (15):
sdio: add TI + wl1271 ids
wireless: wl1271: remove SDIO IDs from driver
omap: mmc: prepare for software card detect support
mmc: support embedded data field in mmc_host
omap: hsmmc: add virtual card detect support
omap zoom2: wlan board muxing
omap zoom3: wlan board muxing
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl12xx: support pdata SDIO handlers
wireless: wl1271: support return value for the set power func
wireless: wl1271: introduce platform device support
wireless: wl1271: take irq info from platform data
wireless: wl1271: make ref_clock configurable by board
omap: zoom: add WLAN device
omap: zoom: enable WLAN device
arch/arm/mach-omap2/Kconfig | 5 +
arch/arm/mach-omap2/Makefile | 1 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 15 ++
arch/arm/mach-omap2/board-zoom-wlan.c | 129 ++++++++++++++++
arch/arm/mach-omap2/board-zoom2.c | 15 ++
arch/arm/mach-omap2/board-zoom3.c | 15 ++
arch/arm/mach-omap2/hsmmc.c | 4 +
arch/arm/mach-omap2/hsmmc.h | 5 +
arch/arm/mach-omap2/include/mach/board-zoom.h | 5 +
arch/arm/plat-omap/include/plat/mmc.h | 5 +
drivers/mmc/core/Kconfig | 8 +
drivers/mmc/host/omap_hsmmc.c | 37 +++++-
drivers/net/wireless/wl12xx/Kconfig | 1 +
drivers/net/wireless/wl12xx/wl1251_sdio.c | 2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c | 2 +-
drivers/net/wireless/wl12xx/wl1271.h | 8 +-
drivers/net/wireless/wl12xx/wl1271_boot.c | 13 +-
drivers/net/wireless/wl12xx/wl1271_boot.h | 1 -
drivers/net/wireless/wl12xx/wl1271_io.h | 8 +-
drivers/net/wireless/wl12xx/wl1271_main.c | 4 +-
drivers/net/wireless/wl12xx/wl1271_sdio.c | 204 +++++++++++++++++++------
drivers/net/wireless/wl12xx/wl1271_spi.c | 8 +-
include/linux/mmc/host.h | 16 ++
include/linux/mmc/sdio_ids.h | 3 +
include/linux/spi/wl12xx.h | 34 ----
include/linux/wl12xx.h | 37 +++++
26 files changed, 486 insertions(+), 99 deletions(-)
create mode 100644 arch/arm/mach-omap2/board-zoom-wlan.c
delete mode 100644 include/linux/spi/wl12xx.h
create mode 100644 include/linux/wl12xx.h
^ permalink raw reply
* [ath9k] ath9k: Expose virtual wiphy indexes to debugfs.
From: greearb @ 2010-07-05 19:52 UTC (permalink / raw)
To: linux-wireless; +Cc: Ben Greear
From: Ben Greear <greearb@candelatech.com>
It is very difficult to map phyX devices to real/virtual
entities because the phyX devices change on module
reload. This patch makes it slightly easier to
associate virtual phy devices with phyX entities.
# echo add=5 > /debug/ath9k/phy0/wiphy
# cat /debug/ath9k/phy0/wiphy
primary: phy0 (ACTIVE chan=0 ht=0)
secondary[5]: phy1 (ACTIVE chan=0 ht=0)
addr: ef:be:ad:de:ef:be
addrmask: ef:be:ad:de:ef:be
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 6e486a5... a58ff60... M drivers/net/wireless/ath/ath9k/ath9k.h
:100644 100644 54aae93... f63423c... M drivers/net/wireless/ath/ath9k/debug.c
:100644 100644 89423ca... 03fd64d... M drivers/net/wireless/ath/ath9k/virtual.c
drivers/net/wireless/ath/ath9k/ath9k.h | 2 +-
drivers/net/wireless/ath/ath9k/debug.c | 12 ++++++++----
drivers/net/wireless/ath/ath9k/virtual.c | 26 ++++++++++++++++++++------
3 files changed, 29 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 6e486a5..a58ff60 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -670,7 +670,7 @@ void ath9k_ps_wakeup(struct ath_softc *sc);
void ath9k_ps_restore(struct ath_softc *sc);
void ath9k_set_bssid_mask(struct ieee80211_hw *hw);
-int ath9k_wiphy_add(struct ath_softc *sc);
+int ath9k_wiphy_add(struct ath_softc *sc, const char* id);
int ath9k_wiphy_del(struct ath_wiphy *aphy);
void ath9k_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb);
int ath9k_wiphy_pause(struct ath_wiphy *aphy);
diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 54aae93..f63423c 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -503,8 +503,8 @@ static ssize_t read_file_wiphy(struct file *file, char __user *user_buf,
if (aphy == NULL)
continue;
len += snprintf(buf + len, sizeof(buf) - len,
- "secondary: %s (%s chan=%d ht=%d)\n",
- wiphy_name(aphy->hw->wiphy),
+ "secondary[%i]: %s (%s chan=%d ht=%d)\n",
+ i, wiphy_name(aphy->hw->wiphy),
ath_wiphy_state_str(aphy->state),
aphy->chan_idx, aphy->chan_is_ht);
}
@@ -589,8 +589,12 @@ static ssize_t write_file_wiphy(struct file *file, const char __user *user_buf,
if (len > 0 && buf[len - 1] == '\n')
buf[len - 1] = '\0';
- if (strncmp(buf, "add", 3) == 0) {
- int res = ath9k_wiphy_add(sc);
+ if (strncmp(buf, "add=", 4) == 0) {
+ int res = ath9k_wiphy_add(sc, buf + 4);
+ if (res < 0)
+ return res;
+ } else if (strncmp(buf, "add", 3) == 0) {
+ int res = ath9k_wiphy_add(sc, NULL);
if (res < 0)
return res;
} else if (strncmp(buf, "del=", 4) == 0) {
diff --git a/drivers/net/wireless/ath/ath9k/virtual.c b/drivers/net/wireless/ath/ath9k/virtual.c
index 89423ca..03fd64d 100644
--- a/drivers/net/wireless/ath/ath9k/virtual.c
+++ b/drivers/net/wireless/ath/ath9k/virtual.c
@@ -99,9 +99,10 @@ void ath9k_set_bssid_mask(struct ieee80211_hw *hw)
ath_hw_setbssidmask(common);
}
-int ath9k_wiphy_add(struct ath_softc *sc)
+int ath9k_wiphy_add(struct ath_softc *sc, const char* id)
{
int i, error;
+ int nid = 0;
struct ath_wiphy *aphy;
struct ath_common *common = ath9k_hw_common(sc->sc_ah);
struct ieee80211_hw *hw;
@@ -112,16 +113,26 @@ int ath9k_wiphy_add(struct ath_softc *sc)
return -ENOMEM;
spin_lock_bh(&sc->wiphy_lock);
- for (i = 0; i < sc->num_sec_wiphy; i++) {
+ if (id && id[0]) {
+ nid = simple_strtoul(id, NULL, 0);
+ if (nid < 0 || nid > 10000) { /* 10,000 should be plenty! */
+ printk("ath9k: id out of range in wiphy_add:"
+ " %i, ignoring.", nid);
+ nid = 0;
+ }
+ }
+
+ for (i = nid; i < sc->num_sec_wiphy; i++) {
if (sc->sec_wiphy[i] == NULL)
break;
}
- if (i == sc->num_sec_wiphy) {
+ if (i >= sc->num_sec_wiphy) {
/* No empty slot available; increase array length */
struct ath_wiphy **n;
+ int q;
n = krealloc(sc->sec_wiphy,
- (sc->num_sec_wiphy + 1) *
+ (i + 1) *
sizeof(struct ath_wiphy *),
GFP_ATOMIC);
if (n == NULL) {
@@ -129,9 +140,12 @@ int ath9k_wiphy_add(struct ath_softc *sc)
ieee80211_free_hw(hw);
return -ENOMEM;
}
- n[i] = NULL;
+ // Null out any new memory allocated.
+ for (q = sc->num_sec_wiphy; q <= i; q++) {
+ n[q] = NULL;
+ }
sc->sec_wiphy = n;
- sc->num_sec_wiphy++;
+ sc->num_sec_wiphy = i+1;
}
SET_IEEE80211_DEV(hw, sc->dev);
--
1.7.0.1
^ permalink raw reply related
* Compat-wireless release for 2010-07-05 is baked
From: Compat-wireless cronjob account @ 2010-07-05 19:03 UTC (permalink / raw)
To: linux-wireless
>From git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next
c48fe0c..39a2e97 history -> origin/history
+ 4985a03...2880928 master -> origin/master (forced update)
9fbd7f9..123f94f stable -> origin/stable
* [new tag] next-20100705 -> next-20100705
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
cat: compat_base_tree: No such file or directory
cat: compat_base_tree_version: No such file or directory
cat: compat_version: No such file or directory
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
scripts/Makefile.clean:17: /var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile: No such file or directory
make[4]: *** No rule to make target `/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile'. Stop.
make[3]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap] Error 2
make[2]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless] Error 2
make[1]: *** [_clean_/var/opt/compat/compat-wireless-2.6] Error 2
make: *** [clean] Error 2
/usr/bin/sha1sum: *.tar.bz2: No such file or directory
compat-wireless code metrics
494471 - Total upstream lines of code being pulled
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Ben Greear @ 2010-07-05 18:57 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: Vasanth Thiagarajan, linux-wireless@vger.kernel.org
In-Reply-To: <4C30AFD0.80100@candelatech.com>
I ran the same test on wireless-testing, and it still crashes.
It appears that the patch you sent is already in wireless-testing,
so I did not apply it.
[root@atom ~]# uname -a
Linux atom 2.6.35-rc3-wl+ #1 SMP Mon Jul 5 11:36:08 PDT 2010 i686 i686 i386 GNU/Linux
[root@atom ~]# echo add > /debug/ath9k/phy0/wiphy
Jul 5 11:54:59 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
[root@atom ~]# rmmod ath9k
BUG: unable to handle kernel NULL pointer dereference at 000000a4
IP: [<f8d455d6>] ath9k_hw_intrpend+0x6/0x49 [ath9k_hw]
*pde = 00000000
Oops: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:05:00.0/net/wlan1/flags
Modules linked in: xt_CT iptable_raw ipt_addrtype xt_DSCP xt_dscp xt_string xt_owner xt_NFQUEUE xt_mul]
Pid: 5817, comm: rmmod Not tainted 2.6.35-rc3-wl+ #1 To be filled by O.E.M./To Be Filled By O.E.M.
EIP: 0060:[<f8d455d6>] EFLAGS: 00010046 CPU: 0
EIP is at ath9k_hw_intrpend+0x6/0x49 [ath9k_hw]
EAX: 00000000 EBX: 00000000 ECX: c08de3bc EDX: f705ec78
ESI: f705ec78 EDI: 00000010 EBP: f4563e70 ESP: f4563e6c
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process rmmod (pid: 5817, ti=f4562000 task=f4504550 task.ti=f4562000)
Stack:
00000000 f4563e88 f8de3cb4 00000010 f6aab6c0 00000282 00000010 f4563ea8
<0> c046d228 f705ec78 00000282 c08de3bc 00000010 c08de380 f705ec78 f4563ebc
<0> c046d28f f705ec78 f7113000 f8f00000 f4563ed0 f8dea27f f7113000 f8def9a8
Call Trace:
[<f8de3cb4>] ? ath_isr+0x25/0x189 [ath9k]
[<c046d228>] ? __free_irq+0x11e/0x15e
[<c046d28f>] ? free_irq+0x27/0x3a
[<f8dea27f>] ? ath_pci_remove+0x2f/0x54 [ath9k]
[<c05816da>] ? pci_device_remove+0x19/0x39
[<c06036d6>] ? __device_release_driver+0x59/0x9d
[<c0603781>] ? driver_detach+0x67/0x85
[<c0602c9d>] ? bus_remove_driver+0x69/0x85
[<c0603b92>] ? driver_unregister+0x4b/0x52
[<c05818a9>] ? pci_unregister_driver+0x2d/0x6e
[<f8dea171>] ? ath_pci_exit+0xd/0xf [ath9k]
[<f8dec664>] ? ath9k_exit+0x8/0x2f [ath9k]
[<c0455232>] ? sys_delete_module+0x16f/0x1c0
[<c07458dc>] ? do_page_fault+0x26a/0x2c5
[<c074590a>] ? do_page_fault+0x298/0x2c5
[<c0402fdc>] ? sysenter_do_call+0x12/0x28
Code: 80 4b 06 10 31 c9 83 c4 68 89 c8 5b 5e 5f 5d c3 55 b9 0c 00 00 00 89 e5 53 8b 98 94 00 00 00 ff
EIP: [<f8d455d6>] ath9k_hw_intrpend+0x6/0x49 [ath9k_hw] SS:ESP 0068:f4563e6c
CR2: 00000000000000a4
---[ end trace 43bc6f57caff1689 ]---
Killed
Jul 5 1
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: wl1271 firmware
From: Pazzo Da Legare @ 2010-07-05 16:49 UTC (permalink / raw)
To: Levi, Shahar; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <AANLkTimcFgxOmw4oOa28unhmSpTt0jNacFKXRXycKKA9@mail.gmail.com>
Dear Shahar,
I start from tiwlan.ini file for tiwlan driver to produce an nvs file.
Could you please indicate values to use for the following parameters
of struct wl1271_nvs_file: general_params.srf1[],
general_params.srf2[], general_params.srf3[],
dyn_radio_params_2[].params.degraded_low_to_normal_thr,
dyn_radio_params_2[].params.normal_to_degraded_high_thr,
dyn_radio_params_5[i].params.degraded_low_to_normal_thr,
dyn_radio_params_5[i].params.normal_to_degraded_high_thr
Thank you very much for your time,
Best Regards,
pz
2010/7/5 Pazzo Da Legare <pazzodalegare@gmail.com>:
> Hi Shahar,
>
> Did you have any news about nvs file? I wrote an email to driver's
> mantaneir too,
>
> Thank you in advance,
>
> pz
>
> 2010/6/30 Levi, Shahar <shahar_levi@ti.com>:
>> Hi pz,
>> I am checking the way to access the FW and NVS file of wl1271.
>> Let me find more details on that and get back to you.
>> Regards,
>> Shahar
>> -----Original Message-----
>> From: linux-wireless-owner@vger.kernel.org [mailto:linux-wireless-owner@vger.kernel.org] On Behalf Of Pazzo Da Legare
>> Sent: Wednesday, June 30, 2010 2:27 PM
>> To: linux-wireless@vger.kernel.org
>> Subject: wl1271 firmware
>>
>> Hi all,
>>
>> I'm looking for wl1271 firmwares. I found wl1271-fw.bin but I cannot
>> find wl1271-nvs.bin needed to use the wl1271's driver.
>> Could you please indicate where I can get it?
>>
>> Thank in advance,
>>
>> pz
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
^ permalink raw reply
* [PATCH] wl1251: Use MODULE_ALIAS macro at correct postion for SPI bus
From: Ameya Palande @ 2010-07-05 14:12 UTC (permalink / raw)
To: linux-wireless; +Cc: kalle.valo, luciano.coelho, juuso.oikarinen
Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
---
drivers/net/wireless/wl12xx/wl1251_main.c | 1 -
drivers/net/wireless/wl12xx/wl1251_spi.c | 1 +
drivers/net/wireless/wl12xx/wl1271_spi.c | 1 +
3 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1251_main.c b/drivers/net/wireless/wl12xx/wl1251_main.c
index 00b2428..35fdf88 100644
--- a/drivers/net/wireless/wl12xx/wl1251_main.c
+++ b/drivers/net/wireless/wl12xx/wl1251_main.c
@@ -1419,5 +1419,4 @@ EXPORT_SYMBOL_GPL(wl1251_free_hw);
MODULE_DESCRIPTION("TI wl1251 Wireles LAN Driver Core");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Kalle Valo <kalle.valo@nokia.com>");
-MODULE_ALIAS("spi:wl1251");
MODULE_FIRMWARE(WL1251_FW_NAME);
diff --git a/drivers/net/wireless/wl12xx/wl1251_spi.c b/drivers/net/wireless/wl12xx/wl1251_spi.c
index e814742..27fdfaa 100644
--- a/drivers/net/wireless/wl12xx/wl1251_spi.c
+++ b/drivers/net/wireless/wl12xx/wl1251_spi.c
@@ -345,3 +345,4 @@ module_exit(wl1251_spi_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Kalle Valo <kalle.valo@nokia.com>");
+MODULE_ALIAS("spi:wl1251");
diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c
index 5189b81..96d25fb 100644
--- a/drivers/net/wireless/wl12xx/wl1271_spi.c
+++ b/drivers/net/wireless/wl12xx/wl1271_spi.c
@@ -461,3 +461,4 @@ MODULE_LICENSE("GPL");
MODULE_AUTHOR("Luciano Coelho <luciano.coelho@nokia.com>");
MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
MODULE_FIRMWARE(WL1271_FW_NAME);
+MODULE_ALIAS("spi:wl1271");
--
1.7.0.4
^ permalink raw reply related
* Re: wl1271 firmware
From: Pazzo Da Legare @ 2010-07-05 7:36 UTC (permalink / raw)
To: Levi, Shahar; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <AC090B9732AB2B4DB7FF476E907FE660010673660C@dnce02.ent.ti.com>
Hi Shahar,
Did you have any news about nvs file? I wrote an email to driver's
mantaneir too,
Thank you in advance,
pz
2010/6/30 Levi, Shahar <shahar_levi@ti.com>:
> Hi pz,
> I am checking the way to access the FW and NVS file of wl1271.
> Let me find more details on that and get back to you.
> Regards,
> Shahar
> -----Original Message-----
> From: linux-wireless-owner@vger.kernel.org [mailto:linux-wireless-owner@vger.kernel.org] On Behalf Of Pazzo Da Legare
> Sent: Wednesday, June 30, 2010 2:27 PM
> To: linux-wireless@vger.kernel.org
> Subject: wl1271 firmware
>
> Hi all,
>
> I'm looking for wl1271 firmwares. I found wl1271-fw.bin but I cannot
> find wl1271-nvs.bin needed to use the wl1271's driver.
> Could you please indicate where I can get it?
>
> Thank in advance,
>
> pz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: rt61pci AP performance issues
From: Helmut Schaa @ 2010-07-05 6:14 UTC (permalink / raw)
To: David Ellingsworth; +Cc: rt2x00 Users List, wireless
In-Reply-To: <AANLkTikRH3YEoZ47ihcZyqBiwfxdBPAEgZdAzAWES8x-@mail.gmail.com>
Am Dienstag 29 Juni 2010 schrieb David Ellingsworth:
> I haven't conducted any other tests beyond what was bisected in the
> attached log. Performance across all those revisions remained somewhat
> fast, and my markings were based solely on client link failure. Each
> bad commit resulted in the link failing after about 10s while
> transferring a file. At which point, the transfer would stop, the AP
> would be unreachable via pings, but the client remained associated to
> the AP. About 30s after that point, the client would timeout and
> re-associate to the AP reactivating the link.
Could you please check if the queues get stuck in that situation? I was
able to sometimes observe queues getting stuck on rt2800.
Just do the following (on the AP mode machine):
mount -t debugfs none /sys/debug
cat /sys/debug/ieee80211/phy0/queues
That should give you something like:
00: 0x00000000/0
01: 0x00000000/0
02: 0x00000000/0
03: 0x00000000/0
And if there's somewhere a 1 instead of a 0 it means that this queue is
stopped (which can/and must actually happen in some scenarios without
causing problems). If that 1 stays there for longer that means something
didn't start the queue anymore and your connection is most likely stuck.
Helmut
^ permalink raw reply
* Re: Problems connectring to an AP with Acer Aspire Revo
From: Carlos Balseiro @ 2010-07-04 19:13 UTC (permalink / raw)
To: linux-wireless
> This seems to indicate that there is some trouble on this platform ...
> and makes me start thinking that this card may not work well on this
> platform.
Just installed Windows 7 on my machine to test this and efectively,
the problem also exist.
^ permalink raw reply
* Compat-wireless release for 2010-07-04 is baked
From: Compat-wireless cronjob account @ 2010-07-04 19:02 UTC (permalink / raw)
To: linux-wireless
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
cat: compat_base_tree: No such file or directory
cat: compat_base_tree_version: No such file or directory
cat: compat_version: No such file or directory
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
scripts/Makefile.clean:17: /var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile: No such file or directory
make[4]: *** No rule to make target `/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile'. Stop.
make[3]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap] Error 2
make[2]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless] Error 2
make[1]: *** [_clean_/var/opt/compat/compat-wireless-2.6] Error 2
make: *** [clean] Error 2
/usr/bin/sha1sum: *.tar.bz2: No such file or directory
compat-wireless code metrics
494455 - Total upstream lines of code being pulled
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Ben Greear @ 2010-07-04 15:59 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: Vasanth Thiagarajan, linux-wireless@vger.kernel.org
In-Reply-To: <20100704093535.GE5053@vasanth-laptop>
On 07/04/2010 02:35 AM, Vasanthakumar Thiagarajan wrote:
> On Sat, Jul 03, 2010 at 10:04:09PM +0530, Ben Greear wrote:
>> On 07/03/2010 12:02 AM, Vasanthakumar Thiagarajan wrote:
>>> On Sat, Jul 03, 2010 at 11:56:14AM +0530, Ben Greear wrote:
>>>> It seems to me that in 2.6.34, there is no code to clean up
>>>> virtual wiphys in ath9k on rmmod. Also, ath9k mailing list
>>>> is returning error about mis-configured DNS server.
>>>>
>>>> This is with un-modified ath9k driver and is repeatable
>>>> every time on my system (crash is often different, but
>>>> it always crashes very quickly).
>>>>
>>>> [root@atom ~]# echo add=5> /debug/ath9k/phy1/wiphy
>>>> -bash: /debug/ath9k/phy1/wiphy: No such file or directory
>>>> [root@atom ~]# echo add=5> /debug/ath9k/phy0/wiphy
>>>> Jul 2 23:22:19 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
>>>> [root@atom ~]# Jul 2 23:22:19 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
>>>> rmmod ath9k
>>>> Jul 2 23:22:24 atom kernel: ath9k 0000:05:00.0: PCI INT A disabled
>>>> Jul 2 23:22:24 atom kernel: ath9k: Driver unloaded
>>>> [root@atom ~]# BUG: spinlock bad magic on CPU#1, iw/2877
>>>> lock: f8a476c0, .magic: 00000000, .owner:<none>/-1, .owner_cpu: 0
>>>> Pid: 2877, comm: iw Not tainted 2.6.34 #7
>>>> Call Trace:
>>>> [<c0730e34>] ? printk+0xf/0x13
>>>> [<c05710d6>] spin_bug+0x7b/0x86
>>>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>>>> [<c0571171>] do_raw_spin_lock+0x1e/0x125
>>>> [<c042f91e>] ? scheduler_tick+0xd6/0x1c9
>>>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>>>> [<c0732a6d>] _raw_spin_lock_irqsave+0x1b/0x20
>>>> [<c0440b59>] __queue_work+0x12/0x2f
>>>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>>>> [<c0440ba4>] delayed_work_timer_fn+0x2e/0x30
>>>>
>>>> I'm new to hacking on this driver..but would love to test
>>>> patches, and if someone wants to suggest a good point in
>>>> the code to remove the virtual phys, I'll make the attempt.
>>>
>>> Can you please try this patch?
>>
>> It still crashes for me, and backtraces look similar.
>>
>> Were you able to reproduce the crash?
>
> with my patch, no. Can you please give the steps to trigger
> this crash?
It happens every time if I:
echo add > /debug/ath9k/phy0/wiphy
rmmod ath9k
I notice the patch applied with offsets. What kernel/driver
version are you testing? I tried .34 kernel as well as the top-of-tree
2.6.35-rcX.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* BCM4311 in Ad-hoc Mode - Connection Unsuccessful
From: Nicholas Betcher @ 2010-07-04 10:37 UTC (permalink / raw)
To: Linux-Wireless Mailing List
In-Reply-To: <AANLkTim3gow5YFI1L-AwUMwGVb-MHkfZTXIIg3mitWne@mail.gmail.com>
Hello,
I have recently been using (lightly) tethering on my Android phone and
it uses Ad-hoc to provide wireless tethering. Unfortunately openSUSE
11.3 RC1 seems to be unable to connect to it. I haven't quite pinned
down at what point it is failing, but it isn't failing at obtaining a
DHCP lease, it's something more problematic. I have verified my
settings are all correct on both sides (computer and phone). Also - to
rule out hardware issues - I have used Windows 7 on the same system to
successfully connect to the phone.
Here are various logs/etc:
lspci -v -nn:
03:00.0 Network controller [0280]: Broadcom Corporation BCM4311
802.11b/g WLAN [14e4:4311] (rev 02)
Subsystem: Hewlett-Packard Company BCM4311 802.11b/g Wireless
LAN Controller [103c:1374]
Flags: bus master, fast devsel, latency 0, IRQ 18
Memory at b8000000 (64-bit, non-prefetchable) [size=16K]
Capabilities: [40] Power Management version 3
Capabilities: [58] Vendor Specific Information: Len=78 <?>
Capabilities: [e8] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [d0] Express Endpoint, MSI 00
Capabilities: [100] Advanced Error Reporting
Capabilities: [13c] Virtual Channel
Capabilities: [160] Device Serial Number [REMOVED INTENTIONALLY]
Capabilities: [16c] Power Budgeting <?>
Kernel driver in use: b43-pci-bridge
dmesg:
[ 328.352293] b43-phy0: Loading firmware version 478.104 (2008-07-01 00:50:23)
[ 328.384141] b43-pci-bridge 0000:03:00.0: PCI: Disallowing DAC for device
[ 328.384147] b43-phy0: DMA mask fallback from 64-bit to 32-bit
[ 328.398967] wlan0: Trigger new scan to find an IBSS to join
[ 331.704086] wlan0: Trigger new scan to find an IBSS to join
[ 335.704063] wlan0: Trigger new scan to find an IBSS to join
[ 336.996057] wlan0: Creating new IBSS network, BSSID [REMOVED INTENTIONALLY]
[ 367.704079] wlan0: No active IBSS STAs - trying to scan for other
IBSS networks with same SSID (merge)
[ 399.704089] wlan0: No active IBSS STAs - trying to scan for other
IBSS networks with same SSID (merge)
/var/log/messages:
Jul 3 01:57:53 NickB-Laptop ifup: wlan0 name: BCM4311 802.11b/g WLAN
Jul 3 01:57:53 NickB-Laptop ifup-wireless: wlan0 warning:
using NO encryption
Jul 3 01:57:53 NickB-Laptop kernel: [ 684.963046] b43-phy0: Loading
firmware version 478.104 (2008-07-01 00:50:23)
Jul 3 01:57:53 NickB-Laptop kernel: [ 684.995149] b43-pci-bridge
0000:03:00.0: PCI: Disallowing DAC for device
Jul 3 01:57:53 NickB-Laptop kernel: [ 684.995153] b43-phy0: DMA mask
fallback from 64-bit to 32-bit
Jul 3 01:57:53 NickB-Laptop kernel: [ 685.008172] wlan0: Selected
IBSS BSSID [REMOVED INTENTIONALLY] based on configured SSID
Jul 3 01:57:54 NickB-Laptop ifup-dhcp: wlan0 Starting DHCP4 client
Jul 3 01:57:54 NickB-Laptop dhcpcd[5932]: wlan0: dhcpcd 3.2.3 starting
Jul 3 01:57:54 NickB-Laptop dhcpcd[5932]: wlan0: hardware address =
[REMOVED INTENTIONALLY]
Jul 3 01:57:54 NickB-Laptop dhcpcd[5932]: wlan0: broadcasting for a lease
Jul 3 01:58:14 NickB-Laptop dhcpcd[5932]: wlan0: timed out
Jul 3 01:58:15 NickB-Laptop ifup-dhcp: wlan0 DHCP4 continues
in background
Jul 3 01:58:24 NickB-Laptop kernel: [ 715.701300] wlan0: No active
IBSS STAs - trying to scan for other IBSS networks with same SSID
(merge)
Jul 3 01:58:31 NickB-Laptop dhcpcd[4983]: eth0: timed out
Jul 3 01:58:31 NickB-Laptop dhcpcd[4983]: eth0: lease expired 1799145
seconds ago
Jul 3 01:58:31 NickB-Laptop dhcpcd[4983]: eth0: broadcasting for a lease
Jul 3 01:58:34 NickB-Laptop dhcpcd[5932]: wlan0: timed out
Jul 3 01:58:34 NickB-Laptop dhcpcd[5932]: wlan0: broadcasting for a lease
Jul 3 01:58:54 NickB-Laptop dhcpcd[5932]: wlan0: timed out
Jul 3 01:58:54 NickB-Laptop dhcpcd[5932]: wlan0: broadcasting for a lease
Jul 3 01:58:56 NickB-Laptop kernel: [ 747.704067] wlan0: No active
IBSS STAs - trying to scan for other IBSS networks with same SSID
(merge)
More is probably needed to truly debug this problem, so please CC me
and let me know what more is needed.
Thanks a million for the great driver, (seriously) :)
Nick Betcher, CPhT
Certified Pharmacy Technician
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Vasanthakumar Thiagarajan @ 2010-07-04 9:35 UTC (permalink / raw)
To: Ben Greear; +Cc: Vasanth Thiagarajan, linux-wireless@vger.kernel.org
In-Reply-To: <4C2F6681.7070202@candelatech.com>
On Sat, Jul 03, 2010 at 10:04:09PM +0530, Ben Greear wrote:
> On 07/03/2010 12:02 AM, Vasanthakumar Thiagarajan wrote:
> > On Sat, Jul 03, 2010 at 11:56:14AM +0530, Ben Greear wrote:
> >> It seems to me that in 2.6.34, there is no code to clean up
> >> virtual wiphys in ath9k on rmmod. Also, ath9k mailing list
> >> is returning error about mis-configured DNS server.
> >>
> >> This is with un-modified ath9k driver and is repeatable
> >> every time on my system (crash is often different, but
> >> it always crashes very quickly).
> >>
> >> [root@atom ~]# echo add=5> /debug/ath9k/phy1/wiphy
> >> -bash: /debug/ath9k/phy1/wiphy: No such file or directory
> >> [root@atom ~]# echo add=5> /debug/ath9k/phy0/wiphy
> >> Jul 2 23:22:19 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
> >> [root@atom ~]# Jul 2 23:22:19 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
> >> rmmod ath9k
> >> Jul 2 23:22:24 atom kernel: ath9k 0000:05:00.0: PCI INT A disabled
> >> Jul 2 23:22:24 atom kernel: ath9k: Driver unloaded
> >> [root@atom ~]# BUG: spinlock bad magic on CPU#1, iw/2877
> >> lock: f8a476c0, .magic: 00000000, .owner:<none>/-1, .owner_cpu: 0
> >> Pid: 2877, comm: iw Not tainted 2.6.34 #7
> >> Call Trace:
> >> [<c0730e34>] ? printk+0xf/0x13
> >> [<c05710d6>] spin_bug+0x7b/0x86
> >> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> >> [<c0571171>] do_raw_spin_lock+0x1e/0x125
> >> [<c042f91e>] ? scheduler_tick+0xd6/0x1c9
> >> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> >> [<c0732a6d>] _raw_spin_lock_irqsave+0x1b/0x20
> >> [<c0440b59>] __queue_work+0x12/0x2f
> >> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> >> [<c0440ba4>] delayed_work_timer_fn+0x2e/0x30
> >>
> >> I'm new to hacking on this driver..but would love to test
> >> patches, and if someone wants to suggest a good point in
> >> the code to remove the virtual phys, I'll make the attempt.
> >
> > Can you please try this patch?
>
> It still crashes for me, and backtraces look similar.
>
> Were you able to reproduce the crash?
with my patch, no. Can you please give the steps to trigger
this crash?
Vasanth
^ permalink raw reply
* Re: ath: Fix uninitialized variable warnings [v2]
From: Prarit Bhargava @ 2010-07-03 19:27 UTC (permalink / raw)
To: Pavel Roskin; +Cc: linux-wireless, ath9k-devel, linville
In-Reply-To: <1278165872.6710.1.camel@mj>
On 07/03/2010 10:04 AM, Pavel Roskin wrote:
> On Thu, 2010-07-01 at 12:09 -0400, Prarit Bhargava wrote:
>
>> Fix 'make CONFIG_DEBUG_SECTION_MISMATCH=y' warning:
>>
> I don't think the warnings you are fixing have anything to do with
> CONFIG_DEBUG_SECTION_MISMATCH.
>
Actually, Pavel -- they do. I've already emailed a question to some of
the gcc developers to see if they can explain to me why *I only see
these warnings if CONFIG_DEBUG_SECTION_MISMATCH is enabled*.
I agree, however, that it shouldn't make a difference and that it may
show a bug in gcc or somewhere in our makefiles.
>> drivers/net/wireless/mwl8k.c: In function 'mwl8k_bss_info_changed_sta':
>> drivers/net/wireless/mwl8k.c:3404: warning: 'ap_legacy_rates' may be used uninitialized in this function
>>
> The patch doesn't appear to touch mwl8k.c at all.
>
> Please fix the description.
>
>
Will do -- sorry, I cut-and-pasted too much...
P.
^ permalink raw reply
* Compat-wireless release for 2010-07-03 is baked
From: Compat-wireless cronjob account @ 2010-07-03 19:02 UTC (permalink / raw)
To: linux-wireless
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
cat: compat_base_tree: No such file or directory
cat: compat_base_tree_version: No such file or directory
cat: compat_version: No such file or directory
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
scripts/Makefile.clean:17: /var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile: No such file or directory
make[4]: *** No rule to make target `/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile'. Stop.
make[3]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap] Error 2
make[2]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless] Error 2
make[1]: *** [_clean_/var/opt/compat/compat-wireless-2.6] Error 2
make: *** [clean] Error 2
/usr/bin/sha1sum: *.tar.bz2: No such file or directory
compat-wireless code metrics
494455 - Total upstream lines of code being pulled
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Ben Greear @ 2010-07-03 17:57 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <4C2F6681.7070202@candelatech.com>
Just for reference, same problem on un-modified 2.6.35-rc3+ (pulled last night)
The crash below is from reproducing it with your patch included.
[root@atom ~]# ls
anaconda-ks.cfg Documents Music Public Videos
Desktop Downloads Pictures Templates
[root@atom ~]# echo add > /debug/ath9k/phy0/wiphy
Jul 3 10:55:24 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
[root@atom ~]# Jul 3 10:55:25 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
[root@atom ~]# rmmod ath9k
BUG: unable to handle kernel NULL pointer dereference at 000000a4
IP: [<f8d65fd1>] ath9k_hw_intrpend+0x6/0x49 [ath9k_hw]
*pde = 00000000
Oops: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:05:03.0/class
Modules linked in:
(It reboots before printing anything else to console).
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: Question on 'iw reg get/set'
From: Luis R. Rodriguez @ 2010-07-03 16:35 UTC (permalink / raw)
To: John W. Linville; +Cc: Ben Greear, linux-wireless
In-Reply-To: <20100702164759.GE2381@tuxdriver.com>
On Fri, Jul 2, 2010 at 9:48 AM, John W. Linville <linville@tuxdriver.com> wrote:
> On Fri, Jul 02, 2010 at 09:42:54AM -0700, Ben Greear wrote:
>> On 07/02/2010 07:12 AM, John W. Linville wrote:
>
>> >The ath9k driver is setting its own regulatory restrictions based on
>> >its EEPROM. Setting the domain from userland can only further restrict
>> >the regulatory settings. The '98' value represents a synthesized
>> >regulatory domain, based on the intersection of the available source
>> >of regulatory information (which can include the EEPROM, the userland
>> >setting, and a country IE from your AP).
>>
>> Is there any way to get/set these raw settings (like, whatever it has in EEPROM)?
>>
>> I expect we may ship some of these systems overseas, and would like the flexibility
>> to set the country-code for testing purposes, if nothing else.
>
> I'll leave it to the Atheros guys to address this.
Your "expectation" of having the freedom to modify the EEPROM is valid
as I agree with it too but current legislation does not allow for it.
So to support upstream drivers we just cannot allow for those type of
changes. You won't get any support if you try to mess with that stuff
unless we get a change in legislation that says otherwise. Please
refer to:
http://wireless.kernel.org/en/vendors/VendorSupport
http://wireless.kernel.org/en/developers/Regulatory/statement
http://wireless.kernel.org/en/developers/Regulatory
Luis
>> Is there any documentation as to what '98' really means, or do we just ignore that
>> value and look at the info printed out after that?
>
> '98' pretty much means "look at the info" :-)
Maybe userspace should be changed to interpret these. I'm on vacation
right now though, patch welcomed for iw.
Luis
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Ben Greear @ 2010-07-03 16:34 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <20100703070259.GA15479@vasanth-laptop>
On 07/03/2010 12:02 AM, Vasanthakumar Thiagarajan wrote:
> On Sat, Jul 03, 2010 at 11:56:14AM +0530, Ben Greear wrote:
>> It seems to me that in 2.6.34, there is no code to clean up
>> virtual wiphys in ath9k on rmmod. Also, ath9k mailing list
>> is returning error about mis-configured DNS server.
>>
>> This is with un-modified ath9k driver and is repeatable
>> every time on my system (crash is often different, but
>> it always crashes very quickly).
>>
>> [root@atom ~]# echo add=5> /debug/ath9k/phy1/wiphy
>> -bash: /debug/ath9k/phy1/wiphy: No such file or directory
>> [root@atom ~]# echo add=5> /debug/ath9k/phy0/wiphy
>> Jul 2 23:22:19 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
>> [root@atom ~]# Jul 2 23:22:19 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
>> rmmod ath9k
>> Jul 2 23:22:24 atom kernel: ath9k 0000:05:00.0: PCI INT A disabled
>> Jul 2 23:22:24 atom kernel: ath9k: Driver unloaded
>> [root@atom ~]# BUG: spinlock bad magic on CPU#1, iw/2877
>> lock: f8a476c0, .magic: 00000000, .owner:<none>/-1, .owner_cpu: 0
>> Pid: 2877, comm: iw Not tainted 2.6.34 #7
>> Call Trace:
>> [<c0730e34>] ? printk+0xf/0x13
>> [<c05710d6>] spin_bug+0x7b/0x86
>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>> [<c0571171>] do_raw_spin_lock+0x1e/0x125
>> [<c042f91e>] ? scheduler_tick+0xd6/0x1c9
>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>> [<c0732a6d>] _raw_spin_lock_irqsave+0x1b/0x20
>> [<c0440b59>] __queue_work+0x12/0x2f
>> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
>> [<c0440ba4>] delayed_work_timer_fn+0x2e/0x30
>>
>> I'm new to hacking on this driver..but would love to test
>> patches, and if someone wants to suggest a good point in
>> the code to remove the virtual phys, I'll make the attempt.
>
> Can you please try this patch?
It still crashes for me, and backtraces look similar.
Were you able to reproduce the crash?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: ath: Fix uninitialized variable warnings [v2]
From: Pavel Roskin @ 2010-07-03 14:04 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: linux-wireless, ath9k-devel, linville
In-Reply-To: <20100701160048.23795.39782.sendpatchset@prarit.bos.redhat.com>
On Thu, 2010-07-01 at 12:09 -0400, Prarit Bhargava wrote:
> Fix 'make CONFIG_DEBUG_SECTION_MISMATCH=y' warning:
I don't think the warnings you are fixing have anything to do with
CONFIG_DEBUG_SECTION_MISMATCH.
> drivers/net/wireless/mwl8k.c: In function 'mwl8k_bss_info_changed_sta':
> drivers/net/wireless/mwl8k.c:3404: warning: 'ap_legacy_rates' may be used uninitialized in this function
The patch doesn't appear to touch mwl8k.c at all.
Please fix the description.
--
Regards,
Pavel Roskin
^ permalink raw reply
* Re: ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Vasanthakumar Thiagarajan @ 2010-07-03 7:02 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <4C2ED806.9000105@candelatech.com>
On Sat, Jul 03, 2010 at 11:56:14AM +0530, Ben Greear wrote:
> It seems to me that in 2.6.34, there is no code to clean up
> virtual wiphys in ath9k on rmmod. Also, ath9k mailing list
> is returning error about mis-configured DNS server.
>
> This is with un-modified ath9k driver and is repeatable
> every time on my system (crash is often different, but
> it always crashes very quickly).
>
> [root@atom ~]# echo add=5 > /debug/ath9k/phy1/wiphy
> -bash: /debug/ath9k/phy1/wiphy: No such file or directory
> [root@atom ~]# echo add=5 > /debug/ath9k/phy0/wiphy
> Jul 2 23:22:19 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
> [root@atom ~]# Jul 2 23:22:19 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
> rmmod ath9k
> Jul 2 23:22:24 atom kernel: ath9k 0000:05:00.0: PCI INT A disabled
> Jul 2 23:22:24 atom kernel: ath9k: Driver unloaded
> [root@atom ~]# BUG: spinlock bad magic on CPU#1, iw/2877
> lock: f8a476c0, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
> Pid: 2877, comm: iw Not tainted 2.6.34 #7
> Call Trace:
> [<c0730e34>] ? printk+0xf/0x13
> [<c05710d6>] spin_bug+0x7b/0x86
> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> [<c0571171>] do_raw_spin_lock+0x1e/0x125
> [<c042f91e>] ? scheduler_tick+0xd6/0x1c9
> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> [<c0732a6d>] _raw_spin_lock_irqsave+0x1b/0x20
> [<c0440b59>] __queue_work+0x12/0x2f
> [<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
> [<c0440ba4>] delayed_work_timer_fn+0x2e/0x30
>
> I'm new to hacking on this driver..but would love to test
> patches, and if someone wants to suggest a good point in
> the code to remove the virtual phys, I'll make the attempt.
Can you please try this patch?
diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 3a14630..6218890 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -516,6 +516,7 @@ void ath_deinit_leds(struct ath_softc *sc);
#define SC_OP_TSF_RESET BIT(11)
#define SC_OP_BT_PRIORITY_DETECTED BIT(12)
#define SC_OP_BT_SCAN BIT(13)
+#define SC_OP_ANI_RUN BIT(14)
/* Powersave flags */
#define PS_WAIT_FOR_BEACON BIT(0)
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 5af2596..41a317d 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -451,6 +451,10 @@ static void ath_start_ani(struct ath_common *common)
{
struct ath_hw *ah = common->ah;
unsigned long timestamp = jiffies_to_msecs(jiffies);
+ struct ath_softc *sc = (struct ath_softc *) common->priv;
+
+ if (!(sc->sc_flags & SC_OP_ANI_RUN))
+ return;
common->ani.longcal_timer = timestamp;
common->ani.shortcal_timer = timestamp;
@@ -766,11 +770,13 @@ static void ath9k_bss_assoc_info(struct ath_softc *sc,
/* Reset rssi stats */
sc->sc_ah->stats.avgbrssi = ATH_RSSI_DUMMY_MARKER;
+ sc->sc_flags |= SC_OP_ANI_RUN;
ath_start_ani(common);
} else {
ath_print(common, ATH_DBG_CONFIG, "Bss Info DISASSOC\n");
common->curaid = 0;
/* Stop ANI */
+ sc->sc_flags &= ~SC_OP_ANI_RUN;
del_timer_sync(&common->ani.timer);
}
}
@@ -1376,8 +1382,10 @@ static int ath9k_add_interface(struct ieee80211_hw *hw,
if (vif->type == NL80211_IFTYPE_AP ||
vif->type == NL80211_IFTYPE_ADHOC ||
- vif->type == NL80211_IFTYPE_MONITOR)
+ vif->type == NL80211_IFTYPE_MONITOR) {
+ sc->sc_flags |= SC_OP_ANI_RUN;
ath_start_ani(common);
+ }
out:
mutex_unlock(&sc->mutex);
@@ -1398,6 +1406,7 @@ static void ath9k_remove_interface(struct ieee80211_hw *hw,
mutex_lock(&sc->mutex);
/* Stop ANI */
+ sc->sc_flags &= ~SC_OP_ANI_RUN;
del_timer_sync(&common->ani.timer);
/* Reclaim beacon resources */
--
Vasanth
^ permalink raw reply related
* ath9k doesn't clean up virtual wifis on rmmod, and crashes.
From: Ben Greear @ 2010-07-03 6:26 UTC (permalink / raw)
To: linux-wireless
It seems to me that in 2.6.34, there is no code to clean up
virtual wiphys in ath9k on rmmod. Also, ath9k mailing list
is returning error about mis-configured DNS server.
This is with un-modified ath9k driver and is repeatable
every time on my system (crash is often different, but
it always crashes very quickly).
[root@atom ~]# echo add=5 > /debug/ath9k/phy1/wiphy
-bash: /debug/ath9k/phy1/wiphy: No such file or directory
[root@atom ~]# echo add=5 > /debug/ath9k/phy0/wiphy
Jul 2 23:22:19 atom kernel: phy1: Selected rate control algorithm 'ath9k_rate_control'
[root@atom ~]# Jul 2 23:22:19 atom kernel: ADDRCONF(NETDEV_UP): wlan1: link is not ready
rmmod ath9k
Jul 2 23:22:24 atom kernel: ath9k 0000:05:00.0: PCI INT A disabled
Jul 2 23:22:24 atom kernel: ath9k: Driver unloaded
[root@atom ~]# BUG: spinlock bad magic on CPU#1, iw/2877
lock: f8a476c0, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
Pid: 2877, comm: iw Not tainted 2.6.34 #7
Call Trace:
[<c0730e34>] ? printk+0xf/0x13
[<c05710d6>] spin_bug+0x7b/0x86
[<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
[<c0571171>] do_raw_spin_lock+0x1e/0x125
[<c042f91e>] ? scheduler_tick+0xd6/0x1c9
[<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
[<c0732a6d>] _raw_spin_lock_irqsave+0x1b/0x20
[<c0440b59>] __queue_work+0x12/0x2f
[<c0440b76>] ? delayed_work_timer_fn+0x0/0x30
[<c0440ba4>] delayed_work_timer_fn+0x2e/0x30
I'm new to hacking on this driver..but would love to test
patches, and if someone wants to suggest a good point in
the code to remove the virtual phys, I'll make the attempt.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox