* [PATCH 00/11] Removing dead code
From: Christoph Egger @ 2010-07-14 12:39 UTC (permalink / raw)
To: David S. Miller, Alexey Dobriyan, Jiri Pirko, Joe Perches,
Stephen Hemminger, Eric Dumazet, Jesper Nilsson, Tejun Heo,
Dongdong Deng, Jiri Kosina, Samuel Ortiz, Andrew Morton,
Roel Kluin, Nicolas Pitre, Tony Lindgren, Daniel Walker,
Alessandro Rubini, Ivo van Doorn, Gertjan van Wingerde,
John W. Linville, Bartlomiej Zolnierkiewicz, Felix Fietkau,
Helmut Schaa, netdev, linux-kernel, linux-wireless, users
Cc: vamos-dev
Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux'
configuration system.
I've been running a check on the drivers/net sourcetree for
config Items not defined in Kconfig and found 11 such
cases. Sourcecode blocks depending on these Items are not reachable
from a vanilla kernel -- dead code. I've seen such dead blocks made on
purpose e.g. while integrating new features into the kernel but
generally they're just useless.
Each of the patches in this patchset removes on such dead
config Item, I'd be glad if you consider applying them. I've been
doing deeper analysis of such issues before and can do so again but
I'm not so sure they were fastly usefull.
I build the patches against a vanilla kernel in order to
try if the kernel compiles with this patches
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
Christoph Egger (11):
Removing dead RT2800PCI_SOC
Removing dead {AR,WAVE}LAN
Removing dead CASSINI_QGE_DEBUG
Removing dead CASSINI_MULTICAST_REG_WRITE
Removing dead CASSINI_NAPI
Removing dead CHELSIO_T1_COUGAR
Removing dead ARCH_PNX010X
Removing dead SH_HICOSH4
Removing dead ETRAX_NETWORK_RED_ON_NO_CONNECTION
Removing dead NETWINDER_{T,R}X_DMA_PROBLEMS
Removing dead REDWOOD_{5,6}
drivers/net/Space.c | 6 --
drivers/net/cassini.c | 25 +--------
drivers/net/cassini.h | 4 -
drivers/net/chelsio/subr.c | 48 +---------------
drivers/net/cris/eth_v10.c | 4 -
drivers/net/cs89x0.c | 96 +------------------------------
drivers/net/cs89x0.h | 4 -
drivers/net/irda/w83977af_ir.c | 33 +---------
drivers/net/smc91x.h | 37 ------------
drivers/net/wireless/rt2x00/Kconfig | 5 --
drivers/net/wireless/rt2x00/rt2800pci.c | 39 -------------
11 files changed, 9 insertions(+), 292 deletions(-)
^ permalink raw reply
* [PATCH 01/11] Removing dead RT2800PCI_SOC
From: Christoph Egger @ 2010-07-14 12:39 UTC (permalink / raw)
To: Ivo van Doorn, Gertjan van Wingerde, John W. Linville,
Bartlomiej Zolnierkiewicz, Felix Fietkau, Helmut Schaa,
linux-wireless, users, netdev, linux-kernel
Cc: vamos-dev
In-Reply-To: <cover.1279110894.git.siccegge@cs.fau.de>
While RT2800PCI_SOC exists in Kconfig, it depends on either
RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
so all Code depending on that can't ever be selected and, if there's
no plan to add these options, should be cleaned up
Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
---
drivers/net/wireless/rt2x00/Kconfig | 5 ----
drivers/net/wireless/rt2x00/rt2800pci.c | 39 -------------------------------
2 files changed, 0 insertions(+), 44 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index eea1ef2..d59195a 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -58,11 +58,6 @@ config RT2800PCI_PCI
depends on PCI
default y
-config RT2800PCI_SOC
- boolean
- depends on RALINK_RT288X || RALINK_RT305X
- default y
-
config RT2800PCI
tristate "Ralink rt28xx/rt30xx/rt35xx (PCI/PCIe/PCMCIA) support (EXPERIMENTAL)"
depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index b2f2327..1445038 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -85,18 +85,9 @@ static void rt2800pci_mcu_status(struct rt2x00_dev *rt2x00dev, const u8 token)
rt2800_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
}
-#ifdef CONFIG_RT2800PCI_SOC
-static void rt2800pci_read_eeprom_soc(struct rt2x00_dev *rt2x00dev)
-{
- u32 *base_addr = (u32 *) KSEG1ADDR(0x1F040000); /* XXX for RT3052 */
-
- memcpy_fromio(rt2x00dev->eeprom, base_addr, EEPROM_SIZE);
-}
-#else
static inline void rt2800pci_read_eeprom_soc(struct rt2x00_dev *rt2x00dev)
{
}
-#endif /* CONFIG_RT2800PCI_SOC */
#ifdef CONFIG_RT2800PCI_PCI
static void rt2800pci_eepromregister_read(struct eeprom_93cx6 *eeprom)
@@ -1160,25 +1151,6 @@ MODULE_DEVICE_TABLE(pci, rt2800pci_device_table);
#endif /* CONFIG_RT2800PCI_PCI */
MODULE_LICENSE("GPL");
-#ifdef CONFIG_RT2800PCI_SOC
-static int rt2800soc_probe(struct platform_device *pdev)
-{
- return rt2x00soc_probe(pdev, &rt2800pci_ops);
-}
-
-static struct platform_driver rt2800soc_driver = {
- .driver = {
- .name = "rt2800_wmac",
- .owner = THIS_MODULE,
- .mod_name = KBUILD_MODNAME,
- },
- .probe = rt2800soc_probe,
- .remove = __devexit_p(rt2x00soc_remove),
- .suspend = rt2x00soc_suspend,
- .resume = rt2x00soc_resume,
-};
-#endif /* CONFIG_RT2800PCI_SOC */
-
#ifdef CONFIG_RT2800PCI_PCI
static struct pci_driver rt2800pci_driver = {
.name = KBUILD_MODNAME,
@@ -1194,17 +1166,9 @@ static int __init rt2800pci_init(void)
{
int ret = 0;
-#ifdef CONFIG_RT2800PCI_SOC
- ret = platform_driver_register(&rt2800soc_driver);
- if (ret)
- return ret;
-#endif
#ifdef CONFIG_RT2800PCI_PCI
ret = pci_register_driver(&rt2800pci_driver);
if (ret) {
-#ifdef CONFIG_RT2800PCI_SOC
- platform_driver_unregister(&rt2800soc_driver);
-#endif
return ret;
}
#endif
@@ -1217,9 +1181,6 @@ static void __exit rt2800pci_exit(void)
#ifdef CONFIG_RT2800PCI_PCI
pci_unregister_driver(&rt2800pci_driver);
#endif
-#ifdef CONFIG_RT2800PCI_SOC
- platform_driver_unregister(&rt2800soc_driver);
-#endif
}
module_init(rt2800pci_init);
--
1.7.0.4
^ permalink raw reply related
* Re: Bug#588196: b43: does not join multicast groups
From: Michael Büsch @ 2010-07-14 12:41 UTC (permalink / raw)
To: Simon Richter
Cc: Larry Finger, Ben Hutchings, Stefano Brivio, linux-wireless,
588196
In-Reply-To: <20100714075037.GA6128@richter>
On 07/14/2010 09:50 AM, Simon Richter wrote:
> Hi,
>
> On Tue, Jul 13, 2010 at 04:05:10PM +0200, Michael Büsch wrote:
>
>> So it is up to the upper layer to detect the failure. I don't think
>> it's possible to automatically detect such incidents for multicast
>> transmissions. So the mechanism fails here.
>
> Well, it is about *receiving* a multicast transmission
The same applies to receiving. The RX queue is also dropped on switch
from DMA to PIO.
> advertisement, sent to 33:33:00:00:00:01). I have no idea where the
> packet is dropped; from my somewhat limited understanding of 802.11, I'd
> expect the frames to be treated like broadcast frames by the AP, so it'd
> be the receiver dropping them in the MAC filter.
The actual switch from DMA to PIO mode completely reinitializes
the hardware and drops all queues.
--
Greetings Michael.
^ permalink raw reply
* Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
From: Luis Correia @ 2010-07-14 12:46 UTC (permalink / raw)
To: Christoph Egger
Cc: Ivo van Doorn, Gertjan van Wingerde, John W. Linville,
Bartlomiej Zolnierkiewicz, Felix Fietkau, Helmut Schaa,
linux-wireless, users, netdev, linux-kernel, vamos-dev
In-Reply-To: <29013fb6eab9e95e95d61df894797d2455dfa10c.1279110894.git.siccegge@cs.fau.de>
On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
> While RT2800PCI_SOC exists in Kconfig, it depends on either
> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
> so all Code depending on that can't ever be selected and, if there's
> no plan to add these options, should be cleaned up
>
> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
NAK,
this is not dead code, it is needed for the Ralink System-on-Chip
Platform devices.
While I can't fix Kconfig errors and the current KConfig file may be
wrong, this code cannot and will not be deleted.
Luis Correia
rt2x00 project admin
> ---
> drivers/net/wireless/rt2x00/Kconfig | 5 ----
> drivers/net/wireless/rt2x00/rt2800pci.c | 39 -------------------------------
> 2 files changed, 0 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index eea1ef2..d59195a 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -58,11 +58,6 @@ config RT2800PCI_PCI
> depends on PCI
> default y
>
> -config RT2800PCI_SOC
> - boolean
> - depends on RALINK_RT288X || RALINK_RT305X
> - default y
> -
> config RT2800PCI
> tristate "Ralink rt28xx/rt30xx/rt35xx (PCI/PCIe/PCMCIA) support (EXPERIMENTAL)"
> depends on (RT2800PCI_PCI || RT2800PCI_SOC) && EXPERIMENTAL
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
> index b2f2327..1445038 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -85,18 +85,9 @@ static void rt2800pci_mcu_status(struct rt2x00_dev *rt2x00dev, const u8 token)
> rt2800_register_write(rt2x00dev, H2M_MAILBOX_CID, ~0);
> }
>
> -#ifdef CONFIG_RT2800PCI_SOC
> -static void rt2800pci_read_eeprom_soc(struct rt2x00_dev *rt2x00dev)
> -{
> - u32 *base_addr = (u32 *) KSEG1ADDR(0x1F040000); /* XXX for RT3052 */
> -
> - memcpy_fromio(rt2x00dev->eeprom, base_addr, EEPROM_SIZE);
> -}
> -#else
> static inline void rt2800pci_read_eeprom_soc(struct rt2x00_dev *rt2x00dev)
> {
> }
> -#endif /* CONFIG_RT2800PCI_SOC */
>
> #ifdef CONFIG_RT2800PCI_PCI
> static void rt2800pci_eepromregister_read(struct eeprom_93cx6 *eeprom)
> @@ -1160,25 +1151,6 @@ MODULE_DEVICE_TABLE(pci, rt2800pci_device_table);
> #endif /* CONFIG_RT2800PCI_PCI */
> MODULE_LICENSE("GPL");
>
> -#ifdef CONFIG_RT2800PCI_SOC
> -static int rt2800soc_probe(struct platform_device *pdev)
> -{
> - return rt2x00soc_probe(pdev, &rt2800pci_ops);
> -}
> -
> -static struct platform_driver rt2800soc_driver = {
> - .driver = {
> - .name = "rt2800_wmac",
> - .owner = THIS_MODULE,
> - .mod_name = KBUILD_MODNAME,
> - },
> - .probe = rt2800soc_probe,
> - .remove = __devexit_p(rt2x00soc_remove),
> - .suspend = rt2x00soc_suspend,
> - .resume = rt2x00soc_resume,
> -};
> -#endif /* CONFIG_RT2800PCI_SOC */
> -
> #ifdef CONFIG_RT2800PCI_PCI
> static struct pci_driver rt2800pci_driver = {
> .name = KBUILD_MODNAME,
> @@ -1194,17 +1166,9 @@ static int __init rt2800pci_init(void)
> {
> int ret = 0;
>
> -#ifdef CONFIG_RT2800PCI_SOC
> - ret = platform_driver_register(&rt2800soc_driver);
> - if (ret)
> - return ret;
> -#endif
> #ifdef CONFIG_RT2800PCI_PCI
> ret = pci_register_driver(&rt2800pci_driver);
> if (ret) {
> -#ifdef CONFIG_RT2800PCI_SOC
> - platform_driver_unregister(&rt2800soc_driver);
> -#endif
> return ret;
> }
> #endif
> @@ -1217,9 +1181,6 @@ static void __exit rt2800pci_exit(void)
> #ifdef CONFIG_RT2800PCI_PCI
> pci_unregister_driver(&rt2800pci_driver);
> #endif
> -#ifdef CONFIG_RT2800PCI_SOC
> - platform_driver_unregister(&rt2800soc_driver);
> -#endif
> }
>
> module_init(rt2800pci_init);
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
From: Ivo Van Doorn @ 2010-07-14 12:52 UTC (permalink / raw)
To: Christoph Egger
Cc: Gertjan van Wingerde, John W. Linville, Bartlomiej Zolnierkiewicz,
Felix Fietkau, Helmut Schaa, linux-wireless, users, netdev,
linux-kernel, vamos-dev, Luis Correia
In-Reply-To: <AANLkTinO32CIe0HBTXjP_bcAz0nMEw6wvcZwcob1fX3r@mail.gmail.com>
On Wed, Jul 14, 2010 at 2:46 PM, Luis Correia <luis.f.correia@gmail.com> wrote:
> On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
>> While RT2800PCI_SOC exists in Kconfig, it depends on either
>> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
>> so all Code depending on that can't ever be selected and, if there's
>> no plan to add these options, should be cleaned up
>>
>> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
>
> NAK,
>
> this is not dead code, it is needed for the Ralink System-on-Chip
> Platform devices.
>
> While I can't fix Kconfig errors and the current KConfig file may be
> wrong, this code cannot and will not be deleted.
When the config option was introduced, the config options RALINK_RT288X and
RALINK_RT305X were supposed to be merged as well soon after by somebody (Felix?)
But since testing is done on SoC boards by Helmut and Felix, I assume the code
isn't dead but actually in use.
Ivo
^ permalink raw reply
* Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
From: John W. Linville @ 2010-07-14 13:15 UTC (permalink / raw)
To: Ivo Van Doorn
Cc: Christoph Egger, Gertjan van Wingerde, Bartlomiej Zolnierkiewicz,
Felix Fietkau, Helmut Schaa, linux-wireless, users, netdev,
linux-kernel, vamos-dev, Luis Correia
In-Reply-To: <AANLkTikCeDys9e1EnE9GdiJtDRcbqW3gzvsmjzvB_yDs@mail.gmail.com>
On Wed, Jul 14, 2010 at 02:52:14PM +0200, Ivo Van Doorn wrote:
> On Wed, Jul 14, 2010 at 2:46 PM, Luis Correia <luis.f.correia@gmail.com> wrote:
> > On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
> >> While RT2800PCI_SOC exists in Kconfig, it depends on either
> >> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
> >> so all Code depending on that can't ever be selected and, if there's
> >> no plan to add these options, should be cleaned up
> >>
> >> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> >
> > NAK,
> >
> > this is not dead code, it is needed for the Ralink System-on-Chip
> > Platform devices.
> >
> > While I can't fix Kconfig errors and the current KConfig file may be
> > wrong, this code cannot and will not be deleted.
>
> When the config option was introduced, the config options RALINK_RT288X and
> RALINK_RT305X were supposed to be merged as well soon after by somebody (Felix?)
>
> But since testing is done on SoC boards by Helmut and Felix, I assume the code
> isn't dead but actually in use.
Perhaps Helmut and Felix can send us the missing code?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply
* Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
From: Bartlomiej Zolnierkiewicz @ 2010-07-14 14:14 UTC (permalink / raw)
To: Ivo Van Doorn
Cc: Egger, Gertjan van Wingerde, John W. Linville, Felix Fietkau,
Helmut Schaa, linux-wireless, users, netdev, linux-kernel,
vamos-dev, Luis Correia
In-Reply-To: <AANLkTikCeDys9e1EnE9GdiJtDRcbqW3gzvsmjzvB_yDs@mail.gmail.com>
On Wednesday 14 July 2010 02:52:14 pm Ivo Van Doorn wrote:
> On Wed, Jul 14, 2010 at 2:46 PM, Luis Correia <luis.f.correia@gmail.com> wrote:
> > On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
> >> While RT2800PCI_SOC exists in Kconfig, it depends on either
> >> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
> >> so all Code depending on that can't ever be selected and, if there's
> >> no plan to add these options, should be cleaned up
> >>
> >> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> >
> > NAK,
> >
> > this is not dead code, it is needed for the Ralink System-on-Chip
> > Platform devices.
> >
> > While I can't fix Kconfig errors and the current KConfig file may be
> > wrong, this code cannot and will not be deleted.
>
> When the config option was introduced, the config options RALINK_RT288X and
> RALINK_RT305X were supposed to be merged as well soon after by somebody (Felix?)
>
> But since testing is done on SoC boards by Helmut and Felix, I assume the code
> isn't dead but actually in use.
>
> Ivo
I fully agree with Luis and Ivo that the proposed patch is invalid and
shouldn't be applied (the "code cannot and will not be deleted" anyway)..
[ Under "The New Normal" rules the code doesn't even have to work to be
merged and/or stay in the kernel so 9 months of code not being used by
any real user doesn't matter a tiny bit.. ]
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply
* Re: [PATCH 01/11] Removing dead RT2800PCI_SOC
From: Felix Fietkau @ 2010-07-14 14:44 UTC (permalink / raw)
To: John W. Linville
Cc: Ivo Van Doorn, Christoph Egger, Gertjan van Wingerde,
Bartlomiej Zolnierkiewicz, Helmut Schaa, linux-wireless, users,
netdev, linux-kernel, vamos-dev, Luis Correia
In-Reply-To: <20100714131527.GB2352@tuxdriver.com>
On 2010-07-14 3:15 PM, John W. Linville wrote:
> On Wed, Jul 14, 2010 at 02:52:14PM +0200, Ivo Van Doorn wrote:
>> On Wed, Jul 14, 2010 at 2:46 PM, Luis Correia <luis.f.correia@gmail.com> wrote:
>> > On Wed, Jul 14, 2010 at 13:39, Christoph Egger <siccegge@cs.fau.de> wrote:
>> >> While RT2800PCI_SOC exists in Kconfig, it depends on either
>> >> RALINK_RT288X or RALINK_RT305X which are both not available in Kconfig
>> >> so all Code depending on that can't ever be selected and, if there's
>> >> no plan to add these options, should be cleaned up
>> >>
>> >> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
>> >
>> > NAK,
>> >
>> > this is not dead code, it is needed for the Ralink System-on-Chip
>> > Platform devices.
>> >
>> > While I can't fix Kconfig errors and the current KConfig file may be
>> > wrong, this code cannot and will not be deleted.
>>
>> When the config option was introduced, the config options RALINK_RT288X and
>> RALINK_RT305X were supposed to be merged as well soon after by somebody (Felix?)
>>
>> But since testing is done on SoC boards by Helmut and Felix, I assume the code
>> isn't dead but actually in use.
>
> Perhaps Helmut and Felix can send us the missing code?
The missing code is a MIPS platform port, which is currently being
maintained in OpenWrt, but is not ready for upstream submission yet.
I'm not working on this code at the moment, but I think it will be
submitted once it's ready.
- Felix
^ permalink raw reply
* [PATCH] iwlwifi: convert new uses of __attribute__ ((packed)) to __packed
From: John W. Linville @ 2010-07-14 14:37 UTC (permalink / raw)
To: linux-wireless; +Cc: Wey-Yi Guy, John W. Linville
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/iwlwifi/iwl-commands.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
index 8d2db9d..f1c0e68 100644
--- a/drivers/net/wireless/iwlwifi/iwl-commands.h
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
@@ -1245,7 +1245,7 @@ struct iwl_txfifo_flush_cmd {
__le32 fifo_control;
__le16 flush_control;
__le16 reserved;
-} __attribute__ ((packed));
+} __packed;
/*
* REPLY_WEP_KEY = 0x20
@@ -3547,7 +3547,7 @@ struct iwl_sensitivity_cmd {
struct iwl_enhance_sensitivity_cmd {
__le16 control; /* always use "1" */
__le16 enhance_table[ENHANCE_HD_TABLE_SIZE]; /* use HD_* as index */
-} __attribute__ ((packed));
+} __packed;
/**
--
1.7.1.1
^ permalink raw reply related
* [PATCH] libertas: convert new uses of __attribute__ ((packed)) to __packed
From: John W. Linville @ 2010-07-14 14:37 UTC (permalink / raw)
To: linux-wireless
Cc: Dan Williams, Holger Schurig, Amitkumar Karwar, libertas-dev,
John W. Linville
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/libertas/cfg.c | 6 +++---
drivers/net/wireless/libertas/host.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
index f36cc97..7e07416 100644
--- a/drivers/net/wireless/libertas/cfg.c
+++ b/drivers/net/wireless/libertas/cfg.c
@@ -891,7 +891,7 @@ struct cmd_key_material {
__le16 action;
struct MrvlIEtype_keyParamSet param;
-} __attribute__ ((packed));
+} __packed;
static int lbs_set_key_material(struct lbs_private *priv,
int key_type,
@@ -1395,7 +1395,7 @@ struct cmd_monitor_mode {
__le16 action;
__le16 mode;
-} __attribute__ ((packed));
+} __packed;
static int lbs_enable_monitor_mode(struct lbs_private *priv, int mode)
{
@@ -1450,7 +1450,7 @@ struct cmd_rssi {
__le16 nf;
__le16 avg_snr;
__le16 avg_nf;
-} __attribute__ ((packed));
+} __packed;
static int lbs_get_signal(struct lbs_private *priv, s8 *signal, s8 *noise)
{
diff --git a/drivers/net/wireless/libertas/host.h b/drivers/net/wireless/libertas/host.h
index db8e209..43d020c 100644
--- a/drivers/net/wireless/libertas/host.h
+++ b/drivers/net/wireless/libertas/host.h
@@ -398,12 +398,12 @@ struct mrvl_ie_domain_param_set {
u8 countrycode[COUNTRY_CODE_LEN];
struct ieee80211_country_ie_triplet triplet[1];
-} __attribute__ ((packed));
+} __packed;
struct cmd_ds_802_11d_domain_info {
__le16 action;
struct mrvl_ie_domain_param_set domain;
-} __attribute__ ((packed));
+} __packed;
struct lbs_802_11d_domain_reg {
/** Country code*/
@@ -411,7 +411,7 @@ struct lbs_802_11d_domain_reg {
/** No. of triplet*/
u8 no_triplet;
struct ieee80211_country_ie_triplet triplet[MRVDRV_MAX_TRIPLET_802_11D];
-} __attribute__ ((packed));
+} __packed;
/*
* Define data structure for CMD_GET_HW_SPEC
--
1.7.1.1
^ permalink raw reply related
* Re: [PATCH] iwlwifi: convert new uses of __attribute__ ((packed)) to __packed
From: Guy, Wey-Yi @ 2010-07-14 15:25 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1279118252-10258-1-git-send-email-linville@tuxdriver.com>
Hi John,
On Wed, 2010-07-14 at 07:37 -0700, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-commands.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-commands.h b/drivers/net/wireless/iwlwifi/iwl-commands.h
> index 8d2db9d..f1c0e68 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-commands.h
> +++ b/drivers/net/wireless/iwlwifi/iwl-commands.h
> @@ -1245,7 +1245,7 @@ struct iwl_txfifo_flush_cmd {
> __le32 fifo_control;
> __le16 flush_control;
> __le16 reserved;
> -} __attribute__ ((packed));
> +} __packed;
>
> /*
> * REPLY_WEP_KEY = 0x20
> @@ -3547,7 +3547,7 @@ struct iwl_sensitivity_cmd {
> struct iwl_enhance_sensitivity_cmd {
> __le16 control; /* always use "1" */
> __le16 enhance_table[ENHANCE_HD_TABLE_SIZE]; /* use HD_* as index */
> -} __attribute__ ((packed));
> +} __packed;
>
>
> /**
Thanks
Wey
^ permalink raw reply
* Re: commit 062bee448bd539580ef9f64efe50fdfe04eeb103 broke my iwlagn 5100
From: Guy, Wey-Yi @ 2010-07-14 15:28 UTC (permalink / raw)
To: Florian Klink; +Cc: Johannes Berg, linux-wireless@vger.kernel.org
In-Reply-To: <e5d3a4df03d6582ddc18af249ed3a2f2@imap.flokli.de>
Hi Florian,
On Wed, 2010-07-14 at 03:06 -0700, Florian Klink wrote:
> Thanks ;-)
>
> On Wed, 14 Jul 2010 12:00:55 +0200, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > [correct wey-yi's address, remove reinette]
> >
> > On Wed, 2010-07-14 at 11:33 +0200, Florian Klink wrote:
> >> Hi,
> >>
> >> I hope I'm writing to the right addresses, this is my first kernel bug
> >> report :-)
> >>
> >> I regulary build linus' tree from git. One day, my wireless card was
> >> unable to connect to the access point. dmesg showed something like this:
> >>
> >> [ 122.290949] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 1)
> >> [ 122.490158] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 2)
> >> [ 122.690057] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 3)
> >> [ 122.890031] wlan0: direct probe to 00:15:0c:xx:xx:xx timed out
> >>
> >> At first, I thought is was some link quality problem and tried it next
> >> to the access point, but it still didn't work.
> >> I booted another (older) kernel and with this one, the card was able to
> >> connect without any problems.
> >>
> >> I bisected the problem and came to commit
> >> 062bee448bd539580ef9f64efe50fdfe04eeb103
> >> iwlwifi: set TX_CMD_FLAG_PROT_REQUIRE_MSK in tx_flag
> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=062bee448bd539580ef9f64efe50fdfe04eeb103
> >>
> >> My wireless card is a Intel Corporation Wireless WiFi Link 5100.
> >>
> >> Will provide more info if needed.
> >>
Could you please load the iwlagn module with module parameter
debug=0x43fff and forward us the dmesg log
Thanks
Wey
>
^ permalink raw reply
* ubuntu 9.04 WLAN no
From: Arne Bahr @ 2010-07-14 15:31 UTC (permalink / raw)
To: linux-wireless
Hi,
I have a problem with my Laptop Samsung x10:
WLAN card: IEEE 802.11b
my Laptop allways says: no IP-Adress obtained
I´m pretty new with Linux and need help. All drivers are known.
Arne
--
GMX DSL: Internet-, Telefon- und Handy-Flat ab 19,99 EUR/mtl.
Bis zu 150 EUR Startguthaben inklusive! http://portal.gmx.net/de/go/dsl
^ permalink raw reply
* Re: [PATCH 2/3] ath9k_htc: implement mac80211 flush op
From: Luis R. Rodriguez @ 2010-07-14 15:37 UTC (permalink / raw)
To: Sujith; +Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
In-Reply-To: <19517.12171.792656.215696@gargle.gargle.HOWL>
On Tue, Jul 13, 2010 at 8:31 PM, Sujith <Sujith.Manoharan@atheros.com> wrote:
> Luis R. Rodriguez wrote:
>> This implements the mac80211 flush callback to let mac80211
>> flush the hardware queues when it deems appropriate.
>>
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 24 ++++++++++++++++++++++++
>> 1 files changed, 24 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>> index e38ca66..fc234a7 100644
>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>> @@ -1803,6 +1803,29 @@ static void ath9k_htc_set_coverage_class(struct ieee80211_hw *hw,
>> mutex_unlock(&priv->mutex);
>> }
>>
>> +static void ath9k_htc_flush(struct ieee80211_hw *hw, bool drop)
>> +{
>> + struct ath9k_htc_priv *priv = hw->priv;
>> + u8 cmd_rsp;
>> + int ret;
>> +
>> + mutex_lock(&priv->mutex);
>> +
>> + if (priv->op_flags & OP_INVALID)
>> + goto err;
>> +
>> + ath9k_htc_ps_wakeup(priv);
>> +
>> + WMI_CMD(WMI_DRAIN_TXQ_ALL_CMDID);
>> + if (drop)
>> + skb_queue_purge(&priv->tx_queue);
>> +
>> + ath9k_htc_ps_restore(priv);
>> +
>> +err:
>> + mutex_unlock(&priv->mutex);
>> +}
>> +
>
> I don't think this would work.
>
> Queuing of packets is done in the HIF (USB) layer.
> Flushing would require dropping (or not) the buffered packets in the
> USB layer.
Ah yes, good point, but I don't see us doing an HIF flush prior to
scan either. Even in the cas where we can rm -rf everything I don't
see us doing an HIF flush, for example device stop, or as you noted
ath9k_htc_radio_disable().
> Also, we don't actually require this, since IDLE state
> is handled in radio_disable(), where everything is flushed properly ...
flush() is for other uses, like prior to scanning, it would mean we
can remove some code from where we do flushes as mac80211 would do
that for us in proper places. It also means we can address flushing
within mac80211 instead of the core driver, and we'd do it in one
place, mac80211 instead of drivers.
Luis
^ permalink raw reply
* Re: commit 062bee448bd539580ef9f64efe50fdfe04eeb103 broke my iwlagn 5100
From: Florian Klink @ 2010-07-14 16:36 UTC (permalink / raw)
To: Guy, Wey-Yi; +Cc: Johannes Berg, linux-wireless, flokli
In-Reply-To: <1279121328.19725.27.camel@wwguy-ubuntu>
Hi,
I did a dmesg with 2.6.35-rc5 and debug=0x43fff.
You can get it here: http://pastebin.com/Q6eCdPZR
Florian
On Wed, 14 Jul 2010 08:28:48 -0700, "Guy, Wey-Yi"
<wey-yi.w.guy@intel.com> wrote:
> Hi Florian,
>
> On Wed, 2010-07-14 at 03:06 -0700, Florian Klink wrote:
>> Thanks ;-)
>>
>> On Wed, 14 Jul 2010 12:00:55 +0200, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> > [correct wey-yi's address, remove reinette]
>> >
>> > On Wed, 2010-07-14 at 11:33 +0200, Florian Klink wrote:
>> >> Hi,
>> >>
>> >> I hope I'm writing to the right addresses, this is my first kernel bug
>> >> report :-)
>> >>
>> >> I regulary build linus' tree from git. One day, my wireless card was
>> >> unable to connect to the access point. dmesg showed something like this:
>> >>
>> >> [ 122.290949] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 1)
>> >> [ 122.490158] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 2)
>> >> [ 122.690057] wlan0: direct probe to 00:15:0c:xx:xx:xx (try 3)
>> >> [ 122.890031] wlan0: direct probe to 00:15:0c:xx:xx:xx timed out
>> >>
>> >> At first, I thought is was some link quality problem and tried it next
>> >> to the access point, but it still didn't work.
>> >> I booted another (older) kernel and with this one, the card was able to
>> >> connect without any problems.
>> >>
>> >> I bisected the problem and came to commit
>> >> 062bee448bd539580ef9f64efe50fdfe04eeb103
>> >> iwlwifi: set TX_CMD_FLAG_PROT_REQUIRE_MSK in tx_flag
>> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=062bee448bd539580ef9f64efe50fdfe04eeb103
>> >>
>> >> My wireless card is a Intel Corporation Wireless WiFi Link 5100.
>> >>
>> >> Will provide more info if needed.
>> >>
> Could you please load the iwlagn module with module parameter
> debug=0x43fff and forward us the dmesg log
>
> Thanks
> Wey
>>
^ permalink raw reply
* [ANN] iw: v0.9.20
From: wireless @ 2010-07-14 17:04 UTC (permalink / raw)
To: linux-wireless
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
A new release of iw (v0.9.20) is available at:
http://wireless.kernel.org/download/iw/iw-0.9.20.tar.bz2
SHA1 sum: 75baf7d5fda2fb4e82c8c979caccc489d0170e45
Here is the short log of the changes included in this
release:
Bruno Randolf (2):
iw: fix makefile for cqm
iw: add channel command name
Christian Lamparter (1):
iw: fix ampdu spacing & max amsdu length reporting
Johannes Berg (19):
update nl80211.h
print unknown commands in supported list with number
add off-channel command
fix scan show_both_ie_sets
update nl80211.h
make commands array easier to handle
update nl80211.h
display unknown WPS TLVs
print max scan IE length
add hex parser util
allow adding IEs to scan
sync nl80211.h from wireless-testing
fix number parsing bugs
update nl80211.h from wireless-testing
allow "link" command to print something for ibss
split out multicast group adding
improve connect vs. notification race behaviour
update nl80211.h
version 0.9.20
Jouni Malinen (2):
iw: Add support for showing Beacon IEs and TIM IE
iw: Parse some common WPS attributes
Juuso Oikarinen (1):
iw: Add support for connection quality monitor configuation
Kalle Valo (1):
iw: add set/get power_save commands
Luciano Coelho (1):
iw: change install command to make it compatible with ancient coreutils
Luis R. Rodriguez (2):
iw: add country IE parsing
iw: fix typo on LDPC capability
Lukáš Turek (1):
iw: Add support for NL80211_ATTR_WIPHY_COVERAGE_CLASS
Teemu Paasikivi (1):
iw: Configure basic rates when joining ibss network
^ permalink raw reply
* Re: commit 062bee448bd539580ef9f64efe50fdfe04eeb103 broke my iwlagn 5100
From: Guy, Wey-Yi @ 2010-07-14 17:27 UTC (permalink / raw)
To: Florian Klink; +Cc: Johannes Berg, linux-wireless@vger.kernel.org
In-Reply-To: <2af581f49d0d7786326de05682b92382@imap.flokli.de>
Johannes,
On Wed, 2010-07-14 at 09:36 -0700, Florian Klink wrote:
> Hi,
>
> I did a dmesg with 2.6.35-rc5 and debug=0x43fff.
> You can get it here: http://pastebin.com/Q6eCdPZR
>
>
based on the log sent by Florian, I did not see bss_info_change with
current BSSID from mac80211. any thought?
I am expected to see something like this,
[165796.572969] ieee80211 phy3: U iwl_bss_info_changed changes =
0xFD
[165796.572972] ieee80211 phy3: U iwl_bss_info_changed BSSID
00:25:9c:d0:9f:e1
[165796.572976] ieee80211 phy3: U iwl_bss_info_changed ERP_PREAMBLE 1
Regards
Wey
^ permalink raw reply
* Re: commit 062bee448bd539580ef9f64efe50fdfe04eeb103 broke my iwlagn 5100
From: Johannes Berg @ 2010-07-14 17:36 UTC (permalink / raw)
To: Guy, Wey-Yi; +Cc: Florian Klink, linux-wireless@vger.kernel.org
In-Reply-To: <1279128461.19725.34.camel@wwguy-ubuntu>
On Wed, 2010-07-14 at 10:27 -0700, Guy, Wey-Yi wrote:
> Johannes,
>
> On Wed, 2010-07-14 at 09:36 -0700, Florian Klink wrote:
> > Hi,
> >
> > I did a dmesg with 2.6.35-rc5 and debug=0x43fff.
> > You can get it here: http://pastebin.com/Q6eCdPZR
>
> >
> >
> based on the log sent by Florian, I did not see bss_info_change with
> current BSSID from mac80211. any thought?
>
> I am expected to see something like this,
>
> [165796.572969] ieee80211 phy3: U iwl_bss_info_changed changes =
> 0xFD
> [165796.572972] ieee80211 phy3: U iwl_bss_info_changed BSSID
> 00:25:9c:d0:9f:e1
> [165796.572976] ieee80211 phy3: U iwl_bss_info_changed ERP_PREAMBLE 1
That'd only happen _after_ association, not before, and assoc fails
here.
johannes
^ permalink raw reply
* Re: commit 062bee448bd539580ef9f64efe50fdfe04eeb103 broke my iwlagn 5100
From: Guy, Wey-Yi @ 2010-07-14 17:44 UTC (permalink / raw)
To: Johannes Berg; +Cc: Florian Klink, linux-wireless@vger.kernel.org
In-Reply-To: <1279129005.3723.8.camel@jlt3.sipsolutions.net>
Hi Florian,
On Wed, 2010-07-14 at 10:36 -0700, Johannes Berg wrote:
> On Wed, 2010-07-14 at 10:27 -0700, Guy, Wey-Yi wrote:
> > Johannes,
> >
> > On Wed, 2010-07-14 at 09:36 -0700, Florian Klink wrote:
> > > Hi,
> > >
> > > I did a dmesg with 2.6.35-rc5 and debug=0x43fff.
> > > You can get it here: http://pastebin.com/Q6eCdPZR
> >
> > >
> > >
> > based on the log sent by Florian, I did not see bss_info_change with
> > current BSSID from mac80211. any thought?
> >
> > I am expected to see something like this,
> >
> > [165796.572969] ieee80211 phy3: U iwl_bss_info_changed changes =
> > 0xFD
> > [165796.572972] ieee80211 phy3: U iwl_bss_info_changed BSSID
> > 00:25:9c:d0:9f:e1
> > [165796.572976] ieee80211 phy3: U iwl_bss_info_changed ERP_PREAMBLE 1
>
> That'd only happen _after_ association, not before, and assoc fails
> here.
>
Could you try different channel instead of channel 12 to see if the
problem still there?
Thanks
Wey
>
^ permalink raw reply
* Re: [PATCH] compat-wireless: fix build of ath5k for CONFIG_PM_SLEEP=n
From: Philip A. Prindeville @ 2010-07-14 18:11 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Hauke Mehrtens, linux-wireless, mcgrof
In-Reply-To: <AANLkTilVf_eOMqvYwcz5XrSVFuk3RNLl7SoVOj-6L6Fu@mail.gmail.com>
On 07/13/2010 04:44 PM, Luis R. Rodriguez wrote:
> On Tue, Jul 13, 2010 at 2:54 PM, Luis R. Rodriguez
> <lrodriguez@atheros.com> wrote:
>> On Mon, Jul 12, 2010 at 12:19 PM, Philip A. Prindeville
>> <philipp_subx@redfish-solutions.com> wrote:
>>> On 07/12/2010 09:30 AM, Luis R. Rodriguez wrote:
>>>> On Sun, Jul 11, 2010 at 1:23 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>>>>> suspend and resume are activated in ath5k if CONFIG_PM_SLEEP is set and
>>>>> not if just CONFIG_PM is set.
>>>>>
>>>>> This should fix the problems reported by Philip Prindeville.
>>>>>
>>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>>>
>>>> Thanks! Applied and pushed out, at noon we'll have a new tarball with this.
>>>>
>>>> Luis
>>>
>>> And...
>>>
>>>
>>> CC [M] /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o
>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c: In function 'l2cap_data_channel':
>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c:4352: error: void value not ignored as it ought to be
>>> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o] Error 1
>>> make[3]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth] Error 2
>>> make[2]: *** [_module_/home/philipp/kernel/build_i586/compat-wireless-2010-07-12] Error 2
>>> make[2]: Leaving directory `/home/philipp/kernel/build_i586/linux-2.6.27.48-astlinux'
>>> make[1]: *** [modules] Error 2
>>> make[1]: Leaving directory `/home/philipp/kernel/build_i586/compat-wireless-2010-07-12'
>>> make: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/wireless/lib80211.ko] Error 2
>>
>> Thanks for reporting this, I am working on it now.
>
> This is now fixed, I'll push out a new tarball shortly.
>
> Luis
That tarball never made it out... can you please retry?
Thanks.
^ permalink raw reply
* Re: [PATCH] compat-wireless: fix build of ath5k for CONFIG_PM_SLEEP=n
From: Luis R. Rodriguez @ 2010-07-14 18:33 UTC (permalink / raw)
To: Philip A. Prindeville; +Cc: Hauke Mehrtens, linux-wireless, mcgrof
In-Reply-To: <4C3DFDB5.10904@redfish-solutions.com>
On Wed, Jul 14, 2010 at 11:11 AM, Philip A. Prindeville
<philipp_subx@redfish-solutions.com> wrote:
> On 07/13/2010 04:44 PM, Luis R. Rodriguez wrote:
>> On Tue, Jul 13, 2010 at 2:54 PM, Luis R. Rodriguez
>> <lrodriguez@atheros.com> wrote:
>>> On Mon, Jul 12, 2010 at 12:19 PM, Philip A. Prindeville
>>> <philipp_subx@redfish-solutions.com> wrote:
>>>> On 07/12/2010 09:30 AM, Luis R. Rodriguez wrote:
>>>>> On Sun, Jul 11, 2010 at 1:23 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>>>>>> suspend and resume are activated in ath5k if CONFIG_PM_SLEEP is set and
>>>>>> not if just CONFIG_PM is set.
>>>>>>
>>>>>> This should fix the problems reported by Philip Prindeville.
>>>>>>
>>>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>>>>
>>>>> Thanks! Applied and pushed out, at noon we'll have a new tarball with this.
>>>>>
>>>>> Luis
>>>>
>>>> And...
>>>>
>>>>
>>>> CC [M] /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o
>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c: In function 'l2cap_data_channel':
>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c:4352: error: void value not ignored as it ought to be
>>>> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o] Error 1
>>>> make[3]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth] Error 2
>>>> make[2]: *** [_module_/home/philipp/kernel/build_i586/compat-wireless-2010-07-12] Error 2
>>>> make[2]: Leaving directory `/home/philipp/kernel/build_i586/linux-2.6.27.48-astlinux'
>>>> make[1]: *** [modules] Error 2
>>>> make[1]: Leaving directory `/home/philipp/kernel/build_i586/compat-wireless-2010-07-12'
>>>> make: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/wireless/lib80211.ko] Error 2
>>>
>>> Thanks for reporting this, I am working on it now.
>>
>> This is now fixed, I'll push out a new tarball shortly.
>>
>> Luis
>
> That tarball never made it out... can you please retry?
The cronjob kicks off at noon PST time.
Luis
^ permalink raw reply
* Re: [PATCH 1/3] ath9k: implement mac80211 flush op
From: Luis R. Rodriguez @ 2010-07-14 18:36 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
In-Reply-To: <1279070845-29442-2-git-send-email-lrodriguez@atheros.com>
On Tue, Jul 13, 2010 at 6:27 PM, Luis R. Rodriguez
<lrodriguez@atheros.com> wrote:
> This implements the mac80211 flush callback to let mac80211
> flush the hardware queues when it deems appropriate.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
John, sorry, please hold off on this one, I need to do some more tests.
Luis
^ permalink raw reply
* Compat-wireless release for 2010-07-14 is baked
From: Compat-wireless cronjob account @ 2010-07-14 19:03 UTC (permalink / raw)
To: linux-wireless
>From git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/compat-wireless-2.6
5a1a386..73374eb master -> origin/master
bff9ce9..f88f925 wl -> origin/wl
>From git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/compat-wireless-2.6
* [new tag] compat-wireless-2010-07-13 -> compat-wireless-2010-07-13
>From git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next
122c2ee..521acd5 history -> origin/history
+ 7e28ebb...c9ce0c0 master -> origin/master (forced update)
* [new tag] next-20100714 -> next-20100714
compat-wireless code metrics
495977 - Total upstream lines of code being pulled
1425 - backport code changes
1191 - backport code additions
234 - backport code deletions
5766 - backport from compat module
7191 - total backport code
1.4499 - % of code consists of backport work
1218 - Crap changes not yet posted
1179 - Crap additions not yet posted
39 - Crap deletions not yet posted
0.2456 - % of crap code
Base tree: linux-next.git
Base tree version: next-20100714
compat-wireless release: compat-wireless-2010-07-13-1-g73374eb
^ permalink raw reply
* Re: [PATCH] compat-wireless: fix build of ath5k for CONFIG_PM_SLEEP=n
From: Philip A. Prindeville @ 2010-07-14 19:42 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Hauke Mehrtens, linux-wireless, mcgrof
In-Reply-To: <AANLkTikzEMY_Ya_QY7XkaNv441YxBcJngEoBYJUYJUA1@mail.gmail.com>
On 07/14/2010 12:33 PM, Luis R. Rodriguez wrote:
> On Wed, Jul 14, 2010 at 11:11 AM, Philip A. Prindeville
> <philipp_subx@redfish-solutions.com> wrote:
>> On 07/13/2010 04:44 PM, Luis R. Rodriguez wrote:
>>> On Tue, Jul 13, 2010 at 2:54 PM, Luis R. Rodriguez
>>> <lrodriguez@atheros.com> wrote:
>>>> On Mon, Jul 12, 2010 at 12:19 PM, Philip A. Prindeville
>>>> <philipp_subx@redfish-solutions.com> wrote:
>>>>> On 07/12/2010 09:30 AM, Luis R. Rodriguez wrote:
>>>>>> On Sun, Jul 11, 2010 at 1:23 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>>>>>>> suspend and resume are activated in ath5k if CONFIG_PM_SLEEP is set and
>>>>>>> not if just CONFIG_PM is set.
>>>>>>>
>>>>>>> This should fix the problems reported by Philip Prindeville.
>>>>>>>
>>>>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>>>>>
>>>>>> Thanks! Applied and pushed out, at noon we'll have a new tarball with this.
>>>>>>
>>>>>> Luis
>>>>>
>>>>> And...
>>>>>
>>>>>
>>>>> CC [M] /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o
>>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c: In function 'l2cap_data_channel':
>>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c:4352: error: void value not ignored as it ought to be
>>>>> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o] Error 1
>>>>> make[3]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth] Error 2
>>>>> make[2]: *** [_module_/home/philipp/kernel/build_i586/compat-wireless-2010-07-12] Error 2
>>>>> make[2]: Leaving directory `/home/philipp/kernel/build_i586/linux-2.6.27.48-astlinux'
>>>>> make[1]: *** [modules] Error 2
>>>>> make[1]: Leaving directory `/home/philipp/kernel/build_i586/compat-wireless-2010-07-12'
>>>>> make: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/wireless/lib80211.ko] Error 2
>>>>
>>>> Thanks for reporting this, I am working on it now.
>>>
>>> This is now fixed, I'll push out a new tarball shortly.
>>>
>>> Luis
>>
>> That tarball never made it out... can you please retry?
>
> The cronjob kicks off at noon PST time.
>
> Luis
Just picked up the tarball:
/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c: In function 'rt2x00pci_initialize':
/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c:156: error: implicit declaration of function 'request_threaded_irq'
make[5]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.o] Error 1
make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00] Error 2
make[4]: *** Waiting for unfinished jobs....
I'm thinking that it might be good to have a variety of nightly builds to detect damage. Do you all have infrastructure for that?
This is building against 2.6.27.48
^ permalink raw reply
* Re: [PATCH] compat-wireless: fix build of ath5k for CONFIG_PM_SLEEP=n
From: Luis R. Rodriguez @ 2010-07-14 20:32 UTC (permalink / raw)
To: Philip A. Prindeville
Cc: Luis Rodriguez, Hauke Mehrtens, linux-wireless@vger.kernel.org,
mcgrof@infradead.org
In-Reply-To: <4C3E1315.5050607@redfish-solutions.com>
On Wed, Jul 14, 2010 at 12:42:13PM -0700, Philip A. Prindeville wrote:
> On 07/14/2010 12:33 PM, Luis R. Rodriguez wrote:
> > On Wed, Jul 14, 2010 at 11:11 AM, Philip A. Prindeville
> > <philipp_subx@redfish-solutions.com> wrote:
> >> On 07/13/2010 04:44 PM, Luis R. Rodriguez wrote:
> >>> On Tue, Jul 13, 2010 at 2:54 PM, Luis R. Rodriguez
> >>> <lrodriguez@atheros.com> wrote:
> >>>> On Mon, Jul 12, 2010 at 12:19 PM, Philip A. Prindeville
> >>>> <philipp_subx@redfish-solutions.com> wrote:
> >>>>> On 07/12/2010 09:30 AM, Luis R. Rodriguez wrote:
> >>>>>> On Sun, Jul 11, 2010 at 1:23 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >>>>>>> suspend and resume are activated in ath5k if CONFIG_PM_SLEEP is set and
> >>>>>>> not if just CONFIG_PM is set.
> >>>>>>>
> >>>>>>> This should fix the problems reported by Philip Prindeville.
> >>>>>>>
> >>>>>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> >>>>>>
> >>>>>> Thanks! Applied and pushed out, at noon we'll have a new tarball with this.
> >>>>>>
> >>>>>> Luis
> >>>>>
> >>>>> And...
> >>>>>
> >>>>>
> >>>>> CC [M] /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o
> >>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c: In function 'l2cap_data_channel':
> >>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c:4352: error: void value not ignored as it ought to be
> >>>>> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o] Error 1
> >>>>> make[3]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth] Error 2
> >>>>> make[2]: *** [_module_/home/philipp/kernel/build_i586/compat-wireless-2010-07-12] Error 2
> >>>>> make[2]: Leaving directory `/home/philipp/kernel/build_i586/linux-2.6.27.48-astlinux'
> >>>>> make[1]: *** [modules] Error 2
> >>>>> make[1]: Leaving directory `/home/philipp/kernel/build_i586/compat-wireless-2010-07-12'
> >>>>> make: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/wireless/lib80211.ko] Error 2
> >>>>
> >>>> Thanks for reporting this, I am working on it now.
> >>>
> >>> This is now fixed, I'll push out a new tarball shortly.
> >>>
> >>> Luis
> >>
> >> That tarball never made it out... can you please retry?
> >
> > The cronjob kicks off at noon PST time.
> >
> > Luis
>
> Just picked up the tarball:
>
> /home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c: In function 'rt2x00pci_initialize':
> /home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c:156: error: implicit declaration of function 'request_threaded_irq'
> make[5]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.o] Error 1
> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00] Error 2
> make[4]: *** Waiting for unfinished jobs....
>
>
> I'm thinking that it might be good to have a variety of nightly builds to detect damage. Do you all have infrastructure for that?
Yeah, feel free to send patches against this to enable that:
git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/compat-user.git
Otherwise I'll get to it when I can.
> This is building against 2.6.27.48
Hauke pointed out threaded ISR stuff needs to be done as was done with b43.
Luis
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox