Linux wireless drivers development
 help / color / mirror / Atom feed
* Re: wl1271: how to use without runtime pm
From: Sergey Matyukevich @ 2010-12-30 22:08 UTC (permalink / raw)
  To: Ohad Ben-Cohen; +Cc: Luciano Coelho, linux-wireless
In-Reply-To: <AANLkTim55FJ_cBE1M7HmhVagfphntZZBLSs9NjTmK_F+@mail.gmail.com>

On Wed, 29 Dec 2010 23:22:05 +0200
Ohad Ben-Cohen <ohad@wizery.com> wrote:

> On Wed, Dec 29, 2010 at 11:07 PM, Sergey Matyukevich
> <geomatsi@gmail.com> wrote:
> > So the question is: what is the proper use of wl1271 driver in the
> > case when  wl1271 card is powered all the time ?
> 
> The wl1271 driver assumes it can control the power of the card.
> 
> If your card's power is always on, you will not be able to toggle the
> interface down and up (as you have experienced).
> 
> It might be possible to change the driver around this "limitation",
> but I'm not sure anyone has ever really tried.

A simple solution which comes to mind would be to perform some kind of
'complete soft reset procedure' for wl1271 card in the beginning of the
function 'wl1271_op_add_interface'. But I guess such a feature is not
available for this card. Qtherwise it would be already implemented by
Luciano and his colleagues.

Thanks, 
Sergey

^ permalink raw reply

* RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged skbs
From: Stephen Hemminger @ 2010-12-30 23:06 UTC (permalink / raw)
  To: Winkler, Tomas, Stephen Hemminger, Johannes Berg
  Cc: davem@davemloft.net, netdev@vger.kernel.org ,
	linux-wireless@vger.kernel.org 

QWx0aG91Z2ggY29weSBpcyBzbG93ZXIgZm9yIGxhcmdlIHBhY2tldHMsIHRoaXMgaXMgYSBub24g
cGVyZm9ybWFuY2UgcGF0aC4gVGhlIGNvZGUgaW4gcXVlc3Rpb24gaXMgZm9yIGJyaWRnZWQgbXVs
dGljYXN0IElwdjYgSUNNUCBwYWNrZXRzLiBUaGlzIGNhc2UgaXMgc28gdW5jcml0aWNhbCBpdCBj
b3VsZCBiZSBkb25lIGluIEJBU0lDIGFuZCBubyBvbmUgY291bGQgcG9zc2libHkgY2FyZSEKCiJX
aW5rbGVyLCBUb21hcyIgPHRvbWFzLndpbmtsZXJAaW50ZWwuY29tPiB3cm90ZToKCj4KPgo+PiAt
LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBTdGVwaGVuIEhlbW1pbmdlciBbbWFp
bHRvOnNoZW1taW5nZXJAdnlhdHRhLmNvbV0KPj4gU2VudDogVGh1cnNkYXksIERlY2VtYmVyIDMw
LCAyMDEwIDk6MDYgUE0KPj4gVG86IEpvaGFubmVzIEJlcmcKPj4gQ2M6IFdpbmtsZXIsIFRvbWFz
OyBkYXZlbUBkYXZlbWxvZnQubmV0OyBuZXRkZXZAdmdlci5rZXJuZWwub3JnOyBsaW51eC0KPj4g
d2lyZWxlc3NAdmdlci5rZXJuZWwub3JnCj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggbmV0LTIuNl0g
YnJpZGdlOiBmaXggYnJfbXVsdGljYXN0X2lwdjZfcmN2IGZvciBwYWdlZAo+PiBza2JzCj4+IAo+
PiBPbiBUaHUsIDMwIERlYyAyMDEwIDE5OjUyOjE0ICswMTAwCj4+IEpvaGFubmVzIEJlcmcgPGpv
aGFubmVzQHNpcHNvbHV0aW9ucy5uZXQ+IHdyb3RlOgo+PiAKPj4gPiBPbiBUaHUsIDIwMTAtMTIt
MzAgYXQgMTA6NDYgLTA4MDAsIFN0ZXBoZW4gSGVtbWluZ2VyIHdyb3RlOgo+PiA+Cj4+ID4gPiBU
aGlzIGRvZXNuJ3QgbG9vayBjb3JyZWN0LiBUaGUgY2FsY3VsYXRpb24gb2YgdGhlIG9mZnNldCBk
b2Vzbid0IGxvb2sKPj4gY29ycmVjdC4KPj4gPiA+IEp1c3QgZm9sbG93aW5nIHRoZSBza2JfY2xv
bmUoKSwgdGhlIHNrYl9wdWxsIHZhbHVlIGlzICJvZmZzZXQiLgo+PiA+ID4gQWxzbywgdGhlIG90
aGVyIGNoZWNrcyByZXR1cm4gLUVJTlZBTCBmb3IgaW5jb3JyZWN0bHkgZm9ybWVkIHBhY2tldC4K
Pj4gPiA+Cj4+ID4gPiAtLS0gYS9uZXQvYnJpZGdlL2JyX211bHRpY2FzdC5jCTIwMTAtMTItMzAg
MTA6Mjk6NTguNTc5NTEwNDg4IC0wODAwCj4+ID4gPiArKysgYi9uZXQvYnJpZGdlL2JyX211bHRp
Y2FzdC5jCTIwMTAtMTItMzAgMTA6NDM6MjcuMjczMzg2NjkxIC0wODAwCj4+ID4gPiBAQCAtMTQ2
NCw2ICsxNDY0LDkgQEAgc3RhdGljIGludCBicl9tdWx0aWNhc3RfaXB2Nl9yY3Yoc3RydWN0Cj4+
ID4gPiAgCWlmIChvZmZzZXQgPCAwIHx8IG5leHRoZHIgIT0gSVBQUk9UT19JQ01QVjYpCj4+ID4g
PiAgCQlyZXR1cm4gMDsKPj4gPiA+Cj4+ID4gPiArCWlmICghcHNrYl9tYXlfcHVsbChza2IsIG9m
ZnNldCkpCj4+ID4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPj4gPiA+ICsKPj4gPiA+ICAJLyogT2th
eSwgd2UgZm91bmQgSUNNUHY2IGhlYWRlciAqLwo+PiA+ID4gIAlza2IyID0gc2tiX2Nsb25lKHNr
YiwgR0ZQX0FUT01JQyk7Cj4+ID4gPiAgCWlmICghc2tiMikKPj4gPgo+PiA+IFdvdWxkbid0IHRo
YXQgbWFrZSBtb3JlIHNlbnNlIGFmdGVyIHRoZSBjbG9uZSBhbnl3YXk/IEJ1dCBpZiB5b3UgbG9v
ayBhdAo+PiA+IG15IGVtYWlsLCB5b3UnbGwgZmluZCB0aGF0IHRoZXJlJ3MgcG90ZW50aWFsbHks
IGFuZCBjb25kaXRpb25hbGx5LCBtb3JlCj4+ID4gc3R1ZmYgdGhhdCB3aWxsIGJlIHJlYWQgZnJv
bSB0aGUgc2tiJ3MgaGVhZGVyLCB3aGljaCBoYXNuJ3QgbmVjZXNzYXJpbHkKPj4gPiBiZWVuIHB1
bGxlZCBpbiwgc28gSSB0aGluayB0aGlzIHN0aWxsIHdvbid0IGZpeCBhbGwgdGhlIGlzc3Vlcy4K
Pj4gPgo+PiA+IFNlZWluZyBob3cgdGhpcyBvbmx5IGFmZmVjdHMgc29tZSBJQ01QdjYgcGFja2V0
cywgbWF5YmUgd2Ugc2hvdWxkIGp1c3QKPj4gPiB1c2Ugc2tiX2NvcHkoKSBpbnN0ZWFkPwo+PiAK
Pj4gSXQgY29tZXMgb3V0IGNsZWFuZXIsIGFuZCB0aGUgY2hlY2sgY2FuIGJlIHNpbXBsaWZpZWQu
Cj4+IAo+PiAtLS0gYS9uZXQvYnJpZGdlL2JyX211bHRpY2FzdC5jCTIwMTAtMTItMzAgMTA6NDc6
MTIuMDMxNzMzODU1IC0wODAwCj4+ICsrKyBiL25ldC9icmlkZ2UvYnJfbXVsdGljYXN0LmMJMjAx
MC0xMi0zMCAxMTowMDoxMi4xMzU4MDEyNjYgLTA4MDAKPj4gQEAgLTE0NjUsMTkgKzE0NjUsMTkg
QEAgc3RhdGljIGludCBicl9tdWx0aWNhc3RfaXB2Nl9yY3Yoc3RydWN0Cj4+ICAJCXJldHVybiAw
Owo+PiAKPj4gIAkvKiBPa2F5LCB3ZSBmb3VuZCBJQ01QdjYgaGVhZGVyICovCj4+IC0Jc2tiMiA9
IHNrYl9jbG9uZShza2IsIEdGUF9BVE9NSUMpOwo+PiArCXNrYjIgPSBza2JfY29weShza2IsIEdG
UF9BVE9NSUMpOwo+PiAgCWlmICghc2tiMikKPj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4+IAo+PiAr
CWVyciA9IC1FSU5WQUw7Cj4+ICsJaWYgKHNrYjItPmxlbiA8IG9mZnNldCArIHNpemVvZigqaWNt
cDZoKSkKPj4gKwkJZ290byBvdXQ7Cj4+ICsKPj4gIAlsZW4gLT0gb2Zmc2V0IC0gc2tiX25ldHdv
cmtfb2Zmc2V0KHNrYjIpOwo+PiAKPj4gIAlfX3NrYl9wdWxsKHNrYjIsIG9mZnNldCk7Cj4+ICAJ
c2tiX3Jlc2V0X3RyYW5zcG9ydF9oZWFkZXIoc2tiMik7Cj4+IAo+PiAtCWVyciA9IC1FSU5WQUw7
Cj4+IC0JaWYgKCFwc2tiX21heV9wdWxsKHNrYjIsIHNpemVvZigqaWNtcDZoKSkpCj4+IC0JCWdv
dG8gb3V0Owo+PiAtCj4+ICAJaWNtcDZoID0gaWNtcDZfaGRyKHNrYjIpOwo+PiAKPj4gIAlzd2l0
Y2ggKGljbXA2aC0+aWNtcDZfdHlwZSkgewo+PiAKPj4KPlNvcnJ5IGZvciBkdW1wIHF1ZXN0aW9u
IGJ1dCBpc24ndCB0aGVyZSBwZXJmb3JtYW5jZSBwZW5hbHR5IG9uIHVzaW5nIHNrYl9jb3B5IHZz
LiBza2JfY2xvbmU/Cj4KPkFueWhvdyBCZWxvdyBpcyBhIGNvZGUgc25pcHBldCBmcm9tIGlwNl9p
bnB1dC5jIHNvIHlvdSBwcm9iYWJseSB3b3VsZCB3YW50IHRvIGZpeCBpdCBhbGwgb3Zlci4gCj5C
VFcgb2Zmc2V0IGFuZCB0aGUgcG9pbnRlciBhcml0aG1ldGljIHJlYWxseSBnaXZlcyB0aGUgc2Ft
ZSBudW1iZXIgKzEsIEknbSBub3Qgc3VybHkgd2h5IHRoZSBvcmlnaW5hbCBhdXRob3Igd291bGQg
dGhvdWdodCBpdCBiZSBzYWZlciB0aGFuIGp1c3QgdXNpbmcgb2Zmc2V0Lgo+Cj4JCQkJCW9mZnNl
dCA9IGlwdjZfc2tpcF9leHRoZHIoc2tiLCBzaXplb2YoKmhkciksCj4gICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJm5leHRoZHIpOwo+ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAob2Zmc2V0IDwgMCkKPiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPiAKPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgaWYgKG5leHRoZHIgIT0gSVBQUk9UT19JQ01QVjYpCj4gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gCj4gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGlmICghcHNrYl9tYXlfcHVsbChza2IsIChza2JfbmV0d29y
a19oZWFkZXIoc2tiKSArCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBvZmZzZXQgKyAxIC0gc2tiLT5kYXRhKSkpCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gCj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGljbXA2ID0gKHN0cnVjdCBpY21wNmhkciAqKShza2JfbmV0d29ya19oZWFkZXIo
c2tiKSArIG9mZnNldCk7Cj4KPgo+Cj5UaGFua3MKPlRvbWFzCj4KPgo+LS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj5J
bnRlbCBJc3JhZWwgKDc0KSBMaW1pdGVkCj4KPlRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVu
dHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIG1hdGVyaWFsIGZvcgo+dGhlIHNvbGUgdXNlIG9m
IHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCj5i
eSBvdGhlcnMgaXMgc3RyaWN0bHkgcHJvaGliaXRlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVu
ZGVkCj5yZWNpcGllbnQsIHBsZWFzZSBjb250YWN0IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwg
Y29waWVzLgo+Cg==


^ permalink raw reply

* [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 arch/m68k/ifpsp060/src/fpsp.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/ifpsp060/src/fpsp.S b/arch/m68k/ifpsp060/src/fpsp.S
index 73613b5..26e85e2 100644
--- a/arch/m68k/ifpsp060/src/fpsp.S
+++ b/arch/m68k/ifpsp060/src/fpsp.S
@@ -3881,7 +3881,7 @@ _fpsp_fline:
 # FP Unimplemented Instruction stack frame and jump to that entry
 # point.
 #
-# but, if the FPU is disabled, then we need to jump to the FPU diabled
+# but, if the FPU is disabled, then we need to jump to the FPU disabled
 # entry point.
 	movc		%pcr,%d0
 	btst		&0x1,%d0
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-1-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/spi/dw_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 0838c79..7c3cf21 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
 		spi_set_clk(dws, clk_div ? clk_div : chip->clk_div);
 		spi_chip_sel(dws, spi->chip_select);
 
-		/* Set the interrupt mask, for poll mode just diable all int */
+		/* Set the interrupt mask, for poll mode just disable all int */
 		spi_mask_intr(dws, 0xff);
 		if (imask)
 			spi_umask_intr(dws, imask);
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-2-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/rtl8187se/r8180_hw.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h
index 3fca144..2911d40 100644
--- a/drivers/staging/rtl8187se/r8180_hw.h
+++ b/drivers/staging/rtl8187se/r8180_hw.h
@@ -554,7 +554,7 @@
 /* by amy for power save		*/
 /* by amy for antenna			*/
 #define EEPROM_SW_REVD_OFFSET 0x3f
-/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable.					*/
+/*  BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled.					*/
 #define EEPROM_SW_AD_MASK			0x0300
 #define EEPROM_SW_AD_ENABLE			0x0100
 
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 04/15]drivers:staging:comedi:drivers:das800.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-3-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/comedi/drivers/das800.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
index aecaedc..3ecae47 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -450,7 +450,7 @@ static irqreturn_t das800_interrupt(int irq, void *d)
 		/* otherwise, stop taking data */
 	} else {
 		spin_unlock_irqrestore(&dev->spinlock, irq_flags);
-		disable_das800(dev);	/* diable hardware triggered conversions */
+		disable_das800(dev);	/* disable hardware triggered conversions */
 		async->events |= COMEDI_CB_EOA;
 	}
 	comedi_event(dev, s);
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 05/15]drivers:staging:vt6655:rf.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-4-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/vt6655/rf.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index b8ec783..cdd9165 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -496,11 +496,11 @@ bool s_bAL7230Init (unsigned long dwIoBase)
 
     //Calibration
     MACvTimer0MicroSDelay(dwIoBase, 150);//150us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:diable
+    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x9ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:active, RCK:disable
     MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:diable, RCK:active
+    bResult &= IFRFbWriteEmbeded(dwIoBase, (0x3ABA8F00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW)); //TXDCOC:disable, RCK:active
     MACvTimer0MicroSDelay(dwIoBase, 30);//30us
-    bResult &= IFRFbWriteEmbeded(dwIoBase, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:diable
+    bResult &= IFRFbWriteEmbeded(dwIoBase, dwAL7230InitTable[CB_AL7230_INIT_SEQ-1]); //TXDCOC:diable, RCK:disable
 
     MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, (SOFTPWRCTL_SWPE3    |
                                                      SOFTPWRCTL_SWPE2    |
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 06/15]drivers:staging:xgifb:vb_setmode.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-5-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/staging/xgifb/vb_setmode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 7016fdd..fb49641 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1920,7 +1920,7 @@ void XGI_SetCRT1FIFO(unsigned short ModeNo,
 
 	data = XGINew_GetReg1(pVBInfo->P3c4, 0x3D);
 	data &= 0xfe;
-	XGINew_SetReg1(pVBInfo->P3c4, 0x3D, data); /* diable auto-threshold */
+	XGINew_SetReg1(pVBInfo->P3c4, 0x3D, data); /* disable auto-threshold */
 
 	if (ModeNo > 0x13) {
 		XGINew_SetReg1(pVBInfo->P3c4, 0x08, 0x34);
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-6-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/net/wireless/iwlwifi/iwl-agn-ict.c |    2 +-
 drivers/net/wireless/iwlwifi/iwl-agn.c     |    4 ++--
 drivers/net/wireless/iwlwifi/iwl-core.c    |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
index a5dbfea..b5cb3be 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
@@ -197,7 +197,7 @@ static irqreturn_t iwl_isr(int irq, void *data)
 
  none:
 	/* re-enable interrupts here since we don't have anything to service. */
-	/* only Re-enable if diabled by irq  and no schedules tasklet. */
+	/* only Re-enable if disabled by irq  and no schedules tasklet. */
 	if (test_bit(STATUS_INT_ENABLED, &priv->status) && !priv->_agn.inta)
 		iwl_enable_interrupts(priv);
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index c2636a7..9b912c0 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1316,7 +1316,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
 	}
 
 	/* Re-enable all interrupts */
-	/* only Re-enable if diabled by irq */
+	/* only Re-enable if disabled by irq */
 	if (test_bit(STATUS_INT_ENABLED, &priv->status))
 		iwl_enable_interrupts(priv);
 
@@ -1530,7 +1530,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
 	}
 
 	/* Re-enable all interrupts */
-	/* only Re-enable if diabled by irq */
+	/* only Re-enable if disabled by irq */
 	if (test_bit(STATUS_INT_ENABLED, &priv->status))
 		iwl_enable_interrupts(priv);
 }
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index 25fb391..8700ab3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -1304,7 +1304,7 @@ irqreturn_t iwl_isr_legacy(int irq, void *data)
 
  none:
 	/* re-enable interrupts here since we don't have anything to service. */
-	/* only Re-enable if diabled by irq */
+	/* only Re-enable if disabled by irq */
 	if (test_bit(STATUS_INT_ENABLED, &priv->status))
 		iwl_enable_interrupts(priv);
 	spin_unlock_irqrestore(&priv->lock, flags);
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-7-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/scsi/lpfc/lpfc_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index b306579..a921f16 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7661,7 +7661,7 @@ lpfc_pci_remove_one_s3(struct pci_dev *pdev)
 	 * the HBA.
 	 */
 
-	/* HBA interrupt will be diabled after this call */
+	/* HBA interrupt will be disabled after this call */
 	lpfc_sli_hba_down(phba);
 	/* Stop kthread signal shall trigger work_done one more time */
 	kthread_stop(phba->worker_thread);
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 09/15]drivers:usb:host Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-8-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable" and also fixes another typo in a comment. 
Please let me know if this is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/usb/host/fhci-hcd.c |    4 ++--
 drivers/usb/host/fhci-tds.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 20092a2..12fd184 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -98,13 +98,13 @@ void fhci_usb_enable_interrupt(struct fhci_usb *usb)
 	usb->intr_nesting_cnt--;
 }
 
-/* diable the usb interrupt */
+/* disable the usb interrupt */
 void fhci_usb_disable_interrupt(struct fhci_usb *usb)
 {
 	struct fhci_hcd *fhci = usb->fhci;
 
 	if (usb->intr_nesting_cnt == 0) {
-		/* diable the timer interrupt */
+		/* disable the timer interrupt */
 		disable_irq_nosync(fhci->timer->irq);
 
 		/* disable the usb interrupt */
diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c
index 7be548c..38fe058 100644
--- a/drivers/usb/host/fhci-tds.c
+++ b/drivers/usb/host/fhci-tds.c
@@ -271,8 +271,8 @@ void fhci_init_ep_registers(struct fhci_usb *usb, struct endpoint *ep,
 
 /*
  * Collect the submitted frames and inform the application about them
- * It is also prepearing the TDs for new frames. If the Tx interrupts
- * are diabled, the application should call that routine to get
+ * It is also preparing the TDs for new frames. If the Tx interrupts
+ * are disabled, the application should call that routine to get
  * confirmation about the submitted frames. Otherwise, the routine is
  * called frome the interrupt service routine during the Tx interrupt.
  * In that case the application is informed by calling the application
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 10/15]drivers:usb:gadget:langwell Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:07 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-9-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not. 

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/usb/gadget/langwell_udc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/langwell_udc.c b/drivers/usb/gadget/langwell_udc.c
index b8ec954..dad278f 100644
--- a/drivers/usb/gadget/langwell_udc.c
+++ b/drivers/usb/gadget/langwell_udc.c
@@ -3063,7 +3063,7 @@ static void langwell_udc_remove(struct pci_dev *pdev)
 
 	kfree(dev->ep);
 
-	/* diable IRQ handler */
+	/* disable IRQ handler */
 	if (dev->got_irq)
 		free_irq(pdev->irq, dev);
 
@@ -3383,7 +3383,7 @@ static int langwell_udc_suspend(struct pci_dev *pdev, pm_message_t state)
 	/* disable interrupt and set controller to stop state */
 	langwell_udc_stop(dev);
 
-	/* diable IRQ handler */
+	/* disable IRQ handler */
 	if (dev->got_irq)
 		free_irq(pdev->irq, dev);
 	dev->got_irq = 0;
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:08 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-10-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/media/video/cx18/cx23418.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
index 2c00980..7e40035 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -177,7 +177,7 @@
    IN[0] - Task handle.
    IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only,
 		      3 = 2D H/V separable, 4 = 2D symmetric non-separable
-   IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
+   IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
    ReturnCode - One of the ERR_CAPTURE_... */
 #define CX18_CPU_SET_SPATIAL_FILTER_TYPE     	(CPU_CMD_MASK_CAPTURE | 0x000C)
 
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:08 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-11-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/media/video/tvp7002.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index e63b40f..c799e4e 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
  * Get the value of a TVP7002 decoder device register.
  * Returns zero when successful, -EINVAL if register read fails or
  * access to I2C client fails, -EPERM if the call is not allowed
- * by diabled CAP_SYS_ADMIN.
+ * by disabled CAP_SYS_ADMIN.
  */
 static int tvp7002_g_register(struct v4l2_subdev *sd,
 						struct v4l2_dbg_register *reg)
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 13/15]drivers:isdn:mISDN:dsp_cmx.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:08 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-12-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/isdn/mISDN/dsp_cmx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_cmx.c b/drivers/isdn/mISDN/dsp_cmx.c
index 76d9e67..309bacf 100644
--- a/drivers/isdn/mISDN/dsp_cmx.c
+++ b/drivers/isdn/mISDN/dsp_cmx.c
@@ -112,7 +112,7 @@
  * Disable rx-data:
  * If cmx is realized in hardware, rx data will be disabled if requested by
  * the upper layer. If dtmf decoding is done by software and enabled, rx data
- * will not be diabled but blocked to the upper layer.
+ * will not be disabled but blocked to the upper layer.
  *
  * HFC conference engine:
  * If it is possible to realize all features using hardware, hardware will be
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:08 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-13-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this 
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 include/media/davinci/vpss.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
index c59cc02..b586495 100644
--- a/include/media/davinci/vpss.h
+++ b/include/media/davinci/vpss.h
@@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
 	short pplen;
 };
 
-/* Used for enable/diable VPSS Clock */
+/* Used for enable/disable VPSS Clock */
 enum vpss_clock_sel {
 	/* DM355/DM365 */
 	VPSS_CCDC_CLOCK,
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-30 23:08 UTC (permalink / raw)
  To: trivial
  Cc: linux-m68k, linux-kernel, netdev, ivtv-devel, linux-media,
	linux-wireless, linux-scsi, spi-devel-general, devel, linux-usb,
	Justin P. Mattock
In-Reply-To: <1293750484-1161-14-git-send-email-justinmattock@gmail.com>

The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/spi/dw_spi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
index 7c3cf21..a3a065f 100644
--- a/drivers/spi/dw_spi.c
+++ b/drivers/spi/dw_spi.c
@@ -910,12 +910,12 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
 	ret = init_queue(dws);
 	if (ret) {
 		dev_err(&master->dev, "problem initializing queue\n");
-		goto err_diable_hw;
+		goto err_disable_hw;
 	}
 	ret = start_queue(dws);
 	if (ret) {
 		dev_err(&master->dev, "problem starting queue\n");
-		goto err_diable_hw;
+		goto err_disable_hw;
 	}
 
 	spi_master_set_devdata(master, dws);
@@ -930,7 +930,7 @@ int __devinit dw_spi_add_host(struct dw_spi *dws)
 
 err_queue_alloc:
 	destroy_queue(dws);
-err_diable_hw:
+err_disable_hw:
 	spi_enable_chip(dws, 0);
 	free_irq(dws->irq, dws);
 err_free_master:
-- 
1.6.5.2.180.gc5b3e


^ permalink raw reply related

* Re: Get slow speed when using ar9170usb driver.
From: Christian Lamparter @ 2010-12-30 23:27 UTC (permalink / raw)
  To: Chin Shi Hong; +Cc: linux-wireless
In-Reply-To: <AANLkTikeehA_cMHndCRidknqVc7Y49_JmPbt4+Np6jDx@mail.gmail.com>

On Thursday 30 December 2010 16:55:18 Chin Shi Hong wrote:
> Dear All,

Hello,

> Wireless adapter model: TP-LINK WN821NC (USB 300Mbps Wireless N adapter)
> Output of lsusb: Bus 001 Device 007: ID 0cf3:1002 Atheros
> Communications, Inc. TP-Link TL-WN821N v2 [Atheros AR9001U-(2)NG]
> Wireless router: TP-LINK W8960N (300Mbps Wireless N router)

That's weird, according to TP-Link's website there wasn't any WN821NC
with a WN821N v2. They "only" let you download the driver for
WN821N v3. v3 very different from the previous v2 generation, it has
new chips (AR7015+AR9287?) and needs the ath9k_htc driver.

Are you sure, you didn't get ripped off here and someone else
has "your" v3?

> Driver name ar9170usb
> Linux distro: Ubuntu 10.10 64 bit
> Kernel version: 2.6.35-24-generic
> 
> If I use Ndiswrapper + Windows XP driver, I can get full 300Mbps.
Have you measured that (with iperf/netperf)? Or is it just the
"Connection Information" pop-up which simply displays "speed: 300 Mbits" ?

> At the same distance, if I use ar9170usb driver, I can only get
> maximum 54Mbps speed.
That's true. here's ar9170usb wiki page:
<http://wireless.kernel.org/en/users/Drivers/ar9170#features> => working
	"802.11 a/b/g"

Also, the old stack (in 2.6.35) does not have minstrel_ht
(rate control algorithm for 11n) so ar9170usb is limited to
the legacy b/g rates.

Furthermore, the old driver lacks any support for aggregation, so the
uplink throughput (even with the fastest 300 mbits rate and under
"perfect" lab conditions) would struggle to get to 40 mbit and beyond.

--

The quickest way around limitations is via backports:
visit <http://wireless.kernel.org/en/users/Download>
and get compat-wireless:

<http://wireless.kernel.org/en/users/Download#Getting_compat-wireless_on_Ubuntu>

Then, you can migrate to carl9170 (a new driver with a new firmware)
for more information, see:
<http://wireless.kernel.org/en/users/Drivers/carl9170>

However, this "new" driver+fw is still in development. You definitely
want to keep your compat-wireless package up-to-date.

Best Regards,
	Christian

^ permalink raw reply

* RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged skbs
From: Winkler, Tomas @ 2010-12-30 23:29 UTC (permalink / raw)
  To: Stephen Hemminger, Stephen Hemminger, Johannes Berg
  Cc: davem@davemloft.net, netdev@vger.kernel.org ,
	linux-wireless@vger.kernel.org 
In-Reply-To: <9mk4bme8o97ir27xi8a9fbsd.1293750376929@email.android.com>

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU3RlcGhlbiBIZW1taW5n
ZXIgW21haWx0bzpzdGVwaGVuLmhlbW1pbmdlckB2eWF0dGEuY29tXQ0KPiBTZW50OiBGcmlkYXks
IERlY2VtYmVyIDMxLCAyMDEwIDE6MDYgQU0NCj4gVG86IFdpbmtsZXIsIFRvbWFzOyBTdGVwaGVu
IEhlbW1pbmdlcjsgSm9oYW5uZXMgQmVyZw0KPiBDYzogZGF2ZW1AZGF2ZW1sb2Z0Lm5ldDsgbmV0
ZGV2QHZnZXIua2VybmVsLm9yZyA7IGxpbnV4LQ0KPiB3aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmcN
Cj4gU3ViamVjdDogUkU6IFtQQVRDSCBuZXQtMi42XSBicmlkZ2U6IGZpeCBicl9tdWx0aWNhc3Rf
aXB2Nl9yY3YgZm9yIHBhZ2VkDQo+IHNrYnMNCj4gDQo+IEFsdGhvdWdoIGNvcHkgaXMgc2xvd2Vy
IGZvciBsYXJnZSBwYWNrZXRzLCB0aGlzIGlzIGEgbm9uIHBlcmZvcm1hbmNlIHBhdGguDQo+IFRo
ZSBjb2RlIGluIHF1ZXN0aW9uIGlzIGZvciBicmlkZ2VkIG11bHRpY2FzdCBJcHY2IElDTVAgcGFj
a2V0cy4gVGhpcyBjYXNlDQo+IGlzIHNvIHVuY3JpdGljYWwgaXQgY291bGQgYmUgZG9uZSBpbiBC
QVNJQyBhbmQgbm8gb25lIGNvdWxkIHBvc3NpYmx5IGNhcmUhDQo+IA0KDQoNCkZhaXIgZW5vdWdo
LCBhbHRob3VnaCB5b3UgZ290IGZldyBvZiB0aG9zZSB3aGVuIHlvdSBjb25uZWN0IHRvIHdpbjcg
Y2xpZW50LiANCkFueWhvdyBteSBmaXggd291bGQgd29yayBpZiB0aGUgc2Vjb25kIHB1bGwgd291
bGQgYmUgDQogIGlmICghcHNrYl9tYXlfcHVsbChza2IyLCBzaXplb2Yoc3RydWN0IG1sZF9tc2cp
KSkgIGluc3RlYWQgb2YgICghcHNrYl9tYXlfcHVsbChza2IyLCBzaXplb2YoKmljbXA2aCkpKQ0K
DQpTZWNvbmQgSSB0aGluayBqdXN0IHRoYXQgbm9uIG11bHRpY2FzdCBwbGFjZXMgc2hvdWxkbid0
IGJlIGZpeGVkIGNvbnRyYXJ5IHRvIG15IHByZXZpb3VzIHN1Z2dlc3Rpb24gYXMgdGhlDQpza2Jf
bmV0d29ya19oZWFkZXIoc2tiKSArIG9mZnNldCArIDEgLSBza2ItPmRhdGEgd2lsbCBnaXZlIHlv
dSBjb3JyZWN0IG9mZnNldCB0byBwdWxsIHVwIGlmIHRoZSBuZXR3b3JrIGhlYWRlciBpcyBub3Qg
b24gc2tiLT5kYXRhLg0KDQoNClRoYW5rcw0KVG9tYXMNCg0KPiAiV2lua2xlciwgVG9tYXMiIDx0
b21hcy53aW5rbGVyQGludGVsLmNvbT4gd3JvdGU6DQo+IA0KPiA+DQo+ID4NCj4gPj4gLS0tLS1P
cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogU3RlcGhlbiBIZW1taW5nZXIgW21haWx0
bzpzaGVtbWluZ2VyQHZ5YXR0YS5jb21dDQo+ID4+IFNlbnQ6IFRodXJzZGF5LCBEZWNlbWJlciAz
MCwgMjAxMCA5OjA2IFBNDQo+ID4+IFRvOiBKb2hhbm5lcyBCZXJnDQo+ID4+IENjOiBXaW5rbGVy
LCBUb21hczsgZGF2ZW1AZGF2ZW1sb2Z0Lm5ldDsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgbGlu
dXgtDQo+ID4+IHdpcmVsZXNzQHZnZXIua2VybmVsLm9yZw0KPiA+PiBTdWJqZWN0OiBSZTogW1BB
VENIIG5ldC0yLjZdIGJyaWRnZTogZml4IGJyX211bHRpY2FzdF9pcHY2X3JjdiBmb3IgcGFnZWQN
Cj4gPj4gc2ticw0KPiA+Pg0KPiA+PiBPbiBUaHUsIDMwIERlYyAyMDEwIDE5OjUyOjE0ICswMTAw
DQo+ID4+IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzQHNpcHNvbHV0aW9ucy5uZXQ+IHdyb3RlOg0K
PiA+Pg0KPiA+PiA+IE9uIFRodSwgMjAxMC0xMi0zMCBhdCAxMDo0NiAtMDgwMCwgU3RlcGhlbiBI
ZW1taW5nZXIgd3JvdGU6DQo+ID4+ID4NCj4gPj4gPiA+IFRoaXMgZG9lc24ndCBsb29rIGNvcnJl
Y3QuIFRoZSBjYWxjdWxhdGlvbiBvZiB0aGUgb2Zmc2V0IGRvZXNuJ3QgbG9vaw0KPiA+PiBjb3Jy
ZWN0Lg0KPiA+PiA+ID4gSnVzdCBmb2xsb3dpbmcgdGhlIHNrYl9jbG9uZSgpLCB0aGUgc2tiX3B1
bGwgdmFsdWUgaXMgIm9mZnNldCIuDQo+ID4+ID4gPiBBbHNvLCB0aGUgb3RoZXIgY2hlY2tzIHJl
dHVybiAtRUlOVkFMIGZvciBpbmNvcnJlY3RseSBmb3JtZWQgcGFja2V0Lg0KPiA+PiA+ID4NCj4g
Pj4gPiA+IC0tLSBhL25ldC9icmlkZ2UvYnJfbXVsdGljYXN0LmMJMjAxMC0xMi0zMCAxMDoyOTo1
OC41Nzk1MTA0ODggLTA4MDANCj4gPj4gPiA+ICsrKyBiL25ldC9icmlkZ2UvYnJfbXVsdGljYXN0
LmMJMjAxMC0xMi0zMCAxMDo0MzoyNy4yNzMzODY2OTEgLTA4MDANCj4gPj4gPiA+IEBAIC0xNDY0
LDYgKzE0NjQsOSBAQCBzdGF0aWMgaW50IGJyX211bHRpY2FzdF9pcHY2X3JjdihzdHJ1Y3QNCj4g
Pj4gPiA+ICAJaWYgKG9mZnNldCA8IDAgfHwgbmV4dGhkciAhPSBJUFBST1RPX0lDTVBWNikNCj4g
Pj4gPiA+ICAJCXJldHVybiAwOw0KPiA+PiA+ID4NCj4gPj4gPiA+ICsJaWYgKCFwc2tiX21heV9w
dWxsKHNrYiwgb2Zmc2V0KSkNCj4gPj4gPiA+ICsJCXJldHVybiAtRUlOVkFMOw0KPiA+PiA+ID4g
Kw0KPiA+PiA+ID4gIAkvKiBPa2F5LCB3ZSBmb3VuZCBJQ01QdjYgaGVhZGVyICovDQo+ID4+ID4g
PiAgCXNrYjIgPSBza2JfY2xvbmUoc2tiLCBHRlBfQVRPTUlDKTsNCj4gPj4gPiA+ICAJaWYgKCFz
a2IyKQ0KPiA+PiA+DQo+ID4+ID4gV291bGRuJ3QgdGhhdCBtYWtlIG1vcmUgc2Vuc2UgYWZ0ZXIg
dGhlIGNsb25lIGFueXdheT8gQnV0IGlmIHlvdSBsb29rDQo+IGF0DQo+ID4+ID4gbXkgZW1haWws
IHlvdSdsbCBmaW5kIHRoYXQgdGhlcmUncyBwb3RlbnRpYWxseSwgYW5kIGNvbmRpdGlvbmFsbHks
IG1vcmUNCj4gPj4gPiBzdHVmZiB0aGF0IHdpbGwgYmUgcmVhZCBmcm9tIHRoZSBza2IncyBoZWFk
ZXIsIHdoaWNoIGhhc24ndCBuZWNlc3NhcmlseQ0KPiA+PiA+IGJlZW4gcHVsbGVkIGluLCBzbyBJ
IHRoaW5rIHRoaXMgc3RpbGwgd29uJ3QgZml4IGFsbCB0aGUgaXNzdWVzLg0KPiA+PiA+DQo+ID4+
ID4gU2VlaW5nIGhvdyB0aGlzIG9ubHkgYWZmZWN0cyBzb21lIElDTVB2NiBwYWNrZXRzLCBtYXli
ZSB3ZSBzaG91bGQganVzdA0KPiA+PiA+IHVzZSBza2JfY29weSgpIGluc3RlYWQ/DQo+ID4+DQo+
ID4+IEl0IGNvbWVzIG91dCBjbGVhbmVyLCBhbmQgdGhlIGNoZWNrIGNhbiBiZSBzaW1wbGlmaWVk
Lg0KPiA+Pg0KPiA+PiAtLS0gYS9uZXQvYnJpZGdlL2JyX211bHRpY2FzdC5jCTIwMTAtMTItMzAg
MTA6NDc6MTIuMDMxNzMzODU1IC0wODAwDQo+ID4+ICsrKyBiL25ldC9icmlkZ2UvYnJfbXVsdGlj
YXN0LmMJMjAxMC0xMi0zMCAxMTowMDoxMi4xMzU4MDEyNjYgLTA4MDANCj4gPj4gQEAgLTE0NjUs
MTkgKzE0NjUsMTkgQEAgc3RhdGljIGludCBicl9tdWx0aWNhc3RfaXB2Nl9yY3Yoc3RydWN0DQo+
ID4+ICAJCXJldHVybiAwOw0KPiA+Pg0KPiA+PiAgCS8qIE9rYXksIHdlIGZvdW5kIElDTVB2NiBo
ZWFkZXIgKi8NCj4gPj4gLQlza2IyID0gc2tiX2Nsb25lKHNrYiwgR0ZQX0FUT01JQyk7DQo+ID4+
ICsJc2tiMiA9IHNrYl9jb3B5KHNrYiwgR0ZQX0FUT01JQyk7DQo+ID4+ICAJaWYgKCFza2IyKQ0K
PiA+PiAgCQlyZXR1cm4gLUVOT01FTTsNCj4gPj4NCj4gPj4gKwllcnIgPSAtRUlOVkFMOw0KPiA+
PiArCWlmIChza2IyLT5sZW4gPCBvZmZzZXQgKyBzaXplb2YoKmljbXA2aCkpDQo+ID4+ICsJCWdv
dG8gb3V0Ow0KPiA+PiArDQo+ID4+ICAJbGVuIC09IG9mZnNldCAtIHNrYl9uZXR3b3JrX29mZnNl
dChza2IyKTsNCj4gPj4NCj4gPj4gIAlfX3NrYl9wdWxsKHNrYjIsIG9mZnNldCk7DQo+ID4+ICAJ
c2tiX3Jlc2V0X3RyYW5zcG9ydF9oZWFkZXIoc2tiMik7DQo+ID4+DQo+ID4+IC0JZXJyID0gLUVJ
TlZBTDsNCj4gPj4gLQlpZiAoIXBza2JfbWF5X3B1bGwoc2tiMiwgc2l6ZW9mKCppY21wNmgpKSkN
Cj4gPj4gLQkJZ290byBvdXQ7DQo+ID4+IC0NCj4gPj4gIAlpY21wNmggPSBpY21wNl9oZHIoc2ti
Mik7DQo+ID4+DQo+ID4+ICAJc3dpdGNoIChpY21wNmgtPmljbXA2X3R5cGUpIHsNCj4gPj4NCj4g
Pj4NCj4gPlNvcnJ5IGZvciBkdW1wIHF1ZXN0aW9uIGJ1dCBpc24ndCB0aGVyZSBwZXJmb3JtYW5j
ZSBwZW5hbHR5IG9uIHVzaW5nDQo+IHNrYl9jb3B5IHZzLiBza2JfY2xvbmU/DQo+ID4NCj4gPkFu
eWhvdyBCZWxvdyBpcyBhIGNvZGUgc25pcHBldCBmcm9tIGlwNl9pbnB1dC5jIHNvIHlvdSBwcm9i
YWJseSB3b3VsZCB3YW50DQo+IHRvIGZpeCBpdCBhbGwgb3Zlci4NCj4gPkJUVyBvZmZzZXQgYW5k
IHRoZSBwb2ludGVyIGFyaXRobWV0aWMgcmVhbGx5IGdpdmVzIHRoZSBzYW1lIG51bWJlciArMSwg
SSdtDQo+IG5vdCBzdXJseSB3aHkgdGhlIG9yaWdpbmFsIGF1dGhvciB3b3VsZCB0aG91Z2h0IGl0
IGJlIHNhZmVyIHRoYW4ganVzdCB1c2luZw0KPiBvZmZzZXQuDQo+ID4NCj4gPgkJCQkJb2Zmc2V0
ID0gaXB2Nl9za2lwX2V4dGhkcihza2IsDQo+IHNpemVvZigqaGRyKSwNCj4gPiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmbmV4dGhkcik7
DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChvZmZzZXQgPCAwKQ0KPiA+
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPiA+DQo+
ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChuZXh0aGRyICE9IElQUFJPVE9f
SUNNUFY2KQ0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8g
b3V0Ow0KPiA+DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghcHNrYl9t
YXlfcHVsbChza2IsDQo+IChza2JfbmV0d29ya19oZWFkZXIoc2tiKSArDQo+ID4gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvZmZzZXQgKyAxIC0gc2ti
LQ0KPiA+ZGF0YSkpKQ0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGdvdG8gb3V0Ow0KPiA+DQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGljbXA2
ID0gKHN0cnVjdCBpY21wNmhkcg0KPiAqKShza2JfbmV0d29ya19oZWFkZXIoc2tiKSArIG9mZnNl
dCk7DQo+ID4NCj4gPg0KPiA+DQo+ID5UaGFua3MNCj4gPlRvbWFzDQo+ID4NCj4gPg0KPiA+LS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tDQo+ID5JbnRlbCBJc3JhZWwgKDc0KSBMaW1pdGVkDQo+ID4NCj4gPlRoaXMgZS1t
YWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIG1hdGVyaWFs
IGZvcg0KPiA+dGhlIHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSBy
ZXZpZXcgb3IgZGlzdHJpYnV0aW9uDQo+ID5ieSBvdGhlcnMgaXMgc3RyaWN0bHkgcHJvaGliaXRl
ZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkDQo+ID5yZWNpcGllbnQsIHBsZWFzZSBjb250
YWN0IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLg0KPiA+DQotLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K
SW50ZWwgSXNyYWVsICg3NCkgTGltaXRlZAoKVGhpcyBlLW1haWwgYW5kIGFueSBhdHRhY2htZW50
cyBtYXkgY29udGFpbiBjb25maWRlbnRpYWwgbWF0ZXJpYWwgZm9yCnRoZSBzb2xlIHVzZSBvZiB0
aGUgaW50ZW5kZWQgcmVjaXBpZW50KHMpLiBBbnkgcmV2aWV3IG9yIGRpc3RyaWJ1dGlvbgpieSBv
dGhlcnMgaXMgc3RyaWN0bHkgcHJvaGliaXRlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVk
CnJlY2lwaWVudCwgcGxlYXNlIGNvbnRhY3QgdGhlIHNlbmRlciBhbmQgZGVsZXRlIGFsbCBjb3Bp
ZXMuCg==


^ permalink raw reply

* Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
From: Michael Büsch @ 2010-12-31  1:57 UTC (permalink / raw)
  To: Mario 'BitKoenig' Holbe; +Cc: Larry Finger, LKML, wireless, b43-dev
In-Reply-To: <20101230204522.GC23219@darkside.kls.lan>

On Thu, 2010-12-30 at 21:45 +0100, Mario 'BitKoenig' Holbe wrote: 
> On Thu, Dec 30, 2010 at 12:37:21PM -0600, Larry Finger wrote:
> > The head of the rng_list is damaged. It is initialized at compile time and
> > should be OK. To help discover the order in which hwrng_register() is called,
> > apply the attached patch. Run it once with commit 84c164a34ffe67908a installed,
> > and once with it reverted.
> 
> All right, 3 dmesg excerpts attached...
> 2.6.37-rc7-vanilla.dmesg:
> 	2.6.37-rc7 vanilla (i.e. with 84c164a34ffe67908a), crashing
> 	via-rng is registered first, b43-rng second
> 2.6.37-rc7-without.dmesg:
> 	2.6.37-rc7 with 84c164a34ffe67908a reverted, not crashing
> 	b43-rng is registered first, via-rng second
> 2.6.37-rc7-without+modprobe.dmesg:
> 	2.6.37-rc7 with 84c164a34ffe67908a reverted, b43 blacklisted and
> 	manually modprobed after via-rng, crashing
> 	via-rng is registered first, b43-rng second
> 
> Seems like the crash shows up when b43-rng is registered second, but not
> when via-rng is registered second.
> Btw.: `cat rng_available' does also not crash when via-rng is registered
> second.


I suspect that there is some "hw_random.h" header version mixup is going
on here. The layout of struct hwrng was changed recently.

Your crash seems to happen on the list head embedded in struct hwrng.

Please make sure that your build environment is clean and you're not
using any external stuff such as compat-wireless. All of hwrng-core,
rng-via and b43 must be compiled against the same hw_random.h.

-- 
Greetings Michael.


^ permalink raw reply

* Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
From: Larry Finger @ 2010-12-31  2:25 UTC (permalink / raw)
  To: Michael Büsch
  Cc: Mario 'BitKoenig' Holbe, LKML, wireless, b43-dev
In-Reply-To: <1293760653.6528.78.camel@maggie>

On 12/30/2010 07:57 PM, Michael Büsch wrote:
> On Thu, 2010-12-30 at 21:45 +0100, Mario 'BitKoenig' Holbe wrote: 
>> On Thu, Dec 30, 2010 at 12:37:21PM -0600, Larry Finger wrote:
>>> The head of the rng_list is damaged. It is initialized at compile time and
>>> should be OK. To help discover the order in which hwrng_register() is called,
>>> apply the attached patch. Run it once with commit 84c164a34ffe67908a installed,
>>> and once with it reverted.
>>
>> All right, 3 dmesg excerpts attached...
>> 2.6.37-rc7-vanilla.dmesg:
>> 	2.6.37-rc7 vanilla (i.e. with 84c164a34ffe67908a), crashing
>> 	via-rng is registered first, b43-rng second
>> 2.6.37-rc7-without.dmesg:
>> 	2.6.37-rc7 with 84c164a34ffe67908a reverted, not crashing
>> 	b43-rng is registered first, via-rng second
>> 2.6.37-rc7-without+modprobe.dmesg:
>> 	2.6.37-rc7 with 84c164a34ffe67908a reverted, b43 blacklisted and
>> 	manually modprobed after via-rng, crashing
>> 	via-rng is registered first, b43-rng second
>>
>> Seems like the crash shows up when b43-rng is registered second, but not
>> when via-rng is registered second.
>> Btw.: `cat rng_available' does also not crash when via-rng is registered
>> second.
> 
> 
> I suspect that there is some "hw_random.h" header version mixup is going
> on here. The layout of struct hwrng was changed recently.
> 
> Your crash seems to happen on the list head embedded in struct hwrng.
> 
> Please make sure that your build environment is clean and you're not
> using any external stuff such as compat-wireless. All of hwrng-core,
> rng-via and b43 must be compiled against the same hw_random.h.

AFAIK, he is building with the mainline 2.6.37-rc7/8 tree from Linus, thus the
build should be clean, but thanks for the heads-up.

In an Email from Herbert Xu that did not go to the wireless or b43 lists, it is
suspected that the xstore command on a VIA CPU might generate more than 4 bytes
of output and clobber the list header. We now also know that a second copy of
via-rng will also fail, thus b43 is cleared.

Larry

^ permalink raw reply

* iwconfig and iwlist
From: James @ 2010-12-31  4:52 UTC (permalink / raw)
  To: linux-wireless

iwconfig says my Encryption key is off but iwlist says it is on (it is
on :-)).
Everything works so that is a minor thing.

$ sudo iwconfig
wlan1     IEEE 802.11bgn  ESSID:"me"  
          Mode:Managed  Frequency:2.462 GHz  Access Point:
00:0F:B5:12:F5:EA   
          Bit Rate=54 Mb/s   Tx-Power=20 dBm   
          Retry  long limit:7   RTS thr:off   Fragment thr:off
          Encryption key:off
          Power Management:off
          Link Quality=51/70  Signal level=-59 dBm  
          Rx invalid nwid:0  Rx invalid crypt:0  Rx invalid frag:0
          Tx excessive retries:0  Invalid misc:0   Missed beacon:0


$ sudo iwlist wlan1 scan
          Cell 10 - Address: 00:0F:B5:12:F5:EA
                    Channel:11
                    Frequency:2.462 GHz (Channel 11)
                    Quality=51/70  Signal level=-59 dBm 
                    Encryption key:on
                    ESSID:"me"
                    Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
                    Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s
                              36 Mb/s; 48 Mb/s; 54 Mb/s
                    Mode:Master
                    Extra:tsf=000000005899a294
                    Extra: Last beacon: 49ms ago
                    IE: Unknown: 000C54656B53617676792E636F6D
                    IE: Unknown: 010482848B96
                    IE: Unknown: 03010B
                    IE: Unknown: 2A0102
                    IE: Unknown: 32088C129824B048606C
                    IE: WPA Version 1
                        Group Cipher : TKIP
                        Pairwise Ciphers (1) : TKIP
                        Authentication Suites (1) : PSK

^ permalink raw reply

* Re: [PATCH 15/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Dan Carpenter @ 2010-12-31  6:34 UTC (permalink / raw)
  To: Justin P. Mattock
  Cc: trivial, devel, linux-scsi, netdev, linux-usb, linux-wireless,
	linux-kernel, ivtv-devel, linux-m68k, spi-devel-general,
	linux-media
In-Reply-To: <1293750484-1161-15-git-send-email-justinmattock@gmail.com>

On Thu, Dec 30, 2010 at 03:08:04PM -0800, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---
>  drivers/spi/dw_spi.c |    6 +++---

You missed one from this file:

/* Set the interrupt mask, for poll mode just diable all int */
                                              ^^^^^^
regards,
dan carpenter


^ permalink raw reply

* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Grant Likely @ 2010-12-31  6:45 UTC (permalink / raw)
  To: Justin P. Mattock
  Cc: trivial, devel, linux-scsi, netdev, linux-usb, linux-wireless,
	linux-kernel, ivtv-devel, linux-m68k, spi-devel-general,
	linux-media
In-Reply-To: <1293750484-1161-2-git-send-email-justinmattock@gmail.com>

On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this 
> is correct or not.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

applied, thanks.

g.

> 
> ---
>  drivers/spi/dw_spi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
> index 0838c79..7c3cf21 100644
> --- a/drivers/spi/dw_spi.c
> +++ b/drivers/spi/dw_spi.c
> @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
>  		spi_set_clk(dws, clk_div ? clk_div : chip->clk_div);
>  		spi_chip_sel(dws, spi->chip_select);
>  
> -		/* Set the interrupt mask, for poll mode just diable all int */
> +		/* Set the interrupt mask, for poll mode just disable all int */
>  		spi_mask_intr(dws, 0xff);
>  		if (imask)
>  			spi_umask_intr(dws, imask);
> -- 
> 1.6.5.2.180.gc5b3e
> 
> 
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment, and, 
> should the need arise, upgrade to a full multi-node Oracle RAC database 
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general

^ permalink raw reply

* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31  6:52 UTC (permalink / raw)
  To: Grant Likely
  Cc: trivial, devel, linux-scsi, netdev, linux-usb, linux-wireless,
	linux-kernel, ivtv-devel, linux-m68k, spi-devel-general,
	linux-media, Dan Carpenter
In-Reply-To: <20101231064515.GC3733@angua.secretlab.ca>

On 12/30/2010 10:45 PM, Grant Likely wrote:
> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>> is correct or not.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> applied, thanks.
>
> g.

ahh.. thanks.. just cleared up the left out diabled that I had thought I 
forgotten(ended up separating comments and code and forgot)
>
>>
>> ---
>>   drivers/spi/dw_spi.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
>> index 0838c79..7c3cf21 100644
>> --- a/drivers/spi/dw_spi.c
>> +++ b/drivers/spi/dw_spi.c
>> @@ -592,7 +592,7 @@ static void pump_transfers(unsigned long data)
>>   		spi_set_clk(dws, clk_div ? clk_div : chip->clk_div);
>>   		spi_chip_sel(dws, spi->chip_select);
>>
>> -		/* Set the interrupt mask, for poll mode just diable all int */
>> +		/* Set the interrupt mask, for poll mode just disable all int */
>>   		spi_mask_intr(dws, 0xff);
>>   		if (imask)
>>   			spi_umask_intr(dws, imask);
>> --
>> 1.6.5.2.180.gc5b3e
>>
>>
>> ------------------------------------------------------------------------------
>> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
>> to consolidate database storage, standardize their database environment, and,
>> should the need arise, upgrade to a full multi-node Oracle RAC database
>> without downtime or disruption
>> http://p.sf.net/sfu/oracle-sfdevnl
>> _______________________________________________
>> spi-devel-general mailing list
>> spi-devel-general@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/spi-devel-general
>

Justin P. Mattock

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox