* Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 22:33 UTC (permalink / raw)
To: Andy Walls
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293830120.2410.11.camel@localhost>
On 12/31/2010 01:15 PM, Andy Walls wrote:
> On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote:
>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>> is correct or not.
> ^^^^^^^^^^^^^^
>
> What, else could it be? The "diablo" chroma spatial filter type? ;)
>
> Looks fine.
>
> Acked-by: Andy Walls<awalls@md.metrocast.net>
depends on what the search engine gives you.. diablo did show up
but figured better throw that in to be safe since some definitions
appear to be incorect but are in fact correct..
>
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/media/video/cx18/cx23418.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
>> index 2c00980..7e40035 100644
>> --- a/drivers/media/video/cx18/cx23418.h
>> +++ b/drivers/media/video/cx18/cx23418.h
>> @@ -177,7 +177,7 @@
>> IN[0] - Task handle.
>> IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only,
>> 3 = 2D H/V separable, 4 = 2D symmetric non-separable
>> - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
>> + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
>> ReturnCode - One of the ERR_CAPTURE_... */
>> #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | 0x000C)
>>
>
>
>
cheers,
Justin P. Mattock
^ permalink raw reply
* Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
From: Andy Walls @ 2010-12-31 21:15 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-11-git-send-email-justinmattock@gmail.com>
On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
^^^^^^^^^^^^^^
What, else could it be? The "diablo" chroma spatial filter type? ;)
Looks fine.
Acked-by: Andy Walls <awalls@md.metrocast.net>
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
> drivers/media/video/cx18/cx23418.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
> index 2c00980..7e40035 100644
> --- a/drivers/media/video/cx18/cx23418.h
> +++ b/drivers/media/video/cx18/cx23418.h
> @@ -177,7 +177,7 @@
> IN[0] - Task handle.
> IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only,
> 3 = 2D H/V separable, 4 = 2D symmetric non-separable
> - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
> + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
> ReturnCode - One of the ERR_CAPTURE_... */
> #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | 0x000C)
>
^ permalink raw reply
* RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged skbs
From: Winkler, Tomas @ 2010-12-31 21:16 UTC (permalink / raw)
To: David Miller, stephen.hemminger@vyatta.com
Cc: shemminger@vyatta.com, johannes@sipsolutions.net,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org
In-Reply-To: <20101231.124533.15243601.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Friday, December 31, 2010 10:46 PM
> To: stephen.hemminger@vyatta.com
> Cc: Winkler, Tomas; shemminger@vyatta.com; johannes@sipsolutions.net;
> netdev@vger.kernel.org; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged
> skbs
>
> From: Stephen Hemminger <stephen.hemminger@vyatta.com>
> Date: Thu, 30 Dec 2010 15:06:16 -0800
>
> > Although copy is slower for large packets, this is a non performance
> > path. The code in question is for bridged multicast Ipv6 ICMP
> > packets. This case is so uncritical it could be done in BASIC and no
> > one could possibly care!
>
> I still think we should be judicious and keep using skb_clone() here.
>
> Simply combine the two pskb_may_pull() calls into one on "skb2" after
> the clone and before the blind __skb_pull() call. Then add a error
> path "out:" called "out_nopush:" for the error path to goto.
>
> Also, I think the "+ 1" in the ipv6 stack code comes from the fact that
> the parsing loop can "peek" into the next header's byte to see the type.
> And I really don't think it's relevant here.
>
> Also, all of these "x_header + ... + 1 - skb->data" factors are
> irrelevent and shouldn't be used. Just pass "offset + sizeof(*icmp6h)"
> to pskb_may_pull().
Sounds reasonable but maybe we shall pass offset + sizeof(struct mld_msg) as *icmp6h is casted to this struct mld_mca is accessed.
struct mld_msg {
struct icmp6hdr mld_hdr;
struct in6_addr mld_mca;
};
Thanks
Tomas
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply
* Re: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged skbs
From: David Miller @ 2010-12-31 20:45 UTC (permalink / raw)
To: stephen.hemminger
Cc: tomas.winkler, shemminger, johannes, netdev, linux-wireless
In-Reply-To: <9mk4bme8o97ir27xi8a9fbsd.1293750376929@email.android.com>
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Thu, 30 Dec 2010 15:06:16 -0800
> Although copy is slower for large packets, this is a non performance
> path. The code in question is for bridged multicast Ipv6 ICMP
> packets. This case is so uncritical it could be done in BASIC and no
> one could possibly care!
I still think we should be judicious and keep using skb_clone() here.
Simply combine the two pskb_may_pull() calls into one on "skb2" after
the clone and before the blind __skb_pull() call. Then add a error
path "out:" called "out_nopush:" for the error path to goto.
Also, I think the "+ 1" in the ipv6 stack code comes from the fact that
the parsing loop can "peek" into the next header's byte to see the type.
And I really don't think it's relevant here.
Also, all of these "x_header + ... + 1 - skb->data" factors are
irrelevent and shouldn't be used. Just pass "offset + sizeof(*icmp6h)"
to pskb_may_pull().
^ permalink raw reply
* Compat-wireless release for 2010-12-31 is baked
From: Compat-wireless cronjob account @ 2010-12-31 20:04 UTC (permalink / raw)
To: linux-wireless
>From git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next
dc86c6c..9b210cb history -> origin/history
+ e635401...bfa221f master -> origin/master (forced update)
387c31c..3643e0e stable -> origin/stable
* [new tag] next-20101231 -> next-20101231
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
cat: compat_base_tree: No such file or directory
cat: compat_base_tree_version: No such file or directory
cat: compat_version: No such file or directory
cat: /var/opt/compat/compat-wireless-2.6/compat_version: No such file or directory
scripts/Makefile.clean:17: /var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile: No such file or directory
make[4]: *** No rule to make target `/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap/Makefile'. Stop.
make[3]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless/hostap] Error 2
make[2]: *** [/var/opt/compat/compat-wireless-2.6/drivers/net/wireless] Error 2
make[1]: *** [_clean_/var/opt/compat/compat-wireless-2.6] Error 2
make: *** [clean] Error 2
compat-wireless code metrics
774936 - Total upstream lines of code being pulled
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 17:59 UTC (permalink / raw)
To: Dan Carpenter, Grant Likely, trivial, devel, linux-scsi, netdev,
linux-usb, linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <20101231174100.GF1886@bicker>
On 12/31/2010 09:41 AM, Dan Carpenter wrote:
> On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
>>> Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
>>>
>>> Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> alright.. so having the backlash is alright for the subject
>
> Well really my point is not so much about backslashes vs colons, it's
> about getting the *one* correct prefix. This stuff is probably
> scriptable most of the time, but you may still be required to think a
> little on the corner cases.
>
> Here is a script to get you started.
>
> git log --format="%s" drivers/spi/dw_spi.c | \
> head -n 20 | \
> perl -ne 's/(.*):.*/$1/; print' | \
> sort | uniq -c | sort -rn | \
> perl -ne 's/^\W+\d+ //; print' | \
> head -n 1
>
> regards,
> dan carpenter
>
thats a nice little script there(just ran it) any way you want to add
this into to getmaintainers.pl or something? (this way people get the
maintainers address plus a subject line in the mix)
Justin P. Mattock
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Dan Carpenter @ 2010-12-31 17:41 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Grant Likely, trivial, devel, linux-scsi, netdev, linux-usb,
linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <4D1DE616.7010105@gmail.com>
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
> >Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> >Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> >regards,
> >dan carpenter
> >
>
> alright.. so having the backlash is alright for the subject
Well really my point is not so much about backslashes vs colons, it's
about getting the *one* correct prefix. This stuff is probably
scriptable most of the time, but you may still be required to think a
little on the corner cases.
Here is a script to get you started.
git log --format="%s" drivers/spi/dw_spi.c | \
head -n 20 | \
perl -ne 's/(.*):.*/$1/; print' | \
sort | uniq -c | sort -rn | \
perl -ne 's/^\W+\d+ //; print' | \
head -n 1
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH v3 2/2] ath9k: Fix STA disconnect issue due to received MIC failed bcast frames
From: Ben Greear @ 2010-12-31 17:19 UTC (permalink / raw)
To: Senthil Balasubramanian; +Cc: linville, linux-wireless, Stable
In-Reply-To: <1291642767-11939-1-git-send-email-senthilkumar@atheros.com>
On 12/06/2010 05:39 AM, Senthil Balasubramanian wrote:
> AR_RxKeyIdxValid will not be set for bcast/mcast frames and so relying
> this status for MIC failed frames is buggy.
>
> Due to this, MIC failure events for broadcast frames are not sent to
> supplicant resulted in AP disconnecting the STA.
>
> Able to pass Wifi Test case 5.2.18 with this fix.
Did this ever make it into wireless-testing? I just did
a rebase, and I notice I'm still carrying this patch in my
local tree?
Thanks,
Ben
>
> Cc: Stable<stable@kernel.org> (2.6.36+)
> Signed-off-by: Senthil Balasubramanian<senthilkumar@atheros.com>
> ---
> v2 -- addressed invalid keyix overrun in tkip_keymap.
> v3 -- fixed setting of rx decrypted flag in case of s/w crypto.
>
> drivers/net/wireless/ath/ath9k/mac.c | 3 +--
> drivers/net/wireless/ath/ath9k/recv.c | 9 ++++++++-
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/mac.c b/drivers/net/wireless/ath/ath9k/mac.c
> index b04b37b..7978b27 100644
> --- a/drivers/net/wireless/ath/ath9k/mac.c
> +++ b/drivers/net/wireless/ath/ath9k/mac.c
> @@ -702,8 +702,7 @@ int ath9k_hw_rxprocdesc(struct ath_hw *ah, struct ath_desc *ds,
> rs->rs_phyerr = phyerr;
> } else if (ads.ds_rxstatus8& AR_DecryptCRCErr)
> rs->rs_status |= ATH9K_RXERR_DECRYPT;
> - else if ((ads.ds_rxstatus8& AR_MichaelErr)&&
> - rs->rs_keyix != ATH9K_RXKEYIX_INVALID)
> + else if (ads.ds_rxstatus8& AR_MichaelErr)
> rs->rs_status |= ATH9K_RXERR_MIC;
> else if (ads.ds_rxstatus8& AR_KeyMiss)
> rs->rs_status |= ATH9K_RXERR_DECRYPT;
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 262c815..876aa8f 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -840,6 +840,10 @@ static bool ath9k_rx_accept(struct ath_common *common,
> struct ath_rx_status *rx_stats,
> bool *decrypt_error)
> {
> +#define is_mc_or_valid_tkip_keyix ((is_mc || \
> + (rx_stats->rs_keyix != ATH9K_RXKEYIX_INVALID&& \
> + test_bit(rx_stats->rs_keyix, common->tkip_keymap))))
> +
> struct ath_hw *ah = common->ah;
> __le16 fc;
> u8 rx_status_len = ah->caps.rx_status_len;
> @@ -881,15 +885,18 @@ static bool ath9k_rx_accept(struct ath_common *common,
> if (rx_stats->rs_status& ATH9K_RXERR_DECRYPT) {
> *decrypt_error = true;
> } else if (rx_stats->rs_status& ATH9K_RXERR_MIC) {
> + bool is_mc;
> /*
> * The MIC error bit is only valid if the frame
> * is not a control frame or fragment, and it was
> * decrypted using a valid TKIP key.
> */
> + is_mc = !!is_multicast_ether_addr(hdr->addr1);
> +
> if (!ieee80211_is_ctl(fc)&&
> !ieee80211_has_morefrags(fc)&&
> !(le16_to_cpu(hdr->seq_ctrl)& IEEE80211_SCTL_FRAG)&&
> - test_bit(rx_stats->rs_keyix, common->tkip_keymap))
> + is_mc_or_valid_tkip_keyix)
> rxs->flag |= RX_FLAG_MMIC_ERROR;
> else
> rx_stats->rs_status&= ~ATH9K_RXERR_MIC;
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* Re: [PATCH 07/15]drivers:net:wireless:iwlwifi Typo change diable to disable.
From: Larry Finger @ 2010-12-31 15:33 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-7-git-send-email-justinmattock@gmail.com>
On 12/30/2010 05:07 PM, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-agn-ict.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-agn.c | 4 ++--
> drivers/net/wireless/iwlwifi/iwl-core.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> index a5dbfea..b5cb3be 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn-ict.c
> @@ -197,7 +197,7 @@ static irqreturn_t iwl_isr(int irq, void *data)
>
> none:
> /* re-enable interrupts here since we don't have anything to service. */
> - /* only Re-enable if diabled by irq and no schedules tasklet. */
> + /* only Re-enable if disabled by irq and no schedules tasklet. */
> if (test_bit(STATUS_INT_ENABLED, &priv->status) && !priv->_agn.inta)
> iwl_enable_interrupts(priv);
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index c2636a7..9b912c0 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -1316,7 +1316,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
> }
>
> /* Re-enable all interrupts */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
>
> @@ -1530,7 +1530,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
> }
>
> /* Re-enable all interrupts */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
> }
> diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
> index 25fb391..8700ab3 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
> @@ -1304,7 +1304,7 @@ irqreturn_t iwl_isr_legacy(int irq, void *data)
>
> none:
> /* re-enable interrupts here since we don't have anything to service. */
> - /* only Re-enable if diabled by irq */
> + /* only Re-enable if disabled by irq */
> if (test_bit(STATUS_INT_ENABLED, &priv->status))
> iwl_enable_interrupts(priv);
> spin_unlock_irqrestore(&priv->lock, flags);
^ permalink raw reply
* Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
From: Larry Finger @ 2010-12-31 15:32 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-3-git-send-email-justinmattock@gmail.com>
On 12/30/2010 05:07 PM, Justin P. Mattock wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
> drivers/staging/rtl8187se/r8180_hw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h
> index 3fca144..2911d40 100644
> --- a/drivers/staging/rtl8187se/r8180_hw.h
> +++ b/drivers/staging/rtl8187se/r8180_hw.h
> @@ -554,7 +554,7 @@
> /* by amy for power save */
> /* by amy for antenna */
> #define EEPROM_SW_REVD_OFFSET 0x3f
> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */
> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */
> #define EEPROM_SW_AD_MASK 0x0300
> #define EEPROM_SW_AD_ENABLE 0x0100
>
^ permalink raw reply
* [PATCH] ath9k : few rate control clean ups
From: Mohammed Shafi Shajakhan @ 2010-12-31 15:19 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lrodriguez, Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Remove some obvious looking dead code and rename few functions
Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
---
drivers/net/wireless/ath/ath9k/rc.c | 16 ++++++++--------
drivers/net/wireless/ath/ath9k/rc.h | 3 ---
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index 896d129..e451478 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -400,7 +400,7 @@ static void ath_rc_sort_validrates(const struct ath_rate_table *rate_table,
}
}
-static void ath_rc_init_valid_txmask(struct ath_rate_priv *ath_rc_priv)
+static void ath_rc_init_valid_rate_idx(struct ath_rate_priv *ath_rc_priv)
{
u8 i;
@@ -408,7 +408,7 @@ static void ath_rc_init_valid_txmask(struct ath_rate_priv *ath_rc_priv)
ath_rc_priv->valid_rate_index[i] = 0;
}
-static inline void ath_rc_set_valid_txmask(struct ath_rate_priv *ath_rc_priv,
+static inline void ath_rc_set_valid_rate_idx(struct ath_rate_priv *ath_rc_priv,
u8 index, int valid_tx_rate)
{
BUG_ON(index > ath_rc_priv->rate_table_size);
@@ -489,7 +489,7 @@ static u8 ath_rc_init_validrates(struct ath_rate_priv *ath_rc_priv,
ath_rc_priv->valid_phy_rateidx[phy][valid_rate_count] = i;
ath_rc_priv->valid_phy_ratecnt[phy] += 1;
- ath_rc_set_valid_txmask(ath_rc_priv, i, 1);
+ ath_rc_set_valid_rate_idx(ath_rc_priv, i, 1);
hi = i;
}
}
@@ -532,7 +532,7 @@ static u8 ath_rc_setvalid_rates(struct ath_rate_priv *ath_rc_priv,
ath_rc_priv->valid_phy_rateidx[phy]
[valid_rate_count] = j;
ath_rc_priv->valid_phy_ratecnt[phy] += 1;
- ath_rc_set_valid_txmask(ath_rc_priv, j, 1);
+ ath_rc_set_valid_rate_idx(ath_rc_priv, j, 1);
hi = A_MAX(hi, j);
}
}
@@ -568,7 +568,7 @@ static u8 ath_rc_setvalid_htrates(struct ath_rate_priv *ath_rc_priv,
ath_rc_priv->valid_phy_rateidx[phy]
[ath_rc_priv->valid_phy_ratecnt[phy]] = j;
ath_rc_priv->valid_phy_ratecnt[phy] += 1;
- ath_rc_set_valid_txmask(ath_rc_priv, j, 1);
+ ath_rc_set_valid_rate_idx(ath_rc_priv, j, 1);
hi = A_MAX(hi, j);
}
}
@@ -1210,7 +1210,7 @@ static void ath_rc_init(struct ath_softc *sc,
}
/* Determine the valid rates */
- ath_rc_init_valid_txmask(ath_rc_priv);
+ ath_rc_init_valid_rate_idx(ath_rc_priv);
for (i = 0; i < WLAN_RC_PHY_MAX; i++) {
for (j = 0; j < MAX_TX_RATE_PHY; j++)
@@ -1321,7 +1321,7 @@ static void ath_tx_status(void *priv, struct ieee80211_supported_band *sband,
struct ath_rate_priv *ath_rc_priv = priv_sta;
struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
struct ieee80211_hdr *hdr;
- int final_ts_idx = 0, tx_status = 0, is_underrun = 0;
+ int final_ts_idx = 0, tx_status = 0;
int long_retry = 0;
__le16 fc;
int i;
@@ -1358,7 +1358,7 @@ static void ath_tx_status(void *priv, struct ieee80211_supported_band *sband,
tx_status = 1;
ath_rc_tx_status(sc, ath_rc_priv, tx_info, final_ts_idx, tx_status,
- (is_underrun) ? sc->hw->max_rate_tries : long_retry);
+ long_retry);
/* Check if aggregation has to be enabled for this tid */
if (conf_is_ht(&sc->hw->conf) &&
diff --git a/drivers/net/wireless/ath/ath9k/rc.h b/drivers/net/wireless/ath/ath9k/rc.h
index 31a004c..5d984b8 100644
--- a/drivers/net/wireless/ath/ath9k/rc.h
+++ b/drivers/net/wireless/ath/ath9k/rc.h
@@ -195,7 +195,6 @@ struct ath_rc_stats {
* @rate_max_phy: phy index for the max rate
* @per: PER for every valid rate in %
* @probe_interval: interval for ratectrl to probe for other rates
- * @prev_data_rix: rate idx of last data frame
* @ht_cap: HT capabilities
* @neg_rates: Negotatied rates
* @neg_ht_rates: Negotiated HT rates
@@ -214,10 +213,8 @@ struct ath_rate_priv {
u32 probe_time;
u32 per_down_time;
u32 probe_interval;
- u32 prev_data_rix;
struct ath_rateset neg_rates;
struct ath_rateset neg_ht_rates;
- struct ath_rate_softc *asc;
const struct ath_rate_table *rate_table;
struct dentry *debugfs_rcstats;
--
1.7.0.4
^ permalink raw reply related
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: James Bottomley @ 2010-12-31 15:06 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Dan Carpenter, Grant Likely, trivial, devel, linux-scsi, netdev,
linux-usb, linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <4D1DE616.7010105@gmail.com>
On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote:
> On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> >> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>>> is correct or not.
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> >>>
> >>> applied, thanks.
> >>>
> >>> g.
> >>
> >> ahh.. thanks.. just cleared up the left out diabled that I had
> >> thought I forgotten(ended up separating comments and code and
> >> forgot)
> >
> > This is really just defensiveness and random grumbling and grumpiness on
> > my part, but one reason I may have missed the first patch is because
> > your subject lines are crap.
> >
> > Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> > Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> > regards,
> > dan carpenter
> >
>
> alright.. so having the backlash is alright for the subject
>
> Thanks for the pointer on this..
There is actually no specific form. Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use. I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.
James
^ permalink raw reply
* Re: Get slow speed when using ar9170usb driver.
From: Christian Lamparter @ 2010-12-31 14:41 UTC (permalink / raw)
To: Chin Shi Hong; +Cc: linux-wireless
In-Reply-To: <AANLkTikTHecf=yDcUgaJ-2RbzVzX5hpr_xbBTDgtiKeb@mail.gmail.com>
On Friday 31 December 2010 14:40:38 Chin Shi Hong wrote:
> On Thu, Dec 30, 2010 at 9:54 PM, Chin Shi Hong <cshong87@gmail.com> wrote:
> > On Fri, Dec 31, 2010 at 7:27 AM, Christian Lamparter
> > <chunkeey@googlemail.com> wrote:
> >> On Thursday 30 December 2010 16:55:18 Chin Shi Hong wrote:
> >>> Wireless adapter model: TP-LINK WN821NC (USB 300Mbps Wireless N adapter)
> >>> Output of lsusb: Bus 001 Device 007: ID 0cf3:1002 Atheros
> >>> Communications, Inc. TP-Link TL-WN821N v2 [Atheros AR9001U-(2)NG]
> >>> Wireless router: TP-LINK W8960N (300Mbps Wireless N router)
> >>
> >> That's weird, according to TP-Link's website there wasn't any WN821NC
> >> with a WN821N v2. They "only" let you download the driver for
> >> WN821N v3. v3 very different from the previous v2 generation, it has
> >> new chips (AR7015+AR9287?) and needs the ath9k_htc driver.
> >
> > WN821NC is actually WN821N shipped with USB cradle. WN821N itself does
> > not ship with any USB Cradle. The character 'C' in WN821NC mean
> > "Cradle". If you purchase WN821N, you will not get any USB Cradle.
> > But, if you purchase WN821NC, what you get is actually WN821N + USB
> > Cradle.
I went the extra mile. Got the windows driver for WN821NC
and installed it (under wine, if that makes a difference?) and
guess what... it's only for ath9k_htc. So why would TP-Link
sabotage themselves and only provide the wrong driver for all
windows customers?
But anyway, it's your stuff that does not work :D.
> > Are you sure, you didn't get ripped off here and someone else
> >> has "your" v3?
> >
> > According to the information printed at the back of my wireless
> > adapter, it is WN821N v2.
Yeah, I found someone on ebay, flogging cradles with WN821Nv2.
> >>> Driver name ar9170usb
> >>> Linux distro: Ubuntu 10.10 64 bit
> >>> Kernel version: 2.6.35-24-generic
> >>>
> >>> If I use Ndiswrapper + Windows XP driver, I can get full 300Mbps.
> >> Have you measured that (with iperf/netperf)? Or is it just the
> >> "Connection Information" pop-up which simply displays "speed: 300 Mbits" ?
> >
> > The 300Mbps is just "display". But, when I test my speed on Windows XP
> > with jperf, it ever reach maximum 2xxMbps.
"It >N<ever reaches the maximum of 200 Mbps?"
Wasn't there something abour wireless PHY vs. TCP speeds in the
"802.11 capturing project"?
I've been looking around for benchmarks for comparisons
While I did not find anything with a WN821N v2, there is one rather
nice review with several adapters, including a Netgear WN111v2.
The WN111v2 has definitely the same chip and driver, I can't say
much about the "design" though, but it should be similar as well.
<http://www.smallnetbuilder.com/wireless/wireless-reviews/31089-80211n-adapter-roundup>
Yup, a very bleak picture.
> >>> At the same distance, if I use ar9170usb driver, I can only get
> >>> maximum 54Mbps speed.
> >> That's true. here's ar9170usb wiki page:
> >> <http://wireless.kernel.org/en/users/Drivers/ar9170#features> => working
> >> "802.11 a/b/g"
> >>
> >> --
> >>
> >> The quickest way around limitations is via backports:
> >> visit <http://wireless.kernel.org/en/users/Download>
> >> and get compat-wireless:
> >>
> > Will try carl9170 again later.
Huh, so have have tried carl9170 before?
> carl9170 not work. Error when trying to run "sudo modprobe carl9170":
> "FATAL: Error inserting carl9170
> (/lib/modules/2.6.35-22-generic/updates/drivers/net/wireless/ath/carl9170/carl9170.ko):
> Invalid argument".
hint: "dmesg" tells you more.
I can only guess that "Invalid argument" actually means in
this context, but it could be related to old/incompatible modules.
Try to reload the ath, mac80211 and cfg80211 modules.
Regards,
Chr
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 14:17 UTC (permalink / raw)
To: Dan Carpenter, Grant Likely, trivial, devel, linux-scsi, netdev,
linux-usb, linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <20101231091136.GC1886@bicker>
On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
>> On 12/30/2010 10:45 PM, Grant Likely wrote:
>>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
>>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>>>> is correct or not.
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> applied, thanks.
>>>
>>> g.
>>
>> ahh.. thanks.. just cleared up the left out diabled that I had
>> thought I forgotten(ended up separating comments and code and
>> forgot)
>
> This is really just defensiveness and random grumbling and grumpiness on
> my part, but one reason I may have missed the first patch is because
> your subject lines are crap.
>
> Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
>
> Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
>
> regards,
> dan carpenter
>
alright.. so having the backlash is alright for the subject
Thanks for the pointer on this..
Justin P. Mattock
^ permalink raw reply
* Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
From: Justin P. Mattock @ 2010-12-31 14:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <4D1DAFF5.3090108@gmail.com>
On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:
> Em 30-12-2010 21:08, Justin P. Mattock escreveu:
>> The below patch fixes a typo "diable" to "disable". Please let me know if this
>> is correct or not.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> Acked-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>
> PS.: Next time, please c/c linux-media ONLY on patches related to media
> drivers (/drivers/video and the corresponding include files). Having to
> dig into a series of 15 patches to just actually look on 3 patches
> is not nice.
>
alright...
>>
>> ---
>> include/media/davinci/vpss.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
>> index c59cc02..b586495 100644
>> --- a/include/media/davinci/vpss.h
>> +++ b/include/media/davinci/vpss.h
>> @@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
>> short pplen;
>> };
>>
>> -/* Used for enable/diable VPSS Clock */
>> +/* Used for enable/disable VPSS Clock */
>> enum vpss_clock_sel {
>> /* DM355/DM365 */
>> VPSS_CCDC_CLOCK,
>
>
Justin P. Mattock
^ permalink raw reply
* Re: Get slow speed when using ar9170usb driver.
From: Chin Shi Hong @ 2010-12-31 13:40 UTC (permalink / raw)
To: Christian Lamparter, linux-wireless
In-Reply-To: <AANLkTi=c1XvwzJjZx+WH0uSSxn8++CCFJ-pJkxa4MtaQ@mail.gmail.com>
On Thu, Dec 30, 2010 at 9:54 PM, Chin Shi Hong <cshong87@gmail.com> wrote:
> On Fri, Dec 31, 2010 at 7:27 AM, Christian Lamparter
> <chunkeey@googlemail.com> wrote:
>> On Thursday 30 December 2010 16:55:18 Chin Shi Hong wrote:
>>> Dear All,
>>
>> Hello,
>>
>>> Wireless adapter model: TP-LINK WN821NC (USB 300Mbps Wireless N adapter)
>>> Output of lsusb: Bus 001 Device 007: ID 0cf3:1002 Atheros
>>> Communications, Inc. TP-Link TL-WN821N v2 [Atheros AR9001U-(2)NG]
>>> Wireless router: TP-LINK W8960N (300Mbps Wireless N router)
>>
>> That's weird, according to TP-Link's website there wasn't any WN821NC
>> with a WN821N v2. They "only" let you download the driver for
>> WN821N v3. v3 very different from the previous v2 generation, it has
>> new chips (AR7015+AR9287?) and needs the ath9k_htc driver.
>
> WN821NC is actually WN821N shipped with USB cradle. WN821N itself does
> not ship with any USB Cradle. The character 'C' in WN821NC mean
> "Cradle". If you purchase WN821N, you will not get any USB Cradle.
> But, if you purchase WN821NC, what you get is actually WN821N + USB
> Cradle.
>
>> Are you sure, you didn't get ripped off here and someone else
>> has "your" v3?
>
> According to the information printed at the back of my wireless
> adapter, it is WN821N v2.
>
>>> Driver name ar9170usb
>>> Linux distro: Ubuntu 10.10 64 bit
>>> Kernel version: 2.6.35-24-generic
>>>
>>> If I use Ndiswrapper + Windows XP driver, I can get full 300Mbps.
>> Have you measured that (with iperf/netperf)? Or is it just the
>> "Connection Information" pop-up which simply displays "speed: 300 Mbits" ?
>
> The 300Mbps is just "display". But, when I test my speed on Windows XP
> with jperf, it ever reach maximum 2xxMbps.
>
>>> At the same distance, if I use ar9170usb driver, I can only get
>>> maximum 54Mbps speed.
>> That's true. here's ar9170usb wiki page:
>> <http://wireless.kernel.org/en/users/Drivers/ar9170#features> => working
>> "802.11 a/b/g"
>>
>> Also, the old stack (in 2.6.35) does not have minstrel_ht
>> (rate control algorithm for 11n) so ar9170usb is limited to
>> the legacy b/g rates.
>>
>> Furthermore, the old driver lacks any support for aggregation, so the
>> uplink throughput (even with the fastest 300 mbits rate and under
>> "perfect" lab conditions) would struggle to get to 40 mbit and beyond.
>>
>> --
>>
>> The quickest way around limitations is via backports:
>> visit <http://wireless.kernel.org/en/users/Download>
>> and get compat-wireless:
>>
>> <http://wireless.kernel.org/en/users/Download#Getting_compat-wireless_on_Ubuntu>
>>
>> Then, you can migrate to carl9170 (a new driver with a new firmware)
>> for more information, see:
>> <http://wireless.kernel.org/en/users/Drivers/carl9170>
>>
>> However, this "new" driver+fw is still in development. You definitely
>> want to keep your compat-wireless package up-to-date.
>>
>> Best Regards,
>> Christian
>>
>
> Will try carl9170 again later.
>
> Regards,
>
carl9170 not work. Error when trying to run "sudo modprobe carl9170":
"FATAL: Error inserting carl9170
(/lib/modules/2.6.35-22-generic/updates/drivers/net/wireless/ath/carl9170/carl9170.ko):
Invalid argument".
regards,
^ permalink raw reply
* Re: [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable.
From: Geert Uytterhoeven @ 2010-12-31 10:33 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-1-git-send-email-justinmattock@gmail.com>
On Fri, Dec 31, 2010 at 00:07, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/m68k/ifpsp060/src/fpsp.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/ifpsp060/src/fpsp.S b/arch/m68k/ifpsp060/src/fpsp.S
> index 73613b5..26e85e2 100644
> --- a/arch/m68k/ifpsp060/src/fpsp.S
> +++ b/arch/m68k/ifpsp060/src/fpsp.S
> @@ -3881,7 +3881,7 @@ _fpsp_fline:
> # FP Unimplemented Instruction stack frame and jump to that entry
> # point.
> #
> -# but, if the FPU is disabled, then we need to jump to the FPU diabled
> +# but, if the FPU is disabled, then we need to jump to the FPU disabled
> # entry point.
> movc %pcr,%d0
> btst &0x1,%d0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH 14/15]include:media:davinci:vpss.h Typo change diable to disable.
From: Mauro Carvalho Chehab @ 2010-12-31 10:27 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-14-git-send-email-justinmattock@gmail.com>
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
PS.: Next time, please c/c linux-media ONLY on patches related to media
drivers (/drivers/video and the corresponding include files). Having to
dig into a series of 15 patches to just actually look on 3 patches
is not nice.
>
> ---
> include/media/davinci/vpss.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/media/davinci/vpss.h b/include/media/davinci/vpss.h
> index c59cc02..b586495 100644
> --- a/include/media/davinci/vpss.h
> +++ b/include/media/davinci/vpss.h
> @@ -44,7 +44,7 @@ struct vpss_pg_frame_size {
> short pplen;
> };
>
> -/* Used for enable/diable VPSS Clock */
> +/* Used for enable/disable VPSS Clock */
> enum vpss_clock_sel {
> /* DM355/DM365 */
> VPSS_CCDC_CLOCK,
^ permalink raw reply
* Re: [PATCH 12/15]drivers:media:video:tvp7002.c Typo change diable to disable.
From: Mauro Carvalho Chehab @ 2010-12-31 10:24 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-12-git-send-email-justinmattock@gmail.com>
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> ---
> drivers/media/video/tvp7002.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
> index e63b40f..c799e4e 100644
> --- a/drivers/media/video/tvp7002.c
> +++ b/drivers/media/video/tvp7002.c
> @@ -789,7 +789,7 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
> * Get the value of a TVP7002 decoder device register.
> * Returns zero when successful, -EINVAL if register read fails or
> * access to I2C client fails, -EPERM if the call is not allowed
> - * by diabled CAP_SYS_ADMIN.
> + * by disabled CAP_SYS_ADMIN.
> */
> static int tvp7002_g_register(struct v4l2_subdev *sd,
> struct v4l2_dbg_register *reg)
^ permalink raw reply
* Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.
From: Mauro Carvalho Chehab @ 2010-12-31 10:23 UTC (permalink / raw)
To: Justin P. Mattock
Cc: trivial, linux-m68k, linux-kernel, netdev, ivtv-devel,
linux-media, linux-wireless, linux-scsi, spi-devel-general, devel,
linux-usb
In-Reply-To: <1293750484-1161-11-git-send-email-justinmattock@gmail.com>
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
> The below patch fixes a typo "diable" to "disable". Please let me know if this
> is correct or not.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> ---
> drivers/media/video/cx18/cx23418.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
> index 2c00980..7e40035 100644
> --- a/drivers/media/video/cx18/cx23418.h
> +++ b/drivers/media/video/cx18/cx23418.h
> @@ -177,7 +177,7 @@
> IN[0] - Task handle.
> IN[1] - luma type: 0 = disable, 1 = 1D horizontal only, 2 = 1D vertical only,
> 3 = 2D H/V separable, 4 = 2D symmetric non-separable
> - IN[2] - chroma type: 0 - diable, 1 = 1D horizontal
> + IN[2] - chroma type: 0 - disable, 1 = 1D horizontal
> ReturnCode - One of the ERR_CAPTURE_... */
> #define CX18_CPU_SET_SPATIAL_FILTER_TYPE (CPU_CMD_MASK_CAPTURE | 0x000C)
>
^ permalink raw reply
* BUG in rt2x00lib_txdone() with 2.6.37-rc8
From: Stephen Boyd @ 2010-12-31 10:23 UTC (permalink / raw)
To: users; +Cc: Ivo van Doorn, linux-wireless, linux-kernel
Hi,
I think I'm hitting a rare bug in rt2x00lib_txdone(). Usually I can't
capture it since a second or third bug hits immediately after and
everything wraps off the screen. I'm fairly certain the same bug is
hitting on rc8, but I only got the oops in my logs with an rc7 kernel
including the latest net tree merge. Reproducing the bug is hit or miss
and I don't know a good way to trigger it.
I have an rt73usb device on an x86_64 machine, lsusb shows:
Bus 001 Device 004: ID 050d:705a Belkin Components F5D7050 Wireless G
Adapter v3000 [Ralink RT2573]
This is all of the oops that I could recover.
[ 9085.714105] BUG: unable to handle kernel NULL pointer dereference at
00000000000000a4
[ 9085.714816] IP: [<ffffffffa0025458>] rt2x00lib_txdone+0x36/0x249
[rt2x00lib]
[ 9085.715017] PGD 215fd067 PUD 292f4067 PMD 0
[ 9085.715017] Oops: 0000 [#1] SMP
[ 9085.715017] last sysfs file:
/sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq
[ 9085.715017] CPU 1
[ 9085.715017] Modules linked in: usb_storage thermal snd_seq_oss
snd_seq_midi snd_seq_dummy snd_pcm_oss snd_mixer_oss snd_hrtimer
snd_emu10k1_synth snd_emux_synth snd_seq_virmidi snd_seq_midi_event
snd_seq_midi_emul snd_seq scsi_wait_scan powernow_k8 mperf i2c_i801 fuse
fan snd_emu10k1 snd_rawmidi snd_ac97_codec ac97_bus snd_pcm
snd_seq_device snd_timer snd_page_alloc snd_util_mem rt73usb crc_itu_t
rt2x00usb snd_hwdep snd processor r8169 via82cxxx rt2x00lib soundcore
mii button k8temp
[ 9085.715017]
[ 9085.715017] Pid: 11513, comm: kworker/1:0 Not tainted 2.6.37-rc7+ #27
MS-7094/MS-7094
[ 9085.715017] RIP: 0010:[<ffffffffa0025458>] [<ffffffffa0025458>]
rt2x00lib_txdone+0x36/0x249 [rt2x00lib]
[ 9085.715017] RSP: 0000:ffff880000057ca0 EFLAGS: 00010286
[ 9085.715017] RAX: 0000000000000030 RBX: ffff88003b64e3c0 RCX:
ffff880000057ca0
[ 9085.715017] RDX: 0000000000000006 RSI: ffff880000057d00 RDI:
0000000000000000
[ 9085.715017] RBP: ffff880000057cf0 R08: ffff88003c7c7110 R09:
0000000000000001
[ 9085.715017] R10: ffffffff81df3c10 R11: 0000000000000282 R12:
ffff88003c586280
[ 9085.715017] R13: 0000000000000000 R14: 0000000000000028 R15:
ffff880000057d00
[ 9085.715017] FS: 00002b41e037b160(0000) GS:ffff88003f
I think the entry or skb in the entry is NULL, but I'm not sure how
that's possible. Here's an objdump of the erroring code if that helps.
0000000000000422 <rt2x00lib_txdone>:
422: 55 push %rbp
423: 48 89 e5 mov %rsp,%rbp
426: 41 57 push %r15
428: 41 56 push %r14
42a: 41 55 push %r13
42c: 41 54 push %r12
42e: 53 push %rbx
42f: 48 83 ec 28 sub $0x28,%rsp
433: e8 00 00 00 00 callq 438 <rt2x00lib_txdone+0x16>
438: 4c 8b 6f 10 mov 0x10(%rdi),%r13
43c: 48 8b 47 08 mov 0x8(%rdi),%rax
440: 49 89 fc mov %rdi,%r12
443: 49 89 f7 mov %rsi,%r15
446: 48 8b 18 mov (%rax),%rbx
449: 49 8d 45 30 lea 0x30(%r13),%rax
44d: 4c 89 ef mov %r13,%rdi
450: 4d 8d 75 28 lea 0x28(%r13),%r14
454: 48 89 45 c8 mov %rax,-0x38(%rbp)
458: 41 8b 95 a4 00 00 00 mov 0xa4(%r13),%edx <--- here
45f: 66 89 55 c2 mov %dx,-0x3e(%rbp)
463: e8 00 00 00 00 callq 468 <rt2x00lib_txdone+0x46>
468: 89 45 c4 mov %eax,-0x3c(%rbp)
46b: 41 8a 45 30 mov 0x30(%r13),%al
^ permalink raw reply
* RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged skbs
From: Johannes Berg @ 2010-12-31 10:18 UTC (permalink / raw)
To: Winkler, Tomas
Cc: Stephen Hemminger, Stephen Hemminger, davem@davemloft.net,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org
In-Reply-To: <6F5C1D715B2DA5498A628E6B9C124F04019BF36ABD@hasmsx504.ger.corp.intel.com>
On Fri, 2010-12-31 at 01:29 +0200, Winkler, Tomas wrote:
>
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen.hemminger@vyatta.com]
> > Sent: Friday, December 31, 2010 1:06 AM
> > To: Winkler, Tomas; Stephen Hemminger; Johannes Berg
> > Cc: davem@davemloft.net; netdev@vger.kernel.org ; linux-
> > wireless@vger.kernel.org
> > Subject: RE: [PATCH net-2.6] bridge: fix br_multicast_ipv6_rcv for paged
> > skbs
> >
> > Although copy is slower for large packets, this is a non performance path.
> > The code in question is for bridged multicast Ipv6 ICMP packets. This case
> > is so uncritical it could be done in BASIC and no one could possibly care!
> >
>
>
> Fair enough, although you got few of those when you connect to win7 client.
> Anyhow my fix would work if the second pull would be
> if (!pskb_may_pull(skb2, sizeof(struct mld_msg))) instead of (!pskb_may_pull(skb2, sizeof(*icmp6h)))
I don't think that works either since that may be longer than the entire
skb's length since the payload still is variable at this point.
johannes
^ permalink raw reply
* Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
From: Dan Carpenter @ 2010-12-31 9:11 UTC (permalink / raw)
To: Justin P. Mattock
Cc: Grant Likely, trivial, devel, linux-scsi, netdev, linux-usb,
linux-wireless, linux-kernel, ivtv-devel, linux-m68k,
spi-devel-general, linux-media
In-Reply-To: <4D1D7DAE.7060504@gmail.com>
On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>is correct or not.
> >>
> >>Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> >
> >applied, thanks.
> >
> >g.
>
> ahh.. thanks.. just cleared up the left out diabled that I had
> thought I forgotten(ended up separating comments and code and
> forgot)
This is really just defensiveness and random grumbling and grumpiness on
my part, but one reason I may have missed the first patch is because
your subject lines are crap.
Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
regards,
dan carpenter
^ permalink raw reply
* Re: Compile error for the last week inside rtlwifi/base.c
From: Weedy @ 2010-12-31 8:24 UTC (permalink / raw)
To: linux-wireless
In-Reply-To: <4D1B6821.5040506@lwfinger.net>
Larry Finger <Larry.Finger@...> writes:
>
> On 12/28/2010 08:43 PM, Weedy wrote:
> > Larry Finger <Larry.Finger@...> writes:
> >
> > Actually I need RTL8192USB, I guess I need to wait more?
>
> What are the USB Ids as shown by the lsusb command?
>
> Larry
idVendor 0x0bda Realtek Semiconductor Corp.
idProduct 0x8171 RTL8188SU 802.11n WLAN Adapter
^ permalink raw reply
* wl12xx maintainer's email address will change
From: Luciano Coelho @ 2010-12-31 8:05 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org
Hi,
Sorry for the spam for those who are not working with wl12xx.
Today is the last day when my current email address
(luciano.coelho@nokia.com) is valid. So please send all requests or
questions that are supposed to reach me to the linux-wireless mailing
list, so I can still read them.
My new email address will be available by the beginning of next week.
--
Cheers,
Luca.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox