* [PATCH 3.10 0/3] Enable 7000 device family on 3.10
From: Emmanuel Grumbach @ 2013-07-15 11:19 UTC (permalink / raw)
To: linux-wireless; +Cc: Emmanuel Grumbach
This small patch series enables 7260 and 3160 devices on 3.10
kernel. Three patches are already in linux.git (3.11-rc1).
One patch is 3.10 specific and disables configuration that is not
supported in 3.10.
Emmanuel Grumbach (1):
iwlwifi: mvm: support BSS only
Johannes Berg (2):
iwlwifi: mvm: adjust firmware D3 configuration API
iwlwifi: bump required firmware API version for 3160/7260
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c | 4 ++--
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 24 +-----------------------
drivers/net/wireless/iwlwifi/pcie/7000.c | 12 ++++++------
4 files changed, 12 insertions(+), 32 deletions(-)
--
1.7.10.4
^ permalink raw reply
* [PATCH 3.10 0/3] Enable 7000 device family on 3.10
From: Emmanuel Grumbach @ 2013-07-15 11:24 UTC (permalink / raw)
To: linux-wireless; +Cc: Emmanuel Grumbach
This small patch series enables 7260 and 3160 devices on 3.10
kernel. Three patches are already in linux.git (3.11-rc1).
One patch is 3.10 specific and disables configuration that is not
supported in 3.10.
Emmanuel Grumbach (1):
iwlwifi: mvm: support BSS only
Johannes Berg (2):
iwlwifi: mvm: adjust firmware D3 configuration API
iwlwifi: bump required firmware API version for 3160/7260
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c | 4 ++--
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 24 +-----------------------
drivers/net/wireless/iwlwifi/pcie/7000.c | 12 ++++++------
4 files changed, 12 insertions(+), 32 deletions(-)
--
1.7.10.4
^ permalink raw reply
* Re: kernel panic on 3.10.0-rc7
From: Krzysztof Mazur @ 2013-07-15 11:25 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Sedat Dilek, peizhao.research, linux-wireless
In-Reply-To: <51E3C571.2060602@openwrt.org>
On Mon, Jul 15, 2013 at 11:48:33AM +0200, Felix Fietkau wrote:
> On 2013-07-15 11:35 AM, Krzysztof Mazur wrote:
> > On Mon, Jul 15, 2013 at 11:27:30AM +0200, Krzysztof Mazur wrote:
> >> On Mon, Jul 15, 2013 at 11:06:27AM +0200, Felix Fietkau wrote:
> >> > Please post the actual message output. Saying "it looks like something
> >> > wrong with the rate control mechanism" doesn't give me anything useful
> >> > to work with.
> >> >
> >>
> >> Sorry, I added you to Cc after I removed the original Oops.
> >>
> >
> > On my system the NULL pointer dereference occurs at 0x806389b0,
> > and the minstrel_get_rate() looks like:
> >
> > 80638990 <minstrel_get_rate>:
> > 80638990: 83 ec 1c sub $0x1c,%esp
> > 80638993: 89 7c 24 14 mov %edi,0x14(%esp)
> > 80638997: 8b 7c 24 20 mov 0x20(%esp),%edi
> > 8063899b: 89 5c 24 0c mov %ebx,0xc(%esp)
> > 8063899f: 89 cb mov %ecx,%ebx
> > 806389a1: 89 6c 24 18 mov %ebp,0x18(%esp)
> > 806389a5: 89 c5 mov %eax,%ebp
> > 806389a7: 89 d0 mov %edx,%eax
> > 806389a9: 89 74 24 10 mov %esi,0x10(%esp)
> > 806389ad: 8b 77 0c mov 0xc(%edi),%esi
> > * 806389b0: 0f b6 49 38 movzbl 0x38(%ecx),%ecx *
> > 806389b4: 8d 56 20 lea 0x20(%esi),%edx
> > 806389b7: 89 54 24 04 mov %edx,0x4(%esp)
> > 806389bb: 89 da mov %ebx,%edx
> > 806389bd: 88 4c 24 0b mov %cl,0xb(%esp)
> > 806389c1: 89 f9 mov %edi,%ecx
> > 806389c3: e8 38 2f fe ff call 8061b900 <rate_control_send_low>
> My x86 assembly is a a bit rusty (I usually work with ARM and MIPS), so
> I'm having trouble figuring out the exact line of code here. Please use
> gdb to track it down.
>
The priv_sta is NULL and it's later dereferenced in:
bool prev_sample = mi->prev_sample;
static void
minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
void *priv_sta, struct ieee80211_tx_rate_control *txrc)
{
struct sk_buff *skb = txrc->skb;
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
struct minstrel_sta_info *mi = priv_sta;
struct minstrel_priv *mp = priv;
struct ieee80211_tx_rate *rate = &info->control.rates[0];
struct minstrel_rate *msr, *mr;
unsigned int ndx;
bool mrr_capable;
bool prev_sample = mi->prev_sample;
int delta;
int sampling_ratio;
With:
diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
index ac7ef54..be17d52 100644
--- a/net/mac80211/rc80211_minstrel.c
+++ b/net/mac80211/rc80211_minstrel.c
@@ -290,9 +290,15 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
struct minstrel_rate *msr, *mr;
unsigned int ndx;
bool mrr_capable;
- bool prev_sample = mi->prev_sample;
+ bool prev_sample;
int delta;
int sampling_ratio;
+
+ if (!mi) {
+ printk("Oops, mi is NULL\n");
+ return;
+ }
+ prev_sample = mi->prev_sample;
/* management/no-ack frames do not use rate control */
if (rate_control_send_low(sta, priv_sta, txrc))
the system no longer crashes and just prints a message.
Krzysiek
^ permalink raw reply related
* [PATCH 3.10 0/3] Enable 7000 device family on 3.10
From: Emmanuel Grumbach @ 2013-07-15 11:44 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
This small patch series enables 7260 and 3160 devices on 3.10
kernel. Three patches are already in linux.git (3.11-rc1).
One patch is 3.10 specific and disables configuration that is not
supported in 3.10.
Emmanuel Grumbach (1):
iwlwifi: mvm: support BSS only
Johannes Berg (2):
iwlwifi: mvm: adjust firmware D3 configuration API
iwlwifi: bump required firmware API version for 3160/7260
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c | 4 ++--
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 24 +-----------------------
drivers/net/wireless/iwlwifi/pcie/7000.c | 12 ++++++------
4 files changed, 12 insertions(+), 32 deletions(-)
--
1.7.10.4
^ permalink raw reply
* [PATCH 3.10 2/3] iwlwifi: mvm: adjust firmware D3 configuration API
From: Emmanuel Grumbach @ 2013-07-15 11:44 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
In-Reply-To: <1373888700-3040-1-git-send-email-emmanuel.grumbach@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
commit dfcb4c3aacedee6838e436fb575b31e138505203 upstream.
The D3 firmware API changed to include a new field, adjust
the driver to it to avoid getting an NMI when configuring.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h b/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
index 51e015d..6f8b2c1 100644
--- a/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
+++ b/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
@@ -75,13 +75,15 @@ enum iwl_d3_wakeup_flags {
* struct iwl_d3_manager_config - D3 manager configuration command
* @min_sleep_time: minimum sleep time (in usec)
* @wakeup_flags: wakeup flags, see &enum iwl_d3_wakeup_flags
+ * @wakeup_host_timer: force wakeup after this many seconds
*
* The structure is used for the D3_CONFIG_CMD command.
*/
struct iwl_d3_manager_config {
__le32 min_sleep_time;
__le32 wakeup_flags;
-} __packed; /* D3_MANAGER_CONFIG_CMD_S_VER_3 */
+ __le32 wakeup_host_timer;
+} __packed; /* D3_MANAGER_CONFIG_CMD_S_VER_4 */
/* TODO: OFFLOADS_QUERY_API_S_VER_1 */
--
1.7.10.4
^ permalink raw reply related
* [PATCH 3.10 1/3] iwlwifi: mvm: support BSS only
From: Emmanuel Grumbach @ 2013-07-15 11:44 UTC (permalink / raw)
To: stable; +Cc: linux-wireless, Emmanuel Grumbach
In-Reply-To: <1373888700-3040-1-git-send-email-emmanuel.grumbach@intel.com>
Only BSS is supported in 3.10. In later kernels, other modes
have been fixed and tested to work.
This will at least allow user to use the regular wifi
functionality.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 36 +--------------------------
1 file changed, 1 insertion(+), 35 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
index a5eb8c8..5b1b86f 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
@@ -78,32 +78,6 @@
#include "fw-api-scan.h"
#include "iwl-phy-db.h"
-static const struct ieee80211_iface_limit iwl_mvm_limits[] = {
- {
- .max = 1,
- .types = BIT(NL80211_IFTYPE_STATION) |
- BIT(NL80211_IFTYPE_AP),
- },
- {
- .max = 1,
- .types = BIT(NL80211_IFTYPE_P2P_CLIENT) |
- BIT(NL80211_IFTYPE_P2P_GO),
- },
- {
- .max = 1,
- .types = BIT(NL80211_IFTYPE_P2P_DEVICE),
- },
-};
-
-static const struct ieee80211_iface_combination iwl_mvm_iface_combinations[] = {
- {
- .num_different_channels = 1,
- .max_interfaces = 3,
- .limits = iwl_mvm_limits,
- .n_limits = ARRAY_SIZE(iwl_mvm_limits),
- },
-};
-
#ifdef CONFIG_PM_SLEEP
static const struct nl80211_wowlan_tcp_data_token_feature
iwl_mvm_wowlan_tcp_token_feature = {
@@ -160,20 +134,12 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
hw->vif_data_size = sizeof(struct iwl_mvm_vif);
hw->chanctx_data_size = sizeof(struct iwl_mvm_phy_ctxt);
- hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
- BIT(NL80211_IFTYPE_P2P_CLIENT) |
- BIT(NL80211_IFTYPE_AP) |
- BIT(NL80211_IFTYPE_P2P_GO) |
- BIT(NL80211_IFTYPE_P2P_DEVICE);
+ hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
hw->wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY |
WIPHY_FLAG_DISABLE_BEACON_HINTS |
WIPHY_FLAG_IBSS_RSN;
- hw->wiphy->iface_combinations = iwl_mvm_iface_combinations;
- hw->wiphy->n_iface_combinations =
- ARRAY_SIZE(iwl_mvm_iface_combinations);
-
hw->wiphy->max_remain_on_channel_duration = 10000;
hw->max_listen_interval = IWL_CONN_MAX_LISTEN_INTERVAL;
--
1.7.10.4
^ permalink raw reply related
* [PATCH 3.10 3/3] iwlwifi: bump required firmware API version for 3160/7260
From: Emmanuel Grumbach @ 2013-07-15 11:45 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
In-Reply-To: <1373888700-3040-1-git-send-email-emmanuel.grumbach@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
commit a2d0909a687b4d250cc2b7481072e361678745ba upstream.
As the firmware API has changed significantly and we don't
have support code for the old APIs, bump the version to be
able to release the version 7 API firmware.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-7000.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-7000.c b/drivers/net/wireless/iwlwifi/iwl-7000.c
index 50263e8..dc94d44 100644
--- a/drivers/net/wireless/iwlwifi/iwl-7000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-7000.c
@@ -67,16 +67,16 @@
#include "iwl-agn-hw.h"
/* Highest firmware API version supported */
-#define IWL7260_UCODE_API_MAX 6
-#define IWL3160_UCODE_API_MAX 6
+#define IWL7260_UCODE_API_MAX 7
+#define IWL3160_UCODE_API_MAX 7
/* Oldest version we won't warn about */
-#define IWL7260_UCODE_API_OK 6
-#define IWL3160_UCODE_API_OK 6
+#define IWL7260_UCODE_API_OK 7
+#define IWL3160_UCODE_API_OK 7
/* Lowest firmware API version supported */
-#define IWL7260_UCODE_API_MIN 6
-#define IWL3160_UCODE_API_MIN 6
+#define IWL7260_UCODE_API_MIN 7
+#define IWL3160_UCODE_API_MIN 7
/* NVM versions */
#define IWL7260_NVM_VERSION 0x0a1d
--
1.7.10.4
^ permalink raw reply related
* [PATCH RESEND 3.9 0/4] Enable 7000 device family on 3.9
From: Emmanuel Grumbach @ 2013-07-15 11:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
This small patch series enables 7260 and 3160 devices on 3.9
kernel. Three patches are already in linux.git (3.11-rc1).
One patch is 3.9 specific and disables configuration that is not
supported in 3.9.
Dor Shaish (1):
iwlwifi: mvm: don't use cts to self
Emmanuel Grumbach (1):
iwlwifi: mvm: support BSS only
Johannes Berg (2):
iwlwifi: mvm: adjust firmware D3 configuration API
iwlwifi: bump required firmware API version for 3160/7260
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c | 4 ++--
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 24 +-----------------------
drivers/net/wireless/iwlwifi/pcie/7000.c | 12 ++++++------
4 files changed, 12 insertions(+), 32 deletions(-)
--
1.7.10.4
^ permalink raw reply
* [PATCH RESEND 3.9 1/4] iwlwifi: mvm: don't use cts to self
From: Emmanuel Grumbach @ 2013-07-15 11:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
In-Reply-To: <1373888804-3077-1-git-send-email-emmanuel.grumbach@intel.com>
From: Dor Shaish <dor.shaish@intel.com>
commit cc7ee2bab3d90b0a09651dcfa2d0c9ec1a115bc8 upstream.
The current fw doesn't currently support cts to self. There
is a bug in the fw that prevents us from using cts to self.
Use full protection (including RTS) for now.
Signed-off-by: Dor Shaish <dor.shaish@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c b/drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c
index bf76b17..864cd6d 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c
+++ b/drivers/net/wireless/iwlwifi/mvm/mac-ctxt.c
@@ -553,9 +553,9 @@ static void iwl_mvm_mac_ctxt_cmd_common(struct iwl_mvm *mvm,
if (vif->bss_conf.qos)
cmd->qos_flags |= cpu_to_le32(MAC_QOS_FLG_UPDATE_EDCA);
+ /* Don't use cts to self as the fw doesn't support it currently. */
if (vif->bss_conf.use_cts_prot)
- cmd->protection_flags |= cpu_to_le32(MAC_PROT_FLG_TGG_PROTECT |
- MAC_PROT_FLG_SELF_CTS_EN);
+ cmd->protection_flags |= cpu_to_le32(MAC_PROT_FLG_TGG_PROTECT);
/*
* I think that we should enable these 2 flags regardless the HT PROT
--
1.7.10.4
^ permalink raw reply related
* [PATCH RESEND 3.9 2/4] iwlwifi: mvm: support BSS only
From: Emmanuel Grumbach @ 2013-07-15 11:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless, Emmanuel Grumbach
In-Reply-To: <1373888804-3077-1-git-send-email-emmanuel.grumbach@intel.com>
Only BSS is support in 3.9. In later kernels, other modes
have been fixed and tested to work.
This will at least allow user to use the regular wifi
functionality.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 24 +-----------------------
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
index 8572358..c9569a0 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
@@ -76,23 +76,6 @@
#include "fw-api-scan.h"
#include "iwl-phy-db.h"
-static const struct ieee80211_iface_limit iwl_mvm_limits[] = {
- {
- .max = 1,
- .types = BIT(NL80211_IFTYPE_STATION) |
- BIT(NL80211_IFTYPE_AP),
- },
-};
-
-static const struct ieee80211_iface_combination iwl_mvm_iface_combinations[] = {
- {
- .num_different_channels = 1,
- .max_interfaces = 3,
- .limits = iwl_mvm_limits,
- .n_limits = ARRAY_SIZE(iwl_mvm_limits),
- },
-};
-
int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
{
struct ieee80211_hw *hw = mvm->hw;
@@ -126,17 +109,12 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
hw->vif_data_size = sizeof(struct iwl_mvm_vif);
hw->chanctx_data_size = sizeof(struct iwl_mvm_phy_ctxt);
- hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
- BIT(NL80211_IFTYPE_AP);
+ hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
hw->wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY |
WIPHY_FLAG_DISABLE_BEACON_HINTS |
WIPHY_FLAG_IBSS_RSN;
- hw->wiphy->iface_combinations = iwl_mvm_iface_combinations;
- hw->wiphy->n_iface_combinations =
- ARRAY_SIZE(iwl_mvm_iface_combinations);
-
hw->wiphy->max_remain_on_channel_duration = 500;
hw->max_listen_interval = IWL_CONN_MAX_LISTEN_INTERVAL;
--
1.7.10.4
^ permalink raw reply related
* [PATCH RESEND 3.9 3/4] iwlwifi: mvm: adjust firmware D3 configuration API
From: Emmanuel Grumbach @ 2013-07-15 11:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
In-Reply-To: <1373888804-3077-1-git-send-email-emmanuel.grumbach@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
commit dfcb4c3aacedee6838e436fb575b31e138505203 upstream.
The D3 firmware API changed to include a new field, adjust
the driver to it to avoid getting an NMI when configuring.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h b/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
index cf6f9a0..937665f 100644
--- a/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
+++ b/drivers/net/wireless/iwlwifi/mvm/fw-api-d3.h
@@ -75,13 +75,15 @@ enum iwl_d3_wakeup_flags {
* struct iwl_d3_manager_config - D3 manager configuration command
* @min_sleep_time: minimum sleep time (in usec)
* @wakeup_flags: wakeup flags, see &enum iwl_d3_wakeup_flags
+ * @wakeup_host_timer: force wakeup after this many seconds
*
* The structure is used for the D3_CONFIG_CMD command.
*/
struct iwl_d3_manager_config {
__le32 min_sleep_time;
__le32 wakeup_flags;
-} __packed; /* D3_MANAGER_CONFIG_CMD_S_VER_3 */
+ __le32 wakeup_host_timer;
+} __packed; /* D3_MANAGER_CONFIG_CMD_S_VER_4 */
/* TODO: OFFLOADS_QUERY_API_S_VER_1 */
--
1.7.10.4
^ permalink raw reply related
* [PATCH RESEND 3.9 4/4] iwlwifi: bump required firmware API version for 3160/7260
From: Emmanuel Grumbach @ 2013-07-15 11:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
In-Reply-To: <1373888804-3077-1-git-send-email-emmanuel.grumbach@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
commit a2d0909a687b4d250cc2b7481072e361678745ba upstream.
As the firmware API has changed significantly and we don't
have support code for the old APIs, bump the version to be
able to release the version 7 API firmware.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/iwlwifi/pcie/7000.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/pcie/7000.c b/drivers/net/wireless/iwlwifi/pcie/7000.c
index 6e35b2b..25c33b0 100644
--- a/drivers/net/wireless/iwlwifi/pcie/7000.c
+++ b/drivers/net/wireless/iwlwifi/pcie/7000.c
@@ -31,16 +31,16 @@
#include "cfg.h"
/* Highest firmware API version supported */
-#define IWL7260_UCODE_API_MAX 6
-#define IWL3160_UCODE_API_MAX 6
+#define IWL7260_UCODE_API_MAX 7
+#define IWL3160_UCODE_API_MAX 7
/* Oldest version we won't warn about */
-#define IWL7260_UCODE_API_OK 6
-#define IWL3160_UCODE_API_OK 6
+#define IWL7260_UCODE_API_OK 7
+#define IWL3160_UCODE_API_OK 7
/* Lowest firmware API version supported */
-#define IWL7260_UCODE_API_MIN 6
-#define IWL3160_UCODE_API_MIN 6
+#define IWL7260_UCODE_API_MIN 7
+#define IWL3160_UCODE_API_MIN 7
/* NVM versions */
#define IWL7260_NVM_VERSION 0x0a1d
--
1.7.10.4
^ permalink raw reply related
* Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
From: John Greene @ 2013-07-15 12:15 UTC (permalink / raw)
To: Joe Perches; +Cc: linville, arend, linux-wireless
In-Reply-To: <1373652022.2614.13.camel@joe-AO722>
On 07/12/2013 02:00 PM, Joe Perches wrote:
> On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
>> Relegate 2 phy messages to debug status as they create excessive
>> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
>
> Hi John,
>
> Just trivia:
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> []
>> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> []
>> - brcms_err(wlc->hw->d11core,
>> + brcms_dbg_ht(wlc->hw->d11core,
>> "%s: ampdu tx phy error (0x%x)\n",
>> __func__, txs->phyerr);
>
> Please keep the indentation of the arguments of
> the same statement aligned to the open parenthesis.
>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> []
>> @@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
> []
>> - brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> + brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
>> txs->phyerr, txh->MainRates);
>
> Here too.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
I'll fix this and post v2.
--
John Greene
^ permalink raw reply
* Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages
From: Joe Perches @ 2013-07-15 12:23 UTC (permalink / raw)
To: John Greene; +Cc: linville, arend, linux-wireless
In-Reply-To: <51E3E7F0.7050308@redhat.com>
On Mon, 2013-07-15 at 08:15 -0400, John Greene wrote:
> On 07/12/2013 02:00 PM, Joe Perches wrote:
> > On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
[]
> > Just trivia:
> >> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> > []
> >> @@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> > []
> >> - brcms_err(wlc->hw->d11core,
> >> + brcms_dbg_ht(wlc->hw->d11core,
> >> "%s: ampdu tx phy error (0x%x)\n",
> >> __func__, txs->phyerr);
> >
> > Please keep the indentation of the arguments of
> > the same statement aligned to the open parenthesis.
[]
> Thanks Joe. My oversight. I wish the checkpatch flagged this stuff.
It does if you use the --strict option.
^ permalink raw reply
* Re: pull request: bluetooth 2013-06-23
From: Pavel Machek @ 2013-07-15 12:28 UTC (permalink / raw)
To: Gustavo Padovan, Marcel Holtmann, linville, linux-wireless,
linux-bluetooth, linux-kernel, Rafael J. Wysocki
In-Reply-To: <20130626124736.GA3337@joana>
>On Wed 2013-06-26 13:47:36, Gustavo Padovan wrote:
> * Pavel Machek <pavel@ucw.cz> [2013-06-26 13:52:55 +0200]:
>
> > On Tue 2013-06-25 22:00:39, Gustavo Padovan wrote:
> > > Hi Marcel,
> > >
> > > * Marcel Holtmann <marcel@holtmann.org> [2013-06-25 13:49:19 -0700]:
> > >
> > > > Hi Pavel,
> > > >
> > > > >> Jaganath Kanakkassery (1):
> > > > >> Bluetooth: Fix invalid length check in l2cap_information_rsp()
> > > > >
> > > > > Could we add the "3.10 vs. thinkpad x60" patch that fixes regression?
> > > > > It is from Johan Hedberg…
> > > >
> > > > that one went into net-next tree. It is scheduled for 3.11 right now.
> > > >
> > > > After 3.10 is out, maybe it can go into -stable, but otherwise I think it is bit late now. Unless someone wants to cherry-pick it.
> > >
> > > That patch is actually in 3.10 already, it was included in the last pull
> > > request and John took it to wireless.git.
> >
> > Is it? I tried pulling yesterday (some updates) and today (no
> > changes), am on:
>
> Dave already pulled it so it should land in mainline anytime soon.
It seems to work in 3.10 and 3.11-rc1. Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply
* [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
From: Felix Fietkau @ 2013-07-15 12:35 UTC (permalink / raw)
To: linux-wireless; +Cc: johannes, krzysiek
When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
the assignment further down, after the rate_control_send_low call.
Reported-by: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: stable@vger.kernel.org # 3.10
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
net/mac80211/rc80211_minstrel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
index ac7ef54..e6512e2 100644
--- a/net/mac80211/rc80211_minstrel.c
+++ b/net/mac80211/rc80211_minstrel.c
@@ -290,7 +290,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
struct minstrel_rate *msr, *mr;
unsigned int ndx;
bool mrr_capable;
- bool prev_sample = mi->prev_sample;
+ bool prev_sample;
int delta;
int sampling_ratio;
@@ -314,6 +314,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
(mi->sample_count + mi->sample_deferred / 2);
/* delta < 0: no sampling required */
+ prev_sample = mi->prev_sample;
mi->prev_sample = false;
if (delta < 0 || (!mrr_capable && prev_sample))
return;
--
1.8.0.2
^ permalink raw reply related
* Re: [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
From: Joe Perches @ 2013-07-15 12:50 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, johannes, krzysiek
In-Reply-To: <1373891706-1071-1-git-send-email-nbd@openwrt.org>
On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote:
> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
> the assignment further down, after the rate_control_send_low call.
>
> Reported-by: Krzysztof Mazur <krzysiek@podlesie.net>
> Cc: stable@vger.kernel.org # 3.10
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Why should this be marked for stable?
It's a local reference only, it's not used.
It's like suggesting that all the initialized
automatics should not be set until after
rate_control_set_low is called.
> ---
> net/mac80211/rc80211_minstrel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
> index ac7ef54..e6512e2 100644
> --- a/net/mac80211/rc80211_minstrel.c
> +++ b/net/mac80211/rc80211_minstrel.c
> @@ -290,7 +290,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
> struct minstrel_rate *msr, *mr;
> unsigned int ndx;
> bool mrr_capable;
> - bool prev_sample = mi->prev_sample;
> + bool prev_sample;
> int delta;
> int sampling_ratio;
>
> @@ -314,6 +314,7 @@ minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
> (mi->sample_count + mi->sample_deferred / 2);
>
> /* delta < 0: no sampling required */
> + prev_sample = mi->prev_sample;
> mi->prev_sample = false;
> if (delta < 0 || (!mrr_capable && prev_sample))
> return;
^ permalink raw reply
* Re: [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
From: Felix Fietkau @ 2013-07-15 12:54 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-wireless, johannes, krzysiek
In-Reply-To: <1373892651.2062.11.camel@joe-AO722>
On 2013-07-15 2:50 PM, Joe Perches wrote:
> On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote:
>> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
>> the assignment further down, after the rate_control_send_low call.
>>
>> Reported-by: Krzysztof Mazur <krzysiek@podlesie.net>
>> Cc: stable@vger.kernel.org # 3.10
>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> Why should this be marked for stable?
>
> It's a local reference only, it's not used.
>
> It's like suggesting that all the initialized
> automatics should not be set until after
> rate_control_set_low is called.
mi is set to priv_sta. It can be NULL. The case of priv_sta==NULL is
caught by rate_control_send_low and causes it to bail out.
- Felix
^ permalink raw reply
* Re: Help adding trace events to xHCI
From: Mathieu Desnoyers @ 2013-07-15 12:55 UTC (permalink / raw)
To: Mark Wielaard
Cc: Sarah Sharp, Kalle Valo, Johannes Berg, Xenia Ragiadakou,
OPW Kernel Interns List, linux-usb, linux-wireless,
Steven Rostedt, linux-trace-users, lttng-dev
In-Reply-To: <20130712193531.GA6954@toonder.wildebeest.org>
* Mark Wielaard (mjw@redhat.com) wrote:
> Hi Mathieu,
>
> On Fri, Jul 12, 2013 at 01:08:28PM -0400, Mathieu Desnoyers wrote:
> > * Sarah Sharp (sarah.a.sharp@linux.intel.com) wrote:
> > > Thanks for the suggestion. I'm not familiar with all the userspace
> > > tools for trace events, so I didn't know about the command parser. Is
> > > there documentation or a list of resources for all the userspace trace
> > > event plugins? If so, can you give us a pointer to it?
> >
> > You might want to try out LTTng-UST. It provides TRACEPOINT_EVENT() and
> > tracepoint() for user-space instrumentation. See:
> >
> > - https://lttng.org/files/doc/man-pages/man3/lttng-ust.3.html
>
> Is that build on the <sys/sdt.h> ust probe points as embedded in glibc
> for example that gdb and systemtap use to access user space trace
> points?
LTTng-UST tracepoints are not built on sdt.h, but they can optionally
emit sdt.h instrumentation. All you need to do is run:
./configure --with-sdt
when configuring lttng-ust, and after a make install, sdt.h
STAP_PROBEV() will be emitted whenever a lttng-ust tracepoint() macro is
used in the system.
> Can tools use lttng-ust and <sys/sdt.h> tracepoints
> interchangeably by parsing the ELF notes described in
> http://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation
Since lttng-ust tracepoints emit sdt.h instrumentation, yes. However,
please note that the reverse is not possible: sdt.h instrumentation does
not allow tracing with LTTng-UST.
Thanks,
Mathieu
>
> Thanks,
>
> Mark
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply
* [PATCH v2] brcmsmac: Further reduce log spam from tx phy messages
From: John Greene @ 2013-07-15 13:31 UTC (permalink / raw)
To: linville; +Cc: arend, linux-wireless
Relegate 2 phy messages to debug status as they create excessive
log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
This is a follow on to net-next 99e94940697adec4f84758adb2db71f4a82c7ba5:
brcmsmac: Reduce log spam in heavy tx, make err print in debug
brcmsmac bcma0:0: phyerr 0x10, rate 0x14
brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
ampdu tx phy error (0x10)
ver 2: Two trivial whitespace fixes.
Signed-off-by: John Greene <jogreene@redhat.com>
---
drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 6 +++---
drivers/net/wireless/brcm80211/brcmsmac/main.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
index bd98285..fa391e4 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
@@ -928,9 +928,9 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
}
} else if (txs->phyerr) {
update_rate = false;
- brcms_err(wlc->hw->d11core,
- "%s: ampdu tx phy error (0x%x)\n",
- __func__, txs->phyerr);
+ brcms_dbg_ht(wlc->hw->d11core,
+ "%s: ampdu tx phy error (0x%x)\n",
+ __func__, txs->phyerr);
}
}
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
index 9fd6f2f..7ca10bf 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
@@ -882,8 +882,8 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
mcl = le16_to_cpu(txh->MacTxControlLow);
if (txs->phyerr)
- brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
- txs->phyerr, txh->MainRates);
+ brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
+ txs->phyerr, txh->MainRates);
if (txs->frameid != le16_to_cpu(txh->TxFrameID)) {
brcms_err(wlc->hw->d11core, "frameid != txh->TxFrameID\n");
--
1.7.11.7
^ permalink raw reply related
* Re: [PATCH 3.11] mac80211/minstrel: fix NULL pointer dereference issue
From: Joe Perches @ 2013-07-15 13:31 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, johannes, krzysiek
In-Reply-To: <51E3F0EA.3060603@openwrt.org>
On Mon, 2013-07-15 at 14:54 +0200, Felix Fietkau wrote:
> On 2013-07-15 2:50 PM, Joe Perches wrote:
> > On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote:
> >> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move
> >> the assignment further down, after the rate_control_send_low call.
[]
> mi is set to priv_sta. It can be NULL. The case of priv_sta==NULL is
> caught by rate_control_send_low and causes it to bail out.
OK, thanks.
^ permalink raw reply
* Re: Help adding trace events to xHCI
From: Jiri Olsa @ 2013-07-15 13:47 UTC (permalink / raw)
To: Steven Rostedt
Cc: Sarah Sharp, Kalle Valo, Johannes Berg, Xenia Ragiadakou,
OPW Kernel Interns List, linux-usb, linux-wireless,
linux-trace-users
In-Reply-To: <1373648143.17876.98.camel@gandalf.local.home>
On Fri, Jul 12, 2013 at 12:55:43PM -0400, Steven Rostedt wrote:
> On Fri, 2013-07-12 at 09:41 -0700, Sarah Sharp wrote:
> > On Fri, Jul 12, 2013 at 07:25:59AM +0300, Kalle Valo wrote:
>
> > Thanks for the suggestion. I'm not familiar with all the userspace
> > tools for trace events, so I didn't know about the command parser. Is
> > there documentation or a list of resources for all the userspace trace
> > event plugins? If so, can you give us a pointer to it?
> >
>
> Currently the plugins only exist in trace-cmd. But there's going to be
> work done to get them into the kernel tools directory. I was just
> talking with Jiri about this today. Perf will require it.
hi,
I made initial backport but got distracted.. ;-)
I'll refresh those patches and resend them out soon..
jirka
^ permalink raw reply
* Re: [Ilw] Re: Slow throughput on Ultimate-N 6300
From: Emmanuel Grumbach @ 2013-07-15 15:27 UTC (permalink / raw)
To: Mariano Aliaga
Cc: Grumbach, Emmanuel, Steve Freitas, ilw@linux.intel.com,
linux-wireless@vger.kernel.org
In-Reply-To: <CAGLHXEnKS-Yz4uia=-KW7HLYUZ9nt_Pba_ZDyfEoehWGaHsUmg@mail.gmail.com>
Hi Mariano,
> I've been also experiencing the "fail to flush tx fifo" bug for a
> long time, so I'll provide my environment and logs in case it's
> helpful:
>
> - System: Thinkpad T410
> - Chipset: Intel Corporation Centrino Advanced-N 6200 [8086:4239] (rev 35)
> - Kernel: 3.10.0 x86_64 (tried 3.2, 3.5, 3.8 and 3.9 also. It got a
> lot better on 3.10 btw)
> - Firmware: 9.221.4.1 build 25532
> - AP: Linksys E1200 fw ver 1.0.00 build 11 (but happens also with
> other N AP's)
> - Log on dmesg: this repeated 12 times when I booted and connected
> to my wifi network
>
> [ 19.576029] iwlwifi 0000:03:00.0: fail to flush all tx fifo queues Q 0
> [ 19.576039] iwlwifi 0000:03:00.0: Current SW read_ptr 3 write_ptr 4
> [ 19.576089] iwl data: 00000000: 08 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 ................
> [ 19.576125] iwlwifi 0000:03:00.0: FH TRBs(0) = 0x00000000
> [ 19.576183] iwlwifi 0000:03:00.0: FH TRBs(1) = 0x80102004
> [ 19.576196] iwlwifi 0000:03:00.0: FH TRBs(2) = 0x00000000
> [ 19.576209] iwlwifi 0000:03:00.0: FH TRBs(3) = 0x80300003
> [ 19.576222] iwlwifi 0000:03:00.0: FH TRBs(4) = 0x00000000
> [ 19.576235] iwlwifi 0000:03:00.0: FH TRBs(5) = 0x00000000
> [ 19.576248] iwlwifi 0000:03:00.0: FH TRBs(6) = 0x00000000
> [ 19.576261] iwlwifi 0000:03:00.0: FH TRBs(7) = 0x00704040
> [ 19.576317] iwlwifi 0000:03:00.0: Q 0 is active and mapped to fifo
> 3 ra_tid 0x0000 [3,4]
> [ 19.576373] iwlwifi 0000:03:00.0: Q 1 is active and mapped to fifo
> 2 ra_tid 0x0000 [0,0]
> [ 19.576429] iwlwifi 0000:03:00.0: Q 2 is active and mapped to fifo
> 1 ra_tid 0x0000 [4,5]
> [ 19.576484] iwlwifi 0000:03:00.0: Q 3 is active and mapped to fifo
> 0 ra_tid 0x0000 [0,0]
> [ 19.576540] iwlwifi 0000:03:00.0: Q 4 is active and mapped to fifo
> 7 ra_tid 0x0000 [65,65]
> [ 19.576595] iwlwifi 0000:03:00.0: Q 5 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576651] iwlwifi 0000:03:00.0: Q 6 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576705] iwlwifi 0000:03:00.0: Q 7 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576761] iwlwifi 0000:03:00.0: Q 8 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576815] iwlwifi 0000:03:00.0: Q 9 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576871] iwlwifi 0000:03:00.0: Q 10 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576928] iwlwifi 0000:03:00.0: Q 11 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.576983] iwlwifi 0000:03:00.0: Q 12 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577038] iwlwifi 0000:03:00.0: Q 13 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577094] iwlwifi 0000:03:00.0: Q 14 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577149] iwlwifi 0000:03:00.0: Q 15 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577204] iwlwifi 0000:03:00.0: Q 16 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577261] iwlwifi 0000:03:00.0: Q 17 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577317] iwlwifi 0000:03:00.0: Q 18 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.577372] iwlwifi 0000:03:00.0: Q 19 is inactive and mapped to
> fifo 0 ra_tid 0x0000 [0,0]
> [ 19.628329] cfg80211: Calling CRDA to update world regulatory domain
> [ 19.632242] cfg80211: World regulatory domain updated:
> [ 19.632245] cfg80211: (start_freq - end_freq @ bandwidth),
> (max_antenna_gain, max_eirp)
> [ 19.632247] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 19.632249] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 19.632250] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz),
> (300 mBi, 2000 mBm)
> [ 19.632252] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 19.632253] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz),
> (300 mBi, 2000 mBm)
> [ 23.041735] wlan0: authenticate with 58:6d:8f:c3:47:2e
> [ 23.068235] wlan0: send auth to 58:6d:8f:c3:47:2e (try 1/3)
> [ 23.081353] wlan0: authenticated
> [ 23.082190] wlan0: associate with 58:6d:8f:c3:47:2e (try 1/3)
> [ 23.085720] wlan0: RX AssocResp from 58:6d:8f:c3:47:2e (capab=0x411
> status=0 aid=6)
> [ 23.091628] wlan0: associated
>
> This does not always happen, it's kind of random. I think it
> happens more frequently in places with a lot of wifi networks
> available.
> I'll try with older firmwares as suggested and let you know. I can
> provide more info if you need.
>
Yes, we know about this. You are (really) not the first to complain.
Unfortunately, I can't point to any fix right now.
^ permalink raw reply
* Re: [PATCH] mac80211: fix duplicate retransmission detection
From: Jason Andryuk @ 2013-07-15 16:15 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1373747861.5549.0.camel@jlt4.sipsolutions.net>
On Sat, Jul 13, 2013 at 4:37 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Sat, 2013-07-13 at 12:28 -0400, Jason Andryuk wrote:
>
>> > + if (rx->skb->len >= 24 && rx->sta &&
>>
>> Shouldn't this check rx->skb first?
>> if (rx->sta && rx->sta->len >= 24 &&
>
> Hmm? did you mean rx->skb? But what makes you think it can be NULL???
Whoops, I totally misread sta v skb. Sorry for the noise.
Jason
^ permalink raw reply
* Re: [PATCH v2] brcmsmac: Further reduce log spam from tx phy messages
From: Arend van Spriel @ 2013-07-15 16:26 UTC (permalink / raw)
To: John Greene; +Cc: linville, linux-wireless
In-Reply-To: <1373895092-27057-1-git-send-email-jogreene@redhat.com>
On 07/15/13 15:31, John Greene wrote:
> Relegate 2 phy messages to debug status as they create excessive
> log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.
> This is a follow on to net-next 99e94940697adec4f84758adb2db71f4a82c7ba5:
> brcmsmac: Reduce log spam in heavy tx, make err print in debug
>
> brcmsmac bcma0:0: phyerr 0x10, rate 0x14
> brcmsmac bcma0:0: brcms_c_ampdu_dotxstatus_complete:
> ampdu tx phy error (0x10)
Hi John,
Thanks for the patch. Still trying to find where these are coming from,
but we seem to have slight variation of this device not showing this.
> ver 2: Two trivial whitespace fixes.
this kind of info recommended to be placed under the signed-off line so
it does not end up in the git log. Apart from that you can add my ack.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: John Greene<jogreene@redhat.com>
> ---
so here
---
> drivers/net/wireless/brcm80211/brcmsmac/ampdu.c | 6 +++---
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> index bd98285..fa391e4 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
> @@ -928,9 +928,9 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
> }
> } else if (txs->phyerr) {
> update_rate = false;
> - brcms_err(wlc->hw->d11core,
> - "%s: ampdu tx phy error (0x%x)\n",
> - __func__, txs->phyerr);
> + brcms_dbg_ht(wlc->hw->d11core,
> + "%s: ampdu tx phy error (0x%x)\n",
> + __func__, txs->phyerr);
> }
> }
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index 9fd6f2f..7ca10bf 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -882,8 +882,8 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
> mcl = le16_to_cpu(txh->MacTxControlLow);
>
> if (txs->phyerr)
> - brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
> - txs->phyerr, txh->MainRates);
> + brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
> + txs->phyerr, txh->MainRates);
>
> if (txs->frameid != le16_to_cpu(txh->TxFrameID)) {
> brcms_err(wlc->hw->d11core, "frameid != txh->TxFrameID\n");
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox