* [PATCH 12/12] wireless: rtl818x: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:32 UTC (permalink / raw)
To: 'John W. Linville'; +Cc: linux-wireless, 'Jingoo Han'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/rtl818x/rtl8180/dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8180/dev.c b/drivers/net/wireless/rtl818x/rtl8180/dev.c
index fc207b2..a91506b 100644
--- a/drivers/net/wireless/rtl818x/rtl8180/dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8180/dev.c
@@ -1122,7 +1122,6 @@ static int rtl8180_probe(struct pci_dev *pdev,
iounmap(priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related
* [PATCH 11/12] wireless: p54pci: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:30 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Christian Lamparter', 'Alexey Khoroshilov',
'Larry Finger'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/p54/p54pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index 57e3af8..f9a07b0 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -631,7 +631,6 @@ static int p54p_probe(struct pci_dev *pdev,
iounmap(priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
p54_free_common(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related
* Re: [PATCH 01/12] wireless: iwlwifi: remove unnecessary pci_set_drvdata()
From: Emmanuel Grumbach @ 2013-09-10 11:30 UTC (permalink / raw)
To: Jingoo Han
Cc: John W. Linville, linux-wireless, Johannes Berg,
Emmanuel Grumbach, ilw@linux.intel.com
In-Reply-To: <00b201ceae17$2e5c3a00$8b14ae00$%han@samsung.com>
On Tue, Sep 10, 2013 at 2:16 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/iwlwifi/pcie/drv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
I picked it up - thanks.
^ permalink raw reply
* [PATCH 10/12] wireless: orinoco: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:29 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Alexey Khoroshilov', 'Kumar Amit Mehta'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/orinoco/orinoco_nortel.c | 2 --
drivers/net/wireless/orinoco/orinoco_pci.c | 2 --
drivers/net/wireless/orinoco/orinoco_plx.c | 2 --
drivers/net/wireless/orinoco/orinoco_tmd.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/drivers/net/wireless/orinoco/orinoco_nortel.c b/drivers/net/wireless/orinoco/orinoco_nortel.c
index d73fdf6..ffb2469 100644
--- a/drivers/net/wireless/orinoco/orinoco_nortel.c
+++ b/drivers/net/wireless/orinoco/orinoco_nortel.c
@@ -234,7 +234,6 @@ static int orinoco_nortel_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -265,7 +264,6 @@ static void orinoco_nortel_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io);
diff --git a/drivers/net/wireless/orinoco/orinoco_pci.c b/drivers/net/wireless/orinoco/orinoco_pci.c
index 677bf14..5ae1191 100644
--- a/drivers/net/wireless/orinoco/orinoco_pci.c
+++ b/drivers/net/wireless/orinoco/orinoco_pci.c
@@ -184,7 +184,6 @@ static int orinoco_pci_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -205,7 +204,6 @@ static void orinoco_pci_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_release_regions(pdev);
diff --git a/drivers/net/wireless/orinoco/orinoco_plx.c b/drivers/net/wireless/orinoco/orinoco_plx.c
index 2559dbd..bbd36d1 100644
--- a/drivers/net/wireless/orinoco/orinoco_plx.c
+++ b/drivers/net/wireless/orinoco/orinoco_plx.c
@@ -273,7 +273,6 @@ static int orinoco_plx_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -301,7 +300,6 @@ static void orinoco_plx_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io);
diff --git a/drivers/net/wireless/orinoco/orinoco_tmd.c b/drivers/net/wireless/orinoco/orinoco_tmd.c
index 42afeee..04b08de 100644
--- a/drivers/net/wireless/orinoco/orinoco_tmd.c
+++ b/drivers/net/wireless/orinoco/orinoco_tmd.c
@@ -170,7 +170,6 @@ static int orinoco_tmd_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -195,7 +194,6 @@ static void orinoco_tmd_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->bridge_io);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 09/12] wireless: mwl8k: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:27 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Lennert Buytenhek'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/mwl8k.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index a3707fd..b953ad6 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -6093,7 +6093,6 @@ err_iounmap:
if (priv->sram != NULL)
pci_iounmap(pdev, priv->sram);
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
err_free_reg:
@@ -6147,7 +6146,6 @@ static void mwl8k_remove(struct pci_dev *pdev)
unmap:
pci_iounmap(pdev, priv->regs);
pci_iounmap(pdev, priv->sram);
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
pci_release_regions(pdev);
pci_disable_device(pdev);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 08/12] wireless: ipw2x00: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:27 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Stanislav Yakovlev'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ipw2x00/ipw2200.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 6b823a1..f394af7 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -11885,7 +11885,6 @@ static int ipw_pci_probe(struct pci_dev *pdev,
pci_release_regions(pdev);
out_pci_disable_device:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
out_free_libipw:
free_libipw(priv->net_dev, 0);
out:
@@ -11966,7 +11965,6 @@ static void ipw_pci_remove(struct pci_dev *pdev)
iounmap(priv->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
/* wiphy_unregister needs to be here, before free_libipw */
wiphy_unregister(priv->ieee->wdev.wiphy);
kfree(priv->ieee->a_band.channels);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 07/12] wireless: wil6210: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:26 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Vladimir Kondratiev', wil6210
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ath/wil6210/pcie_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c
index eb1dc7a..eeceab3 100644
--- a/drivers/net/wireless/ath/wil6210/pcie_bus.c
+++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
@@ -197,7 +197,6 @@ static void wil_pcie_remove(struct pci_dev *pdev)
pci_iounmap(pdev, wil->csr);
pci_release_region(pdev, 0);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(wil6210_pcie_ids) = {
--
1.7.10.4
^ permalink raw reply related
* [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:25 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Kalle Valo',
ath10k
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index e2f9ef5..5ef0422 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -2414,7 +2414,6 @@ err_region:
err_device:
pci_disable_device(pdev);
err_ar:
- pci_set_drvdata(pdev, NULL);
ath10k_core_destroy(ar);
err_ar_pci:
/* call HIF PCI free here */
@@ -2442,7 +2441,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev)
ath10k_core_unregister(ar);
- pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, ar_pci->mem);
pci_release_region(pdev, BAR_NUM);
pci_clear_master(pdev);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 05/12] wireless: airo: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:23 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'David Howells'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/airo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 7fe1964..edf4b57 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -5570,7 +5570,6 @@ static void airo_pci_remove(struct pci_dev *pdev)
airo_print_info(dev->name, "Unregistering...");
stop_airo_card(dev, 1);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static int airo_pci_suspend(struct pci_dev *pdev, pm_message_t state)
--
1.7.10.4
^ permalink raw reply related
* [PATCH 04/12] wireless: adm8211: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:22 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Thomas Huehn',
'Karl Beldan'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/adm8211.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index f9a24e5..cfce83e 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -1924,7 +1924,6 @@ static int adm8211_probe(struct pci_dev *pdev,
pci_iounmap(pdev, priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related
* [PATCH 03/12] wireless: iwlegacy: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:19 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Stanislaw Gruszka'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/iwlegacy/3945-mac.c | 2 --
drivers/net/wireless/iwlegacy/4965-mac.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index 9581d07..dea3b50 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -3811,7 +3811,6 @@ out_iounmap:
out_pci_release_regions:
pci_release_regions(pdev);
out_pci_disable_device:
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
out_ieee80211_free_hw:
ieee80211_free_hw(il->hw);
@@ -3888,7 +3887,6 @@ il3945_pci_remove(struct pci_dev *pdev)
iounmap(il->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
il_free_channel_map(il);
il_free_geos(il);
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 5ab50a5..3982ab7 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -6706,7 +6706,6 @@ out_free_eeprom:
out_iounmap:
iounmap(il->hw_base);
out_pci_release_regions:
- pci_set_drvdata(pdev, NULL);
pci_release_regions(pdev);
out_pci_disable_device:
pci_disable_device(pdev);
@@ -6787,7 +6786,6 @@ il4965_pci_remove(struct pci_dev *pdev)
iounmap(il->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
il4965_uninit_drv(il);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 02/12] wireless: rtlwifi: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:18 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Larry Finger',
'Chaoming Li'
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/rtlwifi/pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 703f839..2b6d3e0 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -2009,7 +2009,6 @@ fail2:
fail1:
if (hw)
ieee80211_free_hw(hw);
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return err;
@@ -2064,8 +2063,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
rtl_pci_disable_aspm(hw);
- pci_set_drvdata(pdev, NULL);
-
ieee80211_free_hw(hw);
}
EXPORT_SYMBOL(rtl_pci_disconnect);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 01/12] wireless: iwlwifi: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:16 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Johannes Berg',
'Emmanuel Grumbach', ilw
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/iwlwifi/pcie/drv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c b/drivers/net/wireless/iwlwifi/pcie/drv.c
index dc02cb9..5c5c423 100644
--- a/drivers/net/wireless/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
@@ -349,7 +349,6 @@ out_free_drv:
iwl_drv_stop(trans_pcie->drv);
out_free_trans:
iwl_trans_pcie_free(iwl_trans);
- pci_set_drvdata(pdev, NULL);
return ret;
}
@@ -360,8 +359,6 @@ static void iwl_pci_remove(struct pci_dev *pdev)
iwl_drv_stop(trans_pcie->drv);
iwl_trans_pcie_free(trans);
-
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_PM_SLEEP
--
1.7.10.4
^ permalink raw reply related
* [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata()
From: Jingoo Han @ 2013-09-10 11:14 UTC (permalink / raw)
To: 'John W. Linville'; +Cc: linux-wireless, 'Jingoo Han'
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
---
drivers/net/wireless/adm8211.c | 1 -
drivers/net/wireless/airo.c | 1 -
drivers/net/wireless/ath/ath10k/pci.c | 2 --
drivers/net/wireless/ath/wil6210/pcie_bus.c | 1 -
drivers/net/wireless/ipw2x00/ipw2200.c | 2 --
drivers/net/wireless/iwlegacy/3945-mac.c | 2 --
drivers/net/wireless/iwlegacy/4965-mac.c | 2 --
drivers/net/wireless/iwlwifi/pcie/drv.c | 3 ---
drivers/net/wireless/mwl8k.c | 2 --
drivers/net/wireless/orinoco/orinoco_nortel.c | 2 --
drivers/net/wireless/orinoco/orinoco_pci.c | 2 --
drivers/net/wireless/orinoco/orinoco_plx.c | 2 --
drivers/net/wireless/orinoco/orinoco_tmd.c | 2 --
drivers/net/wireless/p54/p54pci.c | 1 -
drivers/net/wireless/rtl818x/rtl8180/dev.c | 1 -
drivers/net/wireless/rtlwifi/pci.c | 3 ---
16 files changed, 29 deletions(-)
^ permalink raw reply
* ath9k_htc embedded modules
From: Drasko DRASKOVIC @ 2013-09-10 10:09 UTC (permalink / raw)
To: linux-wireless
Hi all,
anyone aware of ath9k_htc supported embedded modules on the market
(Atheros AR9002U UB94, i.e. AR9280+AR7010 combo).
All I could find from USB based modules is Ralink RT5572 and RT3572
and I do not know how these are supported in linux-wireless (for
example AP mode).
Best regards,
Drasko
^ permalink raw reply
* Re: Linux Wireless Mini-Summit in New Orleans -- 19-20 September
From: Samuel Ortiz @ 2013-09-10 9:46 UTC (permalink / raw)
To: Marcel Holtmann
Cc: John W.Linville, Dan Williams, linux-wireless, johannes,
Gustavo Padovan, linux-bluetooth, linux-nfc
In-Reply-To: <6D969CDD-C551-4C4C-A674-A7518B3EE0AC@holtmann.org>
Hi Marcel, John,
On Mon, 2013-09-09 at 13:48 -0700, Marcel Holtmann wrote:
> Hi John,
>
> >>>> Sorry, forgot to copy linux-bluetooth and linux-nfc...
> >>>>
> >>>> On Thu, Aug 08, 2013 at 02:54:11PM -0400, John W. Linville wrote:
> >>>>> Greetings!
> >>>>>
> >>>>> This is a reminder that we will have a Linux Wireless Mini-Summit in
> >>>>> New Orleans this year on 19-20 September. This will immediately follow
> >>>>> LinuxCon and will run concurrently with Linux Plumber's Conference.
> >>>>> This event includes Linux developers for wireless LAN (802.11),
> >>>>> Bluetooth, and NFC technologies. Both kernel and userland developers
> >>>>> are welcomed and heartily encouraged to attend!
> >>>>>
> >>>>> http://wireless.kernel.org/en/developers/Summits/New-Orleans-2013
> >>>>>
> >>>>> The link above is a Wiki. We are using it to collect discussion
> >>>>> topics and to negotiate agenda/scheduling options for the event.
> >>>>> Please go there to record your intent to attend the event and to
> >>>>> propopse topics for discussion.
> >>>>>
> >>>>> Please be aware that in order to attend the event above one must
> >>>>> register for either LinuxCon or for Linux Plumbers Conference.
> >>>>> Act now, before those events fill-up and close their registrations!
> >>>>>
> >>>>> We are allotted one "large" room (up to ~80 people "theater style"), and
> >>>>> two "small" rooms (up to ~25 people) for this event. Based on history
> >>>>> and the numbers of contributors, the larger room will primarily be
> >>>>> for the 802.11 discussions and any "plenary" topics while the smaller
> >>>>> rooms will be for Bluetooth, NFC, and any "breakout" topics.
> >>>>>
> >>>>> So...thoughts? Topics to discuss?
> >>>
> >>> Ping? We're now just 2 weeks away!
> >>>
> >>> Is our topic list complete? It looks a bit light...
> >>>
> >>> Anyone have any input on scheduling the topics? Are there any
> >>> overlapping LPC sessions that it would make sense to work around?
> >>
> >> I'm attending though I haven't put my name on the wiki yet.
> >>
> >> Random thoughts; it doesn't look like any of these are covered in the
> >> regular LinuxConf or LPC sessions.
> >>
> >> 1) State of the Union (maybe by multiple people in the same session per
> >> their expertise), since perhaps not everyone doing eg 802.11 stuff knows
> >> what's happening in BT or NFC land, or not everyone working on a
> >> specific driver may know what new stuff their driver might need to be
> >> fixed up for. Maybe 5 minutes or less for things like:
> >>
> >> * what's under the most active development right now?
> >> * upcoming new driver, hardware, and new capabilities
> >> * new 802.11 standards
> >> * and what's coming up in the next year from the standards orgs
> >> * what people will start working on soon
> >> * what will 3.13 or 3.14 look like from a wireless perspective?
> >> * 11s mesh status?
> >> * anything interesting in wpa_supplicant land?
> >> * anything new/interesting on the Android front?
> >>
> >> 2) Bluetooth - update about what's new and what's coming up in Bluez
> >> land, and interaction with kernel 802.11 if any,
> >>
> >> 3) NFC - update about what's new and what's coming up in NFC land, where
> >> it's getting used, what the stack looks like
> >>
> >> 4) What are users having the most problems with and how these problems
> >> be fixed better/more quickly? Are they driver bugs? Are they stack
> >> bugs? Supplicant bugs? NM/GUI/etc bugs? Is there anything in our
> >> development processes that's not working as smoothly as it could be?
> >
> > Thanks, Dan -- those all look like decent discussion points.
> > I've added most of the points above to the topic list:
> >
> > http://wireless.kernel.org/en/developers/Summits/New-Orleans-2013
> >
> > Now, we need a few volunteers...
> >
> > Gustavo, can you do a session on Bluetooth developments?
> >
> > Samuel, can you cover NFC?
>
> I can do the Bluetooth part and I am just volunteering Samuel for NFC ;)
Thanks Marcel for the initiative ;)
John, I'll do the NFC part, sorry for not being able to reply earlier.
Cheers,
Samuel.
^ permalink raw reply
* Re: Always send management frames at MCS-0??
From: Krishna Chaitanya @ 2013-09-10 9:17 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-wireless@vger.kernel.org, hostap@lists.shmoo.com
In-Reply-To: <522E5558.4070008@candelatech.com>
On Tue, Sep 10, 2013 at 4:40 AM, Ben Greear <greearb@candelatech.com> wrote:
> Would forcing them to a lower rate at least theoretically improve
> the chance that the packets are properly delivered?
Yes. But we already have a RC algorithm taking care of that.
Right?
^ permalink raw reply
* Re: [PATCH 06/12] wlcore: send EAPOL frames with voice priority
From: Luca Coelho @ 2013-09-10 9:15 UTC (permalink / raw)
To: Arik Nemtsov; +Cc: Eliad Peller, linux-wireless@vger.kernel.org
In-Reply-To: <CA+XVXfc6RG1BngT_+doiOUhtYAgnG9Q0-oXns-ckJkU7XhE5ag@mail.gmail.com>
On Tue, 2013-09-10 at 11:11 +0200, Arik Nemtsov wrote:
> On Tue, Sep 10, 2013 at 9:47 AM, Luca Coelho <luca@coelho.fi> wrote:
> > On Tue, 2013-09-03 at 17:34 +0300, Eliad Peller wrote:
> >> From: Igal Chernobelsky <igalc@ti.com>
> >>
> >> Send EAPOL frames with voice priority by setting TX_HW_ATTR_EAPOL_FRAME
> >> new bit in tx attribute. Sending EAPOL with voice priority fixes
> >> re-key timeout during heavy traffic issue.
> >>
> >> Signed-off-by: Igal Chernobelsky <igalc@ti.com>
> >> Signed-off-by: Eliad Peller <eliad@wizery.com>
> >> ---
> >
> > This seems to be the same problem that Ben had and debugged by himself
> > [1]. Fixing this in hostapd/wpa_supplicant seems more appropriate?
> >
> > This patch seems to take an advantage of some sort of hack in the
> > firmware that will change the priority by itself when the
> > TX_HW_ATTR_EAPOL_GRAME bit is set. If we have a good reason to use this
> > patch, we need to take care of the firmware version as well. This
> > probably doesn't work with the latest published firmware.
> >
> > [1] http://mid.gmane.org/522E18E5.1020503@candelatech.com
>
> I believe he only fixed one mode (AP - hostapd) but not the other (GO
> - wpa_supplicant). Anyway that's what we tested at the time.
Okay, I didn't dig much into it.
> Anyway marking it as this level doesn't do any harm. You're right
> about the FW version though - it should be upstreamed first.
Fair enough. If the firmware implements this, no reason why not use it.
But I'll wait for the new firmware before applying this.
--
Luca.
^ permalink raw reply
* Re: [PATCH 06/12] wlcore: send EAPOL frames with voice priority
From: Arik Nemtsov @ 2013-09-10 9:11 UTC (permalink / raw)
To: Luca Coelho; +Cc: Eliad Peller, linux-wireless@vger.kernel.org
In-Reply-To: <1378795636.4799.44.camel@porter.coelho.fi>
On Tue, Sep 10, 2013 at 9:47 AM, Luca Coelho <luca@coelho.fi> wrote:
> On Tue, 2013-09-03 at 17:34 +0300, Eliad Peller wrote:
>> From: Igal Chernobelsky <igalc@ti.com>
>>
>> Send EAPOL frames with voice priority by setting TX_HW_ATTR_EAPOL_FRAME
>> new bit in tx attribute. Sending EAPOL with voice priority fixes
>> re-key timeout during heavy traffic issue.
>>
>> Signed-off-by: Igal Chernobelsky <igalc@ti.com>
>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>> ---
>
> This seems to be the same problem that Ben had and debugged by himself
> [1]. Fixing this in hostapd/wpa_supplicant seems more appropriate?
>
> This patch seems to take an advantage of some sort of hack in the
> firmware that will change the priority by itself when the
> TX_HW_ATTR_EAPOL_GRAME bit is set. If we have a good reason to use this
> patch, we need to take care of the firmware version as well. This
> probably doesn't work with the latest published firmware.
>
> [1] http://mid.gmane.org/522E18E5.1020503@candelatech.com
I believe he only fixed one mode (AP - hostapd) but not the other (GO
- wpa_supplicant). Anyway that's what we tested at the time.
Anyway marking it as this level doesn't do any harm. You're right
about the FW version though - it should be upstreamed first.
Arik
^ permalink raw reply
* [PATCH 8/8] wireless: wl12xx: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:58 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Luciano Coelho'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ti/wl12xx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl12xx/main.c b/drivers/net/wireless/ti/wl12xx/main.c
index 1c627da..591526b 100644
--- a/drivers/net/wireless/ti/wl12xx/main.c
+++ b/drivers/net/wireless/ti/wl12xx/main.c
@@ -1704,7 +1704,7 @@ static struct ieee80211_sta_ht_cap wl12xx_ht_cap = {
static int wl12xx_setup(struct wl1271 *wl)
{
struct wl12xx_priv *priv = wl->priv;
- struct wlcore_platdev_data *pdev_data = wl->pdev->dev.platform_data;
+ struct wlcore_platdev_data *pdev_data = dev_get_platdata(&wl->pdev->dev);
struct wl12xx_platform_data *pdata = pdev_data->pdata;
wl->rtable = wl12xx_rtable;
--
1.7.10.4
^ permalink raw reply related
* [PATCH 7/8] wireless: wlcore: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:57 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Luciano Coelho'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ti/wlcore/main.c | 2 +-
drivers/net/wireless/ti/wlcore/spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 38995f9..c30e1f1 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -5900,7 +5900,7 @@ static void wlcore_nvs_cb(const struct firmware *fw, void *context)
{
struct wl1271 *wl = context;
struct platform_device *pdev = wl->pdev;
- struct wlcore_platdev_data *pdev_data = pdev->dev.platform_data;
+ struct wlcore_platdev_data *pdev_data = dev_get_platdata(&pdev->dev);
struct wl12xx_platform_data *pdata = pdev_data->pdata;
unsigned long irqflags;
int ret;
diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index 1b0cd98..b2c018d 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -335,7 +335,7 @@ static int wl1271_probe(struct spi_device *spi)
if (!pdev_data)
goto out;
- pdev_data->pdata = spi->dev.platform_data;
+ pdev_data->pdata = dev_get_platdata(&spi->dev);
if (!pdev_data->pdata) {
dev_err(&spi->dev, "no platform data\n");
ret = -ENODEV;
--
1.7.10.4
^ permalink raw reply related
* [PATCH 6/8] wireless: wl1251: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:57 UTC (permalink / raw)
To: 'John W. Linville'; +Cc: linux-wireless, 'Jingoo Han'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ti/wl1251/spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/spi.c b/drivers/net/wireless/ti/wl1251/spi.c
index c7dc6fe..1342f81 100644
--- a/drivers/net/wireless/ti/wl1251/spi.c
+++ b/drivers/net/wireless/ti/wl1251/spi.c
@@ -243,7 +243,7 @@ static int wl1251_spi_probe(struct spi_device *spi)
struct wl1251 *wl;
int ret;
- pdata = spi->dev.platform_data;
+ pdata = dev_get_platdata(&spi->dev);
if (!pdata) {
wl1251_error("no platform data");
return -ENODEV;
--
1.7.10.4
^ permalink raw reply related
* [PATCH 5/8] wireless: libertas: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:56 UTC (permalink / raw)
To: 'John W. Linville'; +Cc: linux-wireless, 'Jingoo Han'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/libertas/if_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
index 4bb6574..5d39ec8 100644
--- a/drivers/net/wireless/libertas/if_spi.c
+++ b/drivers/net/wireless/libertas/if_spi.c
@@ -1128,7 +1128,7 @@ static int if_spi_probe(struct spi_device *spi)
{
struct if_spi_card *card;
struct lbs_private *priv = NULL;
- struct libertas_spi_platform_data *pdata = spi->dev.platform_data;
+ struct libertas_spi_platform_data *pdata = dev_get_platdata(&spi->dev);
int err = 0;
lbs_deb_enter(LBS_DEB_SPI);
--
1.7.10.4
^ permalink raw reply related
* [PATCH 4/8] wireless: cw1200: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:55 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Solomon Peachy'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/cw1200/cw1200_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/cw1200/cw1200_spi.c b/drivers/net/wireless/cw1200/cw1200_spi.c
index d063760..b7d1e0f 100644
--- a/drivers/net/wireless/cw1200/cw1200_spi.c
+++ b/drivers/net/wireless/cw1200/cw1200_spi.c
@@ -355,7 +355,7 @@ static struct hwbus_ops cw1200_spi_hwbus_ops = {
static int cw1200_spi_probe(struct spi_device *func)
{
const struct cw1200_platform_data_spi *plat_data =
- func->dev.platform_data;
+ dev_get_platdata(&func->dev);
struct hwbus_priv *self;
int status;
@@ -431,7 +431,7 @@ static int cw1200_spi_disconnect(struct spi_device *func)
}
kfree(self);
}
- cw1200_spi_off(func->dev.platform_data);
+ cw1200_spi_off(dev_get_platdata(&func->dev));
return 0;
}
--
1.7.10.4
^ permalink raw reply related
* [PATCH 3/8] wireless: brcmfmac: use dev_get_platdata()
From: Jingoo Han @ 2013-09-10 8:54 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Brett Rudley',
'Arend van Spriel', 'Franky (Zhenhui) Lin',
'Hante Meuleman'
In-Reply-To: <005101ceae02$9cbb95f0$d632c1d0$%han@samsung.com>
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
index 64f4a2b..592ae13 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
@@ -468,7 +468,7 @@ static int brcmf_sdio_pd_probe(struct platform_device *pdev)
brcmf_dbg(SDIO, "Enter\n");
- brcmfmac_sdio_pdata = pdev->dev.platform_data;
+ brcmfmac_sdio_pdata = dev_get_platdata(&pdev->dev);
if (brcmfmac_sdio_pdata->power_on)
brcmfmac_sdio_pdata->power_on();
--
1.7.10.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox