* Re: [PATCH] Add protection to get_expected_throughput opcode
From: Julian Calaby @ 2016-09-04 3:22 UTC (permalink / raw)
To: Maxim Altshul; +Cc: Johannes Berg, linux-wireless
In-Reply-To: <20160811103816.1695-1-maxim.altshul@ti.com>
Hi Maxim,
On Thu, Aug 11, 2016 at 8:38 PM, Maxim Altshul <maxim.altshul@ti.com> wrote:
> The patch is done with respect to the patch that was applied:
> [PATCH v3] mac80211: mesh: Add support for HW RC implementation
>
> 1. Patch adds protection as we discussed
> 2. Patch changes the function call that is made in the mesh patch
> to comply with the change.
>
> Maxim Altshul (1):
> mac80211: Add protection to get_expected_throughput opcode
>
> net/mac80211/driver-ops.h | 8 ++++----
> net/mac80211/sta_info.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Where's the patch?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] staging: wilc1000: fix spelling mistake: "retyring" -> "retrying"
From: Julian Calaby @ 2016-09-04 3:16 UTC (permalink / raw)
To: Colin King
Cc: Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman,
linux-wireless, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
In-Reply-To: <20160828112841.10919-1-colin.king@canonical.com>
Hi All,
On Sun, Aug 28, 2016 at 9:28 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] ath10k: Spelling and miscellaneous neatening
From: Julian Calaby @ 2016-09-04 3:16 UTC (permalink / raw)
To: Joe Perches
Cc: Kalle Valo, ath10k, linux-wireless, netdev,
linux-kernel@vger.kernel.org
In-Reply-To: <95a6b65277914d88178ed2b15e182455067cca60.1472490319.git.joe@perches.com>
Hi All,
On Tue, Aug 30, 2016 at 3:05 AM, Joe Perches <joe@perches.com> wrote:
> Correct some trivial comment typos.
> Remove unnecessary parentheses in a long line.
> Convert a return; before the end of a void function definition to just ;
>
> Signed-off-by: Joe Perches <joe@perches.com>
This all looks correct to me. I wish you'd put the code changes in a
separate patch, however it's all noted in the commit log, so...
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"
From: Julian Calaby @ 2016-09-04 3:09 UTC (permalink / raw)
To: Colin King
Cc: Jes Sorensen, Kalle Valo, linux-wireless, netdev,
linux-kernel@vger.kernel.org
In-Reply-To: <20160903164354.13331-1-colin.king@canonical.com>
Hi All,
On Sun, Sep 4, 2016 at 2:43 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistakes in dev_dbg message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: wcn36xx: Implement print_reg indication
From: Kalle Valo @ 2016-09-03 17:36 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev,
linux-kernel, Nicolas Dechesne
In-Reply-To: <1467308789-23475-1-git-send-email-bjorn.andersson@linaro.org>
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> Some firmware versions sends a "print register indication", handle this
> by printing out the content.
>
> Cc: Nicolas Dechesne <ndec@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This doesn't apply anymore, please rebase.
--
Sent by pwcli
https://patchwork.kernel.org/patch/9208737/
^ permalink raw reply
* Re: ath9k: bring back direction setting in ath9k_{start_stop}
From: Kalle Valo @ 2016-09-03 17:35 UTC (permalink / raw)
To: Giedrius Statkevi?ius
Cc: kvalo, ath9k-devel, linux-wireless, ath9k-devel, netdev,
linux-kernel, Miaoqing Pan, stable, Giedrius Statkevičius
In-Reply-To: <20160901174702.8645-1-giedrius.statkevicius@gmail.com>
Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote:
> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup
> led_pin initial") that broken the WLAN status led on my laptop with
> AR9287 after suspending and resuming.
>
> Steps to reproduce:
> * Suspend (laptop)
> * Resume (laptop)
> * Observe that the WLAN led no longer turns ON/OFF depending on the
> status and is always red
>
> Even though for my case it only needs to be set to OUT in ath9k_start
> but for consistency bring back the IN direction setting as well.
>
> Cc: Miaoqing Pan <miaoqing@codeaurora.org>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
I'm planning to queue this to 4.8 if no objections.
--
Sent by pwcli
https://patchwork.kernel.org/patch/9309829/
^ permalink raw reply
* Re: rtlwifi/rtl8192de: Fix print format string
From: Kalle Valo @ 2016-09-03 17:05 UTC (permalink / raw)
To: Oleg Drokin
Cc: Larry Finger, Chaoming Li, linux-wireless, linux-kernel,
Oleg Drokin
In-Reply-To: <1472267543-810602-1-git-send-email-green@linuxhacker.ru>
Oleg Drokin <green@linuxhacker.ru> wrote:
> %ul was likely meant as %lu to print an unsigned long,
> not an unsigned with a letter l at the end.
> But in fact the value printed is u32 anyway, so just drop
> the l completely.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
5856cd5b8dda rtlwifi/rtl8192de: Fix print format string
--
Sent by pwcli
https://patchwork.kernel.org/patch/9302259/
^ permalink raw reply
* Re: [1/3] mwifiex: make "PCI-E is not the winner" print more informative
From: Kalle Valo @ 2016-09-03 17:03 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless, Amitkumar Karwar, Nishant Sarmukadam,
Stanislaw Gruszka
In-Reply-To: <1472137518-10431-2-git-send-email-sgruszka@redhat.com>
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Printing ret and adapter->winner do not provide any useful information
> as those are always 0 at point where the massage is printed. Print value
> read from reg->fw_status register instead.
>
> Stanislaw Gruszka <sgruszka@redhat.com>
Thanks, 3 patches applied to wireless-drivers-next.git:
fd3fbb65cab8 mwifiex: make "PCI-E is not the winner" print more informative
09dd9ec598c3 mwifiex: print status of FW ready event
b9aebb69ecd3 mwifiex: do not print dot when downloading FW
--
Sent by pwcli
https://patchwork.kernel.org/patch/9299495/
^ permalink raw reply
* Re: wl18xx: add time sync configuration api
From: Kalle Valo @ 2016-09-03 17:02 UTC (permalink / raw)
To: Guy Mishol; +Cc: linux-wireless, Guy Mishol
In-Reply-To: <20160824113527.5040-1-guym@ti.com>
Guy Mishol <guym@ti.com> wrote:
> Add time sync configuration api.
> The new api allows to configure the synchronization
> mode (STA/AP/MESH) and (in case of Mesh mode) the
> master address of each zone.
>
> Signed-off-by: Guy Mishol <guym@ti.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
c5aa9541818a wl18xx: add time sync configuration api
--
Sent by pwcli
https://patchwork.kernel.org/patch/9297563/
^ permalink raw reply
* Re: [v2,1/1] brcmfmac: fix pmksa->bssid usage
From: Kalle Valo @ 2016-09-03 17:02 UTC (permalink / raw)
To: Nicolas Iooss
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, linux-wireless,
brcm80211-dev-list.pdl, netdev, linux-kernel, Nicolas Iooss
In-Reply-To: <20160823093717.1065-1-nicolas.iooss_linux@m4x.org>
Nicolas Iooss <nicolas.iooss_linux@m4x.org> wrote:
> The struct cfg80211_pmksa defines its bssid field as:
>
> const u8 *bssid;
>
> contrary to struct brcmf_pmksa, which uses:
>
> u8 bssid[ETH_ALEN];
>
> Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address
> of this field (of type u8**), not the one of its content (which would be
> u8*). Remove the & operator to make brcmf_dbg("%pM") and memcmp()
> behave as expected.
>
> This bug have been found using a custom static checker (which checks the
> usage of %p... attributes at build time). It has been introduced in
> commit 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code"),
> which replaced pmksa->bssid by &pmksa->bssid while refactoring the code,
> without modifying struct cfg80211_pmksa definition.
>
> Replace &pmk[i].bssid with pmk[i].bssid too to make the code clearer,
> this change does not affect the semantic.
>
> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
7703773ef1d8 brcmfmac: fix pmksa->bssid usage
--
Sent by pwcli
https://patchwork.kernel.org/patch/9295351/
^ permalink raw reply
* Re: [v2] brcmfmac: Add USB ID for Cisco Linksys AE1200
From: Kalle Valo @ 2016-09-03 17:01 UTC (permalink / raw)
To: Ismael Luceno
Cc: linux-wireless, Ismael Luceno, brcm80211-dev-list,
Arend van Spriel, Rafał Miłecki
In-Reply-To: <20160822224007.300-1-ismael@iodev.co.uk>
Ismael Luceno <ismael@iodev.co.uk> wrote:
> The AE1200 comes with different revisions of the BCM43235 chipset,
> but all have the same USB ID. Only revision 3 can be supported.
>
> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
Thanks, 1 patch applied to wireless-drivers-next.git:
bccf3ffc8c6d brcmfmac: Add USB ID for Cisco Linksys AE1200
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294493/
^ permalink raw reply
* Re: [V2] rtlwifi: Fix missing country code for Great Britain
From: Kalle Valo @ 2016-09-03 17:00 UTC (permalink / raw)
To: Larry Finger; +Cc: devel, linux-wireless, Larry Finger, Stable
In-Reply-To: <1471894079-14330-1-git-send-email-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Some RTL8821AE devices sold in Great Britain have the country code of
> 0x25 encoded in their EEPROM. This value is not tested in the routine
> that establishes the regulatory info for the chip. The fix is to set
> this code to have the same capabilities as the EU countries. In addition,
> the channels allowed for COUNTRY_CODE_ETSI were more properly suited
> for China and Israel, not the EU. This problem has also been fixed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
0c9d34915307 rtlwifi: Fix missing country code for Great Britain
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294303/
^ permalink raw reply
* Re: rtlwifi: rtl8723ae: Fix leak in _rtl8723e_read_adapter_info()
From: Kalle Valo @ 2016-09-03 16:54 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Larry.Finger, chaoming_li, arnd, joe, linux-wireless,
Christian Engelmayer
In-Reply-To: <1470772452-24642-1-git-send-email-cengelma@gmx.at>
Christian Engelmayer <cengelma@gmx.at> wrote:
> In case of (rtlhal->oem_id != RT_CID_DEFAULT), the function directly
> returns and leaks the already allocated hwinfo memory. Go through the
> correct exit path.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
3eeacaa902a3 rtlwifi: rtl8723ae: Fix leak in _rtl8723e_read_adapter_info()
--
Sent by pwcli
https://patchwork.kernel.org/patch/9272147/
^ permalink raw reply
* Re: zd1211rw: fix spelling mistake "firmeware" -> "firmware"
From: Kalle Valo @ 2016-09-03 17:00 UTC (permalink / raw)
To: Colin Ian King
Cc: Daniel Drake, Ulrich Kunitz, linux-wireless, netdev, linux-kernel
In-Reply-To: <20160822183505.26568-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in dev_err message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
b46b599328e6 zd1211rw: fix spelling mistake "firmeware" -> "firmware"
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294163/
^ permalink raw reply
* Re: [01/20] rtl8xxxu: Mark 0x20f4:0x648b as tested
From: Kalle Valo @ 2016-09-03 16:59 UTC (permalink / raw)
To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger, Jes Sorensen
In-Reply-To: <1471643202-26250-2-git-send-email-Jes.Sorensen@redhat.com>
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Successfully tested by Jocelyn Mayer
>
> Reported-by: J. Mayer <l_indien@magic.fr>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Thanks, 20 patches applied to wireless-drivers-next.git:
b81669b9e0b4 rtl8xxxu: Mark 0x20f4:0x648b as tested
76a8e07d49b6 rtl8xxxu: Mark 0x2001:0x3308 as tested
deb6176e5613 rtl8xxxu: Fix error handling if rtl8xxxu_init_device() fails
690a6d268bdf rtl8xxxu: Add TP-Link TL-WN823N v2 to list of supported devices
44abaa08d002 rtl8xxxu: Add TX page defines for 8723b
e366f45d3627 rtl8xxxu: Switch 8723a to use new rtl8xxxu_init_queue_reserved_page() routine
b492940dc1f7 rtl8xxxu: Switch 8192cu/8188cu devices to use rtl8xxxu_init_queue_reserved_page()
efeb8ce7a98c rtl8xxxu: Remove now obsolete rtl8xxxu_old_init_queue_reserved_page()
e02aa3eef786 rtl8xxxu: Simplify code setting TX buffer boundary
dce7548fd970 rtl8xxxu: Add bit definitions for REG_FPGA0_TX_INFO
0b09628948bc rtl8xxxu: Add interrupt bit definitions for gen2 parts
e3ebcd7428c1 rtl8xxxu: Use flag to indicate whether device has TX report timer support
ee675cc30e07 rtl8xxxu: Convert flags in rtl8xxxu_fileops to bitflags
eed145ab25a3 rtl8xxxu: Introduce fops bitflag indicating type of thermal meter
be49b1f111c7 rtl8xxxu: Simplify calculating of hw value used for setting TX rate
3972cc579140 rtl8xxxu: Determine the need for SGI before handling specific TX desc formats
99afaac4278c rtl8xxxu: Determine need for shore preamble before updating TX descriptors
b59415c2dd08 rtl8xxxu: Split filling of TX descriptors into separate functions
77e3980201e7 rtl8xxxu: gen1: Fix non static symbol warning
7329dc13107b rtl8xxxu: Make rtl8xxxu_ampdu_action less chatty
--
Sent by pwcli
https://patchwork.kernel.org/patch/9291151/
^ permalink raw reply
* Re: [2/2,v2] wlcore: Remove wl pointer from wl_sta structure
From: Kalle Valo @ 2016-09-03 16:56 UTC (permalink / raw)
To: Maxim Altshul; +Cc: linux-kernel, Maxim Altshul, linux-wireless
In-Reply-To: <20160815082400.12053-1-maxim.altshul@ti.com>
Maxim Altshul <maxim.altshul@ti.com> wrote:
> This field was added to wl_sta struct to get hw in situations
> where it was not given to driver by mac80211. In our case,
> get_expected_throughput op did not send hw to driver.
>
> This patch reverts the change, as it is no longer needed due to commit
> 4fdbc67a25ce ("mac80211: call get_expected_throughput only after adding
> station") as hw is now sent as a parameter.
>
> Signed-off-by: Maxim Altshul <maxim.altshul@ti.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
d8c872b57e0f wlcore: Remove wl pointer from wl_sta structure
--
Sent by pwcli
https://patchwork.kernel.org/patch/9280419/
^ permalink raw reply
* Re: rtlwifi: rtl8192de: Fix leak in _rtl92de_read_adapter_info()
From: Kalle Valo @ 2016-09-03 16:52 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Larry.Finger, chaoming_li, arnd, linux-wireless,
Christian Engelmayer
In-Reply-To: <1470770397-24390-1-git-send-email-cengelma@gmx.at>
Christian Engelmayer <cengelma@gmx.at> wrote:
> In case rtl_get_hwinfo() fails, the function directly returns and leaks the
> already allocated hwinfo memory. Go through the correct exit path.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
a0c7858e7479 rtlwifi: rtl8192de: Fix leak in _rtl92de_read_adapter_info()
--
Sent by pwcli
https://patchwork.kernel.org/patch/9272131/
^ permalink raw reply
* [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"
From: Colin King @ 2016-09-03 16:43 UTC (permalink / raw)
To: Jes Sorensen, Kalle Valo, linux-wireless, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistakes in dev_dbg message.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 77048db..9cb1efa 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -3947,11 +3947,11 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
rtl8xxxu_write16(priv, REG_TRXFF_BNDY + 2, priv->fops->trxff_boundary);
ret = rtl8xxxu_download_firmware(priv);
- dev_dbg(dev, "%s: download_fiwmare %i\n", __func__, ret);
+ dev_dbg(dev, "%s: download_firmware %i\n", __func__, ret);
if (ret)
goto exit;
ret = rtl8xxxu_start_firmware(priv);
- dev_dbg(dev, "%s: start_fiwmare %i\n", __func__, ret);
+ dev_dbg(dev, "%s: start_firmware %i\n", __func__, ret);
if (ret)
goto exit;
--
2.9.3
^ permalink raw reply related
* [PATCH][V2] ath10k: fix memory leak on caldata on error exit path
From: Colin King @ 2016-09-03 16:38 UTC (permalink / raw)
To: Kalle Valo, ath10k, linux-wireless, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
caldata is not being free'd on the error exit path, causing
a memory leak and data definitely should not be freed. Free
caldata instead of data.
Thanks to Kalle Valo for spotting that data should not be
free'd.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 9a22c47..afdf0fa 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -2725,7 +2725,7 @@ static int ath10k_pci_hif_fetch_cal_eeprom(struct ath10k *ar, void **data,
return 0;
err_free:
- kfree(data);
+ kfree(caldata);
return -EINVAL;
}
--
2.9.3
^ permalink raw reply related
* Re: [PATCH] ath10k: fix memory leak on caldata on error exit path
From: Colin Ian King @ 2016-09-03 16:33 UTC (permalink / raw)
To: Valo, Kalle
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <87r392z4ox.fsf@kamboji.qca.qualcomm.com>
On 02/09/16 16:45, Valo, Kalle wrote:
> Colin King <colin.king@canonical.com> writes:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> caldata is not being free'd on the error exit path, causing
>> a memory leak. kfree it to fix the leak.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/ath/ath10k/pci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
>> index 9a22c47..886337c 100644
>> --- a/drivers/net/wireless/ath/ath10k/pci.c
>> +++ b/drivers/net/wireless/ath/ath10k/pci.c
>> @@ -2725,6 +2725,7 @@ static int ath10k_pci_hif_fetch_cal_eeprom(struct ath10k *ar, void **data,
>> return 0;
>>
>> err_free:
>> + kfree(caldata);
>> kfree(data);
>>
>> return -EINVAL;
>
> I don't think we should free data at all:
>
> static int ath10k_download_cal_eeprom(struct ath10k *ar)
> {
> size_t data_len;
> void *data = NULL;
> int ret;
>
> ret = ath10k_hif_fetch_cal_eeprom(ar, &data, &data_len);
>
> Instead we should free only caldata, right?
>
Yep, good catch, I'll send V2 later.
Colin
^ permalink raw reply
* Re: [PATCH] ath9k: bring back direction setting in ath9k_{start_stop}
From: Giedrius Statkevičius @ 2016-09-03 16:08 UTC (permalink / raw)
To: kvalo
Cc: ath9k-devel, linux-wireless, ath9k-devel, netdev, linux-kernel,
Miaoqing Pan, Kalle Valo, stable
In-Reply-To: <20160901174702.8645-1-giedrius.statkevicius@gmail.com>
Some more users complaining about this:
https://bbs.archlinux.org/viewtopic.php?id=215978
On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote:
> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup
> led_pin initial") that broken the WLAN status led on my laptop with
> AR9287 after suspending and resuming.
>
> Steps to reproduce:
> * Suspend (laptop)
> * Resume (laptop)
> * Observe that the WLAN led no longer turns ON/OFF depending on the
> status and is always red
>
> Even though for my case it only needs to be set to OUT in ath9k_start
> but for consistency bring back the IN direction setting as well.
>
> Cc: Miaoqing Pan <miaoqing@codeaurora.org>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
[...]
^ permalink raw reply
* Re: mwifiex: add PCIe function level reset support
From: Kalle Valo @ 2016-09-03 15:40 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: linux-wireless, Amitkumar Karwar
In-Reply-To: <1469541704-2880-1-git-send-email-akarwar@marvell.com>
Amitkumar Karwar <akarwar@marvell.com> wrote:
> This patch implements pre and post FLR handlers to support PCIe FLR
> functionality. Software cleanup is performed in pre-FLR whereas
> firmware is downloaded and software is re-initialised in
> post-FLR handler.
>
> Following command triggers FLR.
> echo "1" > /sys/bus/pci/devices/$NUMBER/reset
>
> This feature can be used as a recovery mechanism when firmware gets
> hang.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Doesn't apply anymore, please rebase.
Applying: mwifiex: add PCIe function level reset support
fatal: sha1 information is lacking or useless (drivers/net/wireless/marvell/mwifiex/main.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 mwifiex: add PCIe function level reset support
--
Sent by pwcli
https://patchwork.kernel.org/patch/9248233/
^ permalink raw reply
* Re: [v2] ErrHandling:Make IS_ERR_VALUE_U32 as generic API to avoid IS_ERR_VALUE abuses.
From: Kalle Valo @ 2016-09-03 14:29 UTC (permalink / raw)
To: Arvind Yadav
Cc: zajec5, viresh.kumar, akpm, linux-wireless, linux-kernel,
linville, Arvind Yadav
In-Reply-To: <1468083696-15283-1-git-send-email-arvind.yadav.cs@gmail.com>
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an 'unsigned int' reflects an error.
> As they pass an 'unsigned int' into a function that takes an
> 'unsigned long' argument. This happens to work because the type
> is sign-extended on 64-bit architectures before it gets converted
> into an unsigned type.
>
> However, anything that passes an 'unsigned short' or 'unsigned int'
> argument into IS_ERR_VALUE() is guaranteed to be broken, as are
> 8-bit integers and types that are wider than 'unsigned long'.
>
> It would be nice to any users that are not passing 'unsigned int'
> arguments.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
This touches include/linux/err.h and I'm not very enthusiastic to change
anything in include directory without wider support. I recommend first to just
fix bcma. And separately you can try to improve linux/err.h via some more
approariate tree, not via wireless trees.
--
Sent by pwcli
https://patchwork.kernel.org/patch/9222139/
^ permalink raw reply
* Re: [FIX?] brcmfmac: fix possible overflows in flowrings code by bumping u8 to u16
From: Kalle Valo @ 2016-09-03 14:06 UTC (permalink / raw)
To: Rafał Miłecki
Cc: linux-wireless, Brett Rudley, Arend van Spriel,
Franky (Zhenhui) Lin, Hante Meuleman, brcm80211-dev-list,
Rafał Miłecki
In-Reply-To: <1454198830-13971-1-git-send-email-zajec5@gmail.com>
Rafał Miłecki wrote:
> Some devices may use more than 255 flowings, below is log from BCM4366:
> [ 194.606245] brcmfmac: brcmf_pcie_init_ringbuffers Nr of flowrings is 264
>
> At various places we were using u8 which could lead to storing wrong
> number or infinite loops when indexing incorrectly. Initially this
> issue was spotted as infinite loop in brcmf_flowring_detach.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
There has been no activity on this patch so I'll drop this. Please resend if
this is still needed.
--
Sent by pwcli
https://patchwork.kernel.org/patch/8172531/
^ permalink raw reply
* Re: [v2] bcma: use of_dma_configure() to set initial dma mask
From: Kalle Valo @ 2016-09-03 14:08 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafał Miłecki, Arnd Bergmann, Hauke Mehrtens,
linux-wireless, linux-kernel
In-Reply-To: <1458207563-3453369-1-git-send-email-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> While fixing another bug, I noticed that bcma manually sets up
> a dma_mask pointer for its child devices. We have a generic
> helper for that now, which should be able to cope better with
> any variations that might be needed to deal with cache coherency,
> unusual DMA address offsets, iommus, or limited DMA masks, none
> of which are currently handled here.
>
> This changes the core to use the of_dma_configure(), like
> we do for platform devices that are probed directly from
> DT.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Nobody tested this, so I'll drop the patch.
--
Sent by pwcli
https://patchwork.kernel.org/patch/8608751/
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox