* [PATCH 2/5] drivers: staging: rtl8723au: core: simplify if-break-else
From: Matthias Beyer @ 2016-09-04 19:26 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, Larry Finger, Jes Sorensen, Manuel Messner,
Geliang Tang, Cihangir Akturk, linux-wireless, devel,
linux-kernel
In-Reply-To: <20160904192626.17197-1-mail@beyermatthias.de>
As the if statement breaks/continues the loop, the else block is not
useful and can be omitted.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Manuel Messner <manuel.johannes.messner@hs-furtwangen.de>
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 8b8b6a9..da9f298 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -244,21 +244,18 @@ static void _rtw_roaming(struct rtw_adapter *padapter,
do_join_r = rtw_do_join(padapter);
if (do_join_r == _SUCCESS)
break;
- else {
- DBG_8723A("roaming do_join return %d\n",
- do_join_r);
- pmlmepriv->to_roaming--;
- if (padapter->mlmepriv.to_roaming > 0)
- continue;
- else {
- DBG_8723A("%s(%d) -to roaming fail, "
- "indicate_disconnect\n",
- __func__, __LINE__);
- rtw_indicate_disconnect23a(padapter);
- break;
- }
- }
+ DBG_8723A("roaming do_join return %d\n", do_join_r);
+ pmlmepriv->to_roaming--;
+
+ if (padapter->mlmepriv.to_roaming > 0)
+ continue;
+
+ DBG_8723A("%s(%d) -to roaming fail, "
+ "indicate_disconnect\n",
+ __func__, __LINE__);
+ rtw_indicate_disconnect23a(padapter);
+ break;
}
}
}
--
2.9.3
^ permalink raw reply related
* [PATCH 1/5] drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
From: Matthias Beyer @ 2016-09-04 19:26 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, Larry Finger, Jes Sorensen, Manuel Messner,
Geliang Tang, Cihangir Akturk, linux-wireless, devel,
linux-kernel
In-Reply-To: <20160904192626.17197-1-mail@beyermatthias.de>
This patch fixes the ERRORs which are reported from the checkpatch.pl
script for this file.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
index a786fc4..8b8b6a9 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1397,7 +1397,7 @@ void rtw23a_join_to_handler (unsigned long data)
do_join_r = rtw_do_join(adapter);
if (do_join_r != _SUCCESS) {
DBG_8723A("%s roaming do_join return "
- "%d\n", __func__ , do_join_r);
+ "%d\n", __func__, do_join_r);
continue;
}
break;
@@ -1546,7 +1546,7 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv,
}
if (!*candidate ||
- (*candidate)->network.Rssi<competitor->network.Rssi) {
+ (*candidate)->network.Rssi < competitor->network.Rssi) {
*candidate = competitor;
updated = true;
}
@@ -1894,7 +1894,7 @@ static int SecIsInPMKIDList(struct rtw_adapter *Adapter, u8 *bssid)
do {
if (psecuritypriv->PMKIDList[i].bUsed &&
- ether_addr_equal(psecuritypriv->PMKIDList[i].Bssid, bssid)) {
+ ether_addr_equal(psecuritypriv->PMKIDList[i].Bssid, bssid)) {
break;
} else {
i++;
@@ -2139,7 +2139,7 @@ bool rtw_restructure_ht_ie23a(struct rtw_adapter *padapter, u8 *in_ie,
out_len = *pout_len;
pframe = rtw_set_ie23a(out_ie + out_len,
WLAN_EID_HT_OPERATION,
- p[1], p + 2 , pout_len);
+ p[1], p + 2, pout_len);
}
}
--
2.9.3
^ permalink raw reply related
* [PATCH 0/5] Some cleanup patches for drivers/staging/rtl8723au/core/rtw_mlme.c
From: Matthias Beyer @ 2016-09-04 19:26 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, Larry Finger, Jes Sorensen, Manuel Messner,
Geliang Tang, Cihangir Akturk, linux-wireless, devel,
linux-kernel
This patchset fixes some errors and warnings reported by checkpatch.pl.
Matthias Beyer (5):
drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
drivers: staging: rtl8723au: core: simplify if-break-else
drivers: staging: rtl8723au: core: Refactor pointless branching
drivers: staging: rtl8723au: core: Fix "space prohibited" warning
drivers: staging: rtl8723au: core: Fix indentation
drivers/staging/rtl8723au/core/rtw_mlme.c | 72 ++++++++++++++-----------------
1 file changed, 33 insertions(+), 39 deletions(-)
--
2.9.3
^ permalink raw reply
* [PATCH] mac80211: fix sequence number assignment for PS response frames
From: Felix Fietkau @ 2016-09-04 16:00 UTC (permalink / raw)
To: linux-wireless; +Cc: johannes
When using intermediate queues, sequence number allocation is deferred
until dequeue. This doesn't work for PS response frames, which bypass
those queues.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
net/mac80211/tx.c | 65 ++++++++++++++++++++++++++++---------------------------
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 5023966..cc8e955 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -796,6 +796,36 @@ static __le16 ieee80211_tx_next_seq(struct sta_info *sta, int tid)
return ret;
}
+static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local,
+ struct ieee80211_vif *vif,
+ struct ieee80211_sta *pubsta,
+ struct sk_buff *skb)
+{
+ struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
+ struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+ struct ieee80211_txq *txq = NULL;
+
+ if ((info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) ||
+ (info->control.flags & IEEE80211_TX_CTRL_PS_RESPONSE))
+ return NULL;
+
+ if (!ieee80211_is_data(hdr->frame_control))
+ return NULL;
+
+ if (pubsta) {
+ u8 tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK;
+
+ txq = pubsta->txq[tid];
+ } else if (vif) {
+ txq = vif->txq;
+ }
+
+ if (!txq)
+ return NULL;
+
+ return to_txq_info(txq);
+}
+
static ieee80211_tx_result debug_noinline
ieee80211_tx_h_sequence(struct ieee80211_tx_data *tx)
{
@@ -853,7 +883,8 @@ ieee80211_tx_h_sequence(struct ieee80211_tx_data *tx)
tid = *qc & IEEE80211_QOS_CTL_TID_MASK;
tx->sta->tx_stats.msdu[tid]++;
- if (!tx->sta->sta.txq[0])
+ if (!ieee80211_get_txq(tx->local, info->control.vif, &tx->sta->sta,
+ tx->skb))
hdr->seq_ctrl = ieee80211_tx_next_seq(tx->sta, tid);
return TX_CONTINUE;
@@ -1243,36 +1274,6 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
return TX_CONTINUE;
}
-static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local,
- struct ieee80211_vif *vif,
- struct ieee80211_sta *pubsta,
- struct sk_buff *skb)
-{
- struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
- struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
- struct ieee80211_txq *txq = NULL;
-
- if ((info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) ||
- (info->control.flags & IEEE80211_TX_CTRL_PS_RESPONSE))
- return NULL;
-
- if (!ieee80211_is_data(hdr->frame_control))
- return NULL;
-
- if (pubsta) {
- u8 tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK;
-
- txq = pubsta->txq[tid];
- } else if (vif) {
- txq = vif->txq;
- }
-
- if (!txq)
- return NULL;
-
- return to_txq_info(txq);
-}
-
static void ieee80211_set_skb_enqueue_time(struct sk_buff *skb)
{
IEEE80211_SKB_CB(skb)->control.enqueue_time = codel_get_time();
@@ -3264,7 +3265,7 @@ static bool ieee80211_xmit_fast(struct ieee80211_sub_if_data *sdata,
if (hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_QOS_DATA)) {
*ieee80211_get_qos_ctl(hdr) = tid;
- if (!sta->sta.txq[0])
+ if (!ieee80211_get_txq(local, &sdata->vif, &sta->sta, skb))
hdr->seq_ctrl = ieee80211_tx_next_seq(sta, tid);
} else {
info->flags |= IEEE80211_TX_CTL_ASSIGN_SEQ;
--
2.8.4
^ permalink raw reply related
* Re: [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test
From: Sudip Mukherjee @ 2016-09-04 15:11 UTC (permalink / raw)
To: Matthias Beyer
Cc: gregkh, devel, meleodr, ksenija.stanojevic, Jes.Sorensen,
linux-wireless, linux-kernel, shivanib134, bhaktipriya96,
bhumirks, Larry.Finger
In-Reply-To: <20160904110120.27028-2-mail@beyermatthias.de>
On Sun, Sep 04, 2016 at 01:01:20PM +0200, Matthias Beyer wrote:
> This patch removes the pointless `else if` test.
>
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
> Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
> ---
looks like Greg has already applied your first patch.
db0c12744f8d ("drivers: staging: rtl8723au: hal: Remove pointless test")
regards
sudip
^ permalink raw reply
* [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test
From: Matthias Beyer @ 2016-09-04 11:01 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
In-Reply-To: <20160901155447.GB7979@kroah.com>
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reported-by: David Binderman <linuxdev.baldrick@gmail.com>
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index 6989580..47e8d69 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -3530,7 +3530,7 @@ bthci_CmdLinkStatusNotify(
pBtMgnt->ExtConfig.linkInfo[i].BTProfile,
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec));
pTriple += 4;
- } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
+ } else {
pBtMgnt->ExtConfig.linkInfo[i].ConnectHandle = *((u16 *)&pTriple[0]);
pBtMgnt->ExtConfig.linkInfo[i].BTProfile = pTriple[2];
pBtMgnt->ExtConfig.linkInfo[i].BTCoreSpec = pTriple[3];
--
2.9.3
^ permalink raw reply related
* [PATCH v2 0/1] Remove pointless test
From: Matthias Beyer @ 2016-09-04 11:01 UTC (permalink / raw)
To: gregkh
Cc: Matthias Beyer, devel, linux-kernel, linux-wireless, shivanib134,
ksenija.stanojevic, Jes.Sorensen, meleodr, bhaktipriya96,
bhumirks, Larry.Finger
In-Reply-To: <20160901155447.GB7979@kroah.com>
Re-sending as
On 01-09-2016 17:54:47, Greg KH wrote:
> There is no patch here :(
----8<----
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matthias Beyer (1):
drivers: staging: rtl8723au: hal: Remove pointless test
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.9.3
^ permalink raw reply
* RE: [PATCH] Add protection to get_expected_throughput opcode
From: Altshul, Maxim @ 2016-09-04 6:24 UTC (permalink / raw)
To: Julian Calaby; +Cc: Johannes Berg, linux-wireless
In-Reply-To: <CAGRGNgVLbaxPm5oh7hPohMDi1a5RUiMY8VL=71YcnUY_7TJ1pQ@mail.gmail.com>
PiANCj4gV2hlcmUncyB0aGUgcGF0Y2g/DQo+IA0KWW91IGNhbiBzZWUgaXQgb24gbWFjODAyMTEt
bmV4dC4gDQpDb21taXQgNGZkYmM2N2EyNWNlNTc3Yjc5YjNhZjU5NWU4NzRlOWVmOTIxMzI5Zg0K
DQpNYXgNCj4gDQo+IEVtYWlsOiBqdWxpYW4uY2FsYWJ5QGdtYWlsLmNvbQ0KPiBQcm9maWxlOiBo
dHRwOi8vd3d3Lmdvb2dsZS5jb20vcHJvZmlsZXMvanVsaWFuLmNhbGFieS8NCg0KDQo=
^ permalink raw reply
* Re: [PATCH 2/2] mwifiex: simplify length computation for some memset
From: Julian Calaby @ 2016-09-04 3:24 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless, netdev,
linux-kernel@vger.kernel.org, kernel-janitors
In-Reply-To: <1470641940-26681-1-git-send-email-christophe.jaillet@wanadoo.fr>
Hi All,
On Mon, Aug 8, 2016 at 5:39 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> This patch should be a no-op. It just simplifies code by using the name of
> a variable instead of its type when calling 'sizeof'.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] Add protection to get_expected_throughput opcode
From: Julian Calaby @ 2016-09-04 3:22 UTC (permalink / raw)
To: Maxim Altshul; +Cc: Johannes Berg, linux-wireless
In-Reply-To: <20160811103816.1695-1-maxim.altshul@ti.com>
Hi Maxim,
On Thu, Aug 11, 2016 at 8:38 PM, Maxim Altshul <maxim.altshul@ti.com> wrote:
> The patch is done with respect to the patch that was applied:
> [PATCH v3] mac80211: mesh: Add support for HW RC implementation
>
> 1. Patch adds protection as we discussed
> 2. Patch changes the function call that is made in the mesh patch
> to comply with the change.
>
> Maxim Altshul (1):
> mac80211: Add protection to get_expected_throughput opcode
>
> net/mac80211/driver-ops.h | 8 ++++----
> net/mac80211/sta_info.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Where's the patch?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] staging: wilc1000: fix spelling mistake: "retyring" -> "retrying"
From: Julian Calaby @ 2016-09-04 3:16 UTC (permalink / raw)
To: Colin King
Cc: Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman,
linux-wireless, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
In-Reply-To: <20160828112841.10919-1-colin.king@canonical.com>
Hi All,
On Sun, Aug 28, 2016 at 9:28 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] ath10k: Spelling and miscellaneous neatening
From: Julian Calaby @ 2016-09-04 3:16 UTC (permalink / raw)
To: Joe Perches
Cc: Kalle Valo, ath10k, linux-wireless, netdev,
linux-kernel@vger.kernel.org
In-Reply-To: <95a6b65277914d88178ed2b15e182455067cca60.1472490319.git.joe@perches.com>
Hi All,
On Tue, Aug 30, 2016 at 3:05 AM, Joe Perches <joe@perches.com> wrote:
> Correct some trivial comment typos.
> Remove unnecessary parentheses in a long line.
> Convert a return; before the end of a void function definition to just ;
>
> Signed-off-by: Joe Perches <joe@perches.com>
This all looks correct to me. I wish you'd put the code changes in a
separate patch, however it's all noted in the commit log, so...
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"
From: Julian Calaby @ 2016-09-04 3:09 UTC (permalink / raw)
To: Colin King
Cc: Jes Sorensen, Kalle Valo, linux-wireless, netdev,
linux-kernel@vger.kernel.org
In-Reply-To: <20160903164354.13331-1-colin.king@canonical.com>
Hi All,
On Sun, Sep 4, 2016 at 2:43 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistakes in dev_dbg message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply
* Re: wcn36xx: Implement print_reg indication
From: Kalle Valo @ 2016-09-03 17:36 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev,
linux-kernel, Nicolas Dechesne
In-Reply-To: <1467308789-23475-1-git-send-email-bjorn.andersson@linaro.org>
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> Some firmware versions sends a "print register indication", handle this
> by printing out the content.
>
> Cc: Nicolas Dechesne <ndec@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This doesn't apply anymore, please rebase.
--
Sent by pwcli
https://patchwork.kernel.org/patch/9208737/
^ permalink raw reply
* Re: ath9k: bring back direction setting in ath9k_{start_stop}
From: Kalle Valo @ 2016-09-03 17:35 UTC (permalink / raw)
To: Giedrius Statkevi?ius
Cc: kvalo, ath9k-devel, linux-wireless, ath9k-devel, netdev,
linux-kernel, Miaoqing Pan, stable, Giedrius Statkevičius
In-Reply-To: <20160901174702.8645-1-giedrius.statkevicius@gmail.com>
Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote:
> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup
> led_pin initial") that broken the WLAN status led on my laptop with
> AR9287 after suspending and resuming.
>
> Steps to reproduce:
> * Suspend (laptop)
> * Resume (laptop)
> * Observe that the WLAN led no longer turns ON/OFF depending on the
> status and is always red
>
> Even though for my case it only needs to be set to OUT in ath9k_start
> but for consistency bring back the IN direction setting as well.
>
> Cc: Miaoqing Pan <miaoqing@codeaurora.org>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
I'm planning to queue this to 4.8 if no objections.
--
Sent by pwcli
https://patchwork.kernel.org/patch/9309829/
^ permalink raw reply
* Re: rtlwifi/rtl8192de: Fix print format string
From: Kalle Valo @ 2016-09-03 17:05 UTC (permalink / raw)
To: Oleg Drokin
Cc: Larry Finger, Chaoming Li, linux-wireless, linux-kernel,
Oleg Drokin
In-Reply-To: <1472267543-810602-1-git-send-email-green@linuxhacker.ru>
Oleg Drokin <green@linuxhacker.ru> wrote:
> %ul was likely meant as %lu to print an unsigned long,
> not an unsigned with a letter l at the end.
> But in fact the value printed is u32 anyway, so just drop
> the l completely.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
5856cd5b8dda rtlwifi/rtl8192de: Fix print format string
--
Sent by pwcli
https://patchwork.kernel.org/patch/9302259/
^ permalink raw reply
* Re: [1/3] mwifiex: make "PCI-E is not the winner" print more informative
From: Kalle Valo @ 2016-09-03 17:03 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless, Amitkumar Karwar, Nishant Sarmukadam,
Stanislaw Gruszka
In-Reply-To: <1472137518-10431-2-git-send-email-sgruszka@redhat.com>
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Printing ret and adapter->winner do not provide any useful information
> as those are always 0 at point where the massage is printed. Print value
> read from reg->fw_status register instead.
>
> Stanislaw Gruszka <sgruszka@redhat.com>
Thanks, 3 patches applied to wireless-drivers-next.git:
fd3fbb65cab8 mwifiex: make "PCI-E is not the winner" print more informative
09dd9ec598c3 mwifiex: print status of FW ready event
b9aebb69ecd3 mwifiex: do not print dot when downloading FW
--
Sent by pwcli
https://patchwork.kernel.org/patch/9299495/
^ permalink raw reply
* Re: wl18xx: add time sync configuration api
From: Kalle Valo @ 2016-09-03 17:02 UTC (permalink / raw)
To: Guy Mishol; +Cc: linux-wireless, Guy Mishol
In-Reply-To: <20160824113527.5040-1-guym@ti.com>
Guy Mishol <guym@ti.com> wrote:
> Add time sync configuration api.
> The new api allows to configure the synchronization
> mode (STA/AP/MESH) and (in case of Mesh mode) the
> master address of each zone.
>
> Signed-off-by: Guy Mishol <guym@ti.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
c5aa9541818a wl18xx: add time sync configuration api
--
Sent by pwcli
https://patchwork.kernel.org/patch/9297563/
^ permalink raw reply
* Re: [v2,1/1] brcmfmac: fix pmksa->bssid usage
From: Kalle Valo @ 2016-09-03 17:02 UTC (permalink / raw)
To: Nicolas Iooss
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, linux-wireless,
brcm80211-dev-list.pdl, netdev, linux-kernel, Nicolas Iooss
In-Reply-To: <20160823093717.1065-1-nicolas.iooss_linux@m4x.org>
Nicolas Iooss <nicolas.iooss_linux@m4x.org> wrote:
> The struct cfg80211_pmksa defines its bssid field as:
>
> const u8 *bssid;
>
> contrary to struct brcmf_pmksa, which uses:
>
> u8 bssid[ETH_ALEN];
>
> Therefore in brcmf_cfg80211_del_pmksa(), &pmksa->bssid takes the address
> of this field (of type u8**), not the one of its content (which would be
> u8*). Remove the & operator to make brcmf_dbg("%pM") and memcmp()
> behave as expected.
>
> This bug have been found using a custom static checker (which checks the
> usage of %p... attributes at build time). It has been introduced in
> commit 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code"),
> which replaced pmksa->bssid by &pmksa->bssid while refactoring the code,
> without modifying struct cfg80211_pmksa definition.
>
> Replace &pmk[i].bssid with pmk[i].bssid too to make the code clearer,
> this change does not affect the semantic.
>
> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
7703773ef1d8 brcmfmac: fix pmksa->bssid usage
--
Sent by pwcli
https://patchwork.kernel.org/patch/9295351/
^ permalink raw reply
* Re: [v2] brcmfmac: Add USB ID for Cisco Linksys AE1200
From: Kalle Valo @ 2016-09-03 17:01 UTC (permalink / raw)
To: Ismael Luceno
Cc: linux-wireless, Ismael Luceno, brcm80211-dev-list,
Arend van Spriel, Rafał Miłecki
In-Reply-To: <20160822224007.300-1-ismael@iodev.co.uk>
Ismael Luceno <ismael@iodev.co.uk> wrote:
> The AE1200 comes with different revisions of the BCM43235 chipset,
> but all have the same USB ID. Only revision 3 can be supported.
>
> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
Thanks, 1 patch applied to wireless-drivers-next.git:
bccf3ffc8c6d brcmfmac: Add USB ID for Cisco Linksys AE1200
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294493/
^ permalink raw reply
* Re: [V2] rtlwifi: Fix missing country code for Great Britain
From: Kalle Valo @ 2016-09-03 17:00 UTC (permalink / raw)
To: Larry Finger; +Cc: devel, linux-wireless, Larry Finger, Stable
In-Reply-To: <1471894079-14330-1-git-send-email-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Some RTL8821AE devices sold in Great Britain have the country code of
> 0x25 encoded in their EEPROM. This value is not tested in the routine
> that establishes the regulatory info for the chip. The fix is to set
> this code to have the same capabilities as the EU countries. In addition,
> the channels allowed for COUNTRY_CODE_ETSI were more properly suited
> for China and Israel, not the EU. This problem has also been fixed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org>
Thanks, 1 patch applied to wireless-drivers-next.git:
0c9d34915307 rtlwifi: Fix missing country code for Great Britain
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294303/
^ permalink raw reply
* Re: rtlwifi: rtl8723ae: Fix leak in _rtl8723e_read_adapter_info()
From: Kalle Valo @ 2016-09-03 16:54 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Larry.Finger, chaoming_li, arnd, joe, linux-wireless,
Christian Engelmayer
In-Reply-To: <1470772452-24642-1-git-send-email-cengelma@gmx.at>
Christian Engelmayer <cengelma@gmx.at> wrote:
> In case of (rtlhal->oem_id != RT_CID_DEFAULT), the function directly
> returns and leaks the already allocated hwinfo memory. Go through the
> correct exit path.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
3eeacaa902a3 rtlwifi: rtl8723ae: Fix leak in _rtl8723e_read_adapter_info()
--
Sent by pwcli
https://patchwork.kernel.org/patch/9272147/
^ permalink raw reply
* Re: zd1211rw: fix spelling mistake "firmeware" -> "firmware"
From: Kalle Valo @ 2016-09-03 17:00 UTC (permalink / raw)
To: Colin Ian King
Cc: Daniel Drake, Ulrich Kunitz, linux-wireless, netdev, linux-kernel
In-Reply-To: <20160822183505.26568-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in dev_err message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
b46b599328e6 zd1211rw: fix spelling mistake "firmeware" -> "firmware"
--
Sent by pwcli
https://patchwork.kernel.org/patch/9294163/
^ permalink raw reply
* Re: [01/20] rtl8xxxu: Mark 0x20f4:0x648b as tested
From: Kalle Valo @ 2016-09-03 16:59 UTC (permalink / raw)
To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger, Jes Sorensen
In-Reply-To: <1471643202-26250-2-git-send-email-Jes.Sorensen@redhat.com>
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Successfully tested by Jocelyn Mayer
>
> Reported-by: J. Mayer <l_indien@magic.fr>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Thanks, 20 patches applied to wireless-drivers-next.git:
b81669b9e0b4 rtl8xxxu: Mark 0x20f4:0x648b as tested
76a8e07d49b6 rtl8xxxu: Mark 0x2001:0x3308 as tested
deb6176e5613 rtl8xxxu: Fix error handling if rtl8xxxu_init_device() fails
690a6d268bdf rtl8xxxu: Add TP-Link TL-WN823N v2 to list of supported devices
44abaa08d002 rtl8xxxu: Add TX page defines for 8723b
e366f45d3627 rtl8xxxu: Switch 8723a to use new rtl8xxxu_init_queue_reserved_page() routine
b492940dc1f7 rtl8xxxu: Switch 8192cu/8188cu devices to use rtl8xxxu_init_queue_reserved_page()
efeb8ce7a98c rtl8xxxu: Remove now obsolete rtl8xxxu_old_init_queue_reserved_page()
e02aa3eef786 rtl8xxxu: Simplify code setting TX buffer boundary
dce7548fd970 rtl8xxxu: Add bit definitions for REG_FPGA0_TX_INFO
0b09628948bc rtl8xxxu: Add interrupt bit definitions for gen2 parts
e3ebcd7428c1 rtl8xxxu: Use flag to indicate whether device has TX report timer support
ee675cc30e07 rtl8xxxu: Convert flags in rtl8xxxu_fileops to bitflags
eed145ab25a3 rtl8xxxu: Introduce fops bitflag indicating type of thermal meter
be49b1f111c7 rtl8xxxu: Simplify calculating of hw value used for setting TX rate
3972cc579140 rtl8xxxu: Determine the need for SGI before handling specific TX desc formats
99afaac4278c rtl8xxxu: Determine need for shore preamble before updating TX descriptors
b59415c2dd08 rtl8xxxu: Split filling of TX descriptors into separate functions
77e3980201e7 rtl8xxxu: gen1: Fix non static symbol warning
7329dc13107b rtl8xxxu: Make rtl8xxxu_ampdu_action less chatty
--
Sent by pwcli
https://patchwork.kernel.org/patch/9291151/
^ permalink raw reply
* Re: [2/2,v2] wlcore: Remove wl pointer from wl_sta structure
From: Kalle Valo @ 2016-09-03 16:56 UTC (permalink / raw)
To: Maxim Altshul; +Cc: linux-kernel, Maxim Altshul, linux-wireless
In-Reply-To: <20160815082400.12053-1-maxim.altshul@ti.com>
Maxim Altshul <maxim.altshul@ti.com> wrote:
> This field was added to wl_sta struct to get hw in situations
> where it was not given to driver by mac80211. In our case,
> get_expected_throughput op did not send hw to driver.
>
> This patch reverts the change, as it is no longer needed due to commit
> 4fdbc67a25ce ("mac80211: call get_expected_throughput only after adding
> station") as hw is now sent as a parameter.
>
> Signed-off-by: Maxim Altshul <maxim.altshul@ti.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
d8c872b57e0f wlcore: Remove wl pointer from wl_sta structure
--
Sent by pwcli
https://patchwork.kernel.org/patch/9280419/
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox