* Re: [PATCH 07/10] iwlwifi: remove support for fw older than -17 and -22
From: Coelho, Luciano @ 2016-09-26 20:13 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org; +Cc: kvalo@codeaurora.org
In-Reply-To: <20160922205210.1778-8-luca@coelho.fi>
T24gVGh1LCAyMDE2LTA5LTIyIGF0IDIzOjUyICswMzAwLCBMdWNhIENvZWxobyB3cm90ZToNCj4g
RnJvbTogTHVjYSBDb2VsaG8gPGx1Y2lhbm8uY29lbGhvQGludGVsLmNvbT4NCj4gDQo+IEZXIHZl
cnNpb25zIG9sZGVyIHRoYW4gLTE3IGZvciAzMTYwIGFuZCA3MjYwIGFuZCBvbGRlciB0aGFuIC0y
MiBmb3INCj4gbmV3ZXIgTklDcyBhcmUgbm90IHN1cHBvcnRlZCBhbnltb3JlLsKgwqBEb24ndCBs
b2FkIHRoZXNlIHZlcnNpb25zDQo+IGFuZCByZW1vdmUgY29kZSB0aGF0IGhhbmRsZXMgdGhlbS4N
Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgQ29lbGhvIDxsdWNpYW5vLmNvZWxob0BpbnRlbC5j
b20+DQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgQ29lbGhvIDxsdWNpYW5vLmNvZWxob0BpbnRlbC5j
b20+DQo+IC0tLQ0KDQpIZWgsIGRvdWJsZSBTLU8tQi4gwqBJJ2xsIGZpeCB0aGlzIGJlZm9yZSBz
ZW5kaW5nIHRoZSBwdWxsIHJlcXVlc3QuDQoNCi0tDQpMdWNhLg==
^ permalink raw reply
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: Joe Perches @ 2016-09-26 18:43 UTC (permalink / raw)
To: Kalle Valo
Cc: SF Markus Elfring, linux-wireless, netdev, Jouni Malinen, LKML,
kernel-janitors, Julia Lawall
In-Reply-To: <87mviuy0b7.fsf@kamboji.qca.qualcomm.com>
On Mon, 2016-09-26 at 21:37 +0300, Kalle Valo wrote:
> I talked with Jouni and we concluded marking this fully obsolete is the
> best (so removing the "Maintained" part completelo the shmoo list
> is not used anymore, that can be removed.
Well, it would be best if Jouni submitted something.
^ permalink raw reply
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: Kalle Valo @ 2016-09-26 18:37 UTC (permalink / raw)
To: Joe Perches
Cc: SF Markus Elfring, linux-wireless, netdev, Jouni Malinen, LKML,
kernel-janitors, Julia Lawall
In-Reply-To: <1474913885.2238.19.camel@perches.com>
Joe Perches <joe@perches.com> writes:
> On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote:
>> hostap is an obsolete driver, it's waste of time doing style fixes to it
>> as nobody maintains it anymore.
>
> Dunno know if Jouni is still maintaining this at all
> but maybe a MAINTAINERS update to mark it obsolete so
> checkpatch warns on unnecessary changes.
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6e0a912c3b13..ff293e70fae6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5722,7 +5722,7 @@ M: Jouni Malinen
> L: hostap@shmoo.com (subscribers-only)
> L: linux-wireless@vger.kernel.org
> W: http://hostap.epitest.fi/
> -S: Maintained
> +S: Maintained / Obsolete
> F: drivers/net/wireless/intersil/hostap/
I talked with Jouni and we concluded marking this fully obsolete is the
best (so removing the "Maintained" part completely). Also the shmoo list
is not used anymore, that can be removed.
--
Kalle Valo
^ permalink raw reply
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: Joe Perches @ 2016-09-26 18:18 UTC (permalink / raw)
To: Kalle Valo, SF Markus Elfring
Cc: linux-wireless, netdev, Jouni Malinen, LKML, kernel-janitors,
Julia Lawall
In-Reply-To: <874m52zgjy.fsf@kamboji.qca.qualcomm.com>
On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote:
> hostap is an obsolete driver, it's waste of time doing style fixes to it
> as nobody maintains it anymore.
Dunno know if Jouni is still maintaining this at all
but maybe a MAINTAINERS update to mark it obsolete so
checkpatch warns on unnecessary changes.
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6e0a912c3b13..ff293e70fae6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5722,7 +5722,7 @@ M: Jouni Malinen
L: hostap@shmoo.com (subscribers-only)
L: linux-wireless@vger.kernel.org
W: http://hostap.epitest.fi/
-S: Maintained
+S: Maintained / Obsolete
F: drivers/net/wireless/intersil/hostap/
HP COMPAQ TC1100 TABLET WMI EXTRAS DRIVER
^ permalink raw reply related
* Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets
From: Kalle Valo @ 2016-09-26 18:16 UTC (permalink / raw)
To: IgorMitsyanko
Cc: johannes, linux-wireless, Avinash Patil, Dmitrii Lebed,
Sergei Maksimenko, Sergey Matyukevich, Bindu Therthala,
Huizhao Wang, Kamlesh Rath
In-Reply-To: <7ecc6f46-a65f-2342-d495-0decdeeef8fd@quantenna.com>
IgorMitsyanko <igor.mitsyanko.os@quantenna.com> writes:
> On 09/26/2016 01:56 PM, Kalle Valo wrote:
>> IgorMitsyanko <igor.mitsyanko.os@quantenna.com> writes:
>>> On 09/17/2016 04:46 PM, Kalle Valo wrote:
>>
>> For the initial submission please freeze the driver, otherwise it's pain
>> to review as the driver changes too much in-between review rounds. So at
>> this stage only minimal changes, please.
>>
>> You can continue adding new features and making changes, but do those as
>> follow up patches and use the initial submission as the baseline for the
>> new patches. Once the driver is applied you can submit the rest of the
>> patches adding new features and they will be reviewed similarly like all
>> other wireless patches.
>
> Ok, we will keep patch modification to minimum between revisions, but
> channels-related changes are something we would like to apply: we're
> setting SELF_MANAGED bit right now and do not handle regulatory hints
> from cfg80211, having all the regulatory-related info fixed on device
> itself (region, per-channel Tx powers, DFS requirements). This info is
> what was used to pass regulatory authorities certification, and
> considering seriousness of regulatory compliance requirement it's
> probably better to use the info that is known to be accepted.
> Would it be acceptable if we keep rates/capabilities logic intact, but
> will modify channel-related logic in next patch revision?
Sure, regulatory compliance is important and it's understandable that
you want to fix that. Just give a short summary in the change log what
you changed regarding regulatory to make it easier for the reviewers.
--
Kalle Valo
^ permalink raw reply
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: SF Markus Elfring @ 2016-09-26 18:06 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, netdev, Jouni Malinen, LKML, kernel-janitors,
Julia Lawall
In-Reply-To: <874m52zgjy.fsf@kamboji.qca.qualcomm.com>
> hostap is an obsolete driver, it's waste of time doing style fixes to it
> as nobody maintains it anymore.
Thanks for another bit of your software development attention and this information.
Is it easier to understand than the previous response "Reason: The benefit is not clear."?
Regards,
Markus
^ permalink raw reply
* Re: wil6200
From: Vikram @ 2016-09-26 18:05 UTC (permalink / raw)
To: Lior David; +Cc: linux-wireless
In-Reply-To: <a3435bed-4892-4606-44ac-523e47f57b1b@codeaurora.org>
Hi Lior,
On 26 September 2016 at 18:19, Lior David <liord@codeaurora.org> wrote:
> On 9/25/2016 6:15 PM, Vikram wrote:
>> Hi,
>>
>> Could you please let me know as to how to change the mode of wil6200
>> chip from WBE to WiFi?
>>
>> Regards,
>> Vikram
>>
> What is the exact device you are using? Older devices have firmware that only
> supports WBE mode.
>
> Thanks,
> Lior
I'm using Dell Wireless DW1601 7Gbps WiGig 802.11ad 802.11n 2*2 WiFi
Half Mini Card abgn+ad 2*2:2
Regards,
Vikram
^ permalink raw reply
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: Kalle Valo @ 2016-09-26 18:01 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-wireless, netdev, Jouni Malinen, LKML, kernel-janitors,
Julia Lawall
In-Reply-To: <88d5023a-9a59-ab36-8c6c-a146cae803b5@users.sourceforge.net>
SF Markus Elfring <elfring@users.sourceforge.net> writes:
>> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
>> 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret"
>>
>> Reason: The benefit is not clear.
>
> How do you think about to reduce the source code a bit at these places?
hostap is an obsolete driver, it's waste of time doing style fixes to it
as nobody maintains it anymore.
--
Kalle Valo
^ permalink raw reply
* Re: brcmfmac: drop unused fields from struct brcmf_pub
From: Kalle Valo @ 2016-09-26 17:51 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Rafał Miłecki, Arend van Spriel, Franky Lin,
Hante Meuleman, Pieter-Paul Giesberts, Franky (Zhenhui) Lin,
Colin Ian King,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
open list:NETWORKING DRIVERS, open list
In-Reply-To: <20160923132759.21875-1-zajec5@gmail.com>
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> They seem to be there from the first day. We calculate these values but
> never use them.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Patch applied to wireless-drivers-next.git, thanks.
2df86ad959c9 brcmfmac: drop unused fields from struct brcmf_pub
--
https://patchwork.kernel.org/patch/9348103/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: brcmfmac: fix memory leak in brcmf_fill_bss_param
From: Kalle Valo @ 2016-09-26 17:49 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Rafał Miłecki, Arend van Spriel, Franky Lin,
Hante Meuleman, Pieter-Paul Giesberts, Franky (Zhenhui) Lin,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
open list:NETWORKING DRIVERS, open list
In-Reply-To: <20160921062327.28729-1-zajec5@gmail.com>
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This function is called from get_station callback which means that every
> time user space was getting/dumping station(s) we were leaking 2 KiB.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Fixes: 1f0dc59a6de ("brcmfmac: rework .get_station() callback")
> Cc: stable@vger.kernel.org # 4.2+
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
23e9c128adb2 brcmfmac: fix memory leak in brcmf_fill_bss_param
--
https://patchwork.kernel.org/patch/9342879/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [1/4] rtl8xxxu: Fix off by one error calculating pubq
From: Kalle Valo @ 2016-09-26 17:42 UTC (permalink / raw)
To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger, Jes Sorensen
In-Reply-To: <1474420769-20086-2-git-send-email-Jes.Sorensen@redhat.com>
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> This was detected tracing the 8188eu driver, but doesn't seem to make
> any difference when using it.
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
4 patches applied to wireless-drivers-next.git, thanks.
3a589fae4a2c rtl8xxxu: Fix off by one error calculating pubq
c0a99bbb1b7a rtl8xxxu: Clean up llt_init() API
2fc5dd27bf9b rtl8xxxu: Use a struct rtl8xxxu_fileops * in rtl8xxxu_init_device()
b42fbed6b8a5 rtl8xxxu: Stop log spam from each successful interrupt
--
https://patchwork.kernel.org/patch/9342651/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [1/3] mwifiex: fix kernel crash for USB chipsets
From: Kalle Valo @ 2016-09-26 17:40 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: linux-wireless, Cathy Luo, Nishant Sarmukadam, Shengzhen Li,
Amitkumar Karwar
In-Reply-To: <1474384744-14096-1-git-send-email-akarwar@marvell.com>
Amitkumar Karwar <akarwar@marvell.com> wrote:
> From: Cathy Luo <cluo@marvell.com>
>
> Following crash issue is observed during TCP traffic stress
> test
>
> [ 2253.625439] NMI watchdog: BUG: soft lockup - CPU#3 stuck for 22s!
> [kworker/u17:1:5191]
> [ 2253.625520] Call Trace:
> [ 2253.625527] [<ffffffffc0b47030>] ? moal_spin_lock+0x30/0x30
> [usb8xxx]
> [ 2253.625533] [<ffffffffc0ac3ceb>] ? wlan_wmm_lists_empty+0xb/0xf0
> [mlan]
> [ 2253.625537] [<ffffffffc0ab0ea3>] mlan_main_process+0x1b3/0x720
> [mlan]
> [ 2253.625540] [<ffffffffc0b337f5>] woal_main_work_queue+0x45/0x80
> [usb8xxx]
> [ 2253.625543] [<ffffffff8108aaf0>] process_one_work+0x150/0x3f0
> [ 2253.625545] [<ffffffff8108b1e1>] worker_thread+0x121/0x520
> [ 2253.625547] [<ffffffff8108b0c0>] ? rescuer_thread+0x330/0x330
> [ 2253.625549] [<ffffffff81090222>] kthread+0xd2/0xf0
> [ 2253.625551] [<ffffffff81090150>] ?
> kthread_create_on_node+0x1c0/0x1c0
> [ 2253.625553] [<ffffffff8179423c>] ret_from_fork+0x7c/0xb0
> [ 2253.625555] [<ffffffff81090150>] ?
> kthread_create_on_node+0x1c0/0x1c0
>
> In mwifiex_usb_tx_complete(), we are updating port->block_status first
> and then freeing the skb attached to that URB. We may end up attaching
> new skb to URB in a corner case and same will be freed. This results in
> the kernel crash. The problem is solved by changing the sequence.
>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Shengzhen Li <szli@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
3 patches applied to wireless-drivers-next.git, thanks.
1afac196c167 mwifiex: fix kernel crash for USB chipsets
5476f8030d9a mwifiex: fix race condition causing tx timeout
ac3b561721e9 mwifiex: code rearrangement in mwifiex_usb_host_to_card()
--
https://patchwork.kernel.org/patch/9341883/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [1/9] brcmfmac: ignore 11d configuration errors
From: Kalle Valo @ 2016-09-26 17:38 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: linux-wireless, Hante Meuleman, Arend van Spriel
In-Reply-To: <1474283399-14385-2-git-send-email-arend.vanspriel@broadcom.com>
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> From: Hante Meuleman <hante.meuleman@broadcom.com>
>
> 802.11d is not always supported by firmware anymore. Currently the
> AP configuration of 11d will cause an abort if the ioctl set is
> failing. This behavior is not correct and the error should be
> ignored.
>
> Reviewed-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
9 patches applied to wireless-drivers-next.git, thanks.
b3589dfe0212 brcmfmac: ignore 11d configuration errors
704d1c6b56f4 brcmfmac: rework pointer trickery in brcmf_proto_bcdc_query_dcmd()
bc9816413601 brcmfmac: fix memory leak in brcmf_flowring_add_tdls_peer()
26305d3d7298 brcmfmac: initialize variable in brcmf_sdiod_regrl()
8fa5fdec09cd brcmfmac: remove worker from .ndo_set_mac_address() callback
835680b82f02 brcmfmac: remove unnecessary null pointer check
2b7425f3629b brcmfmac: fix clearing entry IPv6 address
a7ed7828ecda brcmfmac: fix out of bound access on clearing wowl wake indicator
92c313604711 brcmfmac: simplify mapping of auth type
--
https://patchwork.kernel.org/patch/9339033/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] ath10k: fix system hang at qca99x0 probe on x86 platform (DMA32 issue)
From: Ben Greear @ 2016-09-26 16:53 UTC (permalink / raw)
To: Adrian Chadd, Michal Kazior
Cc: Manoharan, Rajkumar, Rajkumar Manoharan, Sebastian Gottschall,
Valo, Kalle, ath10k@lists.infradead.org, nbd@nbd.name,
linux-wireless@vger.kernel.org, netdev
In-Reply-To: <CAJ-VmomcD8FgA34z3OFKZvc5yq8EsHOTqP=Lg-6gFOAcWys8og@mail.gmail.com>
On 07/20/2016 10:02 AM, Adrian Chadd wrote:
> Hi,
>
> The "right" way for the target CPU to interact with host CPU memory
> (and vice versa, for mostly what it's worth) is to have the copy
> engine copy (ie, "DMA") the pieces between them. This may be for
> diagnostic purposes, but it's not supposed to be used like this for
> doing wifi data exchange, right? :-P
>
> Now, there /may/ be some alignment hilarity in various bits of code
> and/or hardware. Eg, Merlin (AR9280) requires its descriptors to be
> within a 4k block - the code to iterate through the descriptor
> physical address space didn't do a "val = val + offset", it did
> something in verilog like "val = (val & 0xffffc000) | (offset &
> 0x3fff)". This meant if you allocated a descriptor that started just
> before the end of a 4k physmem aligned block, you'd end up with
> exciting results. I don't know if there are any situations like this
> in the ath10k hardware, but I'm sure there will be some gotchas
> somewhere.
>
> In any case, if ath10k is consuming too much bounce buffers, the calls
> to allocate memory aren't working right and should be restricted to 32
> bit addresses. Whether that's by using the DMA memory API (before it's
> mapped) or passing in GFP_DMA32 is a fun debate.
>
> (My test hardware arrived, so I'll test this all out today on
> Peregrine-v2 and see if the driver works.)
I have been running this patch for a while:
ath10k: Use GPF_DMA32 for firmware swap memory.
This fixes OS crash when using QCA 9984 NIC on x86-64 system
without vt-d enabled.
Also tested on ea8500 with 9980, and x86-64 with 9980 and 9880.
All tests were with CT firmware.
Signed-off-by: Ben Greear <greearb@candelatech.com>
-------------------- drivers/net/wireless/ath/ath10k/wmi.c --------------------
index e20aa39..727b3aa 100644
@@ -4491,7 +4491,7 @@ static int ath10k_wmi_alloc_chunk(struct ath10k *ar, u32 req_id,
if (!pool_size)
return -EINVAL;
- vaddr = kzalloc(pool_size, GFP_KERNEL | __GFP_NOWARN);
+ vaddr = kzalloc(pool_size, GFP_KERNEL | __GFP_NOWARN | GFP_DMA32);
if (!vaddr)
num_units /= 2;
}
It mostly seems to work, but then sometimes I get a splat like this below. It appears
it is invalid to actually do kzalloc with GFP_DMA32 (based on that BUG_ON that
hit in the new_slab method)??
Any idea for a more proper way to do this?
gfp: 4
------------[ cut here ]------------
kernel BUG at /home/greearb/git/linux-4.7.dev.y/mm/slub.c:1508!
invalid opcode: 0000 [#1] PREEMPT SMP
Modules linked in: coretemp hwmon ath9k intel_rapl ath10k_pci x86_pkg_temp_thermal ath9k_common ath10k_core intel_powerclamp ath9k_hw ath kvm iTCO_wdt mac80211
iTCO_vendor_support irqbypass snd_hda_codec_hdmi 6
CPU: 2 PID: 268 Comm: kworker/u8:5 Not tainted 4.7.2+ #16
Hardware name: To be filled by O.E.M. To be filled by O.E.M./ChiefRiver, BIOS 4.6.5 06/07/2013
Workqueue: ath10k_aux_wq ath10k_wmi_event_service_ready_work [ath10k_core]
task: ffff880036433a00 ti: ffff880036440000 task.ti: ffff880036440000
RIP: 0010:[<ffffffff8124592a>] [<ffffffff8124592a>] new_slab+0x39a/0x410
RSP: 0018:ffff880036443b58 EFLAGS: 00010092
RAX: 0000000000000006 RBX: 00000000024082c4 RCX: 0000000000000000
RDX: 0000000000000006 RSI: ffff88021e30dd08 RDI: ffff88021e30dd08
RBP: ffff880036443b90 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000372 R12: ffff88021dc01200
R13: ffff88021dc00cc0 R14: ffff88021dc01200 R15: 0000000000000001
FS: 0000000000000000(0000) GS:ffff88021e300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3e65c1c730 CR3: 0000000001e06000 CR4: 00000000001406e0
Stack:
ffffffff8127a4fc ffff0a01ffffff10 00000000024082c4 ffff88021dc01200
ffff88021dc00cc0 ffff88021dc01200 0000000000000001 ffff880036443c58
ffffffff81247ac6 ffff88021e31b360 ffff880036433a00 ffff880036433a00
Call Trace:
[<ffffffff8127a4fc>] ? __d_lookup+0x9c/0x160
[<ffffffff81247ac6>] ___slab_alloc+0x396/0x4a0
[<ffffffffa0f8e14d>] ? ath10k_wmi_event_service_ready_work+0x5ad/0x800 [ath10k_core]
[<ffffffff811f5279>] ? alloc_kmem_pages+0x9/0x10
[<ffffffff8120f203>] ? kmalloc_order+0x13/0x40
[<ffffffffa0f8e14d>] ? ath10k_wmi_event_service_ready_work+0x5ad/0x800 [ath10k_core]
[<ffffffff81247bf6>] __slab_alloc.isra.72+0x26/0x40
[<ffffffff81248767>] __kmalloc+0x147/0x1b0
[<ffffffffa0f8e14d>] ath10k_wmi_event_service_ready_work+0x5ad/0x800 [ath10k_core]
[<ffffffff811370a1>] ? dequeue_entity+0x261/0xac0
[<ffffffff8111c2d8>] process_one_work+0x148/0x420
[<ffffffff8111c929>] worker_thread+0x49/0x480
[<ffffffff8111c8e0>] ? rescuer_thread+0x330/0x330
[<ffffffff81121984>] kthread+0xc4/0xe0
[<ffffffff8184d75f>] ret_from_fork+0x1f/0x40
[<ffffffff811218c0>] ? kthread_create_on_node+0x170/0x170
Code: e9 65 fd ff ff 49 8b 57 20 48 8d 42 ff 83 e2 01 49 0f 44 c7 f0 80 08 40 e9 6f fd ff ff 89 c6 48 c7 c7 01 36 c7 81 e8 e8 40 fa ff <0f> 0b ba 00 10 00 00 be
5a 00 00 00 48 89 c7 48 d3 e2 e8 bf 18
RIP [<ffffffff8124592a>] new_slab+0x39a/0x410
RSP <ffff880036443b58>
---[ end trace ea3b0043b2911d93 ]---
static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
{
if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
BUG();
}
return allocate_slab(s,
flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
}
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* [PATCH] staging: wilc1000: fix sparse warning: symbol was not declared. Should it be static?
From: Matias Mucciolo @ 2016-09-26 16:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Aditya Shankar, Ganesh Krishna
Cc: devel, linux-wireless, linux-kernel
In-Reply-To: <20160926155220.GA3319@kroah.com>
- Fixed a sparse warning:
wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index b052628..802bb1d 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
#define ERR BIT(3)
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
--
2.1.4
^ permalink raw reply related
* Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: SF Markus Elfring @ 2016-09-26 16:03 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, netdev, Jouni Malinen, LKML, kernel-janitors,
Julia Lawall
In-Reply-To: <20160926150656.213D961568@smtp.codeaurora.org>
> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
> 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret"
>
> Reason: The benefit is not clear.
How do you think about to reduce the source code a bit at these places?
Regards,
Markus
^ permalink raw reply
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
From: Greg Kroah-Hartman @ 2016-09-26 15:52 UTC (permalink / raw)
To: Matias Mucciolo
Cc: devel, Aditya Shankar, linux-wireless, linux-kernel,
Ganesh Krishna
In-Reply-To: <4399555.QWNJt8EtNN@varitech>
On Mon, Sep 26, 2016 at 12:44:24PM -0300, Matias Mucciolo wrote:
>
> hi
>
> sorry...this is the full warning:
>
> drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
the "should it be static" is the key here, right? Care to fix this up
and resend it?
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH 1/5] wlcore: Prepare family to fix nvs file handling
From: Kalle Valo @ 2016-09-26 15:47 UTC (permalink / raw)
To: Tony Lindgren
Cc: Eyal Reizer, Guy Mishol, Luca Coelho, Maital Hahn, Maxim Altshul,
Shahar Patury, linux-wireless, linux-omap
In-Reply-To: <20160917160633.8767-2-tony@atomide.com>
Tony Lindgren <tony@atomide.com> writes:
> Move struct wilink_family_data to be available for all TI WLAN
> variants. And fix familiy typo, it should be just family.
>
> Looks like wl12xx use two different nvs.bin files and wl18xx
> uses a different conf.bin file.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied to wireless-drivers-next.git, thanks.
--
Kalle Valo
^ permalink raw reply
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
From: Matias Mucciolo @ 2016-09-26 15:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Aditya Shankar, Ganesh Krishna, devel, linux-wireless,
linux-kernel
In-Reply-To: <20160926153733.GA1723@kroah.com>
hi
sorry...this is the full warning:
drivers/staging/wilc1000/wilc_debugfs.c:32:10: warning: symbol 'WILC_DEBUG_LEVEL' was not declared. Should it be static?
--
Matias Mucciolo
Area de Infraestructura.
Piedras 737 C.A.B.A
SUTEBA
On Monday 26 September 2016 17:37:33 Greg Kroah-Hartman wrote:
> On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote:
> >
> > - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
>
> I don't think that was the full warning, as that does not make much
> sense to me, does it to you?
>
> thanks,
>
> greg k-h
^ permalink raw reply
* Re: [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
From: Greg Kroah-Hartman @ 2016-09-26 15:37 UTC (permalink / raw)
To: Matias Mucciolo
Cc: Aditya Shankar, Ganesh Krishna, devel, linux-wireless,
linux-kernel
In-Reply-To: <34310025.aMSyYASYEz@varitech>
On Mon, Sep 26, 2016 at 12:15:18PM -0300, Matias Mucciolo wrote:
>
> - Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
I don't think that was the full warning, as that does not make much
sense to me, does it to you?
thanks,
greg k-h
^ permalink raw reply
* [PATCH] staging: wilc1000: fix symbol 'WILC_DEBUG_LEVEL' was not declared.
From: Matias Mucciolo @ 2016-09-26 15:15 UTC (permalink / raw)
To: Aditya Shankar, Ganesh Krishna, Greg Kroah-Hartman
Cc: linux-wireless, devel, linux-kernel
- Fixed a sparse warning: symbol 'WILC_DEBUG_LEVEL' was not declared.
Signed-off-by: Matias Mucciolo <mmucciolo@suteba.org.ar>
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index b052628..802bb1d 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -29,7 +29,7 @@ static struct dentry *wilc_dir;
#define ERR BIT(3)
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
-atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
+static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
EXPORT_SYMBOL_GPL(WILC_DEBUG_LEVEL);
/*
--
2.1.4
^ permalink raw reply related
* Re: [v3] mwifiex: cfg80211 set_default_mgmt_key handler
From: Kalle Valo @ 2016-09-26 15:21 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: linux-wireless, Ganapathi Bhat, Amitkumar Karwar
In-Reply-To: <1474377383-12600-1-git-send-email-akarwar@marvell.com>
Amitkumar Karwar <akarwar@marvell.com> wrote:
> From: Ganapathi Bhat <gbhat@marvell.com>
>
> Previously device used to start using IGTK key as Tx key as soon as it
> gets downloaded in add_key(). This patch implements set_default_mgmt_key
> handler. We will update Tx key ID in set_default_mgmt_key().
>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
89951db2be53 mwifiex: cfg80211 set_default_mgmt_key handler
--
https://patchwork.kernel.org/patch/9341673/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets
From: IgorMitsyanko @ 2016-09-26 12:45 UTC (permalink / raw)
To: Kalle Valo
Cc: johannes, linux-wireless, Avinash Patil, Dmitrii Lebed,
Sergei Maksimenko, Sergey Matyukevich, Bindu Therthala,
Huizhao Wang, Kamlesh Rath
In-Reply-To: <87oa3byln4.fsf@kamboji.qca.qualcomm.com>
On 09/26/2016 01:56 PM, Kalle Valo wrote:
> IgorMitsyanko <igor.mitsyanko.os@quantenna.com> writes:
>
>> On 09/17/2016 04:46 PM, Kalle Valo wrote:
>>> <igor.mitsyanko.os@quantenna.com> writes:
>>>
>>>> +/* Supported rates to be advertised to the cfg80211 */
>>>> +static struct ieee80211_rate qtnf_rates[] = {
>>>> + {.bitrate = 10, .hw_value = 2, },
>>>> + {.bitrate = 20, .hw_value = 4, },
>>>> + {.bitrate = 55, .hw_value = 11, },
>>>> + {.bitrate = 110, .hw_value = 22, },
>>>> + {.bitrate = 60, .hw_value = 12, },
>>>> + {.bitrate = 90, .hw_value = 18, },
>>>> + {.bitrate = 120, .hw_value = 24, },
>>>> + {.bitrate = 180, .hw_value = 36, },
>>>> + {.bitrate = 240, .hw_value = 48, },
>>>> + {.bitrate = 360, .hw_value = 72, },
>>>> + {.bitrate = 480, .hw_value = 96, },
>>>> + {.bitrate = 540, .hw_value = 108, },
>>>> +};
>>>> +
>>>> +/* Channel definitions to be advertised to cfg80211 */
>>>> +static struct ieee80211_channel qtnf_channels_2ghz[] = {
>>>> + {.center_freq = 2412, .hw_value = 1, },
>>>> + {.center_freq = 2417, .hw_value = 2, },
>>>> + {.center_freq = 2422, .hw_value = 3, },
>>>> + {.center_freq = 2427, .hw_value = 4, },
>>>> + {.center_freq = 2432, .hw_value = 5, },
>>>> + {.center_freq = 2437, .hw_value = 6, },
>>>> + {.center_freq = 2442, .hw_value = 7, },
>>>> + {.center_freq = 2447, .hw_value = 8, },
>>>> + {.center_freq = 2452, .hw_value = 9, },
>>>> + {.center_freq = 2457, .hw_value = 10, },
>>>> + {.center_freq = 2462, .hw_value = 11, },
>>>> + {.center_freq = 2467, .hw_value = 12, },
>>>> + {.center_freq = 2472, .hw_value = 13, },
>>>> + {.center_freq = 2484, .hw_value = 14, },
>>>> +};
>>> I guess some of these static variables could be also const, but didn't
>>> check.
>> We did some changes to this code recently: will get bands info
>> (channel list, rates, capabilities etc) from wireless device itself,
>> it will be in next patch revision.
> For the initial submission please freeze the driver, otherwise it's pain
> to review as the driver changes too much in-between review rounds. So at
> this stage only minimal changes, please.
>
> You can continue adding new features and making changes, but do those as
> follow up patches and use the initial submission as the baseline for the
> new patches. Once the driver is applied you can submit the rest of the
> patches adding new features and they will be reviewed similarly like all
> other wireless patches.
Ok, we will keep patch modification to minimum between revisions, but
channels-related changes are something we would like to apply: we're
setting SELF_MANAGED bit right now and do not handle regulatory hints
from cfg80211, having all the regulatory-related info fixed on device
itself (region, per-channel Tx powers, DFS requirements). This info is
what was used to pass regulatory authorities certification, and
considering seriousness of regulatory compliance requirement it's
probably better to use the info that is known to be accepted.
Would it be acceptable if we keep rates/capabilities logic intact, but
will modify channel-related logic in next patch revision?
In a follow-up patches we're considering introducing closer and more
flexible integration with cfg80211 regulatory logic, allowing host
system itself to provide regulatory info. This will need further legal
consideration though: FCC and European commission seem to stricken rules
recently, maybe having region fixed on device is a more compliant solution.
>
>>>> +static int
>>>> +qtnf_event_handle_sta_assoc(struct qtnf_wmac *mac, struct qtnf_vif *vif,
>>>> + const struct qlink_event_sta_assoc *sta_assoc,
>>>> + u16 len)
>>>> +{
>>>> + const u8 *sta_addr;
>>>> + u16 frame_control;
>>>> + struct station_info sinfo = { 0 };
>>>> + size_t payload_len;
>>>> + u16 tlv_type;
>>>> + u16 tlv_value_len;
>>>> + size_t tlv_full_len;
>>>> + const struct qlink_tlv_hdr *tlv;
>>>> +
>>>> + if (unlikely(len < sizeof(*sta_assoc))) {
>>>> + pr_err("%s: payload is too short (%u < %zu)\n", __func__,
>>>> + len, sizeof(*sta_assoc));
>>>> + return -EINVAL;
>>>> + }
>>> I see unlikely() used a lot, I counted 145 times. Not a big issue but I
>>> don't see the point. In hot path I understand using it, but not
>>> everywhere.
>> Agree, but would you suggest that we remove the ones that we already
>> have but that are not really needed?
> Up to you really. This isn't important, just something I found a bit
> odd.
>
^ permalink raw reply
* Re: [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
From: Kalle Valo @ 2016-09-26 15:06 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-wireless, netdev, Jouni Malinen, LKML, kernel-janitors,
Julia Lawall
In-Reply-To: <65ed528f-7ec5-a0f2-6219-3e63a78ca0ee@users.sourceforge.net>
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Aug 2016 18:21:29 +0200
>
> Remove a jump label which is unneeded in this function at the end.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2 patches set to Rejected.
9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret"
Reason: The benefit is not clear.
--
https://patchwork.kernel.org/patch/9291771/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] brcmfmac: implement more accurate skb tracking
From: Dan Williams @ 2016-09-26 14:59 UTC (permalink / raw)
To: Rafał Miłecki, Arend Van Spriel
Cc: Kalle Valo, Franky Lin, Hante Meuleman, Pieter-Paul Giesberts,
Franky Lin, linux-wireless@vger.kernel.org,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Network Development, Linux Kernel Mailing List,
Rafał Miłecki
In-Reply-To: <CACna6rwnLb3sEPmdx6uhYMstVn04WbP2xzznsjnwgguEXn04=w@mail.gmail.com>
On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote:
> On 26 September 2016 at 13:46, Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
> >
> > On 26-9-2016 12:23, Rafał Miłecki wrote:
> > >
> > > From: Rafał Miłecki <rafal@milecki.pl>
> > >
> > > We need to track 802.1x packets to know if there are any pending
> > > ones
> > > for transmission. This is required for performing key update in
> > > the
> > > firmware.
> >
> > The problem we are trying to solve is a pretty old one. The problem
> > is
> > that wpa_supplicant uses two separate code paths: EAPOL messaging
> > through data path and key configuration though nl80211.
>
> Can I find it described/reported somewhere?
If I understand the issue correctly, you can find all this in the
supplicant code. Once the supplicant has done whatever it wants to do
with the data frames that just happen to be EAPOL it then sends the
keys down to the driver with nl80211.
But it sounds like, instead of sniffing EAPOL frames in the driver skb
tracking and sniffing ETH_P_PAE, you should probably implement support
for NL80211_CMD_CRIT_PROTOCOL_START/NL80211_CMD_CRIT_PROTOCOL_STOP and
key off the passed-in NL80211_CRIT_PROTO_EAPOL. At least at the
beginning of connection setup only EAPOL packets will be allowed
anyway.
It doesn't seem like the supplicant uses NL80211_CRIT_PROTO_EAPOL yet,
but that should also be fixed in the supplicant itself. You should
probably get some comments from Jouni on how he'd like to see all this
work. But generally the less specific sniffing of frames in drivers,
likely the better.
Dan
>
> >
> > >
> > > Unfortunately our old tracking code wasn't very accurate. It was
> > > treating skb as pending as soon as it was passed by the netif.
> > > Actual
> > > handling packet to the firmware was happening later as brcmfmac
> > > internally queues them and uses its own worker(s).
> >
> > That does not seem right. As soon as we get a 1x packet we need to
> > wait
> > with key configuration regardless whether it is still in the driver
> > or
> > handed over to firmware already.
>
> OK, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox