* Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
From: Ben Greear @ 2017-02-07 14:46 UTC (permalink / raw)
To: Valo, Kalle, Adrian Chadd
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Amadeusz Sławiński, ath10k@lists.infradead.org,
Linux Kernel Mailing List
In-Reply-To: <87y3xi4b28.fsf@qca.qualcomm.com>
On 02/07/2017 01:14 AM, Valo, Kalle wrote:
> Adrian Chadd <adrian@freebsd.org> writes:
>
>> Removing this method makes the diff to FreeBSD larger, as "vif" in
>> FreeBSD is a different pointer.
>>
>> (Yes, I have ath10k on freebsd working and I'd like to find a way to
>> reduce the diff moving forward.)
>
> I don't like this "(void *) vif->drv_priv" style that much either but
> apparently it's commonly used in Linux wireless code and already parts
> of ath10k. So this patch just unifies the coding style.
Surely the code compiles to the same thing, so why add a patch that
makes it more difficult for Adrian and makes the code no easier to read
for the rest of us?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply
* [PATCH] wil6210: include moduleparam.h
From: Johannes Berg @ 2017-02-07 14:33 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
This now declares a module parameter, so include the necessary
header file for that.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/ath/wil6210/cfg80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c
index 6aa3ff4240a9..035ff5974058 100644
--- a/drivers/net/wireless/ath/wil6210/cfg80211.c
+++ b/drivers/net/wireless/ath/wil6210/cfg80211.c
@@ -15,6 +15,7 @@
*/
#include <linux/etherdevice.h>
+#include <linux/moduleparam.h>
#include "wil6210.h"
#include "wmi.h"
--
2.9.3
^ permalink raw reply related
* [patch] mac80211: check for allocation failure in debugfs code
From: Dan Carpenter @ 2017-02-07 13:20 UTC (permalink / raw)
To: Johannes Berg, Ben Greear; +Cc: linux-wireless, kernel-janitors
kmalloc() can fail. Also let's move the allocation out of the
declaration block so it's easier to read.
Fixes: 4a5eccaa9350 ("mac80211: Show pending txqlen in debugfs.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
index f62cd0e13c58..4689353aa263 100644
--- a/net/mac80211/debugfs.c
+++ b/net/mac80211/debugfs.c
@@ -249,12 +249,19 @@ static ssize_t misc_read(struct file *file, char __user *user_buf,
struct ieee80211_local *local = file->private_data;
/* Max len of each line is 16 characters, plus 9 for 'pending:\n' */
size_t bufsz = IEEE80211_MAX_QUEUES * 16 + 9;
- char *buf = kzalloc(bufsz, GFP_KERNEL);
- char *pos = buf, *end = buf + bufsz - 1;
+ char *buf;
+ char *pos, *end;
ssize_t rv;
int i;
int ln;
+ buf = kzalloc(bufsz, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ pos = buf;
+ end = buf + bufsz - 1;
+
pos += scnprintf(pos, end - pos, "pending:\n");
for (i = 0; i < IEEE80211_MAX_QUEUES; i++) {
^ permalink raw reply related
* ANNOUNCE: Netdev 2.1 Location and Hotel
From: Jamal Hadi Salim @ 2017-02-07 12:58 UTC (permalink / raw)
To: netdev@vger.kernel.org
Cc: netfilter-devel, netfilter, info, linux-wireless, tech-committee,
David Miller, Stephen Jaworski, Rob Echlin, lwn
Two important announcements
1) We are pleased to announce a location for netdev 2.1:
Le Westin Montréal
270 Rue St. Antoine Ouest, Montreal, QC H2Y 0A3, Canada
Le Westin will also be the conference hotel. We have a speacial
arrangement for all attendees to get speacial rates at the hotel.
We would like to encourage attendees to book at this hotel.
If you can find a better deal for this hotel anywhere else
on the net for the conference days, please notify us immediately
at info@netdevconf.org and we'll contact the hotel.
The hotel registration is at:
https://www.starwoodmeeting.com/Book/netdev2017
The room rates are:
Traditional King: $189
Traditional 2 Queuen: $209
Premium Junior Suite: $269
Extra 3rd and 4th person sharing a room is
$30 CAD per person, per night.
All above rates are in Canadian $ excluding taxes.
Rates are available 3 days before and 3 days after events.
Rates will no longer be available after March 22, 2017.
The Call for Proposals is still open, submit early
to avoid the hazards of last minute traffic. Refer to:
http://netdevconf.org/2.1/submit-proposal.html
2) We would like to announce the registration is now open.
Please go ahead and register sooner than later. It helps us
plan better:
https://onlineregistrations.ca/netdev21/
cheers,
jamal
^ permalink raw reply
* Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e
From: Felix Fietkau @ 2017-02-07 9:57 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-wireless, kvalo
In-Reply-To: <20170206131400.GA2716@redhat.com>
On 2017-02-06 14:14, Stanislaw Gruszka wrote:
> CCK can be used only on 5GHz? OFDM only on 2GHz? I thought any rates can
> be used on both bands. Or maybe this settings is just named wrongly
> i.e. CCK_SIFS mean sifs for 5GHz and OFDM_SIFS - sifs for 2GHz ?
OFDM is used on 2.4 and 5 GHz, CCK only on 2.4 GHz.
According to the datasheet, CCK_SIFS means SIFS after CCK transmission.
- Felix
^ permalink raw reply
* [PATCH] mac80211: add back lost debugfs files
From: Johannes Berg @ 2017-02-07 9:41 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
Somehow these files were never present or lost, but the code
is there and they seem somewhat useful, so add them back.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/mac80211/debugfs.c | 1 +
net/mac80211/debugfs_sta.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
index f62cd0e13c58..47bea0babe78 100644
--- a/net/mac80211/debugfs.c
+++ b/net/mac80211/debugfs.c
@@ -356,6 +356,7 @@ void debugfs_hw_add(struct ieee80211_local *local)
DEBUGFS_ADD(total_ps_buffered);
DEBUGFS_ADD(wep_iv);
+ DEBUGFS_ADD(rate_ctrl_alg);
DEBUGFS_ADD(queues);
DEBUGFS_ADD(misc);
#ifdef CONFIG_PM
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index f6003b8c2c33..42601820db20 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -522,6 +522,7 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
return;
DEBUGFS_ADD(flags);
+ DEBUGFS_ADD(aid);
DEBUGFS_ADD(num_ps_buf_frames);
DEBUGFS_ADD(last_seq_ctrl);
DEBUGFS_ADD(agg_status);
--
2.9.3
^ permalink raw reply related
* Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
From: Valo, Kalle @ 2017-02-07 9:14 UTC (permalink / raw)
To: Adrian Chadd
Cc: Amadeusz Sławiński, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Linux Kernel Mailing List,
ath10k@lists.infradead.org
In-Reply-To: <CAJ-VmonrHpS3MArM9ohHgLvb6xspP_gnVVeJWA9F-pjUpJ+LZA@mail.gmail.com>
Adrian Chadd <adrian@freebsd.org> writes:
> Removing this method makes the diff to FreeBSD larger, as "vif" in
> FreeBSD is a different pointer.
>
> (Yes, I have ath10k on freebsd working and I'd like to find a way to
> reduce the diff moving forward.)
I don't like this "(void *) vif->drv_priv" style that much either but
apparently it's commonly used in Linux wireless code and already parts
of ath10k. So this patch just unifies the coding style.
--=20
Kalle Valo=
^ permalink raw reply
* Re: [v2,1/3] ath9k: rename tx_complete_work to hw_check_work
From: Kalle Valo @ 2017-02-07 9:01 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, kvalo
In-Reply-To: <20170202091452.11939-1-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> wrote:
> Also include common MAC alive check. This should make the hang checks
> more reliable for modes where beacons are not sent and is used as a
> starting point for further hang check improvements
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
3 patches applied to ath-next branch of ath.git, thanks.
d63ffc45c5d3 ath9k: rename tx_complete_work to hw_check_work
a34d0a0da1ab ath9k_hw: check if the chip failed to wake up
3a5e969bb2f6 ath9k: fix race condition in enabling/disabling IRQs
--
https://patchwork.kernel.org/patch/9551439/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: wcn36xx: Implement cancel_hw_scan
From: Kalle Valo @ 2017-02-07 9:00 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev,
linux-kernel, linux-arm-msm, Mart Raudsepp
In-Reply-To: <20170201152747.838-1-bjorn.andersson@linaro.org>
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> In the event that the wcn36xx interface is brought down while a hw_scan
> is active we must abort and wait for the ongoing scan to signal
> completion to mac80211.
>
> Reported-by: Mart Raudsepp <leio@gentoo.org>
> Fixes: 886039036c20 ("wcn36xx: Implement firmware assisted scan")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Mart Raudsepp <leio@gentoo.org>
Patch applied to ath-next branch of ath.git, thanks.
03c95dbef642 wcn36xx: Implement cancel_hw_scan
--
https://patchwork.kernel.org/patch/9550795/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: ath10k: fix reading sram contents for QCA4019
From: Kalle Valo @ 2017-02-07 8:58 UTC (permalink / raw)
To: Ashok Raj Nagarajan; +Cc: ath10k, Ashok Raj Nagarajan, arnagara, linux-wireless
In-Reply-To: <1485887811-23313-1-git-send-email-arnagara@qti.qualcomm.com>
Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> wrote:
> With QCA4019 platform, SRAM address can be accessed directly from host but
> currently, we are assuming sram addresses cannot be accessed directly and
> hence we convert the addresses.
>
> While there, clean up growing hw checks during conversion of target CPU
> address to CE address. Now we have function pointer pertaining to different
> chips.
>
> Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
7f622593cc5a ath10k: fix reading sram contents for QCA4019
--
https://patchwork.kernel.org/patch/9548043/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCHv3] ath10k: fix boot failure in UTF mode/testmode
From: Kalle Valo @ 2017-02-07 8:52 UTC (permalink / raw)
To: c_traja; +Cc: ath10k, Tamizh chelvam, tamizhchelvam, linux-wireless, stable
In-Reply-To: <1485838569-1027-1-git-send-email-c_traja@qti.qualcomm.com>
c_traja@qti.qualcomm.com wrote:
> From: Tamizh chelvam <c_traja@qti.qualcomm.com>
>
> Rx filter reset and the dynamic tx switch mode (EXT_RESOURCE_CFG)
> configuration are causing the following errors when UTF firmware
> is loaded to the target.
>
> Error message 1:
> [ 598.015629] ath10k_pci 0001:01:00.0: failed to ping firmware: -110
> [ 598.020828] ath10k_pci 0001:01:00.0: failed to reset rx filter: -110
> [ 598.141556] ath10k_pci 0001:01:00.0: failed to start core (testmode): -110
>
> Error message 2:
> [ 668.615839] ath10k_ahb a000000.wifi: failed to send ext resource cfg command : -95
> [ 668.618902] ath10k_ahb a000000.wifi: failed to start core (testmode): -95
>
> Avoiding these configurations while bringing the target in
> testmode is solving the problem.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tamizh chelvam <c_traja@qti.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
cb4281528b62 ath10k: fix boot failure in UTF mode/testmode
--
https://patchwork.kernel.org/patch/9546451/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: ath10k: Add debugfs support to get per peer tids log via tracing
From: Kalle Valo @ 2017-02-07 8:51 UTC (permalink / raw)
To: c_mkenna; +Cc: ath10k, mkenna, linux-wireless, Maharaja Kennadyrajan
In-Reply-To: <1485756147-13762-1-git-send-email-c_mkenna@qti.qualcomm.com>
c_mkenna@qti.qualcomm.com wrote:
> From: Maharaja Kennadyrajan <c_mkenna@qti.qualcomm.com>
>
> This patch provides support to get per peer tids log.
>
> echo 1 > /sys/kernel/debug/ieee80211/phyX/netdev\:wlanX/stations/
> XX:XX/peer_debug_trigger
>
> These logs will be the part of FWLOGS which we collect the logs
> via tracing interface. Here we will get the peer tigd logs only
> once(not repeatedly) when we write 1 to the debugfs file.
>
> Signed-off-by: Maharaja Kennadyrajan <c_mkenna@qti.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
ee8b08a1be82 ath10k: add debugfs support to get per peer tids log via tracing
--
https://patchwork.kernel.org/patch/9544499/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [1/3] ath10k: prefer unsigned int over just unsigned
From: Kalle Valo @ 2017-02-07 8:48 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
In-Reply-To: <148603246555.7275.3348416808167032391.stgit@potku.adurom.net>
Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Fixes new checkpatch warnings:
>
> drivers/net/wireless/ath/ath10k/htt.h:1639: Prefer 'unsigned int' to bare use of 'unsigned'
> drivers/net/wireless/ath/ath10k/htt.h:1660: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
3 patches applied to ath-next branch of ath.git, thanks.
b2d604156846 ath10k: prefer unsigned int over just unsigned
019e4280fac9 ath10k: use names in function definition arguments
39bfe9f7c0c9 ath10k: few whitespace fixes
--
https://patchwork.kernel.org/patch/9551583/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] rtlwifi: rtl8192c-common: Fix "BUG: KASAN:
From: Kalle Valo @ 2017-02-07 8:11 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Dmitry Osipenko
In-Reply-To: <20170205162422.26963-1-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> writes:
> Kernels built with CONFIG_KASAN=y report the following BUG for rtl8192cu
> and rtl8192c-common:
>
> ==================================================================
> BUG: KASAN: slab-out-of-bounds in rtl92c_dm_bt_coexist+0x858/0x1e40
> [rtl8192c_common] at addr ffff8801c90edb08
> Read of size 1 by task kworker/0:1/38
> page:ffffea0007243800 count:1 mapcount:0 mapping: (null)
> index:0x0 compound_mapcount: 0
> flags: 0x8000000000004000(head)
> page dumped because: kasan: bad access detected
> CPU: 0 PID: 38 Comm: kworker/0:1 Not tainted 4.9.7-gentoo #3
> Hardware name: Gigabyte Technology Co., Ltd. To be filled by
> O.E.M./Z77-DS3H, BIOS F11a 11/13/2013
> Workqueue: rtl92c_usb rtl_watchdog_wq_callback [rtlwifi]
> 0000000000000000 ffffffff829eea33 ffff8801d7f0fa30 ffff8801c90edb08
> ffffffff824c0f09 ffff8801d4abee80 0000000000000004 0000000000000297
> ffffffffc070b57c ffff8801c7aa7c48 ffff880100000004 ffffffff000003e8
> Call Trace:
> [<ffffffff829eea33>] ? dump_stack+0x5c/0x79
> [<ffffffff824c0f09>] ? kasan_report_error+0x4b9/0x4e0
> [<ffffffffc070b57c>] ? _usb_read_sync+0x15c/0x280 [rtl_usb]
> [<ffffffff824c0f75>] ? __asan_report_load1_noabort+0x45/0x50
> [<ffffffffc06d7a88>] ? rtl92c_dm_bt_coexist+0x858/0x1e40 [rtl8192c_common]
> [<ffffffffc06d7a88>] ? rtl92c_dm_bt_coexist+0x858/0x1e40 [rtl8192c_common]
> [<ffffffffc06d0cbe>] ? rtl92c_dm_rf_saving+0x96e/0x1330 [rtl8192c_common]
> ...
>
> The problem is due to rtl8192ce and rtl8192cu sharing routines, and having
> different layouts of struct rtl_pci_priv, which is used by rtl8192ce, and
> struct rtl_usb_priv, which is used by rtl8192cu. The problem was resolved
> by placing the struct bt_coexist_info at the head of each of those private
> areas.
>
> Reported-and-tested-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org> # 4.0+
> Cc: Dmitry Osipenko <digetx@gmail.com>
Patchwork incorrectly parsed this mail, my guess is because of the long
'========' line:
https://patchwork.kernel.org/patch/9556171/
So I applied this manually to wireless-drivers-next:
6773386f977c rtlwifi: rtl8192c-common: Fix "BUG: KASAN:
Thanks.
--
Kalle Valo
^ permalink raw reply
* Re: [v2, 1/7] rtlwifi: rtl8821ae: Fix typo in symbol for bandwidth numbers
From: Kalle Valo @ 2017-02-07 8:06 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Ping-Ke Shih
In-Reply-To: <20170203173521.6635-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In several places, "BANDWITH" is used when "BANDWIDTH" should have been
> used.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
7 patches applied to wireless-drivers-next.git, thanks.
d5e582523aea rtlwifi: rtl8821ae: Fix typo in symbol for bandwidth numbers
258b93cc391b rtlwifi: btcoexist: Convert halbtc8192e2ant.c to use standard debugging
dd192494e6ed rtlwifi: btcoexist: Convert halbtc8723b1ant.c to use standard debugging
2277f5f1154a rtlwifi: btcoexist: Convert halbtc8723b2ant.c to use standard debugging
bed4ff58af9d rtlwifi: btcoexist: Convert halbtc8821a1ant.c to use standard debugging
10468c3b438c rtlwifi: btcoexist: Convert halbtc8821a2ant.c to use standard debugging
41880bb38a55 rtlwifi: btcoexist: Convert halbtcoutsrc.c to use standard debugging
--
https://patchwork.kernel.org/patch/9554749/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: mwifiex: Avoid skipping WEP key deletion for AP
From: Kalle Valo @ 2017-02-07 8:03 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: linux-wireless, Nishant Sarmukadam, Ganapathi Bhat,
Amitkumar Karwar
In-Reply-To: <1486126822-21958-1-git-send-email-akarwar@marvell.com>
Amitkumar Karwar <akarwar@marvell.com> wrote:
> From: Ganapathi Bhat <gbhat@marvell.com>
>
> This patch fixes the issue specific to AP. AP is started with WEP
> security and external station is connected to it. Data path works
> in this case. Now if AP is restarted with WPA/WPA2 security,
> station is able to connect but ping fails.
>
> Driver skips the deletion of WEP keys if interface type is AP.
> Removing that redundant check resolves the issue.
>
> Fixes: e57f1734d87a ("mwifiex: add key material v2 support")
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
a5b60de6972d mwifiex: Avoid skipping WEP key deletion for AP
--
https://patchwork.kernel.org/patch/9554057/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v4] rt2x00: avoid introducing a USB dependency in the rt2x00lib module
From: Kalle Valo @ 2017-02-07 8:00 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless, Helmut Schaa, Felix Fietkau, Vishal Thanki
In-Reply-To: <1486029460-23431-1-git-send-email-sgruszka@redhat.com>
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> As reported by Felix:
>
> Though protected by an ifdef, introducing an usb symbol dependency in
> the rt2x00lib module is a major inconvenience for distributions that
> package kernel modules split into individual packages.
>
> Get rid of this unnecessary dependency by calling the usb related
> function from a more suitable place.
>
> Cc: Vishal Thanki <vishalthanki@gmail.com>
> Reported-by: Felix Fietkau <nbd@nbd.name>
> Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB")
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
6232c17438ed rt2x00: avoid introducing a USB dependency in the rt2x00lib module
--
https://patchwork.kernel.org/patch/9551537/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: brcmfmac: use wiphy_read_of_freq_limits to respect limits from DT
From: Kalle Valo @ 2017-02-07 7:57 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Arend van Spriel, Franky Lin, Hante Meuleman,
Pieter-Paul Giesberts, Franky Lin, linux-wireless,
brcm80211-dev-list.pdl, Rafał Miłecki
In-Reply-To: <20170117223550.12114-1-zajec5@gmail.com>
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This new helper reads extra frequency limits specified in DT and
> disables unavailable chanels. This is useful for devices (like home
> routers) with chipsets limited e.g. by board design.
>
> In order to respect info read from DT we simply need to check for
> IEEE80211_CHAN_DISABLED bit when constructing channel info.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Patch applied to wireless-drivers-next.git, thanks.
0f83ff697356 brcmfmac: use wiphy_read_of_freq_limits to respect limits from DT
--
https://patchwork.kernel.org/patch/9522069/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: mwifiex: don't include mac80211.h
From: Kalle Valo @ 2017-02-07 7:56 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Johannes Berg
In-Reply-To: <20170105123835.20995-1-johannes@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This driver doesn't use mac80211, so it shouldn't include mac80211.h,
> include only the necessary cfg80211.h instead.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Patch applied to wireless-drivers-next.git, thanks.
50d55b6d3f1c mwifiex: don't include mac80211.h
--
https://patchwork.kernel.org/patch/9498969/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: pull-request: iwlwifi-next 2017-02-06
From: Kalle Valo @ 2017-02-07 7:32 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless, linuxwifi
In-Reply-To: <1486402642.26003.141.camel@coelho.fi>
Luca Coelho <luca@coelho.fi> writes:
> Here's my second pull-request intended for v4.11. Just the usual set of
> fixes, cleanups and improvements, together with the continued work on
> support for new hardware. A bit more details in the tag description.
>
> I have sent this out before and kbuildbot didn't find any issues. I
> have also removed my favorite mistakes, namely the "commit" after the
> Fixes tag. ;)
>
> Please let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 36401cb7ffae731295a6dd1ce2b40d7ad74245f4:
>
> brcmfmac: be more verbose when PSM's watchdog fires (2017-02-02 08:14:26 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-kalle-2017-02-06
>
> for you to fetch changes up to 8364fbb497f00de21d6d347194fa8b6bbae1d6f5:
>
> iwlwifi: mvm: support new beacon template command (2017-02-06 19:19:27 +0200)
>
> ----------------------------------------------------------------
> Second batch of improvements and fixes for v4.11.
>
> * A bunch of bugfixes for the DQA code;
> * Work on support for new A000 devices continues;
> * Some clean-ups and general improvements
>
> ----------------------------------------------------------------
Pulled, thanks.
--
Kalle Valo
^ permalink raw reply
* Re: [PATCH 00/11 V4] rtlwifi: Various updates
From: Kalle Valo @ 2017-02-07 7:29 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Ping-Ke Shih
In-Reply-To: <20170120212716.29887-1-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> writes:
> These 11 changes fix a number of deficiencies. None of them are
> serious enough to be pushed to stable; however they help in the
> stability of the drivers, and in the robustness of authentication/
> association.
>
> This material should be sent to the 4.11 stream.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> ---
>
> V2 - Fix Kalle's comment about unended loops. It now runs a maximum of 200 times.
> V3 - Fix "WARNING: possible condition with no effect (if == else)" found by Test Robot
> V4 - No chenges -resubmitting as requested by Kalle.
> ---
> Larry Finger (1):
> rtlwifi: btcoexist: Change logging in halbtc8192e2ant.c
>
> Ping-Ke Shih (10):
> rtlwifi: Fix programing CAM content sequence.
> rtlwifi: Set retry limit depends on vif type.
> rtlwifi: Add a new enumeration value to btc_set_type
> rtlwifi: btcoexist: Add vendor definition for new btcoexist
> rtlwifi: rtl8723be: btcoexist: Add single_ant_path
> rtlwifi: move btcoex's ant_num declaration
> rtlwifi: rtl8723be: btcoex: add package_type function to btcoex
> rtlwifi: btcoex: move bt_type declaration
> rtlwifi: rtl8723be: fix ant_sel code
> rtlwifi: Add work queue for c2h cmd.
Thanks, as patchwork doesn't seem to detect this patchset I applied these
manually:
1e75622c630b rtlwifi: Fix programing CAM content sequence.
8d0d43e34208 rtlwifi: Set retry limit depends on vif type.
6f85c03bc34c rtlwifi: Add a new enumeration value to btc_set_type
1a2814739fe5 rtlwifi: btcoexist: Add vendor definition for new btcoexist
d46fa3e47aeb rtlwifi: btcoexist: Change logging in halbtc8192e2ant.c
db8cb0095b0e rtlwifi: rtl8723be: btcoexist: Add single_ant_path
0de9b5db9fbf rtlwifi: move btcoex's ant_num declaration
7fe1fe75c311 rtlwifi: rtl8723be: btcoex: add package_type function to btcoex
e0215c142026 rtlwifi: btcoex: move bt_type declaration
0ff78adeef11 rtlwifi: rtl8723be: fix ant_sel code
cceb0a597320 rtlwifi: Add work queue for c2h cmd.
--
Kalle Valo
^ permalink raw reply
* Re: [PATCH 01/11 V3] rtlwifi: Fix programing CAM content sequence.
From: Kalle Valo @ 2017-02-07 7:08 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Ping-Ke Shih, shaofu
In-Reply-To: <90709cde-bcca-eb57-3a61-4c318ed37c92@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 02/06/2017 06:45 AM, Kalle Valo wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> writes:
>>
>>> From: Ping-Ke Shih <pkshih@realtek.com>
>>>
>>> There is a potential race condition when the control byte of a CAM
>>> entry is written first. Write in reverse order to correct the condition.
>>>
>>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>>> Signed-off-by: shaofu <shaofu@realtek.com>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> ---
>>> V2 - no changes
>>> V3 - no changes
>>
>> I missed in my reply to v2 that you had already sent v3 from this
>> patchset. Strange that I don't see this v3 patchset either in patchwork,
>> only v1.
>>
>> Try submitting v4 in case it was just a temporary glitch in patchwork.
>> But if that doesn't help I'll apply these manually.
>
> I have no idea why my patches are not getting handled by patchwork,
> but V4 is not there either.
Yeah, that's odd. I do see your patches on the mailing list so I guess
something in this set is breaking patchwork's email parser. The only
notable difference I saw that in our patches the tags were in this
format:
[PATCH 01/11 V4]
But normally we use something like this:
[PATCH V4 01/11]
I don't know if that would cause patchwork to fail and I don't really
have time to investigate it right now. I'll just apply V4 manually now
and let's hope that the problem doesn't reappear.
--
Kalle Valo
^ permalink raw reply
* Re: [PATCH 01/11 V3] rtlwifi: Fix programing CAM content sequence.
From: Larry Finger @ 2017-02-07 5:42 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Ping-Ke Shih, shaofu
In-Reply-To: <87bmufa3nu.fsf@codeaurora.org>
On 02/06/2017 06:45 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> From: Ping-Ke Shih <pkshih@realtek.com>
>>
>> There is a potential race condition when the control byte of a CAM
>> entry is written first. Write in reverse order to correct the condition.
>>
>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> Signed-off-by: shaofu <shaofu@realtek.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> V2 - no changes
>> V3 - no changes
>
> I missed in my reply to v2 that you had already sent v3 from this
> patchset. Strange that I don't see this v3 patchset either in patchwork,
> only v1.
>
> Try submitting v4 in case it was just a temporary glitch in patchwork.
> But if that doesn't help I'll apply these manually.
I have no idea why my patches are not getting handled by patchwork, but V4 is
not there either.
Larry
^ permalink raw reply
* [PATCH] Make EN2 pin optional in the TRF7970A driver
From: Heiko Schocher @ 2017-02-07 5:22 UTC (permalink / raw)
To: netdev
Cc: Guan Ben, Mark Jonas, Heiko Schocher, devicetree, linux-wireless,
linux-kernel, Rob Herring, Samuel Ortiz, Lauro Ramos Venancio,
Aloisio Almeida Jr, Mark Rutland
From: Guan Ben <ben.guan@cn.bosch.com>
Make the EN2 pin optional. This is useful for boards,
which have this pin fix wired, for example to ground.
Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
Signed-off-by: Heiko Schocher <hs@denx.de>
---
.../devicetree/bindings/net/nfc/trf7970a.txt | 4 ++--
drivers/nfc/trf7970a.c | 26 ++++++++++++----------
2 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
index 32b35a0..5889a3d 100644
--- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
+++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
@@ -5,8 +5,8 @@ Required properties:
- spi-max-frequency: Maximum SPI frequency (<= 2000000).
- interrupt-parent: phandle of parent interrupt handler.
- interrupts: A single interrupt specifier.
-- ti,enable-gpios: Two GPIO entries used for 'EN' and 'EN2' pins on the
- TRF7970A.
+- ti,enable-gpios: One or two GPIO entries used for 'EN' and 'EN2' pins on the
+ TRF7970A. EN2 is optional.
- vin-supply: Regulator for supply voltage to VIN pin
Optional SoC Specific Properties:
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
index 26c9dbb..75079fb 100644
--- a/drivers/nfc/trf7970a.c
+++ b/drivers/nfc/trf7970a.c
@@ -1885,8 +1885,10 @@ static int trf7970a_power_up(struct trf7970a *trf)
usleep_range(5000, 6000);
if (!(trf->quirks & TRF7970A_QUIRK_EN2_MUST_STAY_LOW)) {
- gpio_set_value(trf->en2_gpio, 1);
- usleep_range(1000, 2000);
+ if (gpio_is_valid(trf->en2_gpio)) {
+ gpio_set_value(trf->en2_gpio, 1);
+ usleep_range(1000, 2000);
+ }
}
gpio_set_value(trf->en_gpio, 1);
@@ -1914,7 +1916,8 @@ static int trf7970a_power_down(struct trf7970a *trf)
}
gpio_set_value(trf->en_gpio, 0);
- gpio_set_value(trf->en2_gpio, 0);
+ if (gpio_is_valid(trf->en2_gpio))
+ gpio_set_value(trf->en2_gpio, 0);
ret = regulator_disable(trf->regulator);
if (ret)
@@ -2032,15 +2035,14 @@ static int trf7970a_probe(struct spi_device *spi)
trf->en2_gpio = of_get_named_gpio(np, "ti,enable-gpios", 1);
if (!gpio_is_valid(trf->en2_gpio)) {
- dev_err(trf->dev, "No EN2 GPIO property\n");
- return trf->en2_gpio;
- }
-
- ret = devm_gpio_request_one(trf->dev, trf->en2_gpio,
- GPIOF_DIR_OUT | GPIOF_INIT_LOW, "trf7970a EN2");
- if (ret) {
- dev_err(trf->dev, "Can't request EN2 GPIO: %d\n", ret);
- return ret;
+ dev_info(trf->dev, "No EN2 GPIO property\n");
+ } else {
+ ret = devm_gpio_request_one(trf->dev, trf->en2_gpio,
+ GPIOF_DIR_OUT | GPIOF_INIT_LOW, "trf7970a EN2");
+ if (ret) {
+ dev_err(trf->dev, "Can't request EN2 GPIO: %d\n", ret);
+ return ret;
+ }
}
if (of_property_read_bool(np, "en2-rf-quirk"))
--
2.7.4
^ permalink raw reply related
* [PATCH 07/11 V4] rtlwifi: move btcoex's ant_num declaration
From: Larry Finger @ 2017-02-07 3:30 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger, Ping-Ke Shih
In-Reply-To: <20170120212716.29887-1-Larry.Finger@lwfinger.net>
From: Ping-Ke Shih <pkshih@realtek.com>
File halbtcoutsrc.c is a better place for routine rtl_get_hwpg_ant_num()
than file rtl_btc.c.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
V2 - no changes
V3 - no changes
V4 - no changes
---
.../net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 12 ++++++++++++
drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c | 11 -----------
drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 ++
4 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
index 8e382a8..3958422 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
@@ -151,6 +151,18 @@ u8 rtl_get_hwpg_single_ant_path(struct rtl_priv *rtlpriv)
return rtlpriv->btcoexist.btc_info.single_ant_path;
}
+u8 rtl_get_hwpg_ant_num(struct rtl_priv *rtlpriv)
+{
+ u8 num;
+
+ if (rtlpriv->btcoexist.btc_info.ant_num == ANT_X2)
+ num = 2;
+ else
+ num = 1;
+
+ return num;
+}
+
static void halbtc_leave_lps(struct btc_coexist *btcoexist)
{
struct rtl_priv *rtlpriv;
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c
index d3fd921..54e893c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c
@@ -178,17 +178,6 @@ struct rtl_btc_ops *rtl_btc_get_ops_pointer(void)
}
EXPORT_SYMBOL(rtl_btc_get_ops_pointer);
-u8 rtl_get_hwpg_ant_num(struct rtl_priv *rtlpriv)
-{
- u8 num;
-
- if (rtlpriv->btcoexist.btc_info.ant_num == ANT_X2)
- num = 2;
- else
- num = 1;
-
- return num;
-}
enum rt_media_status mgnt_link_status_query(struct ieee80211_hw *hw)
{
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h b/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h
index 65c1c52..bba7e23e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h
@@ -46,9 +46,9 @@ void rtl_btc_special_packet_notify(struct rtl_priv *rtlpriv, u8 pkt_type);
struct rtl_btc_ops *rtl_btc_get_ops_pointer(void);
-u8 rtl_get_hwpg_ant_num(struct rtl_priv *rtlpriv);
u8 rtl_get_hwpg_bt_exist(struct rtl_priv *rtlpriv);
u8 rtl_get_hwpg_bt_type(struct rtl_priv *rtlpriv);
+u8 rtl_get_hwpg_ant_num(struct rtl_priv *rtlpriv);
u8 rtl_get_hwpg_single_ant_path(struct rtl_priv *rtlpriv);
enum rt_media_status mgnt_link_status_query(struct ieee80211_hw *hw);
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
index 8e82c0c..b46874b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
@@ -2653,6 +2653,8 @@ void rtl8723be_read_bt_coexist_info_from_hwpg(struct ieee80211_hw *hw,
value = hwinfo[EEPROM_RF_BT_SETTING_8723B];
rtlpriv->btcoexist.btc_info.bt_type = BT_RTL8723B;
rtlpriv->btcoexist.btc_info.ant_num = (value & 0x1);
+ rtlpriv->btcoexist.btc_info.single_ant_path =
+ (value & 0x40); /*0xc3[6]*/
} else {
rtlpriv->btcoexist.btc_info.btcoexist = 0;
rtlpriv->btcoexist.btc_info.bt_type = BT_RTL8723B;
--
2.10.2
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox