Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH 09/17] iwlwifi: pcie: don't increment / decrement a bool
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Emmanuel Grumbach, Luca Coelho
In-Reply-To: <20170208112322.29413-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

David reported that the code I added uses the decrement
and increment operator on a boolean variable.

Fix that.

Fixes: 0cd58eaab148 ("iwlwifi: pcie: allow the op_mode to block the tx queues")
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/internal.h b/drivers/net/wireless/intel/iwlwifi/pcie/internal.h
index cf5bda06042c..10937309641a 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/internal.h
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/internal.h
@@ -279,7 +279,7 @@ struct iwl_txq {
 	bool frozen;
 	u8 active;
 	bool ampdu;
-	bool block;
+	int block;
 	unsigned long wd_timeout;
 	struct sk_buff_head overflow_q;
 
-- 
2.11.0

^ permalink raw reply related

* [PATCH 14/17] iwlwifi: mvm: Fix CSA received immediately after association
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Avraham Stern, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Avraham Stern <avraham.stern@intel.com>

The session protection set for association is only removed when
BSS_CHANGED_BEACON_INFO is set and BSS_CHANGED_ASSOC is not set.

However, mac80211 may set both on association (in case a beacon was
already received). In this case, mac80211 will not set
BSS_CHANGED_BEACON_INFO on the next beacons because it has already
notified the beacon change, so the session protection is never removed
(until the session protection ends).

When a CSA is received within this time, the station will fail to
folllow the channel switch because it cannot schedule the time event.

Fix this by removing the session protection when
BSS_CHANGED_BEACON_INFO and BSS_CHANGED_ASSOC are both set.

Signed-off-by: Avraham Stern <avraham.stern@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 15ecd3aba71b..7253b92792bf 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -2008,16 +2008,16 @@ static void iwl_mvm_bss_info_changed_station(struct iwl_mvm *mvm,
 		if (fw_has_capa(&mvm->fw->ucode_capa,
 				IWL_UCODE_TLV_CAPA_UMAC_SCAN))
 			iwl_mvm_config_scan(mvm);
-	} else if (changes & BSS_CHANGED_BEACON_INFO) {
+	}
+
+	if (changes & BSS_CHANGED_BEACON_INFO) {
 		/*
-		 * We received a beacon _after_ association so
+		 * We received a beacon from the associated AP so
 		 * remove the session protection.
 		 */
 		iwl_mvm_remove_time_event(mvm, mvmvif,
 					  &mvmvif->time_event_data);
-	}
 
-	if (changes & BSS_CHANGED_BEACON_INFO) {
 		iwl_mvm_sf_update(mvm, vif, false);
 		WARN_ON(iwl_mvm_enable_beacon_filter(mvm, vif, 0));
 	}
-- 
2.11.0

^ permalink raw reply related

* [PATCH 12/17] iwlwifi: mvm: don't call << operator with a negative value
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Emmanuel Grumbach, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

In https://bugzilla.kernel.org/show_bug.cgi?id=177341 Bob
reported a UBSAN WARNING on rs.c in iwldvm.
Fix the same bug in iwlmvm.

This because
	i = index - 1;
	for (mask = (1 << i); i >= 0; i--, mask >>= 1)

is unsafe: i could be negative and hence we can call <<
on a negative value.
This bug doesn't have any real impact since the condition
of the for loop will prevent any usage of mask.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177341
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
index 13be9a5b83ee..ce907c58ebf6 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
@@ -972,7 +972,9 @@ static u16 rs_get_adjacent_rate(struct iwl_mvm *mvm, u8 index, u16 rate_mask,
 
 		/* Find the previous rate that is in the rate mask */
 		i = index - 1;
-		for (mask = (1 << i); i >= 0; i--, mask >>= 1) {
+		if (i >= 0)
+			mask = BIT(i);
+		for (; i >= 0; i--, mask >>= 1) {
 			if (rate_mask & mask) {
 				low = i;
 				break;
-- 
2.11.0

^ permalink raw reply related

* [PATCH 10/17] iwlwifi: make RTPM depend on EXPERT
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Emmanuel Grumbach, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

Enabling the RTPM Kconfig option can be fairly risky.
Runtime PM must be validated against a specific platform
before it can be safely enabled. Hence, it makes no sense
for distros and other big OS vendors to enable it since
they ship code to various systems and unknown platform.

Make sure that this is hinted properly by making the
IWLWIFI_PCIE_RTPM Kconfig option depend on EXPERT.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=172411
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index b64db47b31bb..c5f2ddf9b0fe 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -90,13 +90,16 @@ config IWLWIFI_BCAST_FILTERING
 
 config IWLWIFI_PCIE_RTPM
        bool "Enable runtime power management mode for PCIe devices"
-       depends on IWLMVM && PM
+       depends on IWLMVM && PM && EXPERT
        default false
        help
          Say Y here to enable runtime power management for PCIe
          devices.  If enabled, the device will go into low power mode
          when idle for a short period of time, allowing for improved
-         power saving during runtime.
+         power saving during runtime. Note that this feature requires
+         a tight integration with the platform. It is not recommended
+         to enable this feature without proper validation with the
+         specific target platform.
 
 	 If unsure, say N.
 
-- 
2.11.0

^ permalink raw reply related

* [PATCH 13/17] iwlwifi: pcie: set STATUS_RFKILL immediately after interrupt
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Golan Ben Ami, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Golan Ben Ami <golan.ben.ami@intel.com>

Currently, when getting a RFKILL interrupt, the transport enters a flow
in which it stops the device, disables other interrupts, etc. After
stopping the device, the transport resets the hw, and sleeps. During
the sleep, a context switch occurs and host commands are sent by upper
layers (e.g. mvm) to the fw. This is possible since the op_mode layer
and the transport layer hold different mutexes.

Since the STATUS_RFKILL bit isn't set, the transport layer doesn't
recognize that RFKILL was toggled on, and no commands can actually be
sent, so it enqueues the command to the tx queue and sets a timer on
the queue.

After switching context back to stopping the device, STATUS_RFKILL is
set, and then the transport can't send the command to the fw.
This eventually results in a queue hang.

Fix this by setting STATUS_RFKILL immediately when
the interrupt is fired.

Signed-off-by: Golan Ben-Ami <golan.ben.ami@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
index e1bf6da20909..de94dfdf2ec9 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
@@ -1609,6 +1609,9 @@ irqreturn_t iwl_pcie_irq_handler(int irq, void *dev_id)
 
 		mutex_lock(&trans_pcie->mutex);
 		hw_rfkill = iwl_is_rfkill_set(trans);
+		if (hw_rfkill)
+			set_bit(STATUS_RFKILL, &trans->status);
+
 		IWL_WARN(trans, "RF_KILL bit toggled to %s.\n",
 			 hw_rfkill ? "disable radio" : "enable radio");
 
@@ -1617,7 +1620,6 @@ irqreturn_t iwl_pcie_irq_handler(int irq, void *dev_id)
 		iwl_trans_pcie_rf_kill(trans, hw_rfkill);
 		mutex_unlock(&trans_pcie->mutex);
 		if (hw_rfkill) {
-			set_bit(STATUS_RFKILL, &trans->status);
 			if (test_and_clear_bit(STATUS_SYNC_HCMD_ACTIVE,
 					       &trans->status))
 				IWL_DEBUG_RF_KILL(trans,
@@ -1954,6 +1956,9 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id)
 
 		mutex_lock(&trans_pcie->mutex);
 		hw_rfkill = iwl_is_rfkill_set(trans);
+		if (hw_rfkill)
+			set_bit(STATUS_RFKILL, &trans->status);
+
 		IWL_WARN(trans, "RF_KILL bit toggled to %s.\n",
 			 hw_rfkill ? "disable radio" : "enable radio");
 
@@ -1962,7 +1967,6 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, void *dev_id)
 		iwl_trans_pcie_rf_kill(trans, hw_rfkill);
 		mutex_unlock(&trans_pcie->mutex);
 		if (hw_rfkill) {
-			set_bit(STATUS_RFKILL, &trans->status);
 			if (test_and_clear_bit(STATUS_SYNC_HCMD_ACTIVE,
 					       &trans->status))
 				IWL_DEBUG_RF_KILL(trans,
-- 
2.11.0

^ permalink raw reply related

* [PATCH 11/17] iwlwifi: dvm: don't call << operator with a negative value
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Emmanuel Grumbach, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

In https://bugzilla.kernel.org/show_bug.cgi?id=177341 Bob
reported a UBSAN WARNING on rs.c.

Undefined behaviour in drivers/net/wireless/intel/iwlwifi/dvm/rs.c:746:18

This because
	i = index - 1;
	for (mask = (1 << i); i >= 0; i--, mask >>= 1)

is unsafe: i could be negative and hence we can call <<
on a negative value.
This bug doesn't have any real impact since the condition
of the for loop will prevent any usage of mask.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177341
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
index 710dbbefd551..ff44ebc5829d 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
@@ -740,7 +740,10 @@ static u16 rs_get_adjacent_rate(struct iwl_priv *priv, u8 index, u16 rate_mask,
 
 		/* Find the previous rate that is in the rate mask */
 		i = index - 1;
-		for (mask = (1 << i); i >= 0; i--, mask >>= 1) {
+		if (i >= 0)
+			mask = BIT(i);
+
+		for (; i >= 0; i--, mask >>= 1) {
 			if (rate_mask & mask) {
 				low = i;
 				break;
-- 
2.11.0

^ permalink raw reply related

* [PATCH 15/17] iwlwifi: mvm: avoid race condition in ADD_STA.
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Goodstein, Mordechay, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: "Goodstein, Mordechay" <mordechay.goodstein@intel.com>

The race happens when we send ADD_STA(auth->assoc) -> LQ_CMD
between the commands the FW sometimes loses the medium for AUX, and
sends a ndp to the AP and the flow becomes, ADD_STA -> send ndp -> LQ_CMD
the problem is that there's no rates yet defined for sending the ndp and
FW generates an assert.

The fix: change the order of the commands to LQ_CMD -> ADD_STA

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 7253b92792bf..d37b1695c64e 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -2627,11 +2627,10 @@ static int iwl_mvm_mac_sta_state(struct ieee80211_hw *hw,
 			mvmvif->ap_assoc_sta_count++;
 			iwl_mvm_mac_ctxt_changed(mvm, vif, false, NULL);
 		}
+
+		iwl_mvm_rs_rate_init(mvm, sta, mvmvif->phy_ctxt->channel->band,
+				     true);
 		ret = iwl_mvm_update_sta(mvm, vif, sta);
-		if (ret == 0)
-			iwl_mvm_rs_rate_init(mvm, sta,
-					     mvmvif->phy_ctxt->channel->band,
-					     true);
 	} else if (old_state == IEEE80211_STA_ASSOC &&
 		   new_state == IEEE80211_STA_AUTHORIZED) {
 
-- 
2.11.0

^ permalink raw reply related

* Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
From: David Miller @ 2017-02-08 16:06 UTC (permalink / raw)
  To: f.fainelli
  Cc: netdev, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, target-devel, andrew, anna.schumaker,
	derek.chickles, felix.manlunas, bfields, jlayton, jirislaby,
	kvalo, mcgrof, madalin.bucur, UNGLinuxDriver, nab, mickflemm,
	nicolas.ferre, raghu.vatsavayi, ralf, satananda.burla,
	thomas.petazzoni, timur, trond.myklebust, vivien.didelot,
	woojung.huh
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

RnJvbTogRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+DQpEYXRlOiBUdWUs
ICA3IEZlYiAyMDE3IDE1OjAyOjUzIC0wODAwDQoNCj4gSSdtIGhvcGluZyB0aGlzIGRvZXNuJ3Qg
Y29uZmxpY3Qgd2l0aCB3aGF0J3MgYWxyZWFkeSBpbiBuZXQtbmV4dC4uLg0KPiANCj4gRGF2aWQs
IHRoaXMgc2hvdWxkIHByb2JhYmx5IGdvIHZpYSB5b3VyIHRyZWUgY29uc2lkZXJpbmcgdGhlIGRp
ZmZzdGF0Lg0KDQpJIHRoaW5rIHlvdSBuZWVkIG9uZSBtb3JlIHJlc3Bpbi4gIEFyZSB5b3UgZG9p
bmcgYW4gYWxsbW9kY29uZmlnIGJ1aWxkPw0KSWYgbm90LCBmb3Igc29tZXRoaW5nIGxpa2UgdGhp
cyBpdCdzIGEgbXVzdDoNCg0KZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL3dpbDYyMTAvY2ZnODAy
MTEuYzoyNDozMDogZXJyb3I6IGV4cGVjdGVkIKEpoiBiZWZvcmUgoWJvb2yiDQogbW9kdWxlX3Bh
cmFtKGRpc2FibGVfYXBfc21lLCBib29sLCAwNDQ0KTsNCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIF4NCmRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC93aWw2MjEwL2NmZzgwMjExLmM6MjU6
MzQ6IGVycm9yOiBleHBlY3RlZCChKaIgYmVmb3JlIHN0cmluZyBjb25zdGFudA0KIE1PRFVMRV9Q
QVJNX0RFU0MoZGlzYWJsZV9hcF9zbWUsICIgbGV0IHVzZXIgc3BhY2UgaGFuZGxlIEFQIG1vZGUg
U01FIik7DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXg0KTGlrZSBsaWtlIHRo
YXQgZmlsZSBuZWVkcyBsaW51eC9tb2R1bGUuaCBpbmNsdWRlZC4NCg0KVGhhbmtzLg0K

^ permalink raw reply

* [PATCH 16/17] iwlwifi: mvm: Fix removal of IGTK
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Ilan Peer, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Ilan Peer <ilan.peer@intel.com>

When removing an IGTK, iwl_mvm_send_sta_igtk() was
called before station ID was retrieved, so the function
was invoked with an invalid station ID. Fix this by first
getting the station ID.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=192411
Signed-off-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 1bad933b3ad4..c35fabdf85da 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -3047,6 +3047,11 @@ int iwl_mvm_remove_sta_key(struct iwl_mvm *mvm,
 
 	/* Get the station from the mvm local station table */
 	mvm_sta = iwl_mvm_get_key_sta(mvm, vif, sta);
+	if (!mvm_sta) {
+		IWL_ERR(mvm, "Failed to find station\n");
+		return -EINVAL;
+	}
+	sta_id = mvm_sta->sta_id;
 
 	IWL_DEBUG_WEP(mvm, "mvm remove dynamic key: idx=%d sta=%d\n",
 		      keyconf->keyidx, sta_id);
@@ -3074,8 +3079,6 @@ int iwl_mvm_remove_sta_key(struct iwl_mvm *mvm,
 		return 0;
 	}
 
-	sta_id = mvm_sta->sta_id;
-
 	ret = __iwl_mvm_remove_sta_key(mvm, sta_id, keyconf, mcast);
 	if (ret)
 		return ret;
-- 
2.11.0

^ permalink raw reply related

* Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
From: Kalle Valo @ 2017-02-08 16:11 UTC (permalink / raw)
  To: David Miller
  Cc: f.fainelli, netdev, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, target-devel, andrew, anna.schumaker,
	derek.chickles, felix.manlunas, bfields, jlayton, jirislaby,
	mcgrof, madalin.bucur, UNGLinuxDriver, nab, mickflemm,
	nicolas.ferre, raghu.vatsavayi, ralf, satananda.burla,
	thomas.petazzoni, timur, trond.myklebust, vivien.didelot,
	woojung.huh
In-Reply-To: <20170208.110626.346978547122180233.davem@davemloft.net>

David Miller <davem@davemloft.net> writes:

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue,  7 Feb 2017 15:02:53 -0800
>
>> I'm hoping this doesn't conflict with what's already in net-next...
>>=20
>> David, this should probably go via your tree considering the diffstat.
>
> I think you need one more respin.  Are you doing an allmodconfig build?
> If not, for something like this it's a must:
>
> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected =E2=80=
=98)=E2=80=99 before =E2=80=98bool=E2=80=99
>  module_param(disable_ap_sme, bool, 0444);
>                               ^
> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected =E2=80=
=98)=E2=80=99 before string constant
>  MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
>                                   ^
> Like like that file needs linux/module.h included.

Johannes already fixed a similar (or same) problem in my tree:

wil6210: include moduleparam.h

https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.gi=
t/commit/?id=3D949c2d0096753d518ef6e0bd8418c8086747196b

I'm planning to send you a pull request tomorrow which contains that
one.

--=20
Kalle Valo

^ permalink raw reply

* RE: KASAN+netlink, was: [PATCH] [net-next?] hns: avoid stack overflow with CONFIG_KASAN
From: David Laight @ 2017-02-08 16:00 UTC (permalink / raw)
  To: 'Johannes Berg', Arnd Bergmann, David Miller,
	netdev@vger.kernel.org
  Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrey Ryabinin, nikolay@cumulusnetworks.com,
	nicolas.dichtel@6wind.com, adobriyan@gmail.com, linux-wireless
In-Reply-To: <1486556665.24745.6.camel@sipsolutions.net>

PiBGcm9tOiBKb2hhbm5lcyBCZXJnDQo+IFNlbnQ6IDA4IEZlYnJ1YXJ5IDIwMTcgMTI6MjQNCi4u
Lg0KPiBCdHcsIHdoYXQncyBjYXVzaW5nIHRoaXMgdG8gc3RhcnQgd2l0aD8gQ2FuJ3QgdGhlIGNv
bXBpbGVyIHJldXNlIHRoZQ0KPiBzdGFjayBwbGFjZXM/DQoNCk9ubHkgaWYgaXQgcmVhbGlzZXMg
dGhleSd2ZSBnb25lIG91dCBvZiBzY29wZSAtIHdoaWNoIHByb2JhYmx5DQpkb2Vzbid0IGhhcHBl
biB3aGVuIHRoZSBmdW5jdGlvbnMgYXJlIGlubGluZWQuDQpUaGUgYWRkcmVzcyBvZiB0aGUgcGFy
YW1ldGVyIGNhbiBiZSBzYXZlZCBieSB0aGUgY2FsbGluZyBmdW5jdGlvbg0KYW5kIHVzZWQgaW4g
YSBsYXRlciBjYWxsLg0KDQpTb21ldGhpbmcgbGlrZSB0aGlzIGlzIHZhbGlkOg0KDQppbnQgZm9v
KGludCAqcCwgaW50IHYpDQp7DQoJc3RhdGljIGludCAqc3Y7DQoJaW50IG9sZCA9IC0xOw0KCWlm
IChzdikge29sZCA9ICpzdjsgKnN2ID0gdjt9DQoJc3YgPSB2Ow0KCXJldHVybiBvbGQ7DQp9DQoN
CnZvaWQgYmFyKC4uLikgew0KCWludCBhLCBiOw0KCS4uLg0KCWZvbygmYSwgMCk7DQoJLi4uDQoJ
Zm9vKCZiLCAxKTsNCgkuLi4NCglmb28oTlVMTCwgMik7DQoJLi4uDQoNCklmIHRoZSBjb21waWxl
ciBzdGFydHMgc2hhcmluZyBzdGFjayBpdCBhbGwgZ29lcyB3cm9uZy4NCg0KCURhdmlkDQoNCg0K

^ permalink raw reply

* Re: [PATCH V3 4/9] brcmfmac: add struct brcmf_pub parameter to the __brcmf_err
From: Rafał Miłecki @ 2017-02-08 15:09 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Arend Van Spriel, Rafał Miłecki, Franky Lin,
	Hante Meuleman, Pieter-Paul Giesberts, Franky Lin, linux-wireless,
	brcm80211-dev-list.pdl
In-Reply-To: <87tw84loop.fsf@kamboji.qca.qualcomm.com>

On 2017-02-08 15:52, Kalle Valo wrote:
> Rafał Miłecki <rafal@milecki.pl> writes:
> 
>> On 2017-02-08 10:54, Arend Van Spriel wrote:
>>> On 2-2-2017 22:33, Rafał Miłecki wrote:
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>> 
>>>> This will allow getting struct device reference from the passed
>>>> brcmf_pub for the needs of dev_err. More detailed messages are 
>>>> really
>>>> important for home routers which frequently have 2 (or even 3)
>>>> wireless
>>>> cards supported by brcmfmac.
>>>> 
>>>> Note that all calls are yet to be updated as for now brcmf_err macro
>>>> always passes NULL. This will be handled in following patch to make
>>>> this
>>>> change easier to review.
>>> 
>>> I prefer brcmf_err() to have struct device reference directly
>>> instead of
>>> using brcmf_pub. That would remove the need for patches 5 till 7 as 
>>> bus
>>> specific code already has struct device. So I have acked the first
>>> three
>>> patches, but would like to revise 8 and 9.
>>> 
>>> Kalle,
>>> 
>>> I acked the first three patches. Can those three still go in for 
>>> 4.11?
>> 
>> Sounds OK to me. Kalle, I ack Arend's request if it isn't too late.
> 
> Ok, I'll try. My plan is to get everything ready for linux-next by
> tomorrow morning (Finland time), let's see how it goes.
> 
> Related to this, Rafał are you still deleting the patches from 
> patchwork
> which should be dropped? I think you are as I can't see patches 4-9
> anymore.
> 
> Now that my patchwork setup is much better (compared to how it was over
> a year ago) I would actually prefer that you don't do that anymore. The
> problem is that when you delete the patch from patchwork it completely
> disappears from patchwork and I can't check the patch or discussion
> anymore. And I'm so accustomed to use patchwork that only seldom I use
> email to find the patch.
> 
> So it would be better to leave the patches as is and let me drop them
> (=change the state Changes Requested, Rejected or similar), which is
> trivial with my script. Otherwise I get this unsure feeling of what
> happened to the patch :)

Yeah, that was me (marked 4-9 as Changes Requested), sorry ;) I won't be 
messing with patches in the future.

^ permalink raw reply

* Re: ath10k: remove unneeded semicolon
From: Kalle Valo @ 2017-02-08 15:01 UTC (permalink / raw)
  To: Waldemar Rymarkiewicz; +Cc: ath10k, Waldemar Rymarkiewicz, linux-wireless
In-Reply-To: <20170202175342.26338-1-ext.waldemar.rymarkiewicz@tieto.com>

Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com> wrote:
> Remove redundant semicolon after switch statement.
> 
> Signed-off-by: Waldemar Rymarkiewicz <ext.waldemar.rymarkiewicz@tieto.com>

Patch applied to ath-next branch of ath.git, thanks.

dab55d1083db ath10k: remove unneeded semicolon

-- 
https://patchwork.kernel.org/patch/9552819/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply

* [PATCH 17/17] iwlwifi: mvm: avoid exceeding the allowed print length
From: Luca Coelho @ 2017-02-08 15:51 UTC (permalink / raw)
  To: linux-wireless; +Cc: kvalo, Golan Ben-Ami, Luca Coelho
In-Reply-To: <20170208155149.1704-1-luca@coelho.fi>

From: Golan Ben-Ami <golan.ben.ami@intel.com>

Divide a mfuart related print so it won't exceed the allowed
MAX_MSG_LEN (110 bytes) per print.

Fixes: 19f63c531b85 ("iwlwifi: mvm: support v2 of mfuart load notification")
Signed-off-by: Golan Ben-Ami <golan.ben.ami@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index c42ef8681b75..45cb4f476e76 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1396,19 +1396,15 @@ void iwl_mvm_rx_mfuart_notif(struct iwl_mvm *mvm,
 	struct iwl_rx_packet *pkt = rxb_addr(rxb);
 	struct iwl_mfuart_load_notif *mfuart_notif = (void *)pkt->data;
 
+	IWL_DEBUG_INFO(mvm,
+		       "MFUART: installed ver: 0x%08x, external ver: 0x%08x, status: 0x%08x, duration: 0x%08x\n",
+		       le32_to_cpu(mfuart_notif->installed_ver),
+		       le32_to_cpu(mfuart_notif->external_ver),
+		       le32_to_cpu(mfuart_notif->status),
+		       le32_to_cpu(mfuart_notif->duration));
+
 	if (iwl_rx_packet_payload_len(pkt) == sizeof(*mfuart_notif))
 		IWL_DEBUG_INFO(mvm,
-			       "MFUART: installed ver: 0x%08x, external ver: 0x%08x, status: 0x%08x, duration: 0x%08x, image size: 0x%08x\n",
-			       le32_to_cpu(mfuart_notif->installed_ver),
-			       le32_to_cpu(mfuart_notif->external_ver),
-			       le32_to_cpu(mfuart_notif->status),
-			       le32_to_cpu(mfuart_notif->duration),
+			       "MFUART: image size: 0x%08x\n",
 			       le32_to_cpu(mfuart_notif->image_size));
-	else
-		IWL_DEBUG_INFO(mvm,
-			       "MFUART: installed ver: 0x%08x, external ver: 0x%08x, status: 0x%08x, duration: 0x%08x\n",
-			       le32_to_cpu(mfuart_notif->installed_ver),
-			       le32_to_cpu(mfuart_notif->external_ver),
-			       le32_to_cpu(mfuart_notif->status),
-			       le32_to_cpu(mfuart_notif->duration));
 }
-- 
2.11.0

^ permalink raw reply related

* pull-request: iwlwifi-next 2017-02-08
From: Luca Coelho @ 2017-02-08 19:01 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless, linuxwifi

[-- Attachment #1: Type: text/plain, Size: 3570 bytes --]

Hi Kalle,

Here's my third and final pull-request intended for v4.11.  As I
mentioned before, I concentrated on our bugfix patches this time.  More
details in the tag description.

I have sent this out before, but I didn't get kbuildbot results yet. 
Hopefully there will be no issues.  I'm sending it out already because
you asked me to send this before 9pm today (I'm probably 1 or 2 minutes
late :P).  It's up to you whether you want to pull it as is or wait for
kbuildbot results.

Please let me know if there are any issues.

Cheers,
Luca.


The following changes since commit 8364fbb497f00de21d6d347194fa8b6bbae1d6f5:

  iwlwifi: mvm: support new beacon template command (2017-02-06 19:19:27 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-kalle-2017-02-08

for you to fetch changes up to 0c8d0a4770cb6863f78a25c8d211f42e9c82251c:

  iwlwifi: mvm: avoid exceeding the allowed print length (2017-02-08 17:54:23 +0200)

----------------------------------------------------------------
Some patches focusing on bugfixes for v4.11:

  * Fix 802.11w, which was failing to due an IGTK bug;
  * A few more bugzilla bug fixes;
  * A channel-switch race condition fix;
  * Some fixes related to suspend/resume with new HW;
  * The RF-kill saga continues;
  * And some other fixes here and there...

----------------------------------------------------------------
Avraham Stern (1):
      iwlwifi: mvm: Fix CSA received immediately after association

Emmanuel Grumbach (5):
      iwlwifi: mvm: use the PROBE_RESP_QUEUE to send deauth to unknown station
      iwlwifi: pcie: don't increment / decrement a bool
      iwlwifi: make RTPM depend on EXPERT
      iwlwifi: dvm: don't call << operator with a negative value
      iwlwifi: mvm: don't call << operator with a negative value

Golan Ben Ami (2):
      iwlwifi: pcie: Re-configure IVAR table after stop device
      iwlwifi: pcie: set STATUS_RFKILL immediately after interrupt

Golan Ben-Ami (1):
      iwlwifi: mvm: avoid exceeding the allowed print length

Goodstein, Mordechay (1):
      iwlwifi: mvm: avoid race condition in ADD_STA.

Gregory Greenman (1):
      iwlwifi: mvm: fix a print of NSS for HT rate

Haim Dreyfuss (3):
      iwlwifi: pcie: move msix conf functions above other functions
      iwlwifi: pcie: separate between SW and HW MSIX configuration
      iwlwifi: pcie: re-configure IVAR table after suspend-resume

Ilan Peer (1):
      iwlwifi: mvm: Fix removal of IGTK

Sara Sharon (2):
      iwlwifi: mvm: fix references to first_agg_queue in DQA mode
      iwlwifi: mvm: fix reorder timer re-arming

 drivers/net/wireless/intel/iwlwifi/Kconfig         |   7 ++-
 drivers/net/wireless/intel/iwlwifi/dvm/rs.c        |   5 +-
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c        |  20 +++----
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c  |  15 +++--
 drivers/net/wireless/intel/iwlwifi/mvm/rs.c        |   6 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c      |   3 +-
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c       |   7 ++-
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c        |  17 +++---
 drivers/net/wireless/intel/iwlwifi/pcie/internal.h |   2 +-
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c       |   8 ++-
 drivers/net/wireless/intel/iwlwifi/pcie/trans.c    | 243 ++++++++++++++++++++++++++++++++++++++++++----------------------------------
 11 files changed, 188 insertions(+), 145 deletions(-)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply

* Re: [PATCH V2] mtd: bcm47xxsflash: use platform_(set|get)_drvdata
From: Brian Norris @ 2017-02-08 19:21 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: David Woodhouse, Boris Brezillon, Marek Vasut, Richard Weinberger,
	Cyrille Pitchen, Kalle Valo, linux-mtd, linux-wireless,
	Hauke Mehrtens, Rafał Miłecki
In-Reply-To: <20170116162818.12094-1-zajec5@gmail.com>

On Mon, Jan 16, 2017 at 05:28:18PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> We have generic place & helpers for storing platform driver data so
> there is no reason for using custom priv pointer.
> 
> This allows cleaning up struct bcma_sflash from unneeded fields.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Kalle: This is mtd focused patch, so I guess it should go through mtd tree. Do
>        you find bcma change important enough to care to Ack it? :)

Applied to l2-mtd.git.

^ permalink raw reply

* Re: pull-request: iwlwifi-next 2017-02-08
From: Kalle Valo @ 2017-02-08 19:35 UTC (permalink / raw)
  To: Luca Coelho; +Cc: linux-wireless, linuxwifi
In-Reply-To: <1486580477.10952.14.camel@coelho.fi>

Luca Coelho <luca@coelho.fi> writes:

> Here's my third and final pull-request intended for v4.11.  As I
> mentioned before, I concentrated on our bugfix patches this time.  More
> details in the tag description.
>
> I have sent this out before, but I didn't get kbuildbot results yet. 
> Hopefully there will be no issues.  I'm sending it out already because
> you asked me to send this before 9pm today (I'm probably 1 or 2 minutes
> late :P).  It's up to you whether you want to pull it as is or wait for
> kbuildbot results.
>
> Please let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 8364fbb497f00de21d6d347194fa8b6bbae1d6f5:
>
>   iwlwifi: mvm: support new beacon template command (2017-02-06 19:19:27 +0200)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git tags/iwlwifi-next-for-kalle-2017-02-08
>
> for you to fetch changes up to 0c8d0a4770cb6863f78a25c8d211f42e9c82251c:
>
>   iwlwifi: mvm: avoid exceeding the allowed print length (2017-02-08 17:54:23 +0200)
>
> ----------------------------------------------------------------
> Some patches focusing on bugfixes for v4.11:
>
>   * Fix 802.11w, which was failing to due an IGTK bug;
>   * A few more bugzilla bug fixes;
>   * A channel-switch race condition fix;
>   * Some fixes related to suspend/resume with new HW;
>   * The RF-kill saga continues;
>   * And some other fixes here and there...
>
> ----------------------------------------------------------------

Pulled, thanks.

-- 
Kalle Valo

^ permalink raw reply

* Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
From: Florian Fainelli @ 2017-02-08 19:45 UTC (permalink / raw)
  To: Kalle Valo, David Miller
  Cc: netdev, linux-mips, linux-nfs, linux-scsi, linux-usb,
	linux-wireless, target-devel, andrew, anna.schumaker,
	derek.chickles, felix.manlunas, bfields, jlayton, jirislaby,
	mcgrof, madalin.bucur, UNGLinuxDriver, nab, mickflemm,
	nicolas.ferre, raghu.vatsavayi, ralf, satananda.burla,
	thomas.petazzoni, timur, trond.myklebust, vivien.didelot,
	woojung.huh
In-Reply-To: <87h944ll0w.fsf@kamboji.qca.qualcomm.com>

On 02/08/2017 08:11 AM, Kalle Valo wrote:
> David Miller <davem@davemloft.net> writes:
> 
>> From: Florian Fainelli <f.fainelli@gmail.com>
>> Date: Tue,  7 Feb 2017 15:02:53 -0800
>>
>>> I'm hoping this doesn't conflict with what's already in net-next...
>>>
>>> David, this should probably go via your tree considering the diffstat.
>>
>> I think you need one more respin.  Are you doing an allmodconfig build?

I did not, instead tried to test each driver individually in different
configurations...

>> If not, for something like this it's a must:
>>
>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
>>  module_param(disable_ap_sme, bool, 0444);
>>                               ^
>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
>>  MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
>>                                   ^
>> Like like that file needs linux/module.h included.
> 
> Johannes already fixed a similar (or same) problem in my tree:
> 
> wil6210: include moduleparam.h
> 
> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b
> 
> I'm planning to send you a pull request tomorrow which contains that
> one.

Thanks Kalle!

David, can you hold on this series until Kalle's pull request gets
submitted? Past this error, allmodconfig builds fine with this patch
series (just tested). Thanks!
-- 
Florian

^ permalink raw reply

* Re: Installing driver for Ubuntu 16.04 Intel(R) Wireless WiFi Link 4965AGN
From: Leopoldo @ 2017-02-08 20:12 UTC (permalink / raw)
  To: sedat.dilek; +Cc: linux-wireless
In-Reply-To: <CA+icZUV-J0+jY8U=5_UwDf1Z7Qgnqswn+gAPhWm8YYkhqWLJjw@mail.gmail.com>

Dear Sedat,

Absolutely clear. As you are my primary contact there, you can extent my 
question to the people there.

I much appreciate your assistance.

Kind regards,

Leopoldo


El 06/02/17 a las 07:01, Sedat Dilek escribió:
> On Sun, Feb 5, 2017 at 6:31 PM, Leopoldo <info@leopoldosoria.com> wrote:
>> Dear Sedat,
>>
>> Did you have the chance to have a look to this?
>>
> No.
> If it was not clear said: I did not promise to look at it, I just said
> sent the logs and people here can look at it.
>
> - Sedat -
>
>> Kind regards.
>>
>> Leopoldo
>>
>>
>> El 16/01/17 a las 21:33, Leopoldo escribió:
>>
>> Dear Sedat,
>>
>> Please, find attached the requested 2 files.
>>
>> Thanking you invaluable collaboration.
>>
>> Leopoldo
>>
>>
>> El 02/01/17 a las 20:39, Sedat Dilek escribió:
>>
>> On Mon, Jan 2, 2017 at 7:11 PM,  <info@leopoldosoria.com> wrote:
>>
>> Dear Madam Sedat,
>>
>> Hehe, my family name is indeed a female first name - Sedat is male.
>>
>> Thank you for your answer.
>>
>> I already consulted Ubuntu Community but it is not so nice for a beginner
>> like me. I tried several recomedations from them, but no way.  So, I
>> thought, it is better to ask to the source.
>>
>> Yes, I have the firmware you mention, but wifi doesn't work. The icon appear
>> in the top bar but it doesn't seem to be conected. It doesn't seach
>> conections even when wifi is activated. The ligh of wifi simbol in the
>> laptop lights some times but others it doesn't.
>>
>> It's difficult to answer without knowing anything about your hardware,
>> your WLAN infrastructure and your WLAN setup on Ubuntu/xenial.
>>
>> It might be helpful if you attach your linux-config and dmesg output.
>>
>> $ cp -v /boot/config-$(uname -r) /tmp
>> $ dmesg > /tmp/dmesg.txt
>>
>> Attach those two files from /tmp directory and people can look at this.
>>
>> - Sedat -
>>
>> Any help is welcome and I won't forget ladies next time, sorry.
>>
>> Thank you for your help and have a happy new year 2017 also.
>>
>> Regards,
>> Leopoldo
>>
>>
>>
>>
>> El 02-01-2017 15:06, Sedat Dilek escribió:
>>
>> On Mon, Jan 2, 2017 at 2:11 PM,  <info@leopoldosoria.com> wrote:
>>
>> Dear Sirs,
>> Which of the below drivers should I install for my Lenovo 3000 V200?
>> I am runing Ubuntu 16.04
>>
>> Intel® Wireless WiFi Link 4965AGN
>> 2.6.24+ iwlwifi-4965-ucode-4.44.14.tgz
>> 2.6.24+ iwlwifi-4965-ucode-4.44.15.tgz
>> 2.6.24+ iwlwifi-4965-ucode-4.44.17.tgz
>> 2.6.24+ iwlwifi-4965-ucode-4.44.1.18.tgz
>> 2.6.24+ iwlwifi-4965-ucode-4.44.1.20.tgz
>> 2.6.24+ iwlwifi-4965-ucode-228.57.1.21.tgz
>> 2.6.28+ (?)     iwlwifi-4965-ucode-228.57.2.21.tgz
>> 2.6.28+ (?)     iwlwifi-4965-ucode-228.57.2.23.tgz
>> 2.6.28+ (?)     iwlwifi-4965-ucode-228.61.2.24.tgz
>>
>> Ans how shoudl I proceed for intalling the right driver?
>>
>> Thank you
>>
>> [ What about the Ladies, Sir :-)? ]
>>
>> Happy new 2017!
>>
>> You need the linux-firmware [1] package.
>> Normally, Ubuntu/xenial should ship it.
>>
>> Check if you have...
>>
>> /lib/firmware/iwlwifi-4965-2.ucode
>>
>> ...file.
>>
>> Not sure why you are asking or what is not working.
>> AFAICS, Ubuntu should have some nice wikis explaining a WLAN setup.
>> A good strategy will always be to consult your distro's help before asking
>> here.
>>
>> [3] as a gift.
>>
>> Regards,
>> - Sedat -
>>
>> [1] http://packages.ubuntu.com/xenial/linux-firmware
>> [2] http://packages.ubuntu.com/xenial/all/linux-firmware/filelist
>> [3] http://www.catb.org/~esr/faqs/smart-questions.html
>>
>>
>>

^ permalink raw reply

* Re: [Patch] NFC: trf7970a:
From: Mark Greer @ 2017-02-08 22:56 UTC (permalink / raw)
  To: Geoff Lansberry
  Cc: linux-wireless, Lauro Ramos Venancio, Aloisio Almeida Jr,
	Samuel Ortiz, Justin Bronder, linux-nfc
In-Reply-To: <20170208225339.GA26286@animalcreek.com>

I just realized that the linux-nfc is not CC'd so adding it.

On Wed, Feb 08, 2017 at 03:53:39PM -0700, Mark Greer wrote:
> On Sun, Dec 18, 2016 at 08:07:33PM -0700, Mark Greer wrote:
> > On Sat, Dec 17, 2016 at 04:19:04PM -0500, Geoff Lansberry wrote:
> > > Mark,   from our consultant:
> > > 
> > > It isn't important whether the flood script is successful in writing
> > > or not. The point of it is to force a segfault by making many
> > > requests. It needs to run for several hundred iterations (successful
> > > or not) in order to generate the segfault.
> > 
> > So neard crashes even when the write fails??  Okay, I'll let it run for
> > a while tomorrow (Monday).
> 
> [Okay, so not exactly "tomorrow" but I did get back to this.]
> 
> Geoff, a few things:
> 
> 1) Any update on these issues?
> 
> 2) Do you have all of the NFC-related patches from the nfc-next master
> branch?  In particular, do you have all of Thierry's patches to
> net/nfc/digial_*.c dated around June-July 2016?  Without those patches,
> I see a panic; with them, I don't.
> 
> 3) Assuming you have all of those patches, please revert the one with the
> summary line of, "NFC: digital: Set the command pending flag", and tell me
> if that stops the "Bogus state" messages.  I don't know which repo/branch
> you're using so I can't provide a commit id.
> 
> Thanks,
> 
> Mark
> --

^ permalink raw reply

* Re: [Patch] NFC: trf7970a:
From: Mark Greer @ 2017-02-08 22:53 UTC (permalink / raw)
  To: Geoff Lansberry
  Cc: linux-wireless, Lauro Ramos Venancio, Aloisio Almeida Jr,
	Samuel Ortiz, Justin Bronder
In-Reply-To: <20161219030733.GA14962@animalcreek.com>

On Sun, Dec 18, 2016 at 08:07:33PM -0700, Mark Greer wrote:
> On Sat, Dec 17, 2016 at 04:19:04PM -0500, Geoff Lansberry wrote:
> > Mark,   from our consultant:
> > 
> > It isn't important whether the flood script is successful in writing
> > or not. The point of it is to force a segfault by making many
> > requests. It needs to run for several hundred iterations (successful
> > or not) in order to generate the segfault.
> 
> So neard crashes even when the write fails??  Okay, I'll let it run for
> a while tomorrow (Monday).

[Okay, so not exactly "tomorrow" but I did get back to this.]

Geoff, a few things:

1) Any update on these issues?

2) Do you have all of the NFC-related patches from the nfc-next master
branch?  In particular, do you have all of Thierry's patches to
net/nfc/digial_*.c dated around June-July 2016?  Without those patches,
I see a panic; with them, I don't.

3) Assuming you have all of those patches, please revert the one with the
summary line of, "NFC: digital: Set the command pending flag", and tell me
if that stops the "Bogus state" messages.  I don't know which repo/branch
you're using so I can't provide a commit id.

Thanks,

Mark
--

^ permalink raw reply

* Re: pull-request: iwlwifi firmwares update 2017-02-03
From: Luca Coelho @ 2017-02-09  6:05 UTC (permalink / raw)
  To: Kyle McMartin
  Cc: linux-wireless, linuxwifi, linux-firmware, Grumbach, Emmanuel,
	Coelho, Luciano
In-Reply-To: <1486111291.26003.86.camel@coelho.fi>

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi Kyle,

On Fri, 2017-02-03 at 10:41 +0200, Luca Coelho wrote:
> Hi Kyle,
> 
> We have updated some of our old firmware releases and also added a new
> release, version 27, for the newer devices.  More details in the tag
> description.
> 
> Please pull or let me know if there are any issues.

Are there any issues with this?

I forgot to say that I'm going to be sending the iwlwifi firmwares out
now (as I have been maintaining the iwlwifi driver upstream).  Emmanuel
can confirm that. :)

--
Cheers,
Luca.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply

* [PATCH] ath6kl: Use net_device_stats from struct net_device
From: Tobias Klauser @ 2017-02-09 11:21 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, netdev

Instead of using a private copy of struct net_device_stats in struct
ath6kl_vif, use stats from struct net_device. Also remove the now
unnecessary .ndo_get_stats function.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/wireless/ath/ath6kl/core.h |  1 -
 drivers/net/wireless/ath/ath6kl/main.c |  8 --------
 drivers/net/wireless/ath/ath6kl/txrx.c | 22 +++++++++++-----------
 3 files changed, 11 insertions(+), 20 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/core.h b/drivers/net/wireless/ath/ath6kl/core.h
index ac25f1781b42..87e99c12d4ba 100644
--- a/drivers/net/wireless/ath/ath6kl/core.h
+++ b/drivers/net/wireless/ath/ath6kl/core.h
@@ -641,7 +641,6 @@ struct ath6kl_vif {
 	u32 txe_intvl;
 	u16 bg_scan_period;
 	u8 assoc_bss_dtim_period;
-	struct net_device_stats net_stats;
 	struct target_stats target_stats;
 	struct wmi_connect_cmd profile;
 	u16 rsn_capab;
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index 1af3fed5a72c..91ee542de3d7 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -1113,13 +1113,6 @@ static int ath6kl_close(struct net_device *dev)
 	return 0;
 }
 
-static struct net_device_stats *ath6kl_get_stats(struct net_device *dev)
-{
-	struct ath6kl_vif *vif = netdev_priv(dev);
-
-	return &vif->net_stats;
-}
-
 static int ath6kl_set_features(struct net_device *dev,
 			       netdev_features_t features)
 {
@@ -1285,7 +1278,6 @@ static const struct net_device_ops ath6kl_netdev_ops = {
 	.ndo_open               = ath6kl_open,
 	.ndo_stop               = ath6kl_close,
 	.ndo_start_xmit         = ath6kl_data_tx,
-	.ndo_get_stats          = ath6kl_get_stats,
 	.ndo_set_features       = ath6kl_set_features,
 	.ndo_set_rx_mode	= ath6kl_set_multicast_list,
 };
diff --git a/drivers/net/wireless/ath/ath6kl/txrx.c b/drivers/net/wireless/ath/ath6kl/txrx.c
index 9df41d5e3249..a531e0c5c1e2 100644
--- a/drivers/net/wireless/ath/ath6kl/txrx.c
+++ b/drivers/net/wireless/ath/ath6kl/txrx.c
@@ -405,7 +405,7 @@ int ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev)
 			skb = skb_realloc_headroom(skb, dev->needed_headroom);
 			kfree_skb(tmp_skb);
 			if (skb == NULL) {
-				vif->net_stats.tx_dropped++;
+				dev->stats.tx_dropped++;
 				return 0;
 			}
 		}
@@ -520,8 +520,8 @@ int ath6kl_data_tx(struct sk_buff *skb, struct net_device *dev)
 fail_tx:
 	dev_kfree_skb(skb);
 
-	vif->net_stats.tx_dropped++;
-	vif->net_stats.tx_aborted_errors++;
+	dev->stats.tx_dropped++;
+	dev->stats.tx_aborted_errors++;
 
 	return 0;
 }
@@ -767,7 +767,7 @@ void ath6kl_tx_complete(struct htc_target *target,
 				/* a packet was flushed  */
 				flushing[if_idx] = true;
 
-			vif->net_stats.tx_errors++;
+			vif->ndev->stats.tx_errors++;
 
 			if (status != -ENOSPC && status != -ECANCELED)
 				ath6kl_warn("tx complete error: %d\n", status);
@@ -783,8 +783,8 @@ void ath6kl_tx_complete(struct htc_target *target,
 				   eid, "OK");
 
 			flushing[if_idx] = false;
-			vif->net_stats.tx_packets++;
-			vif->net_stats.tx_bytes += skb->len;
+			vif->ndev->stats.tx_packets++;
+			vif->ndev->stats.tx_bytes += skb->len;
 		}
 
 		ath6kl_tx_clear_node_map(vif, eid, map_no);
@@ -1365,8 +1365,8 @@ void ath6kl_rx(struct htc_target *target, struct htc_packet *packet)
 	 */
 	spin_lock_bh(&vif->if_lock);
 
-	vif->net_stats.rx_packets++;
-	vif->net_stats.rx_bytes += packet->act_len;
+	vif->ndev->stats.rx_packets++;
+	vif->ndev->stats.rx_bytes += packet->act_len;
 
 	spin_unlock_bh(&vif->if_lock);
 
@@ -1395,8 +1395,8 @@ void ath6kl_rx(struct htc_target *target, struct htc_packet *packet)
 	    ((packet->act_len < min_hdr_len) ||
 	     (packet->act_len > WMI_MAX_AMSDU_RX_DATA_FRAME_LENGTH))) {
 		ath6kl_info("frame len is too short or too long\n");
-		vif->net_stats.rx_errors++;
-		vif->net_stats.rx_length_errors++;
+		vif->ndev->stats.rx_errors++;
+		vif->ndev->stats.rx_length_errors++;
 		dev_kfree_skb(skb);
 		return;
 	}
@@ -1619,7 +1619,7 @@ void ath6kl_rx(struct htc_target *target, struct htc_packet *packet)
 			return;
 		}
 	} else if (!is_broadcast_ether_addr(datap->h_dest)) {
-		vif->net_stats.multicast++;
+		vif->ndev->stats.multicast++;
 	}
 
 	ath6kl_deliver_frames_to_nw_stack(vif->ndev, skb);
-- 
2.11.0

^ permalink raw reply related

* [PATCH] staging: wilc1000: remove unnecessary local array
From: Franck Demathieu @ 2017-02-09 13:48 UTC (permalink / raw)
  To: linux-wireless, devel

It fixes the following warning reported by sparse:

  drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long initializer-string for array of char(no space for nul char)

Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
---
 drivers/staging/wilc1000/linux_wlan.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..fc61f4e 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -64,7 +64,6 @@ static int dev_state_ev_handler(struct notifier_block *this,
 	u8 *ip_addr_buf;
 	struct wilc_vif *vif;
 	u8 null_ip[4] = {0};
-	char wlan_dev_name[5] = "wlan0";
 
 	if (!dev_iface || !dev_iface->ifa_dev || !dev_iface->ifa_dev->dev)
 		return NOTIFY_DONE;
@@ -113,7 +112,7 @@ static int dev_state_ev_handler(struct notifier_block *this,
 			wilc_optaining_ip = false;
 		}
 
-		if (memcmp(dev_iface->ifa_label, wlan_dev_name, 5) == 0)
+		if (memcmp(dev_iface->ifa_label, "wlan0", 5) == 0)
 			wilc_set_power_mgmt(vif, 0, 0);
 
 		wilc_resolve_disconnect_aberration(vif);
-- 
2.10.1

^ permalink raw reply related

* pull-request: wireless-drivers-next 2017-02-09
From: Kalle Valo @ 2017-02-09 14:08 UTC (permalink / raw)
  To: David Miller; +Cc: linux-wireless, netdev, linux-kernel

Hi Dave,

another pull request for net-next. If the merge window starts on Sunday
this would be the last pull request from me with new features. But if it
doesn't open, I'm planning to send one more next week.

Please let me know if there any problems.

Kalle


The following changes since commit 62e13097c46c69dbd7544ab2cd585ccf48f360a4:

  net: phy: broadcom: rehook BCM54612E specific init (2017-02-01 14:20:20 -=
0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next=
.git tags/wireless-drivers-next-for-davem-2017-02-09

for you to fetch changes up to cbda794cf1bb2f4a2e75e11fda1f89457169772e:

  Merge tag 'iwlwifi-next-for-kalle-2017-02-08' of git://git.kernel.org/pub=
/scm/linux/kernel/git/iwlwifi/iwlwifi-next (2017-02-08 21:28:36 +0200)

----------------------------------------------------------------
wireless-drivers-next patches for 4.11

Mostly smaller changeds and fixes all over, nothing really major
standing out.

Major changes:

iwlwifi

* work on support for new A000 devices continues
* fix 802.11w, which was failing to due an IGTK bug

ath10k

* add debugfs file peer_debug_trigger for debugging firmware

----------------------------------------------------------------
Ashok Raj Nagarajan (1):
      ath10k: fix reading sram contents for QCA4019

Avraham Stern (1):
      iwlwifi: mvm: Fix CSA received immediately after association

Beni Lev (1):
      iwlwifi: mvm: Use aux queue for offchannel frames in dqa

Bjorn Andersson (1):
      wcn36xx: Implement cancel_hw_scan

Emmanuel Grumbach (6):
      iwlwifi: mvm: fix PS-Poll enablement
      iwlwifi: mvm: use the PROBE_RESP_QUEUE to send deauth to unknown stat=
ion
      iwlwifi: pcie: don't increment / decrement a bool
      iwlwifi: make RTPM depend on EXPERT
      iwlwifi: dvm: don't call << operator with a negative value
      iwlwifi: mvm: don't call << operator with a negative value

Felix Fietkau (3):
      ath9k: rename tx_complete_work to hw_check_work
      ath9k_hw: check if the chip failed to wake up
      ath9k: fix race condition in enabling/disabling IRQs

Ganapathi Bhat (1):
      mwifiex: Avoid skipping WEP key deletion for AP

Golan Ben Ami (2):
      iwlwifi: pcie: Re-configure IVAR table after stop device
      iwlwifi: pcie: set STATUS_RFKILL immediately after interrupt

Golan Ben-Ami (2):
      iwlwifi: mvm: support v2 of mfuart load notification
      iwlwifi: mvm: avoid exceeding the allowed print length

Goodstein, Mordechay (1):
      iwlwifi: mvm: avoid race condition in ADD_STA.

Gregory Greenman (1):
      iwlwifi: mvm: fix a print of NSS for HT rate

Haim Dreyfuss (3):
      iwlwifi: pcie: move msix conf functions above other functions
      iwlwifi: pcie: separate between SW and HW MSIX configuration
      iwlwifi: pcie: re-configure IVAR table after suspend-resume

Ilan Peer (1):
      iwlwifi: mvm: Fix removal of IGTK

Johannes Berg (10):
      iwlwifi: mvm: reduce usage of IEEE80211_SKB_CB()
      iwlwifi: mvm: fix D3 replay counter value
      iwlwifi: mvm: set AID to firmware only for associated stations
      iwlwifi: mvm: overwrite skb info later
      iwlwifi: mvm/pcie: adjust A-MSDU tx_cmd length in PCIe
      iwlwifi: mvm: align copy-break SKB payload for MQ RX
      iwlwifi: pcie: fix another RF-kill race
      mwifiex: don't include mac80211.h
      wil6210: include moduleparam.h
      ath10k: select WANT_DEV_COREDUMP

Kalle Valo (6):
      Merge tag 'iwlwifi-next-for-kalle-2017-02-06' of git://git.kernel.org=
/.../iwlwifi/iwlwifi-next
      ath10k: prefer unsigned int over just unsigned
      ath10k: use names in function definition arguments
      ath10k: few whitespace fixes
      Merge ath-next from git://git.kernel.org/.../kvalo/ath.git
      Merge tag 'iwlwifi-next-for-kalle-2017-02-08' of git://git.kernel.org=
/.../iwlwifi/iwlwifi-next

Larry Finger (10):
      rtlwifi: btcoexist: Change logging in halbtc8192e2ant.c
      rtlwifi: rtl8821ae: Fix typo in symbol for bandwidth numbers
      rtlwifi: btcoexist: Convert halbtc8192e2ant.c to use standard debuggi=
ng
      rtlwifi: btcoexist: Convert halbtc8723b1ant.c to use standard debuggi=
ng
      rtlwifi: btcoexist: Convert halbtc8723b2ant.c to use standard debuggi=
ng
      rtlwifi: btcoexist: Convert halbtc8821a1ant.c to use standard debuggi=
ng
      rtlwifi: btcoexist: Convert halbtc8821a2ant.c to use standard debuggi=
ng
      rtlwifi: btcoexist: Convert halbtcoutsrc.c to use standard debugging
      rtlwifi: rtl8192c-common: Fix "BUG: KASAN:
      rtlwifi: Move items out of rtl_pci_priv and rtl_usb_priv

Liad Kaufman (1):
      iwlwifi: mvm: release static queues on bcast release

Luca Coelho (2):
      iwlwifi: remove unnecessary argument to iwl_drv_start()
      iwlwifi: remove unnecessary cfg element in iwl_drv

Maharaja Kennadyrajan (1):
      ath10k: add debugfs support to get per peer tids log via tracing

Ping-Ke Shih (10):
      rtlwifi: Fix programing CAM content sequence.
      rtlwifi: Set retry limit depends on vif type.
      rtlwifi: Add a new enumeration value to btc_set_type
      rtlwifi: btcoexist: Add vendor definition for new btcoexist
      rtlwifi: rtl8723be: btcoexist: Add single_ant_path
      rtlwifi: move btcoex's ant_num declaration
      rtlwifi: rtl8723be: btcoex: add package_type function to btcoex
      rtlwifi: btcoex: move bt_type declaration
      rtlwifi: rtl8723be: fix ant_sel code
      rtlwifi: Add work queue for c2h cmd.

Rafa=C5=82 Mi=C5=82ecki (6):
      brcmfmac: check brcmf_bus_get_memdump result for error
      brcmfmac: be more verbose when PSM's watchdog fires
      brcmfmac: use wiphy_read_of_freq_limits to respect limits from DT
      brcmfmac: merge two brcmf_err macros into one
      brcmfmac: switch to C function (__brcmf_err) for printing errors
      brcmfmac: merge two remaining brcmf_err macros

Sara Sharon (14):
      iwlwifi: mvm: support unification of INIT and RT images
      iwlwifi: mvm: cleanup incorrect and redundant define
      iwlwifi: mvm: support new statistics APIs
      iwlwifi: mvm: support new scan API
      iwlwifi: mvm: always free inactive queue when moving ownership
      iwlwifi: mvm: support new alive notification
      iwlwifi: mvm: synchronize firmware DMA paging memory
      iwlwifi: pcie: fix the set of DMA memory mask
      iwlwifi: mvm: fix pending frame counter calculation
      iwlwifi: mvm: cleanup iwl_mvm_tx_mpdu a bit
      iwlwifi: support two phys for a000 devices
      iwlwifi: mvm: support new beacon template command
      iwlwifi: mvm: fix references to first_agg_queue in DQA mode
      iwlwifi: mvm: fix reorder timer re-arming

Stanislaw Gruszka (6):
      rt2x00: avoid introducing a USB dependency in the rt2x00lib module
      rt2x00usb: do not anchor rx and tx urb's
      rt2x00usb: fix anchor initialization
      rt61pci: use entry directly
      rt2x00: call entry directly in rt2x00_dump_frame
      rt2x00: remove queue_entry from skbdesc

Tamizh chelvam (1):
      ath10k: fix boot failure in UTF mode/testmode

Waldemar Rymarkiewicz (1):
      ath10k: remove unneeded semicolon

 drivers/net/wireless/ath/ath10k/Kconfig            |    1 +
 drivers/net/wireless/ath/ath10k/ahb.c              |   23 +
 drivers/net/wireless/ath/ath10k/ce.c               |    6 +-
 drivers/net/wireless/ath/ath10k/core.c             |   14 +-
 drivers/net/wireless/ath/ath10k/debugfs_sta.c      |   65 ++
 drivers/net/wireless/ath/ath10k/htt.h              |    6 +-
 drivers/net/wireless/ath/ath10k/htt_rx.c           |    2 +-
 drivers/net/wireless/ath/ath10k/pci.c              |   53 +-
 drivers/net/wireless/ath/ath10k/pci.h              |    5 +
 drivers/net/wireless/ath/ath10k/wmi.h              |    3 +-
 drivers/net/wireless/ath/ath9k/ath9k.h             |    7 +-
 drivers/net/wireless/ath/ath9k/hw.c                |    4 +
 drivers/net/wireless/ath/ath9k/init.c              |    2 +
 drivers/net/wireless/ath/ath9k/link.c              |   46 +-
 drivers/net/wireless/ath/ath9k/mac.c               |   44 +-
 drivers/net/wireless/ath/ath9k/mac.h               |    1 +
 drivers/net/wireless/ath/ath9k/main.c              |   37 +-
 drivers/net/wireless/ath/ath9k/xmit.c              |    2 -
 drivers/net/wireless/ath/wcn36xx/main.c            |   25 +-
 drivers/net/wireless/ath/wcn36xx/wcn36xx.h         |    1 +
 drivers/net/wireless/ath/wil6210/cfg80211.c        |    1 +
 .../broadcom/brcm80211/brcmfmac/cfg80211.c         |    6 +
 .../wireless/broadcom/brcm80211/brcmfmac/common.c  |   16 +
 .../wireless/broadcom/brcm80211/brcmfmac/debug.c   |   35 +-
 .../wireless/broadcom/brcm80211/brcmfmac/debug.h   |   24 +-
 drivers/net/wireless/intel/iwlwifi/Kconfig         |    7 +-
 drivers/net/wireless/intel/iwlwifi/dvm/rs.c        |    5 +-
 drivers/net/wireless/intel/iwlwifi/iwl-a000.c      |   30 +-
 drivers/net/wireless/intel/iwlwifi/iwl-config.h    |    3 +-
 drivers/net/wireless/intel/iwlwifi/iwl-csr.h       |    1 +
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c       |   25 +-
 drivers/net/wireless/intel/iwlwifi/iwl-drv.h       |    4 +-
 drivers/net/wireless/intel/iwlwifi/mvm/d3.c        |    4 +-
 .../net/wireless/intel/iwlwifi/mvm/fw-api-mac.h    |    7 +-
 .../net/wireless/intel/iwlwifi/mvm/fw-api-scan.h   |  106 +-
 .../net/wireless/intel/iwlwifi/mvm/fw-api-stats.h  |   29 +-
 drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h |   29 +-
 drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h    |   90 +-
 drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c    |    4 +
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c        |  338 +++---
 drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c  |  105 +-
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c  |   39 +-
 drivers/net/wireless/intel/iwlwifi/mvm/mvm.h       |   18 +-
 drivers/net/wireless/intel/iwlwifi/mvm/ops.c       |   24 +-
 drivers/net/wireless/intel/iwlwifi/mvm/power.c     |   44 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rs.c        |    6 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rx.c        |   70 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c      |   14 +-
 drivers/net/wireless/intel/iwlwifi/mvm/scan.c      |  230 +++--
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c       |  234 +++--
 drivers/net/wireless/intel/iwlwifi/mvm/sta.h       |    1 +
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c        |  129 +--
 drivers/net/wireless/intel/iwlwifi/mvm/utils.c     |   16 +-
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c      |   17 +-
 drivers/net/wireless/intel/iwlwifi/pcie/internal.h |    4 +-
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c       |   12 +-
 drivers/net/wireless/intel/iwlwifi/pcie/trans.c    |  251 +++--
 drivers/net/wireless/intel/iwlwifi/pcie/tx.c       |   23 +-
 drivers/net/wireless/marvell/mwifiex/decl.h        |    2 +-
 drivers/net/wireless/marvell/mwifiex/sta_ioctl.c   |    2 -
 drivers/net/wireless/ralink/rt2x00/rt2400pci.c     |    2 +-
 drivers/net/wireless/ralink/rt2x00/rt2500pci.c     |    2 +-
 drivers/net/wireless/ralink/rt2x00/rt2500usb.c     |    2 +-
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c     |    2 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00.h        |    4 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00debug.c   |    7 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00dev.c     |   27 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00queue.c   |    5 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00queue.h   |    2 -
 drivers/net/wireless/ralink/rt2x00/rt2x00usb.c     |   22 +-
 drivers/net/wireless/ralink/rt2x00/rt61pci.c       |    5 +-
 drivers/net/wireless/ralink/rt2x00/rt73usb.c       |    2 +-
 drivers/net/wireless/realtek/rtlwifi/base.c        |   93 ++
 drivers/net/wireless/realtek/rtlwifi/base.h        |    3 +
 .../wireless/realtek/rtlwifi/btcoexist/Makefile    |    6 +-
 .../realtek/rtlwifi/btcoexist/halbtc8192e2ant.c    | 1082 ++++++++++------=
----
 .../realtek/rtlwifi/btcoexist/halbtc8723b1ant.c    |  827 ++++++++-------
 .../realtek/rtlwifi/btcoexist/halbtc8723b2ant.c    |  993 +++++++++-------=
--
 .../realtek/rtlwifi/btcoexist/halbtc8821a1ant.c    |  898 ++++++++--------
 .../realtek/rtlwifi/btcoexist/halbtc8821a2ant.c    | 1075 ++++++++++------=
---
 .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c       |   36 +-
 .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h       |   20 +-
 .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.c   |   16 -
 .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.h   |    5 +-
 drivers/net/wireless/realtek/rtlwifi/cam.c         |    6 +-
 drivers/net/wireless/realtek/rtlwifi/core.c        |   21 +-
 drivers/net/wireless/realtek/rtlwifi/efuse.c       |    5 +-
 drivers/net/wireless/realtek/rtlwifi/efuse.h       |    1 +
 drivers/net/wireless/realtek/rtlwifi/pci.c         |    7 +
 drivers/net/wireless/realtek/rtlwifi/pci.h         |    4 +-
 drivers/net/wireless/realtek/rtlwifi/ps.c          |    3 +
 .../net/wireless/realtek/rtlwifi/rtl8188ee/hw.c    |   14 +-
 .../net/wireless/realtek/rtlwifi/rtl8188ee/led.c   |   19 +-
 .../wireless/realtek/rtlwifi/rtl8192c/dm_common.c  |  143 ++-
 .../net/wireless/realtek/rtlwifi/rtl8192ce/hw.c    |  166 ++-
 .../net/wireless/realtek/rtlwifi/rtl8192ce/led.c   |   19 +-
 .../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c    |    3 +-
 .../net/wireless/realtek/rtlwifi/rtl8192cu/led.c   |   17 +-
 .../net/wireless/realtek/rtlwifi/rtl8192de/hw.c    |   10 +-
 .../net/wireless/realtek/rtlwifi/rtl8192de/led.c   |   19 +-
 .../net/wireless/realtek/rtlwifi/rtl8192ee/fw.c    |   15 +-
 .../net/wireless/realtek/rtlwifi/rtl8192ee/fw.h    |    3 +-
 .../net/wireless/realtek/rtlwifi/rtl8192ee/hw.c    |    6 +-
 .../net/wireless/realtek/rtlwifi/rtl8192ee/led.c   |   14 +-
 .../net/wireless/realtek/rtlwifi/rtl8192ee/sw.c    |    1 +
 .../net/wireless/realtek/rtlwifi/rtl8192se/hw.c    |   12 +-
 .../net/wireless/realtek/rtlwifi/rtl8192se/led.c   |   19 +-
 .../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c    |    8 +-
 .../net/wireless/realtek/rtlwifi/rtl8723ae/led.c   |   19 +-
 .../net/wireless/realtek/rtlwifi/rtl8723be/fw.c    |   18 +-
 .../net/wireless/realtek/rtlwifi/rtl8723be/fw.h    |    3 +-
 .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c    |   50 +-
 .../net/wireless/realtek/rtlwifi/rtl8723be/led.c   |   15 +-
 .../net/wireless/realtek/rtlwifi/rtl8723be/sw.c    |    1 +
 .../net/wireless/realtek/rtlwifi/rtl8821ae/fw.c    |   18 +-
 .../net/wireless/realtek/rtlwifi/rtl8821ae/fw.h    |    3 +
 .../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c    |   10 +-
 .../net/wireless/realtek/rtlwifi/rtl8821ae/led.c   |   24 +-
 .../net/wireless/realtek/rtlwifi/rtl8821ae/phy.c   |   10 +-
 .../net/wireless/realtek/rtlwifi/rtl8821ae/sw.c    |    1 +
 drivers/net/wireless/realtek/rtlwifi/usb.h         |    2 +-
 drivers/net/wireless/realtek/rtlwifi/wifi.h        |   33 +-
 122 files changed, 4689 insertions(+), 3541 deletions(-)

^ permalink raw reply


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox