* Re: [PATCH 01/18] iwlwifi: mvm: ftm: make common calib signed
From: Kalle Valo @ 2019-09-03 11:23 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless
In-Reply-To: <20190821133800.23636-2-luca@coelho.fi>
Luca Coelho <luca@coelho.fi> writes:
> From: Alex Malamud <alex.malamud@intel.com>
>
> The common calib value should be signed, so use int instead of u16.
>
> Signed-off-by: Avraham Stern <avraham.stern@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
[...]
> @@ -1993,6 +2027,9 @@ void iwl_mvm_dbgfs_register(struct iwl_mvm *mvm, struct dentry *dbgfs_dir)
> #endif
> MVM_DEBUGFS_ADD_FILE(he_sniffer_params, mvm->debugfs_dir, 0600);
>
> + if (fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_SET_LTR_GEN2))
> + MVM_DEBUGFS_ADD_FILE(ltr_config, mvm->debugfs_dir, 0200);
The commit log does not seem to match the code?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 05/18] iwlwifi: Set w-pointer upon resume according to SN
From: Kalle Valo @ 2019-09-03 11:26 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless
In-Reply-To: <20190821133800.23636-6-luca@coelho.fi>
Luca Coelho <luca@coelho.fi> writes:
> From: Alex Malamud <alex.malamud@intel.com>
>
> During D3 state, FW may send packets.
> As a result, "write" queue pointer will be incremented by FW.
> Upon resume from D3, driver should adjust its shadows of "write" and "read"
> pointers to the value reported by FW.
>
> 1. Keep TID used during wowlan configuration.
> 2. Upon resume, set driver's "write" and "read" queue pointers
> to the value reported by FW.
>
> Signed-off-by: Alex Malamud <alex.malamud@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
A typo in the title, s/w-pointer/q-pointer/ maybe?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* [PATCH] cfg80211: fix boundary value in ieee80211_frequency_to_channel()
From: Arend van Spriel @ 2019-09-03 11:39 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Arend van Spriel
The boundary value used for the 6G band was incorrect as it would
result in invalid 6G channel number for certain frequencies.
Reported-by: Amar Singhal <asinghal@codeaurora.org>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
net/wireless/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index c999390..006f3ea 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -116,7 +116,7 @@ int ieee80211_frequency_to_channel(int freq)
return (freq - 2407) / 5;
else if (freq >= 4910 && freq <= 4980)
return (freq - 4000) / 5;
- else if (freq < 5940)
+ else if (freq < 5945)
return (freq - 5000) / 5;
else if (freq <= 45000) /* DMG band lower limit */
/* see 802.11ax D4.1 27.3.22.2 */
--
1.9.1
^ permalink raw reply related
* RE: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement
From: Tony Chuang @ 2019-09-03 11:55 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless@vger.kernel.org, jano.vesely@gmail.com,
linux@endlessm.com, briannorris@chromium.org, gojun077@gmail.com,
drake@endlessm.com, davem@davemloft.net, jian-hong@endlessm.com
In-Reply-To: <871rwxr5xp.fsf@kamboji.qca.qualcomm.com>
> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>
> <yhchuang@realtek.com> writes:
>
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > This patch set includes two patches to improve PCI interrupt routine.
> > One is to reduce HW IRQ time, the other is to enable MSI.
> >
> > The patches can be found at:
> > https://patchwork.kernel.org/patch/11114043/
> > https://patchwork.kernel.org/patch/11126007/
> >
> > They were rebased properly to resolve conflicts.
>
> In the future, please use version markings ("v2", "v3" etc) in the
> Subject and not something like "rebased". This makes my life easier as I
> can immeaditely see what is the latest version I should take.
>
Oh, I just combine two patches with different version markings.
And I don't know how to write a proper subject in this case, maybe
I shouldn't use cover latter?
Yan-Hsuan
^ permalink raw reply
* KASAN: use-after-free Read in rsi_rx_done_handler
From: syzbot @ 2019-09-03 12:08 UTC (permalink / raw)
To: amitkarwar, andreyknvl, davem, kvalo, linux-kernel, linux-usb,
linux-wireless, netdev, siva8118, syzkaller-bugs
Hello,
syzbot found the following crash on:
HEAD commit: eea39f24 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=1031c5f2600000
kernel config: https://syzkaller.appspot.com/x/.config?x=d0c62209eedfd54e
dashboard link: https://syzkaller.appspot.com/bug?extid=b563b7f8dbe8223a51e8
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
Unfortunately, I don't have any reproducer for this crash yet.
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+b563b7f8dbe8223a51e8@syzkaller.appspotmail.com
==================================================================
BUG: KASAN: use-after-free in rsi_rx_done_handler+0x3ba/0x490
drivers/net/wireless/rsi/rsi_91x_usb.c:267
Read of size 8 at addr ffff8881cebc0fe8 by task kworker/0:2/102
CPU: 0 PID: 102 Comm: kworker/0:2 Not tainted 5.3.0-rc5+ #28
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0xca/0x13e lib/dump_stack.c:113
print_address_description+0x6a/0x32c mm/kasan/report.c:351
__kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482
kasan_report+0xe/0x12 mm/kasan/common.c:612
rsi_rx_done_handler+0x3ba/0x490 drivers/net/wireless/rsi/rsi_91x_usb.c:267
__usb_hcd_giveback_urb+0x1f2/0x470 drivers/usb/core/hcd.c:1657
usb_hcd_giveback_urb+0x368/0x420 drivers/usb/core/hcd.c:1722
dummy_timer+0x120f/0x2fa2 drivers/usb/gadget/udc/dummy_hcd.c:1965
call_timer_fn+0x179/0x650 kernel/time/timer.c:1322
expire_timers kernel/time/timer.c:1366 [inline]
__run_timers kernel/time/timer.c:1685 [inline]
__run_timers kernel/time/timer.c:1653 [inline]
run_timer_softirq+0x5cc/0x14b0 kernel/time/timer.c:1698
__do_softirq+0x221/0x912 kernel/softirq.c:292
invoke_softirq kernel/softirq.c:373 [inline]
irq_exit+0x178/0x1a0 kernel/softirq.c:413
exiting_irq arch/x86/include/asm/apic.h:537 [inline]
smp_apic_timer_interrupt+0x12f/0x500 arch/x86/kernel/apic/apic.c:1095
apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:830
</IRQ>
RIP: 0010:arch_local_irq_restore arch/x86/include/asm/irqflags.h:85 [inline]
RIP: 0010:console_unlock+0xa2a/0xc40 kernel/printk/printk.c:2471
Code: 00 89 ee 48 c7 c7 20 89 d3 86 e8 61 ad 03 00 65 ff 0d 72 b5 d9 7e e9
db f9 ff ff e8 80 a0 15 00 e8 2b ca 1a 00 ff 74 24 30 9d <e9> 18 fe ff ff
e8 6c a0 15 00 48 8d 7d 08 48 89 f8 48 c1 e8 03 42
RSP: 0018:ffff8881d5077200 EFLAGS: 00000216 ORIG_RAX: ffffffffffffff13
RAX: 0000000000000007 RBX: 0000000000000200 RCX: 0000000000000006
RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffff8881d5068844
RBP: 0000000000000000 R08: ffff8881d5068000 R09: fffffbfff11ad791
R10: fffffbfff11ad790 R11: ffffffff88d6bc87 R12: 000000000000004d
R13: dffffc0000000000 R14: ffffffff829090d0 R15: ffffffff87077430
vprintk_emit+0x171/0x3e0 kernel/printk/printk.c:1986
vprintk_func+0x75/0x113 kernel/printk/printk_safe.c:386
printk+0xba/0xed kernel/printk/printk.c:2046
really_probe.cold+0x69/0x1f6 drivers/base/dd.c:628
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
hub_port_connect drivers/usb/core/hub.c:5098 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
port_event drivers/usb/core/hub.c:5359 [inline]
hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
worker_thread+0x96/0xe20 kernel/workqueue.c:2415
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Allocated by task 102:
save_stack+0x1b/0x80 mm/kasan/common.c:69
set_track mm/kasan/common.c:77 [inline]
__kasan_kmalloc mm/kasan/common.c:487 [inline]
__kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460
kmalloc include/linux/slab.h:552 [inline]
kzalloc include/linux/slab.h:748 [inline]
rsi_init_usb_interface drivers/net/wireless/rsi/rsi_91x_usb.c:599 [inline]
rsi_probe+0x11a/0x15a0 drivers/net/wireless/rsi/rsi_91x_usb.c:780
usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
hub_port_connect drivers/usb/core/hub.c:5098 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
port_event drivers/usb/core/hub.c:5359 [inline]
hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
worker_thread+0x96/0xe20 kernel/workqueue.c:2415
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Freed by task 102:
save_stack+0x1b/0x80 mm/kasan/common.c:69
set_track mm/kasan/common.c:77 [inline]
__kasan_slab_free+0x130/0x180 mm/kasan/common.c:449
slab_free_hook mm/slub.c:1423 [inline]
slab_free_freelist_hook mm/slub.c:1474 [inline]
slab_free mm/slub.c:3016 [inline]
kfree+0xe4/0x2f0 mm/slub.c:3957
rsi_91x_deinit+0x270/0x2f0 drivers/net/wireless/rsi/rsi_91x_main.c:407
rsi_probe+0xcec/0x15a0 drivers/net/wireless/rsi/rsi_91x_usb.c:834
usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
device_add+0xae6/0x16f0 drivers/base/core.c:2165
usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
hub_port_connect drivers/usb/core/hub.c:5098 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
port_event drivers/usb/core/hub.c:5359 [inline]
hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
worker_thread+0x96/0xe20 kernel/workqueue.c:2415
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
The buggy address belongs to the object at ffff8881cebc0f00
which belongs to the cache kmalloc-512 of size 512
The buggy address is located 232 bytes inside of
512-byte region [ffff8881cebc0f00, ffff8881cebc1100)
The buggy address belongs to the page:
page:ffffea00073af000 refcount:1 mapcount:0 mapping:ffff8881da002500
index:0x0 compound_mapcount: 0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 0000000000000000 0000000b00000001 ffff8881da002500
raw: 0000000000000000 00000000800c000c 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff8881cebc0e80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff8881cebc0f00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> ffff8881cebc0f80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8881cebc1000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8881cebc1080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
^ permalink raw reply
* Re: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement
From: Kalle Valo @ 2019-09-03 12:17 UTC (permalink / raw)
To: Tony Chuang
Cc: linux-wireless@vger.kernel.org, jano.vesely@gmail.com,
linux@endlessm.com, briannorris@chromium.org, gojun077@gmail.com,
drake@endlessm.com, davem@davemloft.net, jian-hong@endlessm.com
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D18C5FE8@RTITMBSVM04.realtek.com.tw>
Tony Chuang <yhchuang@realtek.com> writes:
>> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>>
>> <yhchuang@realtek.com> writes:
>>
>> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> >
>> > This patch set includes two patches to improve PCI interrupt routine.
>> > One is to reduce HW IRQ time, the other is to enable MSI.
>> >
>> > The patches can be found at:
>> > https://patchwork.kernel.org/patch/11114043/
>> > https://patchwork.kernel.org/patch/11126007/
>> >
>> > They were rebased properly to resolve conflicts.
>>
>> In the future, please use version markings ("v2", "v3" etc) in the
>> Subject and not something like "rebased". This makes my life easier as I
>> can immeaditely see what is the latest version I should take.
>>
>
> Oh, I just combine two patches with different version markings.
> And I don't know how to write a proper subject in this case, maybe
> I shouldn't use cover latter?
The cover letter was helpful, please continue using that. IIRC the
separate patches were v3 and v4, so using v5 would have been clear for
me. But no need to resend because of this, just trying to streamline the
process and optimise my time :)
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* RE: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement
From: Tony Chuang @ 2019-09-03 12:21 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless@vger.kernel.org, jano.vesely@gmail.com,
linux@endlessm.com, briannorris@chromium.org, gojun077@gmail.com,
drake@endlessm.com, davem@davemloft.net, jian-hong@endlessm.com
In-Reply-To: <87o901po9h.fsf@kamboji.qca.qualcomm.com>
> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>
> Tony Chuang <yhchuang@realtek.com> writes:
>
> >> From: Kalle Valo [mailto:kvalo@codeaurora.org]
> >>
> >> <yhchuang@realtek.com> writes:
> >>
> >> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >> >
> >> > This patch set includes two patches to improve PCI interrupt routine.
> >> > One is to reduce HW IRQ time, the other is to enable MSI.
> >> >
> >> > The patches can be found at:
> >> > https://patchwork.kernel.org/patch/11114043/
> >> > https://patchwork.kernel.org/patch/11126007/
> >> >
> >> > They were rebased properly to resolve conflicts.
> >>
> >> In the future, please use version markings ("v2", "v3" etc) in the
> >> Subject and not something like "rebased". This makes my life easier as I
> >> can immeaditely see what is the latest version I should take.
> >>
> >
> > Oh, I just combine two patches with different version markings.
> > And I don't know how to write a proper subject in this case, maybe
> > I shouldn't use cover latter?
>
> The cover letter was helpful, please continue using that. IIRC the
> separate patches were v3 and v4, so using v5 would have been clear for
> me. But no need to resend because of this, just trying to streamline the
> process and optimise my time :)
>
Sure! Next time I know I should pick the largest number.
Thanks,
Yan-Hsuan
^ permalink raw reply
* Re: [PATCH 4/8] rtw88: 8822c: add FW IQK support
From: Kalle Valo @ 2019-09-03 12:53 UTC (permalink / raw)
To: yhchuang; +Cc: linux-wireless, briannorris, sgruszka
In-Reply-To: <1565174405-2689-5-git-send-email-yhchuang@realtek.com>
<yhchuang@realtek.com> wrote:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> Add support for doing IQK in firmware
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
The commit log does not answer "Why?". What is IQK and how does it help?
No need to resend, I can update the commit log but just let me know what to
add.
--
https://patchwork.kernel.org/patch/11081851/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH v2] rtlwifi: fix non-kerneldoc comment in usb.c
From: Kalle Valo @ 2019-09-03 13:06 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Ping-Ke Shih, David S. Miller, linux-wireless, netdev,
linux-kernel
In-Reply-To: <34195.1565229118@turing-police>
"Valdis wrote:
> Fix spurious warning message when building with W=1:
>
> CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
> drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand * on line 243 - I thought it was a doc line
> drivers/net/wireless/realtek/rtlwifi/usb.c:760: warning: Cannot understand * on line 760 - I thought it was a doc line
> drivers/net/wireless/realtek/rtlwifi/usb.c:790: warning: Cannot understand * on line 790 - I thought it was a doc line
>
> Clean up the comment format.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Patch applied to wireless-drivers-next.git, thanks.
b6326fc025aa rtlwifi: fix non-kerneldoc comment in usb.c
--
https://patchwork.kernel.org/patch/11083073/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
From: Kalle Valo @ 2019-09-03 13:28 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
In-Reply-To: <20190812192741.14479-1-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In the process of converting the bit manipulation macros were converted
> to use GENMASK(), the compiler reported a value too big for the field.
> The offending statement was trying to write 0x100 into a 5-bit field.
> An accompaning comment says to set bit 3, thus the code is changed
> appropriately.
>
> This error has been in the driver since its initial submission.
>
> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
01bb31de5262 rtlwifi: rtl8192cu: Fix value set in descriptor
--
https://patchwork.kernel.org/patch/11090677/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] rtlwifi: remove unused variables 'RTL8712_SDIO_EFUSE_TABLE' and 'MAX_PGPKT_SIZE'
From: Kalle Valo @ 2019-09-03 13:28 UTC (permalink / raw)
To: YueHaibing
Cc: pkshih, davem, linux-kernel, netdev, linux-wireless, YueHaibing
In-Reply-To: <20190816140513.72572-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> drivers/net/wireless/realtek/rtlwifi/efuse.c:16:31:
> warning: RTL8712_SDIO_EFUSE_TABLE defined but not used [-Wunused-const-variable=]
> drivers/net/wireless/realtek/rtlwifi/efuse.c:9:17:
> warning: MAX_PGPKT_SIZE defined but not used [-Wunused-const-variable=]
>
> They are never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
84d31d3b6234 rtlwifi: remove unused variables 'RTL8712_SDIO_EFUSE_TABLE' and 'MAX_PGPKT_SIZE'
--
https://patchwork.kernel.org/patch/11097803/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH v2] rtlwifi: rtl_pci: Fix memory leak when hardware init fails
From: Kalle Valo @ 2019-09-03 13:30 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
In-Reply-To: <20190826220344.7084-1-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> If the call to hw_init() fails for any of the drivers, the driver will
> leak memory that was allocated in BT coexistence setup. Technically, each
> of the drivers should have done this free; however placing it in rtl_pci
> fixes all the drivers with only a single patch.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
8cc782cd997d rtlwifi: rtl_pci: Fix memory leak when hardware init fails
--
https://patchwork.kernel.org/patch/11115745/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 1/5] rtlwifi: rtl8192ee: Remove unused GET_XXX and SET_XXX
From: Kalle Valo @ 2019-09-03 13:31 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
In-Reply-To: <20190831180644.7937-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> As the first step in converting from macros that get/set information
> in the RX and TX descriptors, unused macros are being removed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
5 patches applied to wireless-drivers-next.git, thanks.
8ef113ff0fed rtlwifi: rtl8192ee: Remove unused GET_XXX and SET_XXX
11f92ca1475c rtlwifi: rtl8192ee: Replace local bit manipulation macros
7f1c7460e932 rtlwifi: rtl8192ee: Convert macros that set descriptor
200e8bd4df8f rtlwifi: rtl8192ee: Convert inline routines to little-endian words
9dc35d8a555b rtlwifi: rtl8192ee: Remove some variable initializations
--
https://patchwork.kernel.org/patch/11124953/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 1/4] rtlwifi: rtl8192cu: Remove unused GET_XXX and SET_XXX
From: Kalle Valo @ 2019-09-03 13:34 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
In-Reply-To: <20190901154706.24193-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> As the first step in converting from macros that get/set information
> in the RX and TX descriptors, unused macros are being removed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
4 patches applied to wireless-drivers-next.git, thanks.
4170941ed19c rtlwifi: rtl8192cu: Remove unused GET_XXX and SET_XXX
081420490083 rtlwifi: rtl8192cu: Replace local bit manipulation macros
3925ae06ba60 rtlwifi: rtl8192cu: Convert macros that set descriptor
afd708f74f1e rtlwifi: rtl8192cu: Convert inline routines to little-endian words
--
https://patchwork.kernel.org/patch/11125339/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 1/3] rtlwifi: rtl8821ae: Fix incorrect returned values
From: Kalle Valo @ 2019-09-03 13:34 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
In-Reply-To: <20190903011813.13946-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In commit bd421dab7515 ("rtlwifi: rtl8821ae: Convert macros that set
> descriptor"), all the routines that get fields from a descriptor
> were changed to return signed integer values. This is incorrect for the
> routines that get the entire 32-bit word. In this case, an unsigned
> quantity is required.
>
> Fixes: bd421dab7515 ("rtlwifi: rtl8821ae: Convert macros that set descriptor")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
3 patches applied to wireless-drivers-next.git, thanks.
3bf404b470f9 rtlwifi: rtl8821ae: Fix incorrect returned values
38fcdcbd3def rtlwifi: rtl8188ee: Fix incorrect returned values
fe025ef7d066 rtlwifi: rtl8192ce: Fix incorrect returned values
--
https://patchwork.kernel.org/patch/11127097/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] rtw88: Fix an error message
From: Kalle Valo @ 2019-09-03 13:35 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Yan-Hsuan Chuang, linux-wireless, kernel-janitors
In-Reply-To: <20190814104642.GA14268@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The WARN_ON() macro takes a condition, not a warning message. I've
> changed this to use WARN() instead.
>
> Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
52929cad3293 rtw88: Fix an error message
--
https://patchwork.kernel.org/patch/11093733/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 5.4] rtw88: drop unused rtw_coex_coex_dm_reset()
From: Kalle Valo @ 2019-09-03 13:35 UTC (permalink / raw)
To: Brian Norris
Cc: linux-wireless, Yan-Hsuan Chuang, Guenter Roeck,
kbuild test robot, Brian Norris
In-Reply-To: <20190819181757.204572-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> From: Guenter Roeck <groeck@chromium.org>
>
> 0day reports:
>
> sparse warnings:
>
> drivers/net/wireless/realtek/rtw88/coex.c:2457:6: sparse:
> symbol 'rtw_coex_coex_dm_reset' was not declared. Should it be static?
>
> rtw_coex_coex_dm_reset() is not called. Remove it.
>
> Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
d74d0767b95e rtw88: drop unused rtw_coex_coex_dm_reset()
--
https://patchwork.kernel.org/patch/11101615/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] rtw88: remove redundant assignment to pointer debugfs_topdir
From: Kalle Valo @ 2019-09-03 13:36 UTC (permalink / raw)
To: Colin King
Cc: Yan-Hsuan Chuang, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
In-Reply-To: <20190822113728.25494-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer debugfs_topdir is initialized to a value that is never read
> and it is re-assigned later. The initialization is redundant and can
> be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
9f7d65fb3935 rtw88: remove redundant assignment to pointer debugfs_topdir
--
https://patchwork.kernel.org/patch/11109159/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH rebased 1/2] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ
From: Kalle Valo @ 2019-09-03 13:37 UTC (permalink / raw)
To: yhchuang
Cc: linux-wireless, jano.vesely, linux, briannorris, gojun077, drake,
davem, jian-hong
In-Reply-To: <1567502047-24102-2-git-send-email-yhchuang@realtek.com>
<yhchuang@realtek.com> wrote:
> From: Jian-Hong Pan <jian-hong@endlessm.com>
>
> There is a mass of jobs between spin lock and unlock in the hardware
> IRQ which will occupy much time originally. To make system work more
> efficiently, this patch moves the jobs to the soft IRQ (bottom half) to
> reduce the time in hardware IRQ.
>
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
2 patches applied to wireless-drivers-next.git, thanks.
b3d07736b30a rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ
79066903454b rtw88: pci: enable MSI interrupt
--
https://patchwork.kernel.org/patch/11127455/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] brcm80211: Avoid possible null-pointer dereferences in wlc_phy_radio_init_2056()
From: Kalle Valo @ 2019-09-03 13:37 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, davem, pieter-paul.giesberts, plaes, rvarsha016,
linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-kernel, Jia-Ju Bai
In-Reply-To: <20190729095652.1976-1-baijiaju1990@gmail.com>
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> In wlc_phy_radio_init_2056(), regs_SYN_2056_ptr, regs_TX_2056_ptr and
> regs_RX_2056_ptr may be not assigned, and thus they are still NULL.
> Then, they are used on lines 20042-20050:
> wlc_phy_init_radio_regs(pi, regs_SYN_2056_ptr, (u16) RADIO_2056_SYN);
> wlc_phy_init_radio_regs(pi, regs_TX_2056_ptr, (u16) RADIO_2056_TX0);
> wlc_phy_init_radio_regs(pi, regs_TX_2056_ptr, (u16) RADIO_2056_TX1);
> wlc_phy_init_radio_regs(pi, regs_RX_2056_ptr, (u16) RADIO_2056_RX0);
> wlc_phy_init_radio_regs(pi, regs_RX_2056_ptr, (u16) RADIO_2056_RX1);
>
> Thus, possible null-pointer dereferences may occur.
>
> To avoid these bugs, when these variables are not assigned,
> wlc_phy_radio_init_2056() directly returns.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
b80df89f3909 brcm80211: Avoid possible null-pointer dereferences in wlc_phy_radio_init_2056()
--
https://patchwork.kernel.org/patch/11063553/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] bcma: remove two unused variables
From: Kalle Valo @ 2019-09-03 13:38 UTC (permalink / raw)
To: YueHaibing; +Cc: zajec5, linux-kernel, linux-wireless, YueHaibing
In-Reply-To: <20190809085308.69748-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> drivers/bcma/driver_mips.c:70:18: warning:
> ipsflag_irq_shift defined but not used [-Wunused-const-variable=]
> drivers/bcma/driver_mips.c:62:18: warning:
> ipsflag_irq_mask defined but not used [-Wunused-const-variable=]
>
> They are never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
0a60e0aa495f bcma: remove two unused variables
--
https://patchwork.kernel.org/patch/11085683/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] brcmfmac: remove redundant assignment to pointer hash
From: Kalle Valo @ 2019-09-03 13:38 UTC (permalink / raw)
To: Colin King
Cc: Arend van Spriel, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
David S . Miller, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev, kernel-janitors, linux-kernel
In-Reply-To: <20190809172217.1809-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer hash is being initialized with a value that is never read
> and is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
73c742bb9c9b brcmfmac: remove redundant assignment to pointer hash
--
https://patchwork.kernel.org/patch/11087385/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCHv3] zd1211rw: remove false assertion from zd_mac_clear()
From: Kalle Valo @ 2019-09-03 13:39 UTC (permalink / raw)
To: Oliver Neukum; +Cc: davem, netdev, dsd, kune, linux-wireless, Oliver Neukum
In-Reply-To: <20190813120412.6240-1-oneukum@suse.com>
Oliver Neukum <oneukum@suse.com> wrote:
> The function is called before the lock which is asserted was ever used.
> Just remove it.
>
> Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Patch applied to wireless-drivers-next.git, thanks.
7a2eb7367fde zd1211rw: remove false assertion from zd_mac_clear()
--
https://patchwork.kernel.org/patch/11092009/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] airo: fix memory leaks
From: Kalle Valo @ 2019-09-03 13:39 UTC (permalink / raw)
To: Wenwen Wang
Cc: Wenwen Wang, David S. Miller, Herbert Xu, Dan Carpenter,
Eric Biggers, Ard Biesheuvel,
open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
In-Reply-To: <1565927404-4755-1-git-send-email-wenwen@cs.uga.edu>
Wenwen Wang <wenwen@cs.uga.edu> wrote:
> In proc_BSSList_open(), 'file->private_data' is allocated through kzalloc()
> and 'data->rbuffer' is allocated through kmalloc(). In the following
> execution, if an error occurs, they are not deallocated, leading to memory
> leaks. To fix this issue, free the allocated memory regions before
> returning the error.
>
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Patch applied to wireless-drivers-next.git, thanks.
145a32fe57e3 airo: fix memory leaks
--
https://patchwork.kernel.org/patch/11096733/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] ipw2x00: fix spelling mistake "initializationg" -> "initialization"
From: Kalle Valo @ 2019-09-03 13:40 UTC (permalink / raw)
To: Colin King
Cc: Stanislav Yakovlev, David S . Miller, linux-wireless, netdev,
kernel-janitors, linux-kernel
In-Reply-To: <20190822220025.5690-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in an IPW_DEBUG_INFO message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
14aba89386a4 ipw2x00: fix spelling mistake "initializationg" -> "initialization"
--
https://patchwork.kernel.org/patch/11110159/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox