Re: [PATCH 2/2] nl80211: Add option to adjust transmit power

["Artem Mygaiev" <joculator@gmail.com>]

Hello Juuso

A very minor comment - why do you need 'idx' here? Can't you just directly
access array by NL80211_* index without adding an index variable?

> +	if (info->attrs[NL80211_ATTR_WIPHY_TX_POWER_SETTING]) {
> +		enum nl80211_tx_power_setting type;
> +		int idx, mbm = 0;
> +
> +		if (!rdev->ops->set_tx_power) {
> +			return -EOPNOTSUPP;
> +			goto bad_res;
> +		}
> +
> +		idx = NL80211_ATTR_WIPHY_TX_POWER_SETTING;
> +		type = nla_get_u32(info->attrs[idx]);
> +
> +		if (!info->attrs[NL80211_ATTR_WIPHY_TX_POWER_LEVEL] &&
> +		    (type != NL80211_TX_POWER_AUTOMATIC)) {
> +			result = -EINVAL;
> +			goto bad_res;
> +		}
> +
> +		if (type != NL80211_TX_POWER_AUTOMATIC) {
> +			idx = NL80211_ATTR_WIPHY_TX_POWER_LEVEL;
> +			mbm = nla_get_u32(info->attrs[idx]);
> +		}
> +
> +		result = rdev->ops->set_tx_power(&rdev->wiphy, type, mbm);
> +		if (result)
> +			goto bad_res;
> +	}

-- 
Best regards,
Artem