From: "Wentao Guan" <guanwentao@uniontech.com>
To: "Ping-Ke Shih (pkshih@realtek.com" <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"dian_syuan0116 (dian_syuan0116@r" <dian_syuan0116@realtek.com>,
占俊 <zhanjun@uniontech.com>, 聂诚 <niecheng1@uniontech.com>
Subject: Re:RE: [PATCH] wifi: rtw89: fw: correct rtw89_fw_h2c_default_cmac_tbl_be()
Date: Thu, 11 Jun 2026 17:11:53 +0800 [thread overview]
Message-ID: <tencent_222927A16FE544771FBB4342@qq.com> (raw)
In-Reply-To: <1017648a65ec4b139b76e2eb7583da26@realtek.com>
> Ping-Ke Shih <pkshih@realtek.com> wrote:
> > Sent: Thursday, June 11, 2026 5:06 PM
> > To: Wentao Guan <guanwentao@uniontech.com>
> > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; David Yang(楊典軒)
> > <dian_syuan0116@realtek.com>; zhanjun@uniontech.com; niecheng1@uniontech.com
> > Subject: RE: [PATCH] wifi: rtw89: fw: correct rtw89_fw_h2c_default_cmac_tbl_be()
> >
> > Wentao Guan <guanwentao@uniontech.com> wrote:
> > > BE_CCTL_INFO_W2_PRELOAD_ENABLE is for h2c->w2, not h2c->w1.
> > > These will cause h2c->w1 wrong overlap by w2 and w2 not initialized.
> >
> > Thanks for the catch.
> >
> > >
> > > Fixes: c73607b3a8ef ("wifi: rtw89: fw: add CMAC H2C command to initialize default value for RTL8922D")
> > > Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
> >
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >
>
> To let subject clear, I'll change it to
> " wifi: rtw89: fw: correct preload field of w2 in rtw89_fw_h2c_default_cmac_tbl_be() "
OK, thanks for you review.
BRs
Wentao Guan
prev parent reply other threads:[~2026-06-11 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 8:20 [PATCH] wifi: rtw89: fw: correct rtw89_fw_h2c_default_cmac_tbl_be() Wentao Guan
2026-06-11 9:05 ` Ping-Ke Shih
2026-06-11 9:08 ` Ping-Ke Shih
2026-06-11 9:11 ` Wentao Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_222927A16FE544771FBB4342@qq.com \
--to=guanwentao@uniontech.com \
--cc=dian_syuan0116@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=pkshih@realtek.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox