From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36221 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930AbbGAUe2 (ORCPT ); Wed, 1 Jul 2015 16:34:28 -0400 From: Jes Sorensen To: Dan Carpenter Cc: Michel von Czettritz , gregkh@linux.com, devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 2/3] staging: rtl8723au: fix "incorrect type in assignment" References: <20150701075606.GU28762@mwanda> Date: Wed, 01 Jul 2015 16:34:27 -0400 In-Reply-To: <20150701075606.GU28762@mwanda> (Dan Carpenter's message of "Wed, 1 Jul 2015 10:56:06 +0300") Message-ID: (sfid-20150701_223431_149396_FBD0BC67) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter writes: > On Tue, Jun 30, 2015 at 11:54:02PM +0200, Michel von Czettritz wrote: >> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit >> cast and results in an sparse warning. >> >> Since param and mask won't be changed, the implicit cast can be avoided >> by creating local variables. >> >> Signed-off-by: Michel von Czettritz >> --- >> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> index 1003365..a5e6726 100644 >> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c >> @@ -115,9 +115,10 @@ exit: >> >> int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 *param) >> { >> - *((u32 *)param) = cpu_to_le32(*(param)); >> + __le32 param_le; >> + param_le = cpu_to_le32(*(param)); > > We shouldn't be passing param as a pointer anyway. It should just be > u32 cmd. > > __le32 cmd_le = cpu_to_le32(cmd); > > FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (u8 *)&cmd_le); > > Fold it together with patch 1. I agree, this would be cleaner. Jes