Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

[Jes Sorensen <Jes.Sorensen@redhat.com>]

Kalle Valo <kvalo@codeaurora.org> writes:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>
>>>> +static int rtl8xxxu_debug /* = 0 */; /* Avoid pointless checkpatch noise */
>>>
>>> Either assign it to zero or ignore the checkpatch warning, but please
>>> don't do this.
>>
>> Problem is if I leave the = 0 some people will send pointless patches to
>> change it. The above gets checkpatch to shut up while leaving the
>> indication in place.
>
> Yeah, I guessed that but this is just silly. If it annoys so much fix
> the checkpatch script or really assign it to zero, not this kind of
> comment trickery.

I'll remove it. The real problem here is that checkpatch has gotten to
the point where it is at times causing more harm than good. It is
unlikely to get fixed, get there is a small group who see it as their
mission to force their ways upon others, no matter whether it matters or
not.

Jes