From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC_ARG
Date: Tue, 24 Mar 2015 14:25:10 -0400 [thread overview]
Message-ID: <wrfj8ueml0c9.fsf@redhat.com> (raw)
In-Reply-To: <1427220609.5642.39.camel@perches.com> (Joe Perches's message of "Tue, 24 Mar 2015 11:10:09 -0700")
Joe Perches <joe@perches.com> writes:
> Use the standard vsprintf kernel extension to format
> mac addresses.
>
> This reduces object code size a bit.
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
> o Remove the now unused MAC_FMT and MAC_ARG #defines
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 41 ++++++-------
> drivers/staging/rtl8723au/core/rtw_mlme.c | 26 ++++----
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 72 +++++++++++------------
> drivers/staging/rtl8723au/core/rtw_recv.c | 42 +++++--------
> drivers/staging/rtl8723au/core/rtw_wlan_util.c | 6 +-
> drivers/staging/rtl8723au/core/rtw_xmit.c | 8 +--
> drivers/staging/rtl8723au/include/ieee80211.h | 3 -
> drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 18 +++---
> drivers/staging/rtl8723au/os_dep/os_intfs.c | 7 +--
> 9 files changed, 101 insertions(+), 122 deletions(-)
Looks good to me
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
next prev parent reply other threads:[~2015-03-24 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 18:10 [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC_ARG Joe Perches
2015-03-24 18:25 ` Jes Sorensen [this message]
2015-03-24 23:06 ` [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses Joe Perches
2015-03-25 0:28 ` Jes Sorensen
2015-03-25 0:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfj8ueml0c9.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).