From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52792 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbcLGFIE (ORCPT ); Wed, 7 Dec 2016 00:08:04 -0500 From: Jes Sorensen To: Larry Finger Cc: Bhumika Goyal , julia.lawall@lip6.fr, chaoming_li@realsil.com.cn, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures References: <1480672254-4986-1-git-send-email-bhumirks@gmail.com> <0f223291-734f-7658-57b7-18e962d15823@lwfinger.net> Date: Wed, 07 Dec 2016 00:07:58 -0500 In-Reply-To: <0f223291-734f-7658-57b7-18e962d15823@lwfinger.net> (Larry Finger's message of "Fri, 2 Dec 2016 14:39:25 -0600") Message-ID: (sfid-20161207_060828_040299_B4C28F42) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger writes: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This argument is >> of type const, so rate_control_ops having this property can also be >> declared as const. >> Done using Coccinelle: >> >> @r1 disable optional_qualifier @ >> identifier i; >> position p; >> @@ >> static struct rate_control_ops i@p = {...}; >> >> @ok1@ >> identifier r1.i; >> position p; >> @@ >> ieee80211_rate_control_register(&i@p) >> >> @ok2@ >> identifier r1.i; >> position p; >> @@ >> ieee80211_rate_control_unregister(&i@p) >> >> @bad@ >> position p!={r1.p,ok1.p,ok2.p}; >> identifier r1.i; >> @@ >> i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> static >> +const >> struct rate_control_ops i={...}; >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> +const >> struct rate_control_ops i; >> >> File size before: >> text data bss dec hex filename >> 1991 104 0 2095 82f wireless/realtek/rtlwifi/rc.o >> >> File size after: >> text data bss dec hex filename >> 2095 0 0 2095 wireless/realtek/rtlwifi/rc.o >> [snip] > The content of your patch is OK; however, your subject is not. By > convention, "net: wireless: realtek:" is assumed. We do, however, > include "rtlwifi:" to indicate which part of > drivers/net/wireless/realtek/ is referenced. In addition, the first part of the description is useful and the file size information is reasonable too, but ~20 lines of coccinelle scripts in the commit message is rather pointless. Jes