From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Dan Lenski <dlenski@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] rtl8xxxu: Increase default polling timeout for firmware startup
Date: Tue, 17 May 2016 23:35:42 -0400 [thread overview]
Message-ID: <wrfja8jo3unl.fsf@redhat.com> (raw)
In-Reply-To: <1463534086-22353-2-git-send-email-dlenski@gmail.com> (Dan Lenski's message of "Tue, 17 May 2016 18:14:45 -0700")
Dan Lenski <dlenski@gmail.com> writes:
> This patch increases the default value for the maximum number of polling
> loops to wait for the rtl8xxxu MCU to start after the firmware is loaded
> (from 1000 to 5000).
>
> With RTL8723AU chipset, I frequently encounter "Firmware failed to start"
> errors from rtl8xxxu after a cold boot.
>
> It appears that other chipsets supported by the driver have the same
> problem. Here are a couple of relevant bug reports:
> - http://ubuntuforums.org/showthread.php?t=2321756
> - https://www.mail-archive.com/ubuntu-bugs@lists.ubuntu.com/msg4942468.html
>
> This issue seems to occur because RTL8XXXU_FIRMWARE_POLL_MAX (1000) is
> too short, and the MCU fails to start up as quickly as expected.
>
> With a longer value (5000), the driver starts up consistently and
> successfully after cold-boot.
>
> Signed-off-by: Dan Lenski <dlenski@gmail.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
As previously pointed out, please provide some details about the system
where this goes wrong.
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
> index f2a1bac..39c6ce7 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h
> @@ -49,7 +49,7 @@
> #define TX_PAGE_NUM_NORM_PQ 0x02
>
> #define RTL_FW_PAGE_SIZE 4096
> -#define RTL8XXXU_FIRMWARE_POLL_MAX 1000
> +#define RTL8XXXU_FIRMWARE_POLL_MAX 5000
This is a long delay - how about 2000?
Jes
next prev parent reply other threads:[~2016-05-18 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 1:14 [PATCH 0/2] rtl8xxxu: increase polling timeout for firmware startup Dan Lenski
2016-05-18 1:14 ` [PATCH 1/2] rtl8xxxu: Increase default " Dan Lenski
2016-05-18 1:20 ` Julian Calaby
2016-05-18 3:35 ` Jes Sorensen [this message]
2016-05-18 4:03 ` Daniel Lenski
2016-05-18 14:57 ` Jes Sorensen
2016-05-18 1:14 ` [PATCH 2/2] rtl8xxxu: Make polling timeout for firmware configurable Dan Lenski
2016-05-18 1:21 ` Julian Calaby
2016-05-18 3:36 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfja8jo3unl.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dlenski@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).