Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

[Jes Sorensen <Jes.Sorensen@redhat.com>]

Joe Perches <joe@perches.com> writes:
> On Sun, 2015-08-30 at 14:41 -0400, Jes Sorensen wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> writes:
> []
>> >> +	dev_info(&priv->udev->dev, "%s: dumping efuse (0x%02lx bytes):\n",
>> >> +		 __func__, sizeof(struct rtl8192cu_efuse));
>> >
>> > On a 32-bit PowerPC, the above line outputs the following:
>> >
>> > warning: format ‘%lx’ expects argument of type ‘long unsigned int’,
>> > but argument 4 has type ‘unsigned int’ [-Wformat]
>> >
>> > This issue does not affect the object code, but it should be
>> > fixed. Setting the format specifier to %02x and adding a cast of (int)
>> > before the "size_of" will fix it on both sets of systems.
>> 
>> Ewww, I didn't realize PowerPC 32 was this ugly :( Adding (long) as a
>> cast would have the same effect here, but we will end up with an ugly
>> cast in either case.
>
> don't cast at all and use format specifier %zu instead

Would be %zx in this case, but thanks, I updated that.

Jes