From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 054/113] rtl8xxxu: Implement 8723bu power on sequence
Date: Thu, 10 Mar 2016 09:53:14 -0500 [thread overview]
Message-ID: <wrfjfuvy2xlx.fsf@redhat.com> (raw)
In-Reply-To: <87twkejtd4.fsf@purkki.adurom.net> (Kalle Valo's message of "Thu, 10 Mar 2016 16:32:55 +0200")
Kalle Valo <kvalo@codeaurora.org> writes:
> Jes.Sorensen@redhat.com writes:
>
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This implements the 8723bu specific power on sequence as it is
>> different from that of the 8723au chips.
>>
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> [...]
>
>> @@ -140,7 +144,10 @@
>> #define REG_MAC_PINMUX_CFG 0x0043
>> #define REG_GPIO_PIN_CTRL 0x0044
>> #define REG_GPIO_INTM 0x0048
>> +#define GPIO_INTM_EDGE_TRIG_IRQ BIT(9)
>> +
>> #define REG_LEDCFG0 0x004c
>> +#define LEDCFG0_DPDT_SELECT BIT(23)
>> #define REG_LEDCFG1 0x004d
>> #define REG_LEDCFG2 0x004e
>> #define LEDCFG2_DPDT_SELECT BIT(7)
>> @@ -154,9 +161,13 @@
>> #define REG_GPIO_PIN_CTRL_2 0x0060
>> /* RTL8723 WIFI/BT/GPS Multi-Function GPIO Select. */
>> #define REG_GPIO_IO_SEL_2 0x0062
>> +#define GPIO_IO_SEL_2_GPIO09_INPUT BIT(1)
>> +#define GPIO_IO_SEL_2_GPIO09_IRQ BIT(9)
>>
>> /* RTL8723B */
>> #define REG_PAD_CTRL1 0x0064
>> +#define PAD_CTRL1_SW_DPDT_SEL_DATA BIT(0)
>
> Why two spaces after define?
I use two spaces for bit defines, so it refers to the register
above. It's consistent throughout the code.
Jes
next prev parent reply other threads:[~2016-03-10 14:53 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 22:03 [PATCH 000/113] rtl8xxxu: Add support for rtl8723bu Jes.Sorensen
2016-02-29 22:03 ` [PATCH 001/113] rtl8xxxu: Add initial code to parse rtl8192eu efuse Jes.Sorensen
2016-02-29 22:04 ` [PATCH 002/113] rtl8xxxu: Identify chip vendors correctly Jes.Sorensen
2016-02-29 22:04 ` [PATCH 003/113] rtl8xxxu: Use 1024 byte block loads for 8192eu firmware Jes.Sorensen
2016-02-29 22:04 ` [PATCH 004/113] rtl8xxxu: Add rtl8192eu_nic.bin to the MODULE_FIRMWARE list Jes.Sorensen
2016-02-29 22:04 ` [PATCH 005/113] rtl8xxxu: Implment rtl8192eu_power_on() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 006/113] rtl8xxxu: Add rtl8xxxu_auto_llt_table() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 007/113] rtl8xxxu: Init page boundaries before starting the firmware Jes.Sorensen
2016-02-29 22:04 ` [PATCH 008/113] rtl8xxxu: Init the LLT after we start " Jes.Sorensen
2016-02-29 22:04 ` [PATCH 009/113] rtl8xxxu: Fix incorrect test for auto LLT failure Jes.Sorensen
2016-02-29 22:04 ` [PATCH 010/113] rtl8xxxu: Kludge to drop incorrect USB OUT EP for 8192EU Jes.Sorensen
2016-02-29 22:04 ` [PATCH 011/113] rtl8xxxu: Init REG_HIMR[01] for 8192eu parts Jes.Sorensen
2016-02-29 22:04 ` [PATCH 012/113] rtl8xxxu: Initial rtl8723bu chip identification Jes.Sorensen
2016-02-29 22:04 ` [PATCH 013/113] rtl8xxxu: Add rtl8723bu_parse_efuse() and 8723bu efuse definition Jes.Sorensen
2016-02-29 22:04 ` [PATCH 014/113] rtl8xxxu: Use 1024 byte writes for writing 8723bu firmware Jes.Sorensen
2016-02-29 22:04 ` [PATCH 015/113] rtl8xxxu: Only setup USB interrupts for parts which support it Jes.Sorensen
2016-02-29 22:04 ` [PATCH 016/113] rtl8xxxu: Add rtl8723b_phy_1t_init_table Jes.Sorensen
2016-02-29 22:04 ` [PATCH 017/113] rtl8xxxu: Add rtl8723bu_radioa_1t_init_table Jes.Sorensen
2016-02-29 22:04 ` [PATCH 018/113] rtl8xxxu: Add rtl8723bu_phy_init_antenna_selection() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 019/113] rtl8xxxu: Add rtl8723b_mac_init_table Jes.Sorensen
2016-02-29 22:04 ` [PATCH 020/113] rtl8xxxu: Add 8723by AGC table Jes.Sorensen
2016-02-29 22:04 ` [PATCH 021/113] rtl8xxxu: Handle 32 bit mailbox extension regs found on 8723bu/8192eu/8812 Jes.Sorensen
2016-02-29 22:04 ` [PATCH 022/113] rtl8xxxu: Add some missing register definitions for 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 023/113] rtl8xxxu: Group USB fixups together for all chips Jes.Sorensen
2016-02-29 22:04 ` [PATCH 024/113] rtl8xxxu: Add definitions for new generation h2c commands Jes.Sorensen
2016-02-29 22:04 ` [PATCH 025/113] rtl8xxxu: Don't check for illegal offset when reading from efuse Jes.Sorensen
2016-02-29 22:04 ` [PATCH 026/113] rtl8xxxu: Skip disabled efuse words early Jes.Sorensen
2016-02-29 22:04 ` [PATCH 027/113] rtl8xxxu: rtl8723au: Introduce a pointer to efuse Jes.Sorensen
2016-02-29 22:04 ` [PATCH 028/113] rtl8xxxu: rtl8192cu: " Jes.Sorensen
2016-02-29 22:04 ` [PATCH 029/113] rtl8xxxu: rtl8192eu_parse_efuse(): Use a pointer to the struct rtl8192eu_efuse Jes.Sorensen
2016-02-29 22:04 ` [PATCH 030/113] rtl8xxxu: rtl8723bu_parse_efuse(): Use a pointer to the struct rtl8723bu_efuse Jes.Sorensen
2016-02-29 22:04 ` [PATCH 031/113] rtl8xxxu: rtl8xxxu_h2c_cmd(): Add size argument Jes.Sorensen
2016-02-29 22:04 ` [PATCH 032/113] rtl8xxxu: Do BT_WLAN_CALIBRATION before doing IQK calibration Jes.Sorensen
2016-02-29 22:04 ` [PATCH 033/113] rtl8xxxu: Do not overwrite rtl8xxxu_debug for untested chips Jes.Sorensen
2016-02-29 22:04 ` [PATCH 034/113] rtl8xxxu: Use correct formatting type to print sizeof() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 035/113] rtl8xxxu: Make rtl8xxxu_add_path_on() use device specific init values Jes.Sorensen
2016-02-29 22:04 ` [PATCH 036/113] rtl8xxxu: Add a couple of new register definitions Jes.Sorensen
2016-02-29 22:04 ` [PATCH 037/113] rtl8xxxu: First stab at adding IQK calibration for 8723bu parts Jes.Sorensen
2016-03-10 14:24 ` Kalle Valo
2016-03-10 14:52 ` Jes Sorensen
2016-02-29 22:04 ` [PATCH 038/113] rtl8xxxu: Handle S0S1 register in lc_calibrate() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 039/113] rtl8xxxu: Do LC calibration before IQK calibration Jes.Sorensen
2016-02-29 22:04 ` [PATCH 040/113] rtl8xxxu: Remove backing up certain registers, which was never used Jes.Sorensen
2016-02-29 22:04 ` [PATCH 041/113] rtl8xxxu: rtl8192eu: Map out EFUSE TX power area Jes.Sorensen
2016-02-29 22:04 ` [PATCH 042/113] rtl8xxxu: Initial implementation of rtl8723bu_config_channel() Jes.Sorensen
2016-03-10 14:26 ` Kalle Valo
2016-03-10 14:52 ` Jes Sorensen
2016-02-29 22:04 ` [PATCH 043/113] rtl8xxxu: Initial rtl8723bu_init_bt() code Jes.Sorensen
2016-02-29 22:04 ` [PATCH 044/113] rtl8xxxu: Remove unused variable Jes.Sorensen
2016-02-29 22:04 ` [PATCH 045/113] rtl8xxxu: Improve 8723bu init code Jes.Sorensen
2016-02-29 22:04 ` [PATCH 046/113] rtl8xxxu: Do not ignore wlan activity on 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 047/113] rtl8xxxu: Set the right type for ps tdma " Jes.Sorensen
2016-02-29 22:04 ` [PATCH 048/113] rtl8xxxu: Add rtl8723bu (nextgen) rx descriptor definition Jes.Sorensen
2016-02-29 22:04 ` [PATCH 049/113] rtl8xxxu: Handle 8723bu style rx descriptors Jes.Sorensen
2016-02-29 22:04 ` [PATCH 050/113] rtl8xxxu: Initial functionality to handle C2H events for 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 051/113] rtl8xxxu: Handle BT register writes and MP_OPER events Jes.Sorensen
2016-02-29 22:04 ` [PATCH 052/113] rtl8xxxu: Issue BT_INFO command Jes.Sorensen
2016-02-29 22:04 ` [PATCH 053/113] rtl8xxxu: Do not set REG_AFE_XTAL_CTRL on 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 054/113] rtl8xxxu: Implement 8723bu power on sequence Jes.Sorensen
2016-03-10 14:32 ` Kalle Valo
2016-03-10 14:53 ` Jes Sorensen [this message]
2016-02-29 22:04 ` [PATCH 055/113] rtl8xxxu: Setup LLT before downloading firmware Jes.Sorensen
2016-02-29 22:04 ` [PATCH 056/113] rtl8xxxu: Additional fixes for 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 057/113] rtl8xxxu: Handle XTAL_K value in efuse specific location Jes.Sorensen
2016-02-29 22:04 ` [PATCH 058/113] rtl8xxxu: Another 8723bu patch for rtl8xxxu_init_phy_bb() Jes.Sorensen
2016-02-29 22:04 ` [PATCH 059/113] rtl8xxxu: Another 8723bu magic register set during init Jes.Sorensen
2016-02-29 22:04 ` [PATCH 060/113] rtl8xxxu: Init H2C command register for 8723bu Jes.Sorensen
2016-02-29 22:04 ` [PATCH 061/113] rtl8xxxu: 80M spur hack is for 8723au only Jes.Sorensen
2016-02-29 22:05 ` [PATCH 062/113] rtl8xxxu: Do queue init in same order as 8723bu vendor driver Jes.Sorensen
2016-02-29 22:05 ` [PATCH 063/113] rtl8xxxu: Do not set FPGA0_TX_INFO for 8723bu and use a larger PBP page size Jes.Sorensen
2016-02-29 22:05 ` [PATCH 064/113] rtl8xxxu: Set RX boundary for 8723bu Jes.Sorensen
2016-02-29 23:11 ` Julian Calaby
2016-02-29 23:47 ` Jes Sorensen
2016-02-29 22:05 ` [PATCH 065/113] rtl8xxxu: Initialize burst parameters " Jes.Sorensen
2016-02-29 22:05 ` [PATCH 066/113] rtl8xxxu: Call device specific _config_channel() Jes.Sorensen
2016-02-29 23:12 ` Julian Calaby
2016-02-29 23:48 ` Jes Sorensen
2016-02-29 23:50 ` Julian Calaby
2016-02-29 23:58 ` Jes Sorensen
2016-02-29 22:05 ` [PATCH 067/113] rtl8xxxu: 8723bu lock phy after RF init Jes.Sorensen
2016-02-29 22:05 ` [PATCH 068/113] rtl8xxxu: Add REG_DWBCN1_CTRL_8723B define Jes.Sorensen
2016-02-29 22:05 ` [PATCH 069/113] rtl8xxxu: Group chip quirks together Jes.Sorensen
2016-02-29 22:05 ` [PATCH 070/113] rtl8xxxu: Setup RX aggregation Jes.Sorensen
2016-02-29 22:05 ` [PATCH 071/113] rtl8xxxu: Add missing blank space in front of bracket Jes.Sorensen
2016-02-29 22:05 ` [PATCH 072/113] rtl8xxxu: Implement init_statistics for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 073/113] rtl8xxxu: RF_T_METER is different on the newer chips Jes.Sorensen
2016-02-29 22:05 ` [PATCH 074/113] rtl8xxxu: Set WLAN_ACT_CONTROL per vendor driver setting Jes.Sorensen
2016-02-29 22:05 ` [PATCH 075/113] rtl8xxxu: 8723bu: REG_BT_COEX_TABLE4 is only 8 bits Jes.Sorensen
2016-02-29 22:05 ` [PATCH 076/113] rtl8xxxu: Use name for REG_RFE_BUFFER rather than hard coded value Jes.Sorensen
2016-02-29 22:05 ` [PATCH 077/113] rtl8xxxu: Use REG_RFE_CTRL_ANTA_SRC " Jes.Sorensen
2016-02-29 22:05 ` [PATCH 078/113] rtl8xxxu: Setup coex table correctly (hopefully) Jes.Sorensen
2016-02-29 22:05 ` [PATCH 079/113] rtl8xxxu: Do not use hard-wired RF enable settings for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 080/113] rtl8xxxu: Correct struct rtl8723bu_efuse to list power bases correctly Jes.Sorensen
2016-02-29 22:05 ` [PATCH 081/113] rtl8xxxu: Introduce set_tx_power() fileop and a new 8723b dummy derivative Jes.Sorensen
2016-02-29 22:05 ` [PATCH 082/113] rtl8xxxu: Use size of source pointer when copying efuse data Jes.Sorensen
2016-02-29 22:05 ` [PATCH 083/113] rtl8xxxu: Bump TX power arrays to handle larger channel groups Jes.Sorensen
2016-02-29 22:05 ` [PATCH 084/113] rtl8xxxu: Parse efuse power indices for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 085/113] rtl8xxxu: Set 8723bu TX power for CCK and OFDM rates Jes.Sorensen
2016-02-29 22:05 ` [PATCH 086/113] rtl8xxxu: Set 8723bu MCS TX power Jes.Sorensen
2016-02-29 22:05 ` [PATCH 087/113] rtl8xxxu: Set the correct thermal meter register for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 088/113] rtl8xxxu: Add definition for 8723bu tx descriptor Jes.Sorensen
2016-02-29 22:05 ` [PATCH 089/113] rtl8xxxu: Handle 40 byte TX descriptors for rtl8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 090/113] rtl8xxxu: Do not unconditionally print debug info in rtl8723bu_handle_c2h() Jes.Sorensen
2016-02-29 22:05 ` [PATCH 091/113] rtl8xxxu: Add additional tx descriptor bits for data word 0 Jes.Sorensen
2016-02-29 22:05 ` [PATCH 092/113] rtl8xxxu: Add more 40 byte TX desc bit definitions Jes.Sorensen
2016-02-29 22:05 ` [PATCH 093/113] rtl8xxxu: Set the correct TX descriptor bits for agg and break on 8723b Jes.Sorensen
2016-02-29 22:05 ` [PATCH 094/113] rtl8xxxu: Set sequence number correctly for 40 byte TX descriptors Jes.Sorensen
2016-02-29 22:05 ` [PATCH 095/113] rtl8723au: Update TX descriptor words 4 and 5 definitions Jes.Sorensen
2016-02-29 22:05 ` [PATCH 096/113] rtl8xxxu: TX RTS rate is word 4 for 8723a Jes.Sorensen
2016-02-29 22:05 ` [PATCH 097/113] rtl8xxxu: Improve handling of txdesc32 vs txdesc40 handling Jes.Sorensen
2016-02-29 22:05 ` [PATCH 098/113] rtl8xxxu: Do not parse RX descriptor info for C2H packets Jes.Sorensen
2016-02-29 22:05 ` [PATCH 099/113] rtl8xxxu: Define 8723b H2C ramask command structure Jes.Sorensen
2016-02-29 22:05 ` [PATCH 100/113] rtl8xxxu: Implement basic 8723b specific update_rate_mask() function Jes.Sorensen
2016-02-29 22:05 ` [PATCH 101/113] rtl8xxxu: Report media status using the correct H2C command for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 102/113] rtl8xxxu: Dump contents of unhandled C2H events Jes.Sorensen
2016-02-29 22:05 ` [PATCH 103/113] rtl8xxxu: Process C2H RA_REPORT events for 8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 104/113] rtl8xxxu: Pass RX rate to rx_parse_phystats and enable phystats for rtl8723bu Jes.Sorensen
2016-02-29 22:05 ` [PATCH 105/113] rtl8xxxu: Remove unncessary semicolon Jes.Sorensen
2016-02-29 22:05 ` [PATCH 106/113] rtl8xxxu: convert rtl8723bu_init_bt() into rtl8723b_enable_rf() Jes.Sorensen
2016-02-29 23:46 ` Julian Calaby
2016-02-29 23:51 ` Jes Sorensen
2016-03-01 0:04 ` Julian Calaby
2016-03-01 0:15 ` Jes Sorensen
2016-03-01 0:32 ` Julian Calaby
2016-03-01 1:30 ` Jes Sorensen
2016-03-01 1:47 ` Julian Calaby
2016-02-29 22:05 ` [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits Jes.Sorensen
2016-03-10 14:46 ` Kalle Valo
2016-03-10 14:55 ` Jes Sorensen
2016-02-29 22:05 ` [PATCH 108/113] rtl8xxxu: Implement 8723bu specific disable_rf() function Jes.Sorensen
2016-02-29 22:05 ` [PATCH 109/113] rtl8xxxu: Implement device specific power_off function Jes.Sorensen
2016-02-29 22:05 ` [PATCH 110/113] rtl8xxxu: Flush FIFO before powering down devices Jes.Sorensen
2016-02-29 22:05 ` [PATCH 111/113] rtl8xxxu: Print a warning if flushing the FIFO fails Jes.Sorensen
2016-02-29 23:48 ` Julian Calaby
2016-02-29 23:52 ` Jes Sorensen
2016-02-29 22:05 ` [PATCH 112/113] rtl8xxxu: Use correct 8051 reset function for 8723b parts Jes.Sorensen
2016-02-29 22:05 ` [PATCH 113/113] rtl8xxxu: Temporarily disable 8192eu device init Jes.Sorensen
2016-03-11 12:37 ` [PATCH 000/113] rtl8xxxu: Add support for rtl8723bu Kalle Valo
2016-03-11 19:46 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjfuvy2xlx.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).