linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Sanjeev Sharma <sanjeev_sharma@mentor.com>
Cc: <Larry.Finger@lwfinger.net>, <gregkh@linuxfoundation.org>,
	<linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.
Date: Mon, 27 Oct 2014 09:43:14 +0100	[thread overview]
Message-ID: <wrfjioj5aonx.fsf@redhat.com> (raw)
In-Reply-To: <1414396745-8845-1-git-send-email-sanjeev_sharma@mentor.com> (Sanjeev Sharma's message of "Mon, 27 Oct 2014 13:29:05 +0530")

Sanjeev Sharma <sanjeev_sharma@mentor.com> writes:
> This is a patch to the rtw_cmd.c file that fixes
> Error reported by checkpatch.
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_cmd.c | 83 +++++++++++++++-----------------
>  1 file changed, 40 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
> index 4eaa502..c1f6254 100644
> --- a/drivers/staging/rtl8723au/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
> @@ -957,7 +957,7 @@ static void traffic_status_watchdog(struct rtw_adapter *padapter)
>  		/*  check traffic for  powersaving. */
>  			if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod +
>  			      pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > 8) ||
> -			    pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2)
> +			    pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)
>  				bEnterPS = false;
>  			else
>  				bEnterPS = true;

This makes the line longer than 80 characters, that is worse than the
'problem' you are fixing.

Jes

  reply	other threads:[~2014-10-27  8:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27  7:59 [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch Sanjeev Sharma
2014-10-27  8:43 ` Jes Sorensen [this message]
2014-10-27 14:52   ` Joe Perches
2014-10-29  6:35     ` Sharma, Sanjeev
2014-10-30 14:50       ` Jes Sorensen
2014-11-05 11:35         ` [PATCH v2] " Sanjeev Sharma
2014-11-05 16:27           ` Greg KH
2014-11-06  6:37             ` Sharma, Sanjeev
2014-11-05 17:15           ` Joe Perches
2014-11-06  5:41             ` Sharma, Sanjeev
2014-11-05 11:38         ` [PATCH] " Sharma, Sanjeev
2014-11-06  6:16         ` Sanjeev Sharma
2014-11-06 15:41           ` Greg KH
2014-11-07 11:56             ` Sharma, Sanjeev
2014-11-06  6:36         ` [PATCH] staging:rtl8723au: core: Fix Warning " Sanjeev Sharma
2014-11-06 15:43           ` Greg KH
2014-11-07 12:00             ` Sharma, Sanjeev
2014-11-07 15:46               ` Jes Sorensen
2014-11-11  7:54         ` [PATCH] staging:rtl8723au: core: Added missing space " Sanjeev Sharma
2014-11-11  9:58         ` [PATCH] staging:rtl8723au: core: Fix checkpatch warning Sanjeev Sharma
2014-10-30  7:47     ` [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch Jes Sorensen
2014-10-29  6:32   ` Sharma, Sanjeev
2014-10-30 14:49     ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjioj5aonx.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sanjeev_sharma@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).