From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbaJ0Ion (ORCPT ); Mon, 27 Oct 2014 04:44:43 -0400 From: Jes Sorensen To: Sanjeev Sharma Cc: , , , , Subject: Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch. References: <1414396745-8845-1-git-send-email-sanjeev_sharma@mentor.com> Date: Mon, 27 Oct 2014 09:43:14 +0100 In-Reply-To: <1414396745-8845-1-git-send-email-sanjeev_sharma@mentor.com> (Sanjeev Sharma's message of "Mon, 27 Oct 2014 13:29:05 +0530") Message-ID: (sfid-20141027_094459_768585_A48973D0) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Sanjeev Sharma writes: > This is a patch to the rtw_cmd.c file that fixes > Error reported by checkpatch. > > Signed-off-by: Sanjeev Sharma > --- > drivers/staging/rtl8723au/core/rtw_cmd.c | 83 +++++++++++++++----------------- > 1 file changed, 40 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c > index 4eaa502..c1f6254 100644 > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c > @@ -957,7 +957,7 @@ static void traffic_status_watchdog(struct rtw_adapter *padapter) > /* check traffic for powersaving. */ > if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + > pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) > 8) || > - pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2) > + pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2) > bEnterPS = false; > else > bEnterPS = true; This makes the line longer than 80 characters, that is worse than the 'problem' you are fixing. Jes