From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Andreas Ruprecht <andreas.ruprecht@fau.de>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning
Date: Fri, 29 Jan 2016 13:00:40 -0500 [thread overview]
Message-ID: <wrfjk2ms465z.fsf@redhat.com> (raw)
In-Reply-To: <20160129172908.GA14077@Karyakshetra> (Bhaktipriya Shridhar's message of "Fri, 29 Jan 2016 22:59:08 +0530")
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index d28f29a..e8a16b9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)
>
> dump_mgntframe23a(padapter, pmgntframe);
>
> - return;
> }
If you insist on pushing this rather unncessary change, please do it
properly, and remove the blank line before the return statement as well.
Jes
next prev parent reply other threads:[~2016-01-29 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:29 [PATCH] staging: rtl8723au: Fixes unnecessary return warning Bhaktipriya Shridhar
2016-01-29 18:00 ` Jes Sorensen [this message]
2016-01-29 23:17 ` Julian Calaby
2016-01-30 1:28 ` Joe Perches
2016-01-30 3:09 ` Julian Calaby
2016-01-30 3:18 ` Joe Perches
2016-01-30 6:53 ` Bhakti Priya
2016-01-30 7:24 ` Joe Perches
2016-01-30 12:02 ` Julian Calaby
2016-01-30 12:09 ` Joe Perches
2016-01-31 14:31 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjk2ms465z.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andreas.ruprecht@fau.de \
--cc=bhaktipriya96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).