From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47696 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756890AbcC2PTq (ORCPT ); Tue, 29 Mar 2016 11:19:46 -0400 From: Jes Sorensen To: Bhumika Goyal Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, joe@perches.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8723au: Remove function rtw_enqueue_{recvbuf23a/recvbuf23a_to_head} References: <1458973495-17403-1-git-send-email-bhumirks@gmail.com> Date: Tue, 29 Mar 2016 11:19:43 -0400 In-Reply-To: <1458973495-17403-1-git-send-email-bhumirks@gmail.com> (Bhumika Goyal's message of "Sat, 26 Mar 2016 11:54:55 +0530") Message-ID: (sfid-20160329_172005_695521_6C3CD0D5) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Bhumika Goyal writes: > The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head > are never used anywhere in the kernel. So, remove their definition and > prototype. > Grepped to find occurences. > > Signed-off-by: Bhumika Goyal > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 25 ------------------------- > drivers/staging/rtl8723au/include/rtw_recv.h | 2 -- > 2 files changed, 27 deletions(-) Looks reasonable to me. Acked-by: Jes Sorensen Jes > diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c > index 989ed07..150dabc 100644 > --- a/drivers/staging/rtl8723au/core/rtw_recv.c > +++ b/drivers/staging/rtl8723au/core/rtw_recv.c > @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter) > return cnt; > } > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - spin_lock_bh(&queue->lock); > - > - list_del_init(&precvbuf->list); > - list_add(&precvbuf->list, get_list_head(queue)); > - > - spin_unlock_bh(&queue->lock); > - > - return _SUCCESS; > -} > - > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - unsigned long irqL; > - > - spin_lock_irqsave(&queue->lock, irqL); > - > - list_del_init(&precvbuf->list); > - > - list_add_tail(&precvbuf->list, get_list_head(queue)); > - spin_unlock_irqrestore(&queue->lock, irqL); > - return _SUCCESS; > -} > - > struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue) > { > unsigned long irqL; > diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h > index dc784be..85a5edb 100644 > --- a/drivers/staging/rtl8723au/include/rtw_recv.h > +++ b/drivers/staging/rtl8723au/include/rtw_recv.h > @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu > > u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter); > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue); > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue); > struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue); > > void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext);