* [PATCH v2] staging: rtl8723au: Fix resource leak
@ 2015-09-27 19:48 Mateusz Kulikowski
2015-09-28 11:27 ` Sudip Mukherjee
2015-09-28 18:23 ` Jes Sorensen
0 siblings, 2 replies; 3+ messages in thread
From: Mateusz Kulikowski @ 2015-09-27 19:48 UTC (permalink / raw)
To: Larry.Finger, Jes.Sorensen
Cc: Mateusz Kulikowski, gregkh, linux-wireless, devel, linux-kernel
Firmware was not released properly if kmemdup fails.
Addresses-Coverity-Id: 1269118
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index cd014f7..ecf54ee 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
@@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter)
goto Exit;
}
firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);
+ fw_size = fw->size;
+ release_firmware(fw);
if (!firmware_buf) {
rtStatus = _FAIL;
goto Exit;
}
buf = firmware_buf;
- fw_size = fw->size;
- release_firmware(fw);
/* To Check Fw header. Added by tynli. 2009.12.04. */
pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: rtl8723au: Fix resource leak
2015-09-27 19:48 [PATCH v2] staging: rtl8723au: Fix resource leak Mateusz Kulikowski
@ 2015-09-28 11:27 ` Sudip Mukherjee
2015-09-28 18:23 ` Jes Sorensen
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-09-28 11:27 UTC (permalink / raw)
To: Mateusz Kulikowski
Cc: Larry.Finger, Jes.Sorensen, devel, gregkh, linux-wireless,
linux-kernel
On Sun, Sep 27, 2015 at 09:48:19PM +0200, Mateusz Kulikowski wrote:
> Firmware was not released properly if kmemdup fails.
>
> Addresses-Coverity-Id: 1269118
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
Not seen your v2 while replying to your v1. Sorry for the noise.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8723au: Fix resource leak
2015-09-27 19:48 [PATCH v2] staging: rtl8723au: Fix resource leak Mateusz Kulikowski
2015-09-28 11:27 ` Sudip Mukherjee
@ 2015-09-28 18:23 ` Jes Sorensen
1 sibling, 0 replies; 3+ messages in thread
From: Jes Sorensen @ 2015-09-28 18:23 UTC (permalink / raw)
To: Mateusz Kulikowski
Cc: Larry.Finger, gregkh, linux-wireless, devel, linux-kernel
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> writes:
> Firmware was not released properly if kmemdup fails.
>
> Addresses-Coverity-Id: 1269118
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index cd014f7..ecf54ee 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter)
> goto Exit;
> }
> firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);
> + fw_size = fw->size;
> + release_firmware(fw);
> if (!firmware_buf) {
> rtStatus = _FAIL;
> goto Exit;
> }
> buf = firmware_buf;
> - fw_size = fw->size;
> - release_firmware(fw);
>
> /* To Check Fw header. Added by tynli. 2009.12.04. */
> pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-28 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-27 19:48 [PATCH v2] staging: rtl8723au: Fix resource leak Mateusz Kulikowski
2015-09-28 11:27 ` Sudip Mukherjee
2015-09-28 18:23 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).