From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbbGURrL (ORCPT ); Tue, 21 Jul 2015 13:47:11 -0400 From: Jes Sorensen To: Steve Pennington Cc: Larry Finger , Greg Kroah-Hartman , Greg Donald , Joe Perches , Roberta Dobrescu , Masanari Iida , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723au: fix incorrect type in assignment warning References: <1437499895-18532-1-git-send-email-sgpenn@gmail.com> Date: Tue, 21 Jul 2015 13:47:10 -0400 In-Reply-To: <1437499895-18532-1-git-send-email-sgpenn@gmail.com> (Steve Pennington's message of "Tue, 21 Jul 2015 12:31:35 -0500") Message-ID: (sfid-20150721_194729_013732_B8806DB9) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Steve Pennington writes: > Repaced call to htons with call to cpu_to_be16s to fix the > following sparse warning: > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in assignment (different base types) > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: expected unsigned short [unsigned] [assigned] [usertype] len > drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: got restricted __be16 [usertype] > > Signed-off-by: Steve Pennington > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c > index 274a4b6..39318ae 100644 > --- a/drivers/staging/rtl8723au/core/rtw_recv.c > +++ b/drivers/staging/rtl8723au/core/rtw_recv.c > @@ -1554,7 +1554,7 @@ static int wlanhdr_to_ethhdr (struct recv_frame *precvframe) > ether_addr_copy(ptr + ETH_ALEN, pattrib->src); > > if (!bsnaphdr) { > - len = htons(len); > + cpu_to_be16s(&len); > memcpy(ptr + 12, &len, 2); > } Thats an awful fix - use put_unaligned_le16() instead. Jes