From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcC2Qr5 (ORCPT ); Tue, 29 Mar 2016 12:47:57 -0400 From: Jes Sorensen To: Colin King Cc: Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtl8xxxu: fix uninitialized return value in ret References: <1459269876-15559-1-git-send-email-colin.king@canonical.com> Date: Tue, 29 Mar 2016 12:47:55 -0400 In-Reply-To: <1459269876-15559-1-git-send-email-colin.king@canonical.com> (Colin King's message of "Tue, 29 Mar 2016 17:44:36 +0100") Message-ID: (sfid-20160329_184832_062974_0B89F22F) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Colin King writes: > From: Colin Ian King > > several functions are not initializing a return status in ret > resulting in garbage to be returned instead of 0 for success. > Currently, the calls to these functions are not checking the > return, however, it seems prudent to return the correct status > in case they are to be checked at a later date. > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks for the patch! I'm surprised the compiler didn't warn about this. I'll add it to my queue for rtl8xxxu. Cheers, Jes > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > index abdff45..9262aad 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c > @@ -5231,7 +5231,7 @@ static void rtl8xxxu_set_ampdu_min_space(struct rtl8xxxu_priv *priv, u8 density) > static int rtl8xxxu_active_to_emu(struct rtl8xxxu_priv *priv) > { > u8 val8; > - int count, ret; > + int count, ret = 0; > > /* Start of rtl8723AU_card_enable_flow */ > /* Act to Cardemu sequence*/ > @@ -5281,7 +5281,7 @@ static int rtl8723bu_active_to_emu(struct rtl8xxxu_priv *priv) > u8 val8; > u16 val16; > u32 val32; > - int count, ret; > + int count, ret = 0; > > /* Turn off RF */ > rtl8xxxu_write8(priv, REG_RF_CTRL, 0); > @@ -5338,7 +5338,7 @@ static int rtl8xxxu_active_to_lps(struct rtl8xxxu_priv *priv) > { > u8 val8; > u8 val32; > - int count, ret; > + int count, ret = 0; > > rtl8xxxu_write8(priv, REG_TXPAUSE, 0xff);