* [PATCH] staging: rtl8723au: remove redundant initialization
@ 2015-05-12 10:01 Gujulan Elango, Hari Prasath (H.)
2015-05-12 11:07 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Gujulan Elango, Hari Prasath (H.) @ 2015-05-12 10:01 UTC (permalink / raw)
To: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
joe@perches.com, linux-wireless@vger.kernel.org,
Babu, Viswanathan (V.)
The variable pHalData is initialized twice in this same function with
same value.So removing one of them.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
index 11e1108..9733aa6 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
@@ -55,7 +55,7 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen,
u8 h2c_box_num;
u32 msgbox_addr;
u32 msgbox_ex_addr;
- struct hal_data_8723a *pHalData = GET_HAL_DATA(padapter);
+ struct hal_data_8723a *pHalData;
u32 h2c_cmd = 0;
u16 h2c_cmd_ex = 0;
int ret = _FAIL;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723au: remove redundant initialization
2015-05-12 10:01 [PATCH] staging: rtl8723au: remove redundant initialization Gujulan Elango, Hari Prasath (H.)
@ 2015-05-12 11:07 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-05-12 11:07 UTC (permalink / raw)
To: Gujulan Elango, Hari Prasath (H.)
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Larry.Finger@lwfinger.net, joe@perches.com,
linux-wireless@vger.kernel.org, Babu, Viswanathan (V.)
"Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com> writes:
> The variable pHalData is initialized twice in this same function with
> same value.So removing one of them.
>
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks fine to me
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-12 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-12 10:01 [PATCH] staging: rtl8723au: remove redundant initialization Gujulan Elango, Hari Prasath (H.)
2015-05-12 11:07 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).