From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: rtl8723au: fix some confusing indenting
Date: Sat, 03 May 2014 23:09:07 +0200 [thread overview]
Message-ID: <wrfjvbtmpo24.fsf@ultrasam.lan.trained-monkey.org> (raw)
In-Reply-To: <20140503201919.GB32753@mwanda> (Dan Carpenter's message of "Sat, 3 May 2014 23:19:19 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains. The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Urgh yes, that should be cleaned up!
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
> case WLAN_EID_ERP_INFO:
> case WLAN_EID_EXT_SUPP_RATES:
> case WLAN_EID_VENDOR_SPECIFIC:
> - if (rtw_validate_vendor_specific_ies(pos, elen))
> - unknown++;
> + if (rtw_validate_vendor_specific_ies(pos, elen))
> + unknown++;
> break;
> case WLAN_EID_RSN:
> case WLAN_EID_PWR_CAPABILITY:
prev parent reply other threads:[~2014-05-03 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 20:19 [patch] staging: rtl8723au: fix some confusing indenting Dan Carpenter
2014-05-03 21:09 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjvbtmpo24.fsf@ultrasam.lan.trained-monkey.org \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox