From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy
Date: Sun, 18 Jan 2015 10:24:28 -0500 [thread overview]
Message-ID: <wrfjzj9gt8lv.fsf@redhat.com> (raw)
In-Reply-To: <20150117215040.GA16839@kroah.com> (Greg Kroah-Hartman's message of "Sat, 17 Jan 2015 13:50:40 -0800")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Sun, Dec 07, 2014 at 03:37:20PM +0100, Emil Renner Berthing wrote:
>> This also fixes a sparse warning.
>
> What sparse warning? What's wrong with the original code? Unless Jes
> resends this to me, I don't see the need to apply it, sorry.
I agree, I cannot see what this is fixing, it does however add an ugly
cast.
If you want to change the paramters passed to FillH2CCmd() then change
the prototype and create something like struct h2c_cmd_arg{} and apply
that across the board.
NACK
Jes
prev parent reply other threads:[~2015-01-18 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 14:37 [PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy Emil Renner Berthing
2015-01-17 21:50 ` Greg Kroah-Hartman
2015-01-18 15:24 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjzj9gt8lv.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).