Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Aristeu Rozanski <arozansk@redhat.com>
To: linux-wpan@vger.kernel.org
Cc: Alexander Aring <aar@pengutronix.de>,
	Stefan Schmidt <stefan@osg.samsung.com>,
	Jukka Rissanen <jukka.rissanen@linux.intel.com>,
	Aristeu Rozanski <arozansk@redhat.com>
Subject: [PATCH v2 1/2] mac802154: don't warn on unsupported frames
Date: Mon, 25 Jul 2016 11:46:40 -0400	[thread overview]
Message-ID: <1469461601-656-1-git-send-email-arozansk@redhat.com> (raw)

Just because we don't support certain types of frames yet doesn't mean
we have to flood the message log with warnings about "invalid" frames.

v2: get rid of stats update, some of them were wrong, others might change in
    the future

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
---
 net/mac802154/rx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
index 446e130..b978da0 100644
--- a/net/mac802154/rx.c
+++ b/net/mac802154/rx.c
@@ -101,6 +101,11 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata,
 	sdata->dev->stats.rx_bytes += skb->len;
 
 	switch (mac_cb(skb)->type) {
+	case IEEE802154_FC_TYPE_BEACON:
+	case IEEE802154_FC_TYPE_ACK:
+	case IEEE802154_FC_TYPE_MAC_CMD:
+		goto fail;
+
 	case IEEE802154_FC_TYPE_DATA:
 		return ieee802154_deliver_skb(skb);
 	default:
-- 
1.8.3.1


             reply	other threads:[~2016-07-25 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 15:46 Aristeu Rozanski [this message]
2016-07-25 15:46 ` [PATCH v2 2/2] mac802154: use rate limited warnings for malformed frames Aristeu Rozanski
2016-07-25 16:19   ` Alexander Aring
2016-07-25 17:24   ` Marcel Holtmann
2016-07-25 16:19 ` [PATCH v2 1/2] mac802154: don't warn on unsupported frames Alexander Aring
2016-07-25 17:24 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469461601-656-1-git-send-email-arozansk@redhat.com \
    --to=arozansk@redhat.com \
    --cc=aar@pengutronix.de \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=stefan@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox