From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Cc: aar@pengutronix.de, linux-wpan@vger.kernel.org
Subject: Re: [PATCH 2/3] Bluetooth: 6lowpan: Print errors during recv_pkt
Date: Wed, 05 Apr 2017 15:23:42 +0300 [thread overview]
Message-ID: <1491395022.3437.7.camel@linux.intel.com> (raw)
In-Reply-To: <20170403144857.4661-2-luiz.dentz@gmail.com>
Hi Luiz,
On Mon, 2017-04-03 at 17:48 +0300, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This makes should make it more clear why a packet is being dropped.
>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/6lowpan.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 2063e96..5b91e85 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -337,6 +337,7 @@ static int recv_pkt(struct sk_buff *skb, struct
> net_device *dev,
>
> ret = iphc_decompress(local_skb, dev, peer);
> if (ret < 0) {
> + BT_DBG("iphc_decompress failed: %d", ret);
> kfree_skb(local_skb);
> goto drop;
> }
> @@ -356,6 +357,7 @@ static int recv_pkt(struct sk_buff *skb, struct
> net_device *dev,
> consume_skb(local_skb);
> consume_skb(skb);
> } else {
> + BT_DBG("unknown packet type");
> goto drop;
> }
>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cheers,
Jukka
next prev parent reply other threads:[~2017-04-05 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 14:48 [PATCH 1/3] Bluetooth: 6lowpan: Remove unnecessary peer lookup Luiz Augusto von Dentz
2017-04-03 14:48 ` [PATCH 2/3] Bluetooth: 6lowpan: Print errors during recv_pkt Luiz Augusto von Dentz
2017-04-05 12:23 ` Jukka Rissanen [this message]
2017-04-03 14:48 ` [PATCH 3/3] Bluetooth: L2CAP: Don't return -EAGAIN if out of credits Luiz Augusto von Dentz
2017-04-05 12:24 ` Jukka Rissanen
2017-04-05 12:23 ` [PATCH 1/3] Bluetooth: 6lowpan: Remove unnecessary peer lookup Jukka Rissanen
2017-04-05 13:47 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491395022.3437.7.camel@linux.intel.com \
--to=jukka.rissanen@linux.intel.com \
--cc=aar@pengutronix.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).