From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, oliver@neukum.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, alex.aring@gmail.com,
jukka.rissanen@linux.intel.com, stefan@datenfreihafen.org,
matt@codeconstruct.com.au, linux-usb@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h
Date: Thu, 03 Feb 2022 12:53:48 +0800 [thread overview]
Message-ID: <17bcd4cf0b983578325715f89d98c3e3f85c5a4e.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20220203043457.2222388-1-kuba@kernel.org>
Hi Jakub,
> Nothing in ipv6.h needs ndisc.h, drop it.
Looks good, we lose the ARPHRD definitions without ndisc.h, but your
change to add if_arp.h addresses that:
> --- a/net/mctp/device.c
> +++ b/net/mctp/device.c
> @@ -6,6 +6,7 @@
> * Copyright (c) 2021 Google
> */
>
> +#include <linux/if_arp.h>
> #include <linux/if_link.h>
> #include <linux/mctp.h>
> #include <linux/netdevice.h>
So, for the net/mctp part:
Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>
Cheers,
Jeremy
next prev parent reply other threads:[~2022-02-03 4:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 4:34 [PATCH net-next] net: don't include ndisc.h from ipv6.h Jakub Kicinski
2022-02-03 4:53 ` Jeremy Kerr [this message]
2022-02-03 15:14 ` Stefan Schmidt
2022-02-03 22:48 ` David Ahern
2022-02-03 23:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17bcd4cf0b983578325715f89d98c3e3f85c5a4e.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alex.aring@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stefan@datenfreihafen.org \
--cc=vfalico@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox