From: Alexander Aring <alex.aring@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Walter Mack <wmack@componentsw.com>,
linux-wpan@vger.kernel.org, alan@signal11.us
Subject: Re: PATCH IEEE 802.15.4: Add module parameter to mrf24j40 to allow use of external transmitters/receivers
Date: Mon, 15 Sep 2014 01:13:52 +0200 [thread overview]
Message-ID: <20140914231350.GA5984@omega> (raw)
In-Reply-To: <7155618F-72E7-4CFD-865F-86A9E1847095@holtmann.org>
Hi Marcel,
thanks for caring about this.
On Sun, Sep 14, 2014 at 01:30:02PM -0700, Marcel Holtmann wrote:
> Hi Walter,
>
> > Add module parameter ext_rx_tx to support designs that use an external transmitter/receiver
>
> this commit message is now missing all the details. That is not what I asked for. Start by reading Documentation/SubmittingPatches on what is expected.
>
> > Signed-off-by: Walter J. Mack<wmack@componentsw.com>
>
> you really need to address the review comments that I made on your previous submission. Just sending the same patch that has the same coding style issues and has not addressed all comments is a waste of everyone's time.
>
Please also tag and base the patch for wpan-next.
Additional add the mrf24j40 maintainer alan@signal11.us to cc. After alan
ack alan it, I will apply this patch.
- Alex
next prev parent reply other threads:[~2014-09-14 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 20:19 PATCH IEEE 802.15.4: Add module parameter to mrf24j40 to allow use of external transmitters/receivers Walter Mack
2014-09-14 20:30 ` Marcel Holtmann
[not found] ` <5416009E.1020309@componentsw.com>
2014-09-14 21:03 ` Marcel Holtmann
2014-09-14 23:13 ` Alexander Aring [this message]
2014-09-14 23:29 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140914231350.GA5984@omega \
--to=alex.aring@gmail.com \
--cc=alan@signal11.us \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=wmack@componentsw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox