From: Alexander Aring <alex.aring@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Simon Vincent <simon.vincent@xsilon.com>,
linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com
Subject: Re: [PATCH linux-wpan] 6lowpan: ensure header compression does not corrupt ipv6 header
Date: Mon, 22 Sep 2014 10:29:59 +0200 [thread overview]
Message-ID: <20140922082958.GA10332@omega> (raw)
In-Reply-To: <20140922082303.GA6279@omega>
Hi,
On Mon, Sep 22, 2014 at 10:23:03AM +0200, Alexander Aring wrote:
> Hi,
>
> On Sun, Sep 21, 2014 at 09:31:31AM +0200, Alexander Aring wrote:
> > On Sat, Sep 20, 2014 at 09:26:53PM +0200, Alexander Aring wrote:
> > ...
> > > > > + /* We must take a copy of the skb before we modify/replace the ipv6
> > > > > + * header as the header could be used elsewhere
> > > > > + */
> > > > > + skb = skb_unshare(skb, GFP_KERNEL);
> > > > > +
> > >
> > > need to be GFP_ATOMIC, xmit callback has atomic context.
> >
> > also check on return value here.
>
> We should also do it like while receiving, see [0].
>
> Only if shared make clone and buffer isn't shared. Do this with
> "skb_share_check".
>
hmpf, this doesn't work... maybe there is a bigger problem with
refcounting of skb, because I understand that skb_share_check unshare
the buffer when the skb is used twice.
- Alex
prev parent reply other threads:[~2014-09-22 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 15:42 [PATCH linux-wpan] 6lowpan: ensure header compression does not corrupt ipv6 header Simon Vincent
2014-09-20 6:48 ` Martin Townsend
2014-09-20 14:55 ` Marcel Holtmann
2014-09-20 19:26 ` Alexander Aring
2014-09-21 7:31 ` Alexander Aring
2014-09-22 8:23 ` Alexander Aring
2014-09-22 8:29 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922082958.GA10332@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon.vincent@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox