From: Alexander Aring <alex.aring@gmail.com>
To: Simon Vincent <simon.vincent@xsilon.com>
Cc: linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com,
marcel@holtmann.org
Subject: Re: [PATCH linux-wpan v3] ieee802154: 6lowpan: ensure header compression does not corrupt ipv6 header
Date: Mon, 22 Sep 2014 12:01:42 +0200 [thread overview]
Message-ID: <20140922100141.GC21350@omega> (raw)
In-Reply-To: <20140922095817.GB21350@omega>
On Mon, Sep 22, 2014 at 11:58:17AM +0200, Alexander Aring wrote:
> Hi Simon,
>
> So last but not least, I run checkpatch on it, you should always run
> checkpatch before sending patches. And also pass the argument "--strict"
> on checkpatch.
>
> Example:
> ./scripts/checkpatch.pl --strict 0001-ieee802154-6lowpan-ensure-header-compression-does-no.patch
>
> ERROR: trailing whitespace
> #119: FILE: net/ieee802154/6lowpan_rtnl.c:135:
> +^Imemcpy(&info->daddr.u.extended_addr, daddr, $
>
> CHECK: Alignment should match open parenthesis
> #120: FILE: net/ieee802154/6lowpan_rtnl.c:136:
> + memcpy(&info->daddr.u.extended_addr, daddr,
> + sizeof(info->daddr.u.extended_addr));
>
> ERROR: trailing whitespace
> #122: FILE: net/ieee802154/6lowpan_rtnl.c:138:
> +^Imemcpy(&info->saddr.u.extended_addr, saddr, $
>
> CHECK: Alignment should match open parenthesis
> #123: FILE: net/ieee802154/6lowpan_rtnl.c:139:
> + memcpy(&info->saddr.u.extended_addr, saddr,
> + sizeof(info->daddr.u.extended_addr));
>
and again sorry. Maybe I have this in my local rework branch but I do
hacking there and doesn't care about whitespace. Only at end of the
rework for creating "real mainline patches", I will care about that.
I hope you understand that. Sorry! :-)
- Alex
prev parent reply other threads:[~2014-09-22 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 9:38 [PATCH linux-wpan v3] ieee802154: 6lowpan: ensure header compression does not corrupt ipv6 header Simon Vincent
2014-09-22 9:58 ` Alexander Aring
2014-09-22 10:01 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922100141.GC21350@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon.vincent@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox