From: Alexander Aring <alex.aring@gmail.com>
To: Simon Vincent <simon.vincent@xsilon.com>
Cc: linux-wpan@vger.kernel.org, varkabhadram@gmail.com,
jukka.rissanen@linux.intel.com
Subject: Re: [PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop PACKET_OTHERHOST skbs in 6lowpan
Date: Thu, 2 Oct 2014 11:29:13 +0200 [thread overview]
Message-ID: <20141002092911.GD3850@omega> (raw)
In-Reply-To: <1412240206-6098-4-git-send-email-simon.vincent@xsilon.com>
On Thu, Oct 02, 2014 at 09:56:46AM +0100, Simon Vincent wrote:
> There is no point processing pkts which are PACKET_OTHERHOST
> in 6lowpan as they are discarded as soon as they reach the
> ipv6 layer. Therefore we should drop them in the 6lowpan layer.
>
> Signed-off-by: Simon Vincent <simon.vincent@xsilon.com>
> ---
> net/ieee802154/6lowpan_rtnl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
> index e246edc..820922a 100644
> --- a/net/ieee802154/6lowpan_rtnl.c
> +++ b/net/ieee802154/6lowpan_rtnl.c
> @@ -515,6 +515,9 @@ static int lowpan_rcv(struct sk_buff *skb, struct net_device *dev,
> if (!netif_running(dev))
> goto drop_skb;
>
> + if (skb->pkt_type == PACKET_OTHERHOST)
> + goto drop_skb;
> +
> if (dev->type != ARPHRD_IEEE802154)
> goto drop_skb;
>
This one should also added in bluetooth, but I don't know where. Maybe
Jukka will take care of this.
- Alex
next prev parent reply other threads:[~2014-10-02 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 8:56 [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST Simon Vincent
2014-10-02 8:56 ` [PATCH linux-wpan 1/3] 6lowpan: Ensure pkt_type is not lost Simon Vincent
2014-10-02 9:16 ` Alexander Aring
2014-10-02 8:56 ` [PATCH linux-wpan 2/3] ieee802154: " Simon Vincent
2014-10-02 8:56 ` [PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop PACKET_OTHERHOST skbs in 6lowpan Simon Vincent
2014-10-02 9:29 ` Alexander Aring [this message]
2014-10-05 18:17 ` Alexander Aring
2014-10-02 9:15 ` [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST Alexander Aring
2014-10-02 9:28 ` Alexander Aring
2014-10-02 9:36 ` Simon Vincent
2014-10-02 9:43 ` Jukka Rissanen
2014-10-02 9:54 ` Alexander Aring
2014-10-02 9:58 ` Alexander Aring
2014-10-02 10:12 ` Jukka Rissanen
2014-10-02 10:22 ` Alexander Aring
2014-10-02 10:37 ` Alexander Aring
2014-10-02 10:39 ` Simon Vincent
2014-10-02 10:43 ` Alexander Aring
2014-10-02 10:51 ` Alexander Aring
2014-10-02 10:58 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002092911.GD3850@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wpan@vger.kernel.org \
--cc=simon.vincent@xsilon.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox