From: Alexander Aring <alex.aring@gmail.com>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: Simon Vincent <simon.vincent@xsilon.com>,
linux-wpan@vger.kernel.org, varkabhadram@gmail.com,
marcel@holtmann.org
Subject: Re: [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST
Date: Thu, 2 Oct 2014 12:37:13 +0200 [thread overview]
Message-ID: <20141002103713.GA20200@omega> (raw)
In-Reply-To: <20141002102200.GA19732@omega>
On Thu, Oct 02, 2014 at 12:22:01PM +0200, Alexander Aring wrote:
...
>
> Okay, then maybe bluetooth 6lowpan need to set it to PACKET_HOST always.
>
> Another idea would be:
> We could also set PACKET_BROADCAST if the IPv6 address is a
> multicast/broadcast addresss.
>
> But it looks wrong, the PACKET_FOO values should be set by mac layer only.
>
>
> What I deteced is at [0]. There it checks if the "mac frame" was
> broadcast or multicast. I don't know when this occurs, I need to check
> this but it seems to be broken, when we always set the PACKET_HOST.
>
>
>
> Simon had issues with routing when IPv6 Layer gets a skb with PACKET_HOST and
> it was PACKET_OTHERHOSTS before.
>
>
> Simon:
>
> Maybe only send patch:
>
> [PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop PACKET_OTHERHOST skbs in 6lowpan
>
> this should fix your routing problems, but issue with [0] still exists.
>
Another idea would be to put out the handling of setting pkt_type inside
the 6LOWPAN GENERIC branch. This is what Martin does in the lowpan_rcv
fixes... I still need some time to review his patch.
Maybe Simon add patch "[PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop
PACKET_OTHERHOST skbs in 6lowpan" this only affects the 802.15.4 branch.
Then Martin solve the lowpan_rcv issue which put out the handling of
pkt_type in lowpan_header_create function. Then you can do whatever
bluetooth need to do there and we can drop the override of set this
value to PACKET_HOST.
- Alex
next prev parent reply other threads:[~2014-10-02 10:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 8:56 [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST Simon Vincent
2014-10-02 8:56 ` [PATCH linux-wpan 1/3] 6lowpan: Ensure pkt_type is not lost Simon Vincent
2014-10-02 9:16 ` Alexander Aring
2014-10-02 8:56 ` [PATCH linux-wpan 2/3] ieee802154: " Simon Vincent
2014-10-02 8:56 ` [PATCH linux-wpan 3/3] ieee802154: 6lowpan: Drop PACKET_OTHERHOST skbs in 6lowpan Simon Vincent
2014-10-02 9:29 ` Alexander Aring
2014-10-05 18:17 ` Alexander Aring
2014-10-02 9:15 ` [PATCH linux-wpan 0/3] Fix handling of skbs of type PACKET_OTHERHOST Alexander Aring
2014-10-02 9:28 ` Alexander Aring
2014-10-02 9:36 ` Simon Vincent
2014-10-02 9:43 ` Jukka Rissanen
2014-10-02 9:54 ` Alexander Aring
2014-10-02 9:58 ` Alexander Aring
2014-10-02 10:12 ` Jukka Rissanen
2014-10-02 10:22 ` Alexander Aring
2014-10-02 10:37 ` Alexander Aring [this message]
2014-10-02 10:39 ` Simon Vincent
2014-10-02 10:43 ` Alexander Aring
2014-10-02 10:51 ` Alexander Aring
2014-10-02 10:58 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002103713.GA20200@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon.vincent@xsilon.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).